Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 60
    • Issues 60
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 22
    • Merge requests 22
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1555

remove unnecessary check for test_get_time_begin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mladen Ivkovic requested to merge timeline_unit_test_fix into master May 12, 2022
  • Overview 23
  • Commits 3
  • Changes 1

It turns out I had a deprecated check left over when determining a starting point in the test_get_integer_time_begin function.

I first pick some random point on the timeline which is a viable time_begin, and then determine a random point on the timeline at a later integer-time and try to reconstruct the originally picked time_begin. While picking the original time_begin, I threw an error if time_begin == max_nr_steps, which was an oversight. (Particularly so since I later explicitly also tests what happens if I provide the function with a current time that is > max_nr_timesteps.)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: timeline_unit_test_fix