Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1511

Make sure sync is still executed for particles that are also limited.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bert Vandenbroucke requested to merge limiter-vs-sync into master Mar 29, 2022
  • Overview 10
  • Commits 1
  • Changes 4

Turns out limiter and sync do not play nice together. If a particle is marked by both the limiter and the sync, then the limiter gets executed first and erases the sync flag. Since the limiter blindly reduces the time step size without recomputing it, this can result in a particle time step that is way too large.

To remedy this, this MR disables the limiter action for particles that are also marked for sync, without resetting the limiter flag (wakeup). After the new particle time step has been determined in the sync, the actual new time step is then set to the minimum of this new time step and the time step requested by the limiter.

While fixing this bug, another issue popped up, involving a couple of missing activations of the sync task for cells that only have active self/bh_feedback tasks. These were added.

Edited Mar 30, 2022 by Bert Vandenbroucke
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: limiter-vs-sync