Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 23
    • Merge requests 23
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1467

RT GEAR thermochemistry first attempt

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mladen Ivkovic requested to merge rt-gear-thermochemistry-first-attempt into master Dec 10, 2021
  • Overview 32
  • Commits 27
  • Changes 39

This MR introduces the first working version for GEAR-RT including thermochemistry. This includes:

  • doing cooling, heating, and ionizing with grackle during the thermochemistry tasks, and modifying the radiation fields appropriately
  • added option to choose stellar spectra, which are used to estimate average interaction cross sections over a photon frequency interval. Currently have constant and blackbody spectrum ready.
  • added flux exchange of ionizing species during hydro
  • added call to rt_kick_extra, where extra RT related operations during a kick are performed, analoguely to hydro_kick_extra
  • added option to set upper threshold for star time steps

ToDo before WIP is removed:

  • wait for !1460 (merged) to be merged and rebase
  • clean up and format code (@everybody else, pls don't look at the current state, it's embarrassing)
  • check whether documentation is up to date
  • add new function prototypes to all other schemes
  • check that you don't break anything else
  • discuss addition of rt_additions.h
  • update all param files of all examples to include new compulsory parameters so that things at least don't crash at startup

Future ToDos: (not part of this MR)

  • update examples (in particular Strömgren Spheres)
  • add example to test heating/ionization of gas and energy conservation in a case without radiation sources
  • add futher Iliev+09 tests
  • add option for user to provide cross sections in parameter file, and script/program to compute them outside swift
  • cleaner, leaner way of dealing with ionizing species
  • move from explicit cgs in thermochemistry to internal units, test for
  • enforce 10% rule recursively during thermochemistry (currently no such rule)
  • add theory
  • take care of particle drifts
Edited Dec 20, 2021 by Mladen Ivkovic
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rt-gear-thermochemistry-first-attempt