Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 60
    • Issues 60
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1466

Moved no neighbour warnings for stars and BH from ghost loop to part_has_no_neighbours() to reduce output frequency.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bert Vandenbroucke requested to merge less-ghost-warnings into master Dec 09, 2021
  • Overview 2
  • Commits 1
  • Changes 6

What the title says.

The current warning triggers if a particle had no neighbours in the first iteration, which apparently happens quite frequently for stars. part_has_no_neighbours() is only called after the ghost gives up on the particle, so this should only trigger the warning if a particle actually has no neighbours for the whole step.

I am still preparing another MR with ghost iteration statistics. Is it worth adding a no neighbour counter that also covers the first iteration?

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: less-ghost-warnings