Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1046

New unique ID

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Loic Hausammann requested to merge unique_id_2 into master Mar 23, 2020
  • Overview 37
  • Commits 13
  • Changes 13

Hey,

In this merge request, I am implementing a way of getting new unique IDs. The idea is to simply find the max ID in the IC and then I request two slices for each rank starting from the max. The idea of the two slices is to have a current slice and once I finish it, I am using the new one. Every time that we rebuild, I am requesting a new slice if the first one is finished.

This will not work with your particle splitting. Do you wish a test to check that we are not using both of them?

It is very light, therefore I am not sure if it is worth to add an if around it.

I have tested it with the SmallCosmoVolume on two ranks and after getting a few different slices, I have only unique IDs.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: unique_id_2