Do not pass the chemistry model object to the diffusion loop. Extend the...
Do not pass the chemistry model object to the diffusion loop. Extend the converage of the testSymmetry and testHydroMPIrules unit tests
Loading
-
@matthieu Can I ask why you removed the chemistry data from the diffusion loop?
I introduced it two weeks ago for the GEAR FVPM diffusion scheme
-
The FVPM diffusion is still not in master... Since the FVPM diffusion is a large branch with two submodules, I am merging it bit by bit. Two weeks ago, we merged the high-level API changes that touch everything outside the chemistry, including passing the chemistry properties to the loops.
I know... But in this case, I need the parameters for the Riemann solver and the diffusion flux stored in the chemistry props. We can discuss this once I merge this part for the parabolic diffusion.
Please sign in to comment