SWIFTsim merge requestshttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests2017-08-03T15:17:18Zhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/384Threadpoolize all the things2017-08-03T15:17:18ZPedro GonnetThreadpoolize all the thingsThese are all the remaining function from the list in #338. I've tested this as far as possible on my laptop, i.e. MPI and gravity *should* work.These are all the remaining function from the list in #338. I've tested this as far as possible on my laptop, i.e. MPI and gravity *should* work.Scalable SPH in multi-dtMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/383Revert "Merge branch 'threadpool_task_plots' into 'master'"2017-07-28T17:17:12ZPeter W. DraperRevert "Merge branch 'threadpool_task_plots' into 'master'"This reverts merge request !375.
There is a problem running the testThreadpool program when built with:
```
./configure --disable-optimization
```
it is crashing during the program exit phase.This reverts merge request !375.
There is a problem running the testThreadpool program when built with:
```
./configure --disable-optimization
```
it is crashing during the program exit phase.Peter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/382Disc patch x2017-07-30T17:05:41ZBert VandenbrouckeDisc patch xReplaced disc patch potential in z with a disc patch potential in x. Added a 1D version of the disc patch test. Changed the GIZMO time step criterion (fixed a bug in the original criterion, and tried to make the criterion stricter to cop...Replaced disc patch potential in z with a disc patch potential in x. Added a 1D version of the disc patch test. Changed the GIZMO time step criterion (fixed a bug in the original criterion, and tried to make the criterion stricter to cope with the disc patch potential). Removed some gravity variables that were no longer used. Put the flux limiter in a separate file and made it configurable.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/381Fix to make test27cells still give 48 neighbours2017-07-27T16:17:10ZAidan ChalkFix to make test27cells still give 48 neighboursSmall change as test27fix we want to still output the weighted number of neighbours as described by other people.Small change as test27fix we want to still output the weighted number of neighbours as described by other people.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/380Allocate a separate sort array for each dimensions.2017-08-02T15:57:47ZPedro GonnetAllocate a separate sort array for each dimensions.As discussed, fixes #334.As discussed, fixes #334.Peter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/379Fix problems with empty hydro tasks.2017-08-02T11:10:58ZPedro GonnetFix problems with empty hydro tasks.Fixes #333.Fixes #333.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/378Mpi drifts2017-07-28T16:35:24ZPedro GonnetMpi driftsInstead of drifting all particles in the super-cell before sending, drift only the sub-cells that are involved in an interaction. For deep hierarchies, this saves a lot of drifting.
This merge request removes two tests for drifted par...Instead of drifting all particles in the super-cell before sending, drift only the sub-cells that are involved in an interaction. For deep hierarchies, this saves a lot of drifting.
This merge request removes two tests for drifted particles when sending and receiving, as not all particles will be drifted and we can't know which ones need to be drifted there and then. Note, however, that undrifted particles will still be caught in the interaction tasks.Scalable SPH in multi-dtMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/377Split gravity tasks2017-08-03T10:09:00ZPedro GonnetSplit gravity tasksApply a similar splitting scheme for gravity tasks as for hydroApply a similar splitting scheme for gravity tasks as for hydroScalable SPH in multi-dtMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/376Make SWIFT static library a dependency of all tests2017-07-26T08:21:58ZPeter W. DraperMake SWIFT static library a dependency of all testsWe need to rebuild those after any updates.
Fixes #329. We need to rebuild those after any updates.
Fixes #329. Peter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/375Threadpool task plots2017-07-30T19:54:18ZPedro GonnetThreadpool task plotsAdds the following:
* `--enable-threadpool-debugging` to the `./configure` flags,
* `-Y` to `main.c` to enable dumping threadpool timers much like the task timers.
This generates `threadpool_info-step%d.dat` files every `-Y` ste...Adds the following:
* `--enable-threadpool-debugging` to the `./configure` flags,
* `-Y` to `main.c` to enable dumping threadpool timers much like the task timers.
This generates `threadpool_info-step%d.dat` files every `-Y` steps which contain the mapper function name, the id of the thread that executed it, the number of chunks processed, and the `tic` and `toc` timers for the mapper function.Peter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/374Random fixes2017-07-27T15:08:14ZPedro GonnetRandom fixesWe only need `ti_sort` in debug mode.We only need `ti_sort` in debug mode.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/373Fewer mpi comms2017-07-27T08:40:53ZPedro GonnetFewer mpi commsRe-think when and how we activate communication tasks and pair tasks spanning local and foreign cells.
This should result in much fewer interaction tasks, send/recv pairs, and drifts.Re-think when and how we activate communication tasks and pair tasks spanning local and foreign cells.
This should result in much fewer interaction tasks, send/recv pairs, and drifts.Scalable SPH in multi-dtPeter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/372Made sure Gizmo hydro_part_has_no_neighbours implementation does sensible thi...2017-07-24T14:46:42ZBert VandenbrouckeMade sure Gizmo hydro_part_has_no_neighbours implementation does sensible things.Set volume, gradient matrix, cell centroid and total surface area (used for flux limiter) to safe values in `hydro_part_has_no_neighbours`.Set volume, gradient matrix, cell centroid and total surface area (used for flux limiter) to safe values in `hydro_part_has_no_neighbours`.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/371Make sure the GIZMO extra loop uses the in and out ghost tasks and not just t...2017-07-18T13:46:56ZMatthieu SchallerMake sure the GIZMO extra loop uses the in and out ghost tasks and not just the main ghost task.Fixes #326.Fixes #326.Peter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/370Add checks for particles that are at same position and updates to the h_max o...2017-07-20T14:50:17ZPeter W. DraperAdd checks for particles that are at same position and updates to the h_max of top-level cells.Investigating #324 has turned up a couple of issues that we probably should
handle better. The first is particles with the same position. These are not
allowed. The second is a mismatch between the cells h_max values and those
of the...Investigating #324 has turned up a couple of issues that we probably should
handle better. The first is particles with the same position. These are not
allowed. The second is a mismatch between the cells h_max values and those
of the particles when running the ghost tasks for the first time and when
the initial estimates of h are small, so we get too many top-level cells
initially and a regrid is needed (if this isn't done then the particles
test to be moved outside their cell and we need to rebuild, even though
a rebuild has just been done).
This fixes both by reporting an error when particles are found in the
same location, and updates the top-level cells h_max to those of the
particles (note this must be followed by a regrid as any sub-cells
will have the wrong h_max).
Also now reports if gparts are at the same location. That is inefficient
not a show stopper.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/369Use the basename for the HDF5 files2017-07-14T17:18:29ZPeter W. DraperUse the basename for the HDF5 filesThese are relative to the container file and could include directory information (we assume XMF file is written into same directory as the snapshots).
Fixes #325.These are relative to the container file and could include directory information (we assume XMF file is written into same directory as the snapshots).
Fixes #325.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/368Check if snapshot directory exists and add a digit to the output2017-07-14T13:21:36ZLoic HausammannCheck if snapshot directory exists and add a digit to the outputFix issue #321 Fix issue #321 Peter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/367Remove 8-cell limit in gravity + non periodic case2017-07-13T21:04:20ZLoic HausammannRemove 8-cell limit in gravity + non periodic caseFix issue #323 Fix issue #323 Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/366[WIP]Timestep limiter2017-07-28T16:37:17ZMatthieu Schaller[WIP]Timestep limiterMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/365Subsize2017-07-14T17:01:18ZPedro GonnetSubsizeUse separate parameters to determine when a pair or self interaction should be made a sub-cell task.Use separate parameters to determine when a pair or self interaction should be made a sub-cell task.Scalable SPH in multi-dtMatthieu SchallerMatthieu Schaller