SWIFTsim merge requestshttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests2023-10-24T09:48:43Zhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1799Correctly read in critical accretion rate in SPIN/JET BH scheme2023-10-24T09:48:43ZFilip HuskoCorrectly read in critical accretion rate in SPIN/JET BH schemeThe critical Eddington ratio parameter, `mdot_crit_ADAF`, is used to switch between the thin accretion disc/thermal feedback to the thick disc/jet feedback. In previous versions of the model, this was connected to the accretion viscosity...The critical Eddington ratio parameter, `mdot_crit_ADAF`, is used to switch between the thin accretion disc/thermal feedback to the thick disc/jet feedback. In previous versions of the model, this was connected to the accretion viscosity parameter `alpha_acc`, based on theory. While we still know there should be a connection, it is a bit more flexible to have both parameters as explicit ones in the code
I now correct this to read in `mdot_crit_ADAF` from the parameter file. The suggested value is also changed to 0.03 instead of 0.01 in the parameter files (we know it's at a bit higher Eddington ratios than 0.01). A value of 0.03 is also more consistent with the current choice of `alpha_acc`, which is 0.2.https://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1796Uniformised MHD parameter names in FDI abd VP too2023-10-19T12:32:29ZOrestis KarapiperisUniformised MHD parameter names in FDI abd VP tooChanged Reta to resistive_eta in FDI and VP. Names should be uniform across all flavours now.Changed Reta to resistive_eta in FDI and VP. Names should be uniform across all flavours now.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1795Fstasys/naming in mhd io ver012023-10-19T12:30:16ZFederico Andrés StasyszynFstasys/naming in mhd io ver01I thought I already merges this.I thought I already merges this.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1794copy odi magnetosonic speeds functions into fdi and vep2023-10-19T12:29:20ZFederico Andrés Stasyszyncopy odi magnetosonic speeds functions into fdi and vepJust make compatible the functions called.
No change in the way things are calculated.
added error messages to NONE MHDJust make compatible the functions called.
No change in the way things are calculated.
added error messages to NONE MHDMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1793Fix random cone test2023-10-19T12:40:18ZFilip HuskoFix random cone testFixes #870.
In a recent MR, the function `random_direction_in_cone` that generates a random unit vector within a given cone was modified. It no longer takes both the ID of a BH and a gas particle as inputs, but only the former. However,...Fixes #870.
In a recent MR, the function `random_direction_in_cone` that generates a random unit vector within a given cone was modified. It no longer takes both the ID of a BH and a gas particle as inputs, but only the former. However, this means that the `testRandomCone.h` test was less random than we wanted, and was thus failing.
I have modified that test in a very simple way. It still does exactly the same thing, but we now generate a random id `id_random` and pass `id_BH + id_random` instead of `id_BH` to the `random_direction_in_cone` function. The test again passes with this change.https://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1791Dedner scalar time derivative is now calculated in a function, and the scalar...2023-10-17T12:04:55ZOrestis KarapiperisDedner scalar time derivative is now calculated in a function, and the scalar...Dedner scalar time derivative is now calculated in a function, and the scalar itself is now time integrated in the drift.Dedner scalar time derivative is now calculated in a function, and the scalar itself is now time integrated in the drift.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1790Mhd canvas sid2023-10-19T12:32:45ZMatthieu SchallerMhd canvas sidMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1789Calculating root mean square B and average divB error in statistics files2023-10-17T12:22:05ZOrestis KarapiperisCalculating root mean square B and average divB error in statistics filesI don't know C properly, sorry if this is an abomination. The code compiles at least.I don't know C properly, sorry if this is an abomination. The code compiles at least.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1788head comments in functions2023-10-12T13:09:49ZFederico Andrés Stasyszynhead comments in functionsand formattingand formattinghttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1786Uniformisation of parameter names, one convetion2023-10-11T15:48:26ZOrestis KarapiperisUniformisation of parameter names, one convetionMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1785Added function to calculate magnetosonic speed2023-10-12T13:11:14ZOrestis KarapiperisAdded function to calculate magnetosonic speedBreak MHD speeds calculation into two : magnetosonic speed (=sqrt(cs**2 + v_Alfven**2)) and fast magnetosonic wave phase velocity (same, augmented with a projection factor). First is used in Dedner, second is used in v_sigBreak MHD speeds calculation into two : magnetosonic speed (=sqrt(cs**2 + v_Alfven**2)) and fast magnetosonic wave phase velocity (same, augmented with a projection factor). First is used in Dedner, second is used in v_sigMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1784Better treatment of gradB tensor and associated AR switch + minor variable...2023-10-11T15:43:05ZOrestis KarapiperisBetter treatment of gradB tensor and associated AR switch + minor variable...Better treatment of gradB tensor and associated AR switch + minor variable name changes for consistencyBetter treatment of gradB tensor and associated AR switch + minor variable name changes for consistencyMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1783Symmetric Operator for DivB in VeP and FDI2023-10-11T16:19:32ZFederico Andrés StasyszynSymmetric Operator for DivB in VeP and FDIAdded some comments and small reorganize in ODI (check @okarapiperis).
Clean up a little bit and pre-organizing for next steps in VeP and FDI.Added some comments and small reorganize in ODI (check @okarapiperis).
Clean up a little bit and pre-organizing for next steps in VeP and FDI.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1782Removing OPTional parameters in all MHD schemes.2023-10-11T09:36:40ZFederico Andrés StasyszynRemoving OPTional parameters in all MHD schemes.NOTE: dont in generate B form ICs as it will desapearNOTE: dont in generate B form ICs as it will desapearOrestis KarapiperisOrestis Karapiperishttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1780Time integration fix for Phi in FDI.2023-10-10T15:53:56ZFederico Andrés StasyszynTime integration fix for Phi in FDI.No need for variable Phi (Dedner scalar field) in xp.
Only time integrate in the Kick step.No need for variable Phi (Dedner scalar field) in xp.
Only time integrate in the Kick step.Federico Andrés StasyszynFederico Andrés Stasyszynhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1779Moved the divB from density to gradient loop2023-10-10T15:54:39ZFederico Andrés StasyszynMoved the divB from density to gradient loopJust affects FDIJust affects FDIFederico Andrés StasyszynFederico Andrés Stasyszynhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1778FDI and VeP, changes in mhd_io to comply with naming policies2023-10-10T15:53:30ZFederico Andrés StasyszynFDI and VeP, changes in mhd_io to comply with naming policiesformatting the naming of the output fo FDI and VeP. Also I did not touch ODI, @okarapiperis do you want to fix this?
WARNING! it will break all makeIC and plotting in MHD tests. But we must start from some place.
Also It will force us to...formatting the naming of the output fo FDI and VeP. Also I did not touch ODI, @okarapiperis do you want to fix this?
WARNING! it will break all makeIC and plotting in MHD tests. But we must start from some place.
Also It will force us to run all tests again and check.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1776adding balsara eq 1 in ODI scheme2023-10-07T09:12:24ZFederico Andrés Stasyszynadding balsara eq 1 in ODI schemeTesting new modality of pushes. Jusr add Balsara switch eq 1 in ODI.
I also add some additional fields in the standard plot.py of Roberts flowTesting new modality of pushes. Jusr add Balsara switch eq 1 in ODI.
I also add some additional fields in the standard plot.py of Roberts flowMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1774skip particle timestep data collection in space_split.c when running without RT2023-11-09T16:40:19ZMladen Ivkovicskip particle timestep data collection in space_split.c when running without RTIssue reported by Yolan in !1749 .
For new progeny cells, when running without RT, particle time bins are zero. Then those time bins get collected to determine the time step vars for the progeny cell, leading to wrong results.
This oug...Issue reported by Yolan in !1749 .
For new progeny cells, when running without RT, particle time bins are zero. Then those time bins get collected to determine the time step vars for the progeny cell, leading to wrong results.
This oughtta fix it, but I haven't had time to test it yet.
ToDo's Mladen:
* [x] Testing this fix
* [x] Check that there aren't other places where this could be an issue
* [x] run the bloody formatterMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1773Add barotropic EoS2023-10-06T14:55:04ZMatthieu SchallerAdd barotropic EoSAdd barotropic EoS that is used in some MHD problems.
Todo:
- [x] Add reference to the paper where this is taken from,
- [x] Fix the few equations labelled as "IS THIS CORRECT",
- [x] Fix the Doxygen comments to have the correct equa...Add barotropic EoS that is used in some MHD problems.
Todo:
- [x] Add reference to the paper where this is taken from,
- [x] Fix the few equations labelled as "IS THIS CORRECT",
- [x] Fix the Doxygen comments to have the correct equations.
- [x] Fix the example/parameter_examples.yml file to have a description of the two parameters.Matthieu SchallerMatthieu Schaller