SWIFTsim merge requestshttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests2023-09-11T10:48:37Zhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1665Draft: Add threadpool mappers for scheduler_reweight2023-09-11T10:48:37ZPeter W. DraperDraft: Add threadpool mappers for scheduler_reweightIs better than serial code (100ms compared to 500ms in my test), but has one issue, which is some weights will be less optimal than before as the accumulation of weights will not happen between threads. This is why we use a uniform chunk...Is better than serial code (100ms compared to 500ms in my test), but has one issue, which is some weights will be less optimal than before as the accumulation of weights will not happen between threads. This is why we use a uniform chunk to keep the work load from too many splits.
For any reasonable set of tasks this is a small issue, there is no effect measureable that I can see.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1624Draft: Add magma2 SPH scheme2023-07-15T16:33:16ZZhen XiangDraft: Add magma2 SPH schemeI just added the MAGMA2 scheme in the branch MAGMA2 and are there some advices for the future implementation?
I added the two extra profiles:
- hydro_iact_cosmo.h and hydro_iact_sphenix.h. One is added the cosmological term and anothe...I just added the MAGMA2 scheme in the branch MAGMA2 and are there some advices for the future implementation?
I added the two extra profiles:
- hydro_iact_cosmo.h and hydro_iact_sphenix.h. One is added the cosmological term and another is using the sphenix's diffusion parameter.
- There is a parameter called h_crit in the runner_iact_force and runner_iact_nonsym_force , which is the inverse of the resolution eta. And everytime I just change the parameter manually
- Also for the matrix inversion, I just paste the function invert_dimension_by_dimension_matrixin swift, and it might need clear a bit and call the function instead
- And I just directly use constant viscosity and diffusion parameters into the function without define it in the hydro_parameter.h. It also might need to change a bit
- Last thing is MAGMA2 use the quadratically mid point reconstruction and it is also worth to test the linearly reconstruction. Since it may increases the computing effciency.https://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/1530Draft: Blank functions for MHD support2024-03-12T13:49:10ZMatthieu SchallerDraft: Blank functions for MHD supportChanges:
- Moved the signal velocity calculation to a new file that is SPH-scheme independant. There are two versions in there, one for MHD runs, one for non-MHD runs
- Added the `mhd` directory for the scheme specific things. In ther...Changes:
- Moved the signal velocity calculation to a new file that is SPH-scheme independant. There are two versions in there, one for MHD runs, one for non-MHD runs
- Added the `mhd` directory for the scheme specific things. In there there is only `None` scheme for now, i.e. no-MHD runs
- Added all the empty functions for the loops over neighbours
- Added all the empty functions for the things done in-between loops (drift, kick, reset...)
- Added a small structure that is carried by the particles to contain the MHD fields.
Todo:
- [ ] Deal with the case where the MHD wants three loops but the hydro only needs two...
- [x] Deal with Gasoline signal velocity
- [x] Prevent MHD + Gizmo
- [x] Unit tests
- [x] Cleanly deal with mu_0
- [x] Cleanly deal with stats
- [ ] Cleanly deal with div v
- [ ] Work out units of B^2 PS.