SWIFTsim merge requestshttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests2018-12-12T11:03:53Zhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/697Add functions to calculate temperature of particles.2018-12-12T11:03:53ZMatthieu SchallerAdd functions to calculate temperature of particles.Changes:
- Added function to compute T for a given particle and cooling model (#511),
- Used the correct definition of Helium fraction throughout EAGLE cooling code (#510),
- Added temperature to the snapshots
- Fixed a mistake i...Changes:
- Added function to compute T for a given particle and cooling model (#511),
- Used the correct definition of Helium fraction throughout EAGLE cooling code (#510),
- Added temperature to the snapshots
- Fixed a mistake in the EAGLE Compton cooling code that was using logT and not T.
- Style improvements to the EAGLE cooling code.
- Fixed the EAGLE examples yaml files to use the correct name for cooling-related variables.
- Clarified calculation of delta redshift for a given time-step size.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/708Correct additional eagle cooling abundances2018-12-20T17:28:38ZMatthieu SchallerCorrect additional eagle cooling abundancesImplements #509.Implements #509.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/720Implement EAGLE-like entropy floor2019-01-21T09:39:13ZMatthieu SchallerImplement EAGLE-like entropy floorI have finished working on the entropy floor. I have added only a few things since last week's branch that you tested.
If you are happy with it, you can accept this merge request into your branch and we can then work from there to get y...I have finished working on the entropy floor. I have added only a few things since last week's branch that you tested.
If you are happy with it, you can accept this merge request into your branch and we can then work from there to get your branch into master.Folkert NobelsFolkert Nobelshttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/723Adds ANARCHY-PU Scheme2019-01-28T11:59:52ZJosh BorrowAdds ANARCHY-PU SchemeThis MR adds the ANARCHY-PU scheme.
Let's see what Jenkins has to say about this one. I will follow up in the next 12-24 hours with some final check plots, so please wait to merge until we've seen those. Feel free to take a look at the ...This MR adds the ANARCHY-PU scheme.
Let's see what Jenkins has to say about this one. I will follow up in the next 12-24 hours with some final check plots, so please wait to merge until we've seen those. Feel free to take a look at the code changes though, as there are a few ones in the core.Add ANARCHY-SPHMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/705Star formation following Schaye082019-02-06T10:57:24ZMatthieu SchallerStar formation following Schaye08Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/737Apply the entropy floor in the cooling routine2019-02-13T21:14:37ZMatthieu SchallerApply the entropy floor in the cooling routineMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/761Make the EAGLE cooling model use the smoothed metal abundances and not the ra...2019-03-17T22:35:18ZMatthieu SchallerMake the EAGLE cooling model use the smoothed metal abundances and not the raw ones.Implements #513.Implements #513.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/760H and He Reionization heating2019-03-18T17:36:28ZMatthieu SchallerH and He Reionization heatingFixes #554. Implements #526. Adds a cosmological test evolving a uniform Universe with gas mean density to test the temperature evolution.Fixes #554. Implements #526. Adds a cosmological test evolving a uniform Universe with gas mean density to test the temperature evolution.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/764Add EOS temperature from entropy floor2019-03-20T13:18:15ZFolkert NobelsAdd EOS temperature from entropy floorThis merge request fixes a difference we implemented differently in SWIFT as compared to EAGLE. Instead of calculating the EOS temperature from the star formation EOS we need to calculate this from the entropy floor, this merge request d...This merge request fixes a difference we implemented differently in SWIFT as compared to EAGLE. Instead of calculating the EOS temperature from the star formation EOS we need to calculate this from the entropy floor, this merge request does that. I also have run the idealized disk without problems, it produces the same result. threshold density (numb/cm^3) is around 0.03 for solar, that still has a temperature above the threshold given by around (0.03/0.1)^(1/3)*8000 K*10^.5 = 17000 K, so in the case of my disk, it produces exactly the same result as before. Any comments on the code?Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/769The EAGLE entropy floor should use the mean baryon density to compute an over...2019-03-22T20:10:04ZMatthieu SchallerThe EAGLE entropy floor should use the mean baryon density to compute an over-density.This may help with the low-density low-temperature behaviour of the code in the EAGLE-12 exampleThis may help with the low-density low-temperature behaviour of the code in the EAGLE-12 exampleJosh BorrowJosh Borrowhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/765Variable AV fix | Cosmology2019-04-08T19:21:48ZJosh BorrowVariable AV fix | CosmologyFixes the AV and AD coefficients in ANARCHY and in the Morris & Monaghan AV. Thanks to @bvandenbroucke for the Cosmological Sod Shock tests, they were instrumental in debugging this.
Before fix; artificial diffusion coefficient as a fun...Fixes the AV and AD coefficients in ANARCHY and in the Morris & Monaghan AV. Thanks to @bvandenbroucke for the Cosmological Sod Shock tests, they were instrumental in debugging this.
Before fix; artificial diffusion coefficient as a function of space:
![compare_alpha_broken](/uploads/a44fb2195f23bf88adb19c7e233278e6/compare_alpha_broken.png)
After fix:
![compare_alpha_fixed](/uploads/e373341e8ca30f59fc3830f70fb8037f/compare_alpha_fixed.png)
I am currently testing this fix with the EAGLE_12 to see if it rectifies the problem we were having there. Once that is over (I guess whether it passes or not), I'll re-assign this and remove the WIP.Add ANARCHY-SPHMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/755Star Formation History logger2019-04-18T21:18:24ZFolkert NobelsStar Formation History loggerLogger that logs the complete star formation of the simulation in a txt file.Logger that logs the complete star formation of the simulation in a txt file.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/798No cooling limit2019-05-01T18:43:33ZMatthieu SchallerNo cooling limitMultiple changes:
- Remove the Newton cooling scheme from the main cooling track.
- Fix the cooling from Iron.
- Do not set a maximal du/dt taking into account the increase in time-step size.
- Check the entropy floor in the dr...Multiple changes:
- Remove the Newton cooling scheme from the main cooling track.
- Fix the cooling from Iron.
- Do not set a maximal du/dt taking into account the increase in time-step size.
- Check the entropy floor in the drift and kick.
- Recompute the pressure and sound-speed *after* the floor has been applied.ParisMatthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/803Star formation sub grid update2019-05-01T12:11:39ZFolkert NobelsStar formation sub grid updateI changed the temperature criteria to an entropy criteria to be faster, furthermore I added the birth temperature to the snapshots and added a histogram plot to the solutions.
So I run tests using the lowres8 isolated galaxy without fe...I changed the temperature criteria to an entropy criteria to be faster, furthermore I added the birth temperature to the snapshots and added a histogram plot to the solutions.
So I run tests using the lowres8 isolated galaxy without feedback, and I don't seem to see any difference in the results:
Old:
![KS_law](/uploads/e5cab3e449c0da7d331a677ba4bf49bc/KS_law.png)
New:
![KS_law](/uploads/f4c1c0218137ff66ee4da2d8b5999f3a/KS_law.png)
Same for the SFH:
Old:
![SFH_all](/uploads/af755d00c34dcdbec51f53fe1e2c82ab/SFH_all.png)
New:
![SFH_all](/uploads/89f7604c19ec5fb0003232118756bdc8/SFH_all.png)
I will run the one with feedback to check if it gives a similar result.
One thing, I assumed that in general we want to keep the functionality to call the cooling function in `star_formation_is_star_forming` function for other subgrid models, so that function still has the required arguments.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/804Implementation of black hole accretion and feedback2019-05-08T12:27:56ZMatthieu SchallerImplementation of black hole accretion and feedbackAdds the following:
- self/pair tasks for the black holes
- MPI communication tasks for the black holes
- A new black holes properties structure to contain the BH model details
- New type of black holes for the EAGLE model
- ...Adds the following:
- self/pair tasks for the black holes
- MPI communication tasks for the black holes
- A new black holes properties structure to contain the BH model details
- New type of black holes for the EAGLE model
- Bondi + Eddington accretion model for the EAGLE AGN model
- Update to the yaml parameter files for the new parameters
- Update to the python analysis scripts
- Update to the low-z ICs to contain black hole smoothing lengths.ParisPeter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/805Communication tasks for on-the-fly star formation2019-05-10T14:28:18ZMatthieu SchallerCommunication tasks for on-the-fly star formationAllow star-formation in combination with stellar feedback over MPI.
Specifically this involves:
- A new communication task propagating the counts of stars in cells that have created stars.
- A change in the unskipping strategy of s...Allow star-formation in combination with stellar feedback over MPI.
Specifically this involves:
- A new communication task propagating the counts of stars in cells that have created stars.
- A change in the unskipping strategy of star tasks. They need to be activated also in the case where
the cell is only active for hydro purposes as that cell may form a star.ParisPeter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/820When doing stellar or AGN feedback, set the particles' viscosity to the maxim...2019-05-20T19:00:44ZMatthieu SchallerWhen doing stellar or AGN feedback, set the particles' viscosity to the maximal value.Implements #576Implements #576ParisJosh BorrowJosh Borrowhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/834EAGLE SF: Name change of parameters2019-06-11T13:14:25ZFolkert NobelsEAGLE SF: Name change of parametersI changed two parameters of the EAGLE star formation model to be more clear.I changed two parameters of the EAGLE star formation model to be more clear.Matthieu SchallerMatthieu Schallerhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/845Blackholes swallowing - Gas case2023-01-24T08:46:47ZMatthieu SchallerBlackholes swallowing - Gas caseThis implements the following:
- Black holes carry metal information. That is obtained at brith time and written to snapshots.
- Added 1 new loop over the gas neighbours of BHs to tag the gas particles that will be swallowed.
- Add...This implements the following:
- Black holes carry metal information. That is obtained at brith time and written to snapshots.
- Added 1 new loop over the gas neighbours of BHs to tag the gas particles that will be swallowed.
- Added a field to the gas particles to carry the swallowing information.
- Added a set of tasks to process the particles that have been tagged for swallowing.
- Reduced the number of BH tasks by only creating them for cells that actually contain black holes.
- Added the communication and dependencies that are needed for the swallowing.
- Implemented the EAGLE model for BH swallowing of gas.
- In debugging mode, copy the (const) pointer to the task that is run into the runner. Helps seeing where we are.ParisPeter W. DraperPeter W. Draperhttps://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/merge_requests/852Added diffusion reset in hydro when doing feedback and updated function signa...2019-06-26T18:13:46ZJosh BorrowAdded diffusion reset in hydro when doing feedback and updated function signaturesWe need to also reset the diffusion to zero when doing feedback as well as resetting the viscosity to max.
I have:
+ Done this for schemes that include variable diffusion
+ Re-named the function to `hydro_diffusive_feedback_reset`...We need to also reset the diffusion to zero when doing feedback as well as resetting the viscosity to max.
I have:
+ Done this for schemes that include variable diffusion
+ Re-named the function to `hydro_diffusive_feedback_reset` as this no longer only resets the viscosityAdd ANARCHY-SPHMatthieu SchallerMatthieu Schaller