- 01 Aug, 2016 1 commit
-
-
Peter W. Draper authored
Clean up allocations and deallocations Two improvements to the code: - Replaced all calls to `alloca()` by `malloc()` and `posix_memalign()` depending on use case. - Added cleaning up code to free up all the allocated memory. The second change is there to make sure we don't have memory leaks by easing the read of the memory sanitizer output. There is only one allocation that cannot be easily freed at the end of a run. In space.c (line 1327) we allocate cells in batches and then use them as a linked list. No memory leak there, just a hard unnecessary work to clean up at the end of a run. That allows to run the EAGLE_50 example for hundreds of steps. See merge request !211
-
- 30 Jul, 2016 1 commit
-
-
Matthieu Schaller authored
-
- 29 Jul, 2016 11 commits
-
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Peter W. Draper authored
Correct the equation for the entropy time derivative in GADGET2_SPH This fixes #183 meaning that energy is now correctly conserved. It also: - Adds a parameter file and run script for the perturbed box test case. - Adds entropy to the diagnostics file. - Replace the MPI_AllReduce in the statistics collection by an MPI_Reduce since only rank 0 writes anyway. - Gives a better documentation for the `approx_exp()` function. - Adds an accuracy test for the approximate maths functions (currently only exp()) - Adds a test no make sure the symmetric and non-symmetric versions of the SPH interaction routines give the same answer. That was the origin of the energy non-conservation bug. See merge request !210
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Peter W. Draper authored
-
Matthieu Schaller authored
Test 125 Added a new test to help @jwillis with vectorization. The old tests are now more thorough as well. See merge request !208
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
Corrected names in testSingle.c to reflect part struct change. See merge request !209
-
- 28 Jul, 2016 11 commits
-
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
James Willis authored
-
James Willis authored
-
- 27 Jul, 2016 10 commits
-
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
Time integration mistake ? Noticed this time integration mistake whilst working on the gravity code. Could this explain the non-conservation of energy ? See merge request !196
-
James Willis authored
-
Peter W. Draper authored
Intrinsic vectorisation I have implemented vectorised versions of the symmetrical and non-symmetrical density and force interaction functions for the `GADGET_SPH` scheme. There are also tests for each interaction in `tests/testInteractions.c`. There are some bug fixes in the `DEFAULT_SPH` along with changes to the `struct part` and minor renaming of variables. Calculations of the `balsara` switch and `P_over_rho2` are now performed in `hydro_prepare_force()` rather than in `runner_iact_nonsym_force` or `runner_iact_force`. Note: The !203 `gadget2-part-update` branch should be merged with master prior to this merge request. See merge request !204
-
Matthieu Schaller authored
-
Matthieu Schaller authored
Add entropy to the energy diagnostic file. Use an MPI_Reduce instead of MPI_Allreduce to get the values
-
James Willis authored
-
James Willis authored
-
- 26 Jul, 2016 6 commits
-
-
James Willis authored
-
James Willis authored
Conflicts: src/hydro/Default/hydro_iact.h src/hydro/Gadget2/hydro.h src/hydro/Gadget2/hydro_debug.h src/hydro/Gadget2/hydro_iact.h src/hydro/Gadget2/hydro_part.h tests/testInteractions.c tests/testSymInt.c
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-