- 11 Apr, 2017 8 commits
-
-
Matthieu Schaller authored
Reduce number of all-to-all communications Attempt to answer #273. Just a place marker for the moment. See merge request !323
-
Peter W. Draper authored
Do not recurse to lower cells within the sub-tasks if they don't contain any particles. This should fix #274. @jwillis could you please check that your setup that crashes works with this version ? It builds on your proposed fix but I moved the decision of aborting higher up in the recursion. See merge request !326
-
Peter W. Draper authored
Do not recurse to lower cells within the sub-tasks if they don't contain any particles. This should fix #274. @jwillis could you please check that your setup that crashes works with this version ? It builds on your proposed fix but I moved the decision of aborting higher up in the recursion. See merge request !326
-
James Willis authored
-
James Willis authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
- 10 Apr, 2017 4 commits
-
-
Matthieu Schaller authored
Added smoothing length correction limiter to Gizmo hydro_predict_extra. For some reason, the smoothing length prediction in GIZMO sometimes goes completely wrong, causing the code to crash in space_regrid, see #271. To overcome this, I have added a limit on the increase in smoothing length during the prediction step for GIZMO. This appears to solve the issue @jwillis was having with the EAGLE_12 test (I am currently testing it on one of my machines, and it's still running after 6000 steps). I'm not sure it is worth looking into the cause of the bad smoothing length predictions. The smoothing length update is computed based on a mixture of SPH and GIZMO variables, so this is bound to go wrong sometimes. Maybe there are smarter ways to do this. See merge request !318
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Peter W. Draper authored
-
- 03 Apr, 2017 2 commits
-
-
Peter W. Draper authored
-
Matthieu Schaller authored
-
- 01 Apr, 2017 7 commits
-
-
Matthieu Schaller authored
-
Matthieu Schaller authored
Moved the sorting entry structure to a separate file following @jwillis' work in the vectorisation branch.
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
Voronoi tests work now. I think I added all missing files used by `SHADOWFAX_SPH` and `GIZMO_SPH` to `Makefile.am`. I have also introduced a tolerance for geometric tests in the 2D Voronoi algorithm, which fixes round off issues that caused `testVoronoi2D` to fail if compiled with optimizations enabled. This fixes #282. See merge request !325
-
- 31 Mar, 2017 2 commits
-
-
Peter W. Draper authored
Gravity multi dt This fully implements self-gravity bar the periodic task over MPI. Could you please check that is does not break anything on the hydro side ? If you are interested in running with self-gravity I'd recommend using the updated EAGLE_12 case and run with `-D -G`. My next steps is to work on the formal requirement of using `-D` alongside the `-G`. I also need to finish working out the automated scripts to generate code for the higher-order multipoles but that is orthogonal to the integration of the code into the master. See merge request !324
-
Bert Vandenbroucke authored
Added missing SHADOWFAX_SPH and GIZMO_SPH files to src/Makefile.am. Removed unused counter from riemann_solve_brent().
-
- 30 Mar, 2017 2 commits
-
-
Matthieu Schaller authored
-
Peter W. Draper authored
-
- 24 Mar, 2017 8 commits
-
-
Bert Vandenbroucke authored
Introduced a tolerance for the 2D Voronoi algorithm to handle round off problems. The 2D Voronoi test now works for both the optimized and the non-optimized version of the code.
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
- 23 Mar, 2017 5 commits
-
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
-
Matthieu Schaller authored
1D and 2D moving mesh algorithm I have added a new hydro scheme, `SHADOWFAX_SPH`, that uses a finite volume method on a moving mesh. The scheme is very similar to `GIZMO_SPH`, except that during the density loop an actual Voronoi cell is constructed for every particle, which is then used to get a volume to update the primitive quantities, and faces through which fluxes are exchanged. There are also some small changes in the way gradients are computed, and in the way the velocity of the particles is set. The Voronoi cell construction is completely different for 1D, 2D, and 3D, and currently only 1D and 2D have a stable implementation. 3D should compile, but does not produce reliable results (yet). However, I think it would be good to merge this in already, to prevent it from drifting too far apart from `master`. The current implementation is hydro only, but it should be very straightforward to add gravity, similarly to the way it is done in `GIZMO_SPH`. Below the results for the 2D Sod shock and Sedov blast test (the noise on the density is caused by the fact that the initial conditions contain mass and not density). The 2D Noh test crashes because of time stepping issues; I think we really need a time step limiter to make it work properly.   See merge request !321
-
- 22 Mar, 2017 2 commits
-
-
Peter W. Draper authored
Uses '1' as we could possibly have a second or third requirement for collections...
-
Matthieu Schaller authored
-