Fixed the gravity bugs reported in #363. Need to find a good rebuild criterion for gravity-only runs.

Run naive interactions

Added an option to run the naive interactions instead of the optimized ones. These are to be used for debugging purposes.

See merge request !428

Patch vectorised pair interactions

Implements small optimisations to `runner_dopair1_density_vec` suggested in #354:
 - Break out of the loop checking for active particles if the cell itself is inactive
 - Do the calculation in the frame of `cj` and not `ci` since this is where the shift vector brings us.
 - Correctly apply the rshift value on the axis linking cells.

See merge request !407

Fix to #363. Drifting decision needs to use the same multipole information as the actual tree walk. Also fix some gravity_cache padding values.

Added the missing DOSELF1_NAIVE() interaction function. Added checks that particles are drifted also in the subset functions.

Use H5Lexists to check whether /Units exists in IC files before attempting to read them

Updated to use H5Lexists to check whether user has input units into 
their Initial Conditions files. This avoids error rasises from H5G* when
opening files without units and reverting back to the ones specified in
the parameterfile. We now also let users know when their units are being
read from their ICs explicitly.

See merge request !427

their Initial Conditions files. This avoids error rasises from H5G* when
opening files without units and reverting back to the ones specified in
the parameterfile. We now also let users know when their units are being
read from their ICs explicitly.

Clean up task and threadpool plotting scripts

Merges MPI and non-MPI task dump plotting and analysis scripts into single
versions that deal with both outputs.

Various tweaks so that we can generate and display task and threadpool
plots together for comparison (non-MPI only).

See #337.

See merge request !425

Symmetric version of DOPAIR2

Here is a much much better version. I now reproduce the pattern that was used in the original version but with correct loop bounds and use of rshift. 

It's now almost on par with the old (but wrong) version. 

See merge request !426

Also remove debugging output

Previously worked the other way around, which is incorrect.

When given a range of 0 autorange the tasks and plot the threadpoool using the autoranged limits of the tasks

Applied @jwillis' correction to the second loop of DOPAIR2. dx_max was entering the external loop with the wrong sign.

Keep maintenance down.

Don't touch the pinning of the main thread when not using affinity.

There is a problem when the cpu mask is empty and using multiple MPI ranks on a node, in that case all the main threads end up pinned to one core during the reading of the initial conditions (and any other tasks done before engine_init is called).


See merge request !423

Modify the inner-loop exit condition to incorporate the distance on the axis calculation rather than pre-compute it.

There is a problem when the cpu mask is empty and using multiple MPI ranks on a node, in that case all the main threads end up pinned to one core during the reading of the initial condition (and any other tasks done before engine_init is called).

In DOPAIR2(), once we have a pj candidate, check the distance on the axis using hj instead of relying only on the earlier hj_max check.

Reverse the loop to find the exit condition in DOPAIR2() to go from the centre to the outside

Follows @jwillis' suggestion in #362.

Also implements an early exit in the outer loop. If no particle can be in range any more (based on hi_max and hj_max), no need to keep checking the next particles.

See merge request !422