From df7b684ab8fbca0ffbb18a861684c34029c320f0 Mon Sep 17 00:00:00 2001 From: Filip Husko <filip.husko@durham.ac.uk> Date: Tue, 24 Oct 2023 09:37:32 +0000 Subject: [PATCH] Correctly read in critical accretion rate in SPIN/JET BH scheme --- doc/RTD/source/SubgridModels/AGNSpinJets/params.rst | 2 +- .../IdealisedCluster_M13/idealised_cluster_M13.yml | 1 + .../IdealisedCluster_M135/idealised_cluster_M135.yml | 1 + .../IdealisedCluster_M14/idealised_cluster_M14.yml | 1 + .../IdealisedCluster_M15/idealised_cluster_M15.yml | 1 + examples/parameter_example.yml | 2 +- src/black_holes/SPIN_JET/black_holes_properties.h | 5 +++-- 7 files changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/RTD/source/SubgridModels/AGNSpinJets/params.rst b/doc/RTD/source/SubgridModels/AGNSpinJets/params.rst index eef4286a1a..1fda66ccbf 100644 --- a/doc/RTD/source/SubgridModels/AGNSpinJets/params.rst +++ b/doc/RTD/source/SubgridModels/AGNSpinJets/params.rst @@ -50,7 +50,7 @@ Below we give an example of parameter choices applicable for e.g. a 50 Mpc box. include_jets: 1 # Global switch whether to include jet feedback [1] or not [0]. turn_off_radiative_feedback: 0 # Global switch whether to turn off radiative (thermal) feedback [1] or not [0]. This should only be used if 'include_jets' is set to 1, since we want feedback in some form or another. alpha_acc: 0.2 # Viscous alpha of the subgrid accretion disks. Likely to be within the 0.1-0.3 range. The main effect is that it sets the transition accretion rate between thin and thick disk, as dot(m) = 0.2 * alpha^2. - mdot_crit_ADAF: 0.01 # The transition normalized accretion rate (Eddington ratio) at which the disc goes from thick (low accretion rates) to thin (high accretion rates). The feedback also changes from kinetic jets to thermal isotropic, respectively. + mdot_crit_ADAF: 0.03 # The transition normalized accretion rate (Eddington ratio) at which the disc goes from thick (low accretion rates) to thin (high accretion rates). The feedback also changes from kinetic jets to thermal isotropic, respectively. seed_spin: 0.01 # The (randomly-directed) black hole spin assigned to BHs when they are seeded. Should be strictly between 0 and 1. AGN_jet_velocity_model: Constant # How AGN jet velocities are calculated. If 'Constant', a single value is used. If 'BlackHoleMass', then an empirical relation between halo mass and black hole mass is used to calculate jet velocities. 'HaloMass' is currently not supported. v_jet_km_p_s: 3160. # Jet velocity to use if 'AGN_jet_velocity_model' is 'Constant'. Units are km/s. diff --git a/examples/IdealisedCluster/IdealisedCluster_M13/idealised_cluster_M13.yml b/examples/IdealisedCluster/IdealisedCluster_M13/idealised_cluster_M13.yml index 1e4987e518..2a195a5737 100644 --- a/examples/IdealisedCluster/IdealisedCluster_M13/idealised_cluster_M13.yml +++ b/examples/IdealisedCluster/IdealisedCluster_M13/idealised_cluster_M13.yml @@ -284,6 +284,7 @@ SPINJETAGN: include_jets: 1 # Global switch whether to include jet feedback [1] or not [0]. Requires the 'include_spin' parameter to also be set to 1. turn_off_radiative_feedback: 1 # Global switch whether to turn off radiative feedback [1] or not [0]. This should only be used if 'include_jets' is set to 1. alpha_acc: 0.2 # Viscous alpha of the subgrid accretion disks. Should be within the 0.1-0.3 range. + mdot_crit_ADAF: 0.03 # The transition normalized accretion rate (Eddington ratio) at which the disc goes from thick (low accretion rates) to thin (high accretion rates). The feedback also changes from kinetic jets to thermal isotropic, respectively. delta_ADAF: 0.2 # Electron heating parameter, which controls the strength of radiative feedback in thick disks. Should be between 0.1 and 0.5. TD_region: B # How to treat the subgrid accretion disk if it is thin, according to the Shakura & Sunyaev (1973) model. If set to B, region b will be used. If set to C, region c will be used. N_jet: 2 # Target number of particles to kick as part of a single jet feedback event. Should be a multiple of 2 to ensure approximate momentum conservation. diff --git a/examples/IdealisedCluster/IdealisedCluster_M135/idealised_cluster_M135.yml b/examples/IdealisedCluster/IdealisedCluster_M135/idealised_cluster_M135.yml index c0a8d256ed..5a6f29eaf0 100644 --- a/examples/IdealisedCluster/IdealisedCluster_M135/idealised_cluster_M135.yml +++ b/examples/IdealisedCluster/IdealisedCluster_M135/idealised_cluster_M135.yml @@ -284,6 +284,7 @@ SPINJETAGN: include_jets: 1 # Global switch whether to include jet feedback [1] or not [0]. Requires the 'include_spin' parameter to also be set to 1. turn_off_radiative_feedback: 1 # Global switch whether to turn off radiative feedback [1] or not [0]. This should only be used if 'include_jets' is set to 1. alpha_acc: 0.2 # Viscous alpha of the subgrid accretion disks. Should be within the 0.1-0.3 range. + mdot_crit_ADAF: 0.03 # The transition normalized accretion rate (Eddington ratio) at which the disc goes from thick (low accretion rates) to thin (high accretion rates). The feedback also changes from kinetic jets to thermal isotropic, respectively. delta_ADAF: 0.2 # Electron heating parameter, which controls the strength of radiative feedback in thick disks. Should be between 0.1 and 0.5. TD_region: B # How to treat the subgrid accretion disk if it is thin, according to the Shakura & Sunyaev (1973) model. If set to B, region b will be used. If set to C, region c will be used. N_jet: 2 # Target number of particles to kick as part of a single jet feedback event. Should be a multiple of 2 to ensure approximate momentum conservation. diff --git a/examples/IdealisedCluster/IdealisedCluster_M14/idealised_cluster_M14.yml b/examples/IdealisedCluster/IdealisedCluster_M14/idealised_cluster_M14.yml index b29df144d0..07fb724733 100644 --- a/examples/IdealisedCluster/IdealisedCluster_M14/idealised_cluster_M14.yml +++ b/examples/IdealisedCluster/IdealisedCluster_M14/idealised_cluster_M14.yml @@ -284,6 +284,7 @@ SPINJETAGN: include_jets: 1 # Global switch whether to include jet feedback [1] or not [0]. Requires the 'include_spin' parameter to also be set to 1. turn_off_radiative_feedback: 1 # Global switch whether to turn off radiative feedback [1] or not [0]. This should only be used if 'include_jets' is set to 1. alpha_acc: 0.2 # Viscous alpha of the subgrid accretion disks. Should be within the 0.1-0.3 range. + mdot_crit_ADAF: 0.03 # The transition normalized accretion rate (Eddington ratio) at which the disc goes from thick (low accretion rates) to thin (high accretion rates). The feedback also changes from kinetic jets to thermal isotropic, respectively. delta_ADAF: 0.2 # Electron heating parameter, which controls the strength of radiative feedback in thick disks. Should be between 0.1 and 0.5. TD_region: B # How to treat the subgrid accretion disk if it is thin, according to the Shakura & Sunyaev (1973) model. If set to B, region b will be used. If set to C, region c will be used. N_jet: 2 # Target number of particles to kick as part of a single jet feedback event. Should be a multiple of 2 to ensure approximate momentum conservation. diff --git a/examples/IdealisedCluster/IdealisedCluster_M15/idealised_cluster_M15.yml b/examples/IdealisedCluster/IdealisedCluster_M15/idealised_cluster_M15.yml index f029c7c019..71dbf91abb 100644 --- a/examples/IdealisedCluster/IdealisedCluster_M15/idealised_cluster_M15.yml +++ b/examples/IdealisedCluster/IdealisedCluster_M15/idealised_cluster_M15.yml @@ -284,6 +284,7 @@ SPINJETAGN: include_jets: 1 # Global switch whether to include jet feedback [1] or not [0]. Requires the 'include_spin' parameter to also be set to 1. turn_off_radiative_feedback: 1 # Global switch whether to turn off radiative feedback [1] or not [0]. This should only be used if 'include_jets' is set to 1. alpha_acc: 0.2 # Viscous alpha of the subgrid accretion disks. Should be within the 0.1-0.3 range. + mdot_crit_ADAF: 0.03 # The transition normalized accretion rate (Eddington ratio) at which the disc goes from thick (low accretion rates) to thin (high accretion rates). The feedback also changes from kinetic jets to thermal isotropic, respectively. delta_ADAF: 0.2 # Electron heating parameter, which controls the strength of radiative feedback in thick disks. Should be between 0.1 and 0.5. TD_region: B # How to treat the subgrid accretion disk if it is thin, according to the Shakura & Sunyaev (1973) model. If set to B, region b will be used. If set to C, region c will be used. N_jet: 2 # Target number of particles to kick as part of a single jet feedback event. Should be a multiple of 2 to ensure approximate momentum conservation. diff --git a/examples/parameter_example.yml b/examples/parameter_example.yml index c94a480fa1..06f73b8e2b 100644 --- a/examples/parameter_example.yml +++ b/examples/parameter_example.yml @@ -788,7 +788,7 @@ SPINJETAGN: include_jets: 1 # Global switch whether to include jet feedback [1] or not [0]. turn_off_radiative_feedback: 0 # Global switch whether to turn off radiative (thermal) feedback [1] or not [0]. This should only be used if 'include_jets' is set to 1, since we want feedback in some form or another. alpha_acc: 0.2 # Viscous alpha of the subgrid accretion disks. Likely to be within the 0.1-0.3 range. The main effect is that it sets the transition accretion rate between the thin and thick disk, as dot(m) = 0.2 * alpha^2. - mdot_crit_ADAF: 0.01 # The transition normalized accretion rate (Eddington ratio) at which the disc goes from thick (low accretion rates) to thin (high accretion rates). The feedback also changes from kinetic jets to thermal isotropic, respectively. + mdot_crit_ADAF: 0.03 # The transition normalized accretion rate (Eddington ratio) at which the disc goes from thick (low accretion rates) to thin (high accretion rates). The feedback also changes from kinetic jets to thermal isotropic, respectively. seed_spin: 0.01 # The (randomly-directed) black hole spin assigned to BHs when they are seeded. Should be strictly between 0 and 1. AGN_jet_velocity_model: Constant # How AGN jet velocities are calculated. If 'Constant', a single value is used. If 'BlackHoleMass', then an empirical relation between halo mass and black hole mass is used to calculate jet velocities. 'HaloMass' is currently not supported. v_jet_km_p_s: 3160. # Jet velocity to use if 'AGN_jet_velocity_model' is 'Constant'. Units are km/s. diff --git a/src/black_holes/SPIN_JET/black_holes_properties.h b/src/black_holes/SPIN_JET/black_holes_properties.h index 9a044d297a..ff497d45a9 100644 --- a/src/black_holes/SPIN_JET/black_holes_properties.h +++ b/src/black_holes/SPIN_JET/black_holes_properties.h @@ -668,9 +668,10 @@ INLINE static void black_holes_props_init(struct black_holes_props *bp, bp->seed_spin); } - /* Calculate the critical transition accretion rate between the thick and + /* The critical transition accretion rate between the thick and thin disk regimes. */ - bp->mdot_crit_ADAF = 0.2 * bp->alpha_acc_2; + bp->mdot_crit_ADAF = + parser_get_param_float(params, "SPINJETAGN:mdot_crit_ADAF"); /* Calculate the gas-to-total pressure ratio as based on simulations (see Yuan & Narayan 2014) */ -- GitLab