From af1f075e33c6376624e28fb915024d09b371e1a0 Mon Sep 17 00:00:00 2001
From: Bert Vandenbroucke <bert.vandenbroucke@ugent.be>
Date: Thu, 15 Sep 2016 17:19:58 +0200
Subject: [PATCH] Fixed bug in HLLC Riemann solver flux calculation.
---
src/riemann/riemann_hllc.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/riemann/riemann_hllc.h b/src/riemann/riemann_hllc.h
index b8b1239d77..1a4c3f5f83 100644
--- a/src/riemann/riemann_hllc.h
+++ b/src/riemann/riemann_hllc.h
@@ -145,11 +145,13 @@ __attribute__((always_inline)) INLINE static void riemann_solve_for_flux(
we add the extra velocity flux due to the absolute motion of the fluid
similarly, we need to add the energy fluxes due to the absolute motion */
v2 = vij[0] * vij[0] + vij[1] * vij[1] + vij[2] * vij[2];
+ // order is important: we first use the momentum fluxes to update the energy
+ // flux and then de-boost the momentum fluxes!
+ totflux[4] += vij[0] * totflux[1] + vij[1] * totflux[2] +
+ vij[2] * totflux[3] + 0.5 * v2 * totflux[0];
totflux[1] += vij[0] * totflux[0];
totflux[2] += vij[1] * totflux[0];
totflux[3] += vij[2] * totflux[0];
- totflux[4] += vij[0] * totflux[1] + vij[1] * totflux[2] +
- vij[2] * totflux[3] + 0.5 * v2 * totflux[0];
}
#endif /* SWIFT_RIEMANN_HLLC_H */
--
GitLab