From 95c42c6ee828d8c527f353c643e7b42ad58f9bf1 Mon Sep 17 00:00:00 2001 From: Yves Revaz <yves.revaz@epfl.ch> Date: Mon, 10 Mar 2025 09:12:04 +0000 Subject: [PATCH] tiny improvements --- doc/RTD/source/GettingStarted/compiling_code.rst | 10 ++++++++++ doc/RTD/source/SubgridModels/Basic/index.rst | 2 +- doc/RTD/source/SubgridModels/GEAR/index.rst | 12 ++++++++---- .../IsolatedGalaxy_multi_component/makeDisk.py | 2 +- 4 files changed, 20 insertions(+), 6 deletions(-) diff --git a/doc/RTD/source/GettingStarted/compiling_code.rst b/doc/RTD/source/GettingStarted/compiling_code.rst index 9498fe9039..bc08e7118f 100644 --- a/doc/RTD/source/GettingStarted/compiling_code.rst +++ b/doc/RTD/source/GettingStarted/compiling_code.rst @@ -105,6 +105,16 @@ GRACKLE GRACKLE cooling is implemented in SWIFT. If you wish to take advantage of it, you will need it installed. It can be found `here <https://github.com/grackle-project/grackle>`_. +.. warning:: + (State 2023) Grackle is experiencing current development, and the API is subject + to changes in the future. For convenience, a frozen version is hosted as a fork + on github here: https://github.com/mladenivkovic/grackle-swift . + The version available there will be tried and tested and ensured to work with + SWIFT. + + Additionally, that repository hosts files necessary to install that specific + version of grackle with spack. + HEALPix C library ~~~~~~~~~~~~~~~~~~~ diff --git a/doc/RTD/source/SubgridModels/Basic/index.rst b/doc/RTD/source/SubgridModels/Basic/index.rst index 710da13715..0a6ea4b5be 100644 --- a/doc/RTD/source/SubgridModels/Basic/index.rst +++ b/doc/RTD/source/SubgridModels/Basic/index.rst @@ -6,7 +6,7 @@ Basic model (others) ==================== Sinks: Simple Bondi-Hoyle accretion -~~~~~~~~~~~~~~~~~~~~~~~~ +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The ``Basic`` sink model provides a foundation on which new sink implementations could be built. It includes a prescription for Bondi-Hoyle gas accretion, and a method for sink-sink mergers that is a slightly simplified version of the implementation used in GEAR. diff --git a/doc/RTD/source/SubgridModels/GEAR/index.rst b/doc/RTD/source/SubgridModels/GEAR/index.rst index 4b01c9d778..30b79689a2 100644 --- a/doc/RTD/source/SubgridModels/GEAR/index.rst +++ b/doc/RTD/source/SubgridModels/GEAR/index.rst @@ -63,10 +63,14 @@ In order to compile SWIFT with Grackle, you need to provide the options ``with-c where ``$GRACKLE_ROOT`` is the root of the install directory (not the ``lib``). .. warning:: - The actual Grackle version fully supported by SWIFT is 3.2.1. It can be downloaded from - `the official Grackle git repository <https://github.com/grackle-project/grackle/archive/refs/tags/grackle-3.2.1.tar.gz>`_. - However, this version still had a bug when using threadsafe functions. Alternately, it is possible to get a fixed version - using `the following fork frozen for compatibility with SWIFT <https://github.com/mladenivkovic/grackle-swift>`_. + (State 2023) Grackle is experiencing current development, and the API is subject + to changes in the future. For convenience, a frozen version is hosted as a fork + on github here: https://github.com/mladenivkovic/grackle-swift . + The version available there will be tried and tested and ensured to work with + SWIFT. + + Additionally, that repository hosts files necessary to install that specific + version of grackle with spack. To compile it, run diff --git a/examples/IsolatedGalaxy/IsolatedGalaxy_multi_component/makeDisk.py b/examples/IsolatedGalaxy/IsolatedGalaxy_multi_component/makeDisk.py index 70f5c2d9c4..39d4c9419a 100755 --- a/examples/IsolatedGalaxy/IsolatedGalaxy_multi_component/makeDisk.py +++ b/examples/IsolatedGalaxy/IsolatedGalaxy_multi_component/makeDisk.py @@ -557,7 +557,7 @@ nb3.set_tpe("stars_1") # position expected by swift nb4 = nb.select("gas") if hydro == 0: - nb4.set_tpe("bndry") + nb4.set_tpe("stars_1") nb = nb1 + nb2 + nb3 + nb4 -- GitLab