From 5debd18beec28364c7a7562d3385bb1c13347e66 Mon Sep 17 00:00:00 2001 From: Matthieu Schaller <schaller@strw.leidenuniv.nl> Date: Wed, 29 May 2019 15:59:09 +0200 Subject: [PATCH] Initialize arrays of characters before using them in the meta-data. --- src/parallel_io.c | 2 +- src/serial_io.c | 2 +- src/single_io.c | 2 +- src/units.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/parallel_io.c b/src/parallel_io.c index 7ba28d6f50..d58ee80814 100644 --- a/src/parallel_io.c +++ b/src/parallel_io.c @@ -426,7 +426,7 @@ void prepareArray(struct engine* e, hid_t grp, char* fileName, FILE* xmfFile, if (h_data < 0) error("Error while creating dataspace '%s'.", props.name); /* Write unit conversion factors for this data set */ - char buffer[FIELD_BUFFER_SIZE]; + char buffer[FIELD_BUFFER_SIZE] = {0}; units_cgs_conversion_string(buffer, snapshot_units, props.units); float baseUnitsExp[5]; units_get_base_unit_exponents_array(baseUnitsExp, props.units); diff --git a/src/serial_io.c b/src/serial_io.c index e16a3351d7..80eff5adac 100644 --- a/src/serial_io.c +++ b/src/serial_io.c @@ -311,7 +311,7 @@ void prepareArray(const struct engine* e, hid_t grp, char* fileName, props.dimension, props.type); /* Write unit conversion factors for this data set */ - char buffer[FIELD_BUFFER_SIZE]; + char buffer[FIELD_BUFFER_SIZE] = {0}; units_cgs_conversion_string(buffer, snapshot_units, props.units); float baseUnitsExp[5]; units_get_base_unit_exponents_array(baseUnitsExp, props.units); diff --git a/src/single_io.c b/src/single_io.c index d1ef358b03..3e6ea192de 100644 --- a/src/single_io.c +++ b/src/single_io.c @@ -323,7 +323,7 @@ void writeArray(const struct engine* e, hid_t grp, char* fileName, props.dimension, props.type); /* Write unit conversion factors for this data set */ - char buffer[FIELD_BUFFER_SIZE]; + char buffer[FIELD_BUFFER_SIZE] = {0}; units_cgs_conversion_string(buffer, snapshot_units, props.units); float baseUnitsExp[5]; units_get_base_unit_exponents_array(baseUnitsExp, props.units); diff --git a/src/units.c b/src/units.c index 807640a1d2..ef69bb73de 100644 --- a/src/units.c +++ b/src/units.c @@ -522,7 +522,7 @@ float units_general_a_factor(const struct unit_system* us, void units_general_cgs_conversion_string(char* buffer, const struct unit_system* us, const float baseUnitsExponents[5]) { - char temp[32]; + char temp[32] = {0}; const double a_exp = units_general_a_factor(us, baseUnitsExponents); const double h_exp = 0.; /* There are no h-factors in SWIFT outputs. */ -- GitLab