diff --git a/configure.ac b/configure.ac index ba119835680f3679809f3d4d3f0133f74ea04454..3477cace47ea2c26e5e93b3217c99743c1a739f3 100644 --- a/configure.ac +++ b/configure.ac @@ -1008,9 +1008,10 @@ AC_ARG_WITH([python], ) if test "x$with_python" != "xno"; then AC_CACHE_CHECK( - "python version", - ac_cv_ver_python, - [ac_cv_ver_python=`python -c 'import sys;print(sys.version[[:3]])' 2> /dev/null`]) + "python version", + ac_cv_ver_python, + [ac_cv_ver_python=`python -c 'import sys;print(sys.version[[:3]])' 2> /dev/null`] + ) if test "x$with_python" != "xyes" -a "x$with_python" != "x"; then PYTHON_LIBS="" @@ -1019,6 +1020,7 @@ if test "x$with_python" != "xno"; then PYTHON_LIBS="" PYTHON_INCS="" fi + have_python="yes" AC_CHECK_PROGS( @@ -1033,8 +1035,8 @@ if test "x$with_python" != "xno"; then [PyArg_ParseTuple], [AC_DEFINE([HAVE_PYTHON],1,[The python library appears to be present.]) ], - [AC_MSG_ERROR(Cannot find python library!)] - ) + [AC_MSG_ERROR(Cannot find python library!)], + [$PYTHON_LIBS]) fi AC_SUBST([PYTHON_LIBS]) AC_SUBST([PYTHON_INCS]) diff --git a/logger/Makefile.am b/logger/Makefile.am index d2cc4a8a72f4aa27cdda7b9809c90f727a461ba8..bc0d67ffbcd908799c6de5b1c64a23d5dc462b4d 100644 --- a/logger/Makefile.am +++ b/logger/Makefile.am @@ -39,11 +39,11 @@ lib_LTLIBRARIES = libswiftlogger.la # endif # List required headers -include_HEADERS = header.h io.h particle.h timeline.h tools.h +include_HEADERS = header.h io.h particle.h timeline.h logger_tools.h # Common source files AM_SOURCES = header.c io.c logger_loader.c particle.c \ - timeline.c tools.c + timeline.c logger_tools.c # Include files for distribution, not installation. nobase_noinst_HEADERS = diff --git a/logger/header.c b/logger/header.c index 6edfd6d5e0e97a9429f83969552a4aa35c891099..70a806607183b29673241aba7832e6995a52c123 100644 --- a/logger/header.c +++ b/logger/header.c @@ -1,7 +1,7 @@ #include "header.h" #include "io.h" -#include "tools.h" +#include "logger_tools.h" #include <Python.h> #include <stdio.h> diff --git a/logger/header.h b/logger/header.h index c2e89850418b94eb4d05381e698534a3719652c9..06ada140666628530edfd18cbda8f35e52eff0ce 100644 --- a/logger/header.h +++ b/logger/header.h @@ -1,7 +1,7 @@ #ifndef __LOGGER_HEADER_H__ #define __LOGGER_HEADER_H__ -#include "tools.h" +#include "logger_tools.h" #include <Python.h> #include <stdio.h> diff --git a/logger/io.c b/logger/io.c index 9ed62e7fc905e816199d17122aa993fa4e27785d..bab4953a73924684593cc0dc09ad58bc244a0dc6 100644 --- a/logger/io.c +++ b/logger/io.c @@ -1,6 +1,6 @@ #include "io.h" #include "header.h" -#include "tools.h" +#include "logger_tools.h" /* file size */ #include <sys/stat.h> @@ -24,7 +24,7 @@ int io_open_file(char *filename, int *fd, void **map) { if (*fd == -1) error(errno, "Unable to open file %s", filename); /* get file size */ - size_t size; + size_t size = 0; int status = io_get_file_size(*fd, &size); if (status != 0) return status; @@ -38,7 +38,7 @@ int io_open_file(char *filename, int *fd, void **map) { int io_close_file(int *fd, void **map) { /* get file size */ - size_t size; + size_t size = 0; int status = io_get_file_size(*fd, &size); if (status != 0) return status; diff --git a/logger/io.h b/logger/io.h index da4cf34e5367372e3c641f1081a280972faecd66..5f909c68e92258ad495613f247748da314344324 100644 --- a/logger/io.h +++ b/logger/io.h @@ -2,7 +2,7 @@ #define __SWIFT_LOGGER_IO_H__ #include "header.h" -#include "tools.h" +#include "logger_tools.h" #include <stdio.h> #include <stdlib.h> diff --git a/logger/logger_loader.c b/logger/logger_loader.c index 108f94a89c660147551744d22cffe01c1cf59e2d..c60e0875b9e4748d4f692f40b947fb5ad59c4ba1 100644 --- a/logger/logger_loader.c +++ b/logger/logger_loader.c @@ -335,7 +335,7 @@ static PyObject *pyReverseOffset(__attribute__((unused)) PyObject *self, /* definition of the method table */ -static PyMethodDef logger_loaderMethods[] = { +static PyMethodDef libswiftloggerMethods[] = { {"loadFromIndex", loadFromIndex, METH_VARARGS, "Load snapshot directly from the offset in an index file."}, {"reverseOffset", pyReverseOffset, METH_VARARGS, @@ -344,21 +344,21 @@ static PyMethodDef logger_loaderMethods[] = { {NULL, NULL, 0, NULL} /* Sentinel */ }; -static struct PyModuleDef logger_loadermodule = { +static struct PyModuleDef libswiftloggermodule = { PyModuleDef_HEAD_INIT, - "logger_loader", + "libswiftlogger", "Module reading a SWIFTsim logger snapshot", -1, - logger_loaderMethods, + libswiftloggerMethods, NULL, /* m_slots */ NULL, /* m_traverse */ NULL, /* m_clear */ NULL /* m_free */ }; -PyMODINIT_FUNC PyInit_logger_loader(void) { +PyMODINIT_FUNC PyInit_libswiftlogger(void) { PyObject *m; - m = PyModule_Create(&logger_loadermodule); + m = PyModule_Create(&libswiftloggermodule); if (m == NULL) return NULL; import_array(); diff --git a/logger/tools.c b/logger/logger_tools.c similarity index 97% rename from logger/tools.c rename to logger/logger_tools.c index ce2fde8f4c5f12fc0491a2a867e88c2420d8c80b..d668ab6e66fa665b2e693740987ea1efbdffc999 100644 --- a/logger/tools.c +++ b/logger/logger_tools.c @@ -1,4 +1,4 @@ -#include "tools.h" +#include "logger_tools.h" #include "header.h" #include "io.h" @@ -45,7 +45,7 @@ int _tools_get_next_chunk_backward(const struct header *h, void *map, while (current_offset < file_size) { size_t mask = 0; size_t prev_offset; - int test = io_read_mask(h, map, ¤t_offset, &mask, &prev_offset); + test = io_read_mask(h, map, ¤t_offset, &mask, &prev_offset); if (test != 0) return test; prev_offset = current_offset - prev_offset - chunk_header; diff --git a/logger/tools.h b/logger/logger_tools.h similarity index 100% rename from logger/tools.h rename to logger/logger_tools.h diff --git a/logger/particle.c b/logger/particle.c index 26b20a8fd5bdb7a38f744d32a7730e88996b5cd8..dfd27d8e196143f88de78edb68a995bb50270a45 100644 --- a/logger/particle.c +++ b/logger/particle.c @@ -2,7 +2,7 @@ #include "header.h" #include "io.h" #include "timeline.h" -#include "tools.h" +#include "logger_tools.h" #include <stdio.h> #include <stdlib.h> diff --git a/logger/particle.h b/logger/particle.h index 07712cd369f6e284ec9d39338ac2773194ff665f..d787fcc424ffa43b736a6e2fbde31a4528c80049 100644 --- a/logger/particle.h +++ b/logger/particle.h @@ -3,7 +3,7 @@ #include "header.h" #include "timeline.h" -#include "tools.h" +#include "logger_tools.h" #include <stdio.h> #include <stdlib.h> diff --git a/logger/timeline.c b/logger/timeline.c index 7eec898d54c0152231bc28ccb7b1ac211ec08a15..6ec15b36a7b41e6248b4249f690f1cb9ed0b51ce 100644 --- a/logger/timeline.c +++ b/logger/timeline.c @@ -14,7 +14,6 @@ int time_read(integertime_t *timestamp, double *time, const struct header *h, vo size_t *offset) { int error_code = 0; size_t mask = 0; - size_t ind = 0; size_t prev_offset = 0; *timestamp = 0; *time = 0; @@ -24,6 +23,8 @@ int time_read(integertime_t *timestamp, double *time, const struct header *h, vo if (error_code != 0) return error_code; #ifdef SWIFT_DEBUG_CHECKS + size_t ind = 0; + /* check if timestamp is present */ if (!header_is_present_and_get_index(h, "timestamp", &ind)) error(EIO, "Header does not contain a timestamp"); diff --git a/logger/timeline.h b/logger/timeline.h index c5231dcaf78fe4816adbf1bb87d7dd799013142e..96b3cd79000c307e3089cc1120c154ed1ee02489 100644 --- a/logger/timeline.h +++ b/logger/timeline.h @@ -2,7 +2,7 @@ #define __TIMELINE_H__ #include "header.h" -#include "tools.h" +#include "logger_tools.h" typedef char timebin_t; typedef long long integertime_t;