From 2cda534da1de7fc7962cb73080002b8cb7a43082 Mon Sep 17 00:00:00 2001 From: "Peter W. Draper" <p.w.draper@durham.ac.uk> Date: Mon, 14 Dec 2015 15:56:11 +0000 Subject: [PATCH] Add fixes for -Wformat-security warnings (seems to be enabled on Ubuntu). This doesn't allow non-string literals as formats, these may include format specifiers and can cause buffer overruns, maybe. --- src/version.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/version.c b/src/version.c index 1d6b09b722..e49d0cda90 100644 --- a/src/version.c +++ b/src/version.c @@ -37,9 +37,9 @@ const char *git_revision(void) { static const char *revision = GIT_REVISION; if(!initialised) { if(strlen(revision) == 0) - sprintf(buf, "Unknown"); + sprintf(buf, "%s", "unknown"); else - sprintf(buf, revision); + sprintf(buf, "%s", revision); initialised = 1; } return buf; @@ -56,9 +56,9 @@ const char *git_branch(void) { static const char *branch = GIT_BRANCH; if(!initialised) { if(strlen(branch) == 0) - sprintf(buf, "Unknown"); + sprintf(buf, "%s", "unknown"); else - sprintf(buf, branch); + sprintf(buf, "%s", branch); initialised = 1; } return buf; -- GitLab