From 0f94a9bd9ddedd06319a7bfceb67d6998435eb72 Mon Sep 17 00:00:00 2001
From: "Peter W. Draper" <p.w.draper@durham.ac.uk>
Date: Wed, 15 Nov 2017 11:32:18 +0000
Subject: [PATCH] Fix up commenting
---
examples/plot_task_dependencies.sh | 11 +++++++----
src/scheduler.c | 6 +++---
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/examples/plot_task_dependencies.sh b/examples/plot_task_dependencies.sh
index 820f20e228..77784d8a9c 100755
--- a/examples/plot_task_dependencies.sh
+++ b/examples/plot_task_dependencies.sh
@@ -1,10 +1,13 @@
#!/bin/bash
-# Check that the required file is present
-if [ ! -e dependency_graph.dot ]
-then
- echo "Missing task-graph output! Can generate figure."
+# Creates a graphic from the task graph file dependency_graph.dot.
+# Requires the graphviz command "dot".
+
+if [ ! -e dependency_graph.dot ]; then
+ echo "Missing task-graph output 'dependency_graph.dot'! Cannot generate figure."
else
dot -Tpng dependency_graph.dot -o task_graph.png
+ echo "Output written to task_graph.png"
fi
+exit
diff --git a/src/scheduler.c b/src/scheduler.c
index 940e55b84b..f85a058b5f 100644
--- a/src/scheduler.c
+++ b/src/scheduler.c
@@ -128,7 +128,7 @@ void scheduler_write_dependencies(struct scheduler *s, int verbose) {
/* Conservative number of dependencies per task type */
const int max_nber_dep = 128;
- /* Number of possibble relations between tasks */
+ /* Number of possible relations between tasks */
const int nber_relation =
2 * task_type_count * task_subtype_count * max_nber_dep;
@@ -146,7 +146,7 @@ void scheduler_write_dependencies(struct scheduler *s, int verbose) {
/* Create file */
char filename[200] = "dependency_graph.dot";
FILE *f = fopen(filename, "w");
- if (f == NULL) error("Error opening depenency graph file.");
+ if (f == NULL) error("Error opening dependency graph file.");
/* Write header */
fprintf(f, "digraph task_dep {\n");
@@ -159,7 +159,7 @@ void scheduler_write_dependencies(struct scheduler *s, int verbose) {
for (int i = 0; i < s->nr_tasks; i++) {
const struct task *ta = &s->tasks[i];
- /* and theirs dependencies */
+ /* and their dependencies */
for (int j = 0; j < ta->nr_unlock_tasks; j++) {
const struct task *tb = ta->unlock_tasks[j];
--
GitLab