engine.c 157 KB
Newer Older
Pedro Gonnet's avatar
Pedro Gonnet committed
1
/*******************************************************************************
2
 * This file is part of SWIFT.
3
 * Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
4
 *                    Matthieu Schaller (matthieu.schaller@durham.ac.uk)
Peter W. Draper's avatar
Peter W. Draper committed
5
 *               2015 Peter W. Draper (p.w.draper@durham.ac.uk)
6
7
8
 *                    Angus Lepper (angus.lepper@ed.ac.uk)
 *               2016 John A. Regan (john.a.regan@durham.ac.uk)
 *                    Tom Theuns (tom.theuns@durham.ac.uk)
9
 *
Pedro Gonnet's avatar
Pedro Gonnet committed
10
11
12
13
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
14
 *
Pedro Gonnet's avatar
Pedro Gonnet committed
15
16
17
18
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
19
 *
Pedro Gonnet's avatar
Pedro Gonnet committed
20
21
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
22
 *
Pedro Gonnet's avatar
Pedro Gonnet committed
23
24
25
26
27
28
29
30
31
 ******************************************************************************/

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <sched.h>
32
#include <stdbool.h>
33
34
35
36
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
37

38
39
/* MPI headers. */
#ifdef WITH_MPI
40
#include <mpi.h>
41
42
#endif

Angus Lepper's avatar
Angus Lepper committed
43
44
#ifdef HAVE_LIBNUMA
#include <numa.h>
45
46
#endif

47
/* This object's header. */
Pedro Gonnet's avatar
Pedro Gonnet committed
48
#include "engine.h"
49
50

/* Local headers. */
51
#include "active.h"
52
#include "atomic.h"
53
#include "cell.h"
54
#include "clocks.h"
55
56
#include "cycle.h"
#include "debug.h"
57
#include "error.h"
58
#include "gravity.h"
59
#include "hydro.h"
60
#include "map.h"
61
#include "minmax.h"
62
#include "parallel_io.h"
63
#include "part.h"
64
#include "partition.h"
James Willis's avatar
James Willis committed
65
#include "profiler.h"
66
67
#include "proxy.h"
#include "runner.h"
68
69
#include "serial_io.h"
#include "single_io.h"
70
#include "sort_part.h"
71
#include "statistics.h"
72
#include "timers.h"
73
#include "tools.h"
74
#include "units.h"
75
#include "version.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
76

77
78
79
/* Particle cache size. */
#define CACHE_SIZE 512

80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
const char *engine_policy_names[] = {"none",
                                     "rand",
                                     "steal",
                                     "keep",
                                     "block",
                                     "cpu_tight",
                                     "mpi",
                                     "numa_affinity",
                                     "hydro",
                                     "self_gravity",
                                     "external_gravity",
                                     "cosmology_integration",
                                     "drift_all",
                                     "reconstruct_mpoles",
                                     "cooling",
                                     "sourceterms",
                                     "stars"};
Pedro Gonnet's avatar
Pedro Gonnet committed
97

98
99
100
/** The rank of the engine as a global variable (for messages). */
int engine_rank;

101
102
103
104
/**
 * @brief Link a density/force task to a cell.
 *
 * @param e The #engine.
105
 * @param l A pointer to the #link, will be modified atomically.
106
107
108
109
 * @param t The #task.
 *
 * @return The new #link pointer.
 */
110
void engine_addlink(struct engine *e, struct link **l, struct task *t) {
111

112
  /* Get the next free link. */
113
114
115
116
117
  const int ind = atomic_inc(&e->nr_links);
  if (ind >= e->size_links) {
    error("Link table overflow.");
  }
  struct link *res = &e->links[ind];
118

119
  /* Set it atomically. */
120
  res->t = t;
121
  res->next = atomic_swap(l, res);
122
}
123

124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
/**
 * @brief Recursively add non-implicit ghost tasks to a cell hierarchy.
 */
void engine_add_ghosts(struct engine *e, struct cell *c, struct task *ghost_in,
                       struct task *ghost_out) {
  if (!c->split || c->count < engine_max_parts_per_ghost) {
    struct scheduler *s = &e->sched;
    c->ghost =
        scheduler_addtask(s, task_type_ghost, task_subtype_none, 0, 0, c, NULL);
    scheduler_addunlock(s, ghost_in, c->ghost);
    scheduler_addunlock(s, c->ghost, ghost_out);
  } else {
    for (int k = 0; k < 8; k++)
      if (c->progeny[k] != NULL)
        engine_add_ghosts(e, c->progeny[k], ghost_in, ghost_out);
  }
}

142
143
144
145
146
147
/**
 * @brief Generate the hydro hierarchical tasks for a hierarchy of cells -
 * i.e. all the O(Npart) tasks.
 *
 * Tasks are only created here. The dependencies will be added later on.
 *
148
149
 * Note that there is no need to recurse below the super-cell.
 *
150
151
152
 * @param e The #engine.
 * @param c The #cell.
 */
153
void engine_make_hierarchical_tasks(struct engine *e, struct cell *c) {
154
155

  struct scheduler *s = &e->sched;
156
  const int periodic = e->s->periodic;
157
  const int is_with_hydro = (e->policy & engine_policy_hydro);
158
  const int is_self_gravity = (e->policy & engine_policy_self_gravity);
159
  const int is_external_gravity = (e->policy & engine_policy_external_gravity);
160
  const int is_with_cooling = (e->policy & engine_policy_cooling);
Matthieu Schaller's avatar
Matthieu Schaller committed
161
  const int is_with_sourceterms = (e->policy & engine_policy_sourceterms);
162

163
  /* Are we in a super-cell ? */
164
  if (c->super == c) {
165

166
    /* Add the sort task. */
167
    if (is_with_hydro) {
168
169
      c->sorts = scheduler_addtask(s, task_type_sort, task_subtype_none, 0, 0,
                                   c, NULL);
170
    }
171

172
173
174
    /* Local tasks only... */
    if (c->nodeID == e->nodeID) {

175
      /* Add the drift tasks corresponding to the policy. */
176
      if (is_with_hydro) {
177
178
        c->drift_part = scheduler_addtask(s, task_type_drift_part,
                                          task_subtype_none, 0, 0, c, NULL);
179
      }
180
181
182
183
      if (is_self_gravity || is_external_gravity) {
        c->drift_gpart = scheduler_addtask(s, task_type_drift_gpart,
                                           task_subtype_none, 0, 0, c, NULL);
      }
184

185
186
      /* Add the two half kicks */
      c->kick1 = scheduler_addtask(s, task_type_kick1, task_subtype_none, 0, 0,
187
                                   c, NULL);
188
189

      c->kick2 = scheduler_addtask(s, task_type_kick2, task_subtype_none, 0, 0,
190
                                   c, NULL);
Tom Theuns's avatar
Tom Theuns committed
191

192
193
      /* Add the time-step calculation task and its dependency */
      c->timestep = scheduler_addtask(s, task_type_timestep, task_subtype_none,
194
                                      0, 0, c, NULL);
195
196

      scheduler_addunlock(s, c->kick2, c->timestep);
197
      scheduler_addunlock(s, c->timestep, c->kick1);
198

199
      /* Add the gravity tasks */
200
      if (is_self_gravity) {
201

202
203
        /* Initialisation of the multipoles */
        c->init_grav = scheduler_addtask(s, task_type_init_grav,
204
                                         task_subtype_none, 0, 0, c, NULL);
205

206
207
        /* Gravity non-neighbouring pm calculations */
        c->grav_long_range = scheduler_addtask(
208
            s, task_type_grav_long_range, task_subtype_none, 0, 0, c, NULL);
209

210
211
        /* Gravity recursive down-pass */
        c->grav_down = scheduler_addtask(s, task_type_grav_down,
212
                                         task_subtype_none, 0, 0, c, NULL);
213

214
        if (periodic) scheduler_addunlock(s, c->init_grav, c->grav_ghost[0]);
215
        scheduler_addunlock(s, c->init_grav, c->grav_long_range);
216
217
        scheduler_addunlock(s, c->grav_long_range, c->grav_down);
        scheduler_addunlock(s, c->grav_down, c->kick2);
218
219
      }

220
      /* Generate the ghost tasks. */
221
      if (is_with_hydro) {
222
223
224
225
226
227
228
        c->ghost_in =
            scheduler_addtask(s, task_type_ghost, task_subtype_none, 0,
                              /* implicit = */ 1, c, NULL);
        c->ghost_out =
            scheduler_addtask(s, task_type_ghost, task_subtype_none, 0,
                              /* implicit = */ 1, c, NULL);
        engine_add_ghosts(e, c, c->ghost_in, c->ghost_out);
229

230
/* Generate the extra ghost task. */
231
#ifdef EXTRA_HYDRO_LOOP
Matthieu Schaller's avatar
Matthieu Schaller committed
232
        c->extra_ghost = scheduler_addtask(s, task_type_extra_ghost,
233
                                           task_subtype_none, 0, 0, c, NULL);
234
#endif
235
      }
236

237
      /* Cooling task */
238
      if (is_with_cooling) {
Matthieu Schaller's avatar
Matthieu Schaller committed
239
        c->cooling = scheduler_addtask(s, task_type_cooling, task_subtype_none,
240
                                       0, 0, c, NULL);
241
242
243
244

        scheduler_addunlock(s, c->cooling, c->kick2);
      }

245
      /* add source terms */
246
      if (is_with_sourceterms) {
247
        c->sourceterms = scheduler_addtask(s, task_type_sourceterms,
248
                                           task_subtype_none, 0, 0, c, NULL);
249
      }
250
251
    }

252
  } else { /* We are above the super-cell so need to go deeper */
253

254
255
256
#ifdef SWIFT_DEBUG_CHECKS
    if (c->super != NULL) error("Incorrectly set super pointer");
#endif
257

258
259
260
261
    /* Recurse. */
    if (c->split)
      for (int k = 0; k < 8; k++)
        if (c->progeny[k] != NULL)
262
          engine_make_hierarchical_tasks(e, c->progeny[k]);
263
  }
264
}
265

266
267
268
269
270
271
272
273
274
275
void engine_make_hierarchical_tasks_mapper(void *map_data, int num_elements,
                                           void *extra_data) {
  struct engine *e = (struct engine *)extra_data;

  for (int ind = 0; ind < num_elements; ind++) {
    struct cell *c = &((struct cell *)map_data)[ind];
    engine_make_hierarchical_tasks(e, c);
  }
}

276
#ifdef WITH_MPI
277
/**
Peter W. Draper's avatar
Peter W. Draper committed
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
 * Do the exchange of one type of particles with all the other nodes.
 *
 * @param counts 2D array with the counts of particles to exchange with
 *               each other node.
 * @param parts the particle data to exchange
 * @param new_nr_parts the number of particles this node will have after all
 *                     exchanges have completed.
 * @param sizeofparts sizeof the particle struct.
 * @param alignsize the memory alignment required for this particle type.
 * @param mpi_type the MPI_Datatype for these particles.
 * @param nr_nodes the number of nodes to exchange with.
 * @param nodeID the id of this node.
 *
 * @result new particle data constructed from all the exchanges with the
 *         given alignment.
293
 */
294
static void *engine_do_redistribute(int *counts, char *parts,
295
296
                                    size_t new_nr_parts, size_t sizeofparts,
                                    size_t alignsize, MPI_Datatype mpi_type,
297
                                    int nr_nodes, int nodeID) {
298
299

  /* Allocate a new particle array with some extra margin */
300
  char *parts_new = NULL;
301
302
  if (posix_memalign(
          (void **)&parts_new, alignsize,
303
          sizeofparts * new_nr_parts * engine_redistribute_alloc_margin) != 0)
304
305
306
307
    error("Failed to allocate new particle data.");

  /* Prepare MPI requests for the asynchronous communications */
  MPI_Request *reqs;
308
309
  if ((reqs = (MPI_Request *)malloc(sizeof(MPI_Request) * 2 * nr_nodes)) ==
      NULL)
310
311
    error("Failed to allocate MPI request list.");

312
  /* Only send and receive only "chunk" particles per request. So we need to
313
314
315
   * loop as many times as necessary here. Make 2Gb/sizeofparts so we only
   * send 2Gb packets. */
  const int chunk = INT_MAX / sizeofparts;
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
  int sent = 0;
  int recvd = 0;

  int activenodes = 1;
  while (activenodes) {

    for (int k = 0; k < 2 * nr_nodes; k++) reqs[k] = MPI_REQUEST_NULL;

    /* Emit the sends and recvs for the data. */
    size_t offset_send = sent;
    size_t offset_recv = recvd;
    activenodes = 0;

    for (int k = 0; k < nr_nodes; k++) {

      /* Indices in the count arrays of the node of interest */
      const int ind_send = nodeID * nr_nodes + k;
      const int ind_recv = k * nr_nodes + nodeID;

      /* Are we sending any data this loop? */
      int sending = counts[ind_send] - sent;
      if (sending > 0) {
        activenodes++;
339
        if (sending > chunk) sending = chunk;
340
341
342
343

        /* If the send and receive is local then just copy. */
        if (k == nodeID) {
          int receiving = counts[ind_recv] - recvd;
344
          if (receiving > chunk) receiving = chunk;
345
          memcpy(&parts_new[offset_recv * sizeofparts],
346
                 &parts[offset_send * sizeofparts], sizeofparts * receiving);
347
348
        } else {
          /* Otherwise send it. */
349
350
351
          int res =
              MPI_Isend(&parts[offset_send * sizeofparts], sending, mpi_type, k,
                        ind_send, MPI_COMM_WORLD, &reqs[2 * k + 0]);
352
353
354
355
          if (res != MPI_SUCCESS)
            mpi_error(res, "Failed to isend parts to node %i.", k);
        }
      }
356

357
      /* If we're sending to this node, then move past it to next. */
358
      if (counts[ind_send] > 0) offset_send += counts[ind_send];
359

360
361
362
363
364
365
      /* Are we receiving any data from this node? Note already done if coming
       * from this node. */
      if (k != nodeID) {
        int receiving = counts[ind_recv] - recvd;
        if (receiving > 0) {
          activenodes++;
366
          if (receiving > chunk) receiving = chunk;
367
368
369
370
371
372
          int res = MPI_Irecv(&parts_new[offset_recv * sizeofparts], receiving,
                              mpi_type, k, ind_recv, MPI_COMM_WORLD,
                              &reqs[2 * k + 1]);
          if (res != MPI_SUCCESS)
            mpi_error(res, "Failed to emit irecv of parts from node %i.", k);
        }
373
374
      }

375
      /* If we're receiving from this node, then move past it to next. */
376
      if (counts[ind_recv] > 0) offset_recv += counts[ind_recv];
377
378
    }

379
380
381
382
383
384
385
    /* Wait for all the sends and recvs to tumble in. */
    MPI_Status stats[2 * nr_nodes];
    int res;
    if ((res = MPI_Waitall(2 * nr_nodes, reqs, stats)) != MPI_SUCCESS) {
      for (int k = 0; k < 2 * nr_nodes; k++) {
        char buff[MPI_MAX_ERROR_STRING];
        MPI_Error_string(stats[k].MPI_ERROR, buff, &res);
386
387
        message("request from source %i, tag %i has error '%s'.",
                stats[k].MPI_SOURCE, stats[k].MPI_TAG, buff);
388
389
      }
      error("Failed during waitall for part data.");
390
    }
391
392
393
394

    /* Move to next chunks. */
    sent += chunk;
    recvd += chunk;
395
396
397
398
399
400
401
402
403
404
  }

  /* Free temps. */
  free(reqs);

  /* And return new memory. */
  return parts_new;
}
#endif

405
/**
406
 * @brief Redistribute the particles amongst the nodes according
407
408
 *      to their cell's node IDs.
 *
409
410
411
412
 * The strategy here is as follows:
 * 1) Each node counts the number of particles it has to send to each other
 * node.
 * 2) The number of particles of each type is then exchanged.
413
414
415
416
 * 3) The particles to send are placed in a temporary buffer in which the
 * part-gpart links are preserved.
 * 4) Each node allocates enough space for the new particles.
 * 5) (Asynchronous) communications are issued to transfer the data.
417
418
 *
 *
419
420
 * @param e The #engine.
 */
421
void engine_redistribute(struct engine *e) {
422

423
#ifdef WITH_MPI
424

425
426
  const int nr_nodes = e->nr_nodes;
  const int nodeID = e->nodeID;
427
  struct space *s = e->s;
428
  struct cell *cells = s->cells_top;
429
  const int nr_cells = s->nr_cells;
430
  const int *cdim = s->cdim;
431
  const double iwidth[3] = {s->iwidth[0], s->iwidth[1], s->iwidth[2]};
432
433
434
  const double dim[3] = {s->dim[0], s->dim[1], s->dim[2]};
  struct part *parts = s->parts;
  struct gpart *gparts = s->gparts;
435
  struct spart *sparts = s->sparts;
436
  ticks tic = getticks();
437

438
  /* Allocate temporary arrays to store the counts of particles to be sent
439
440
   * and the destination of each particle */
  int *counts;
441
  if ((counts = (int *)malloc(sizeof(int) * nr_nodes * nr_nodes)) == NULL)
442
    error("Failed to allocate counts temporary buffer.");
443
  bzero(counts, sizeof(int) * nr_nodes * nr_nodes);
444

445
  int *dest;
446
  if ((dest = (int *)malloc(sizeof(int) * s->nr_parts)) == NULL)
447
448
    error("Failed to allocate dest temporary buffer.");

449
  /* Get destination of each particle */
450
  for (size_t k = 0; k < s->nr_parts; k++) {
451
452

    /* Periodic boundary conditions */
453
    for (int j = 0; j < 3; j++) {
454
455
456
457
458
      if (parts[k].x[j] < 0.0)
        parts[k].x[j] += dim[j];
      else if (parts[k].x[j] >= dim[j])
        parts[k].x[j] -= dim[j];
    }
James Willis's avatar
James Willis committed
459
460
461
    const int cid =
        cell_getid(cdim, parts[k].x[0] * iwidth[0], parts[k].x[1] * iwidth[1],
                   parts[k].x[2] * iwidth[2]);
462
463
#ifdef SWIFT_DEBUG_CHECKS
    if (cid < 0 || cid >= s->nr_cells)
464
      error("Bad cell id %i for part %zu at [%.3e,%.3e,%.3e].", cid, k,
465
466
467
            parts[k].x[0], parts[k].x[1], parts[k].x[2]);
#endif

468
    dest[k] = cells[cid].nodeID;
469
470

    /* The counts array is indexed as count[from * nr_nodes + to]. */
471
472
    counts[nodeID * nr_nodes + dest[k]] += 1;
  }
473
474

  /* Sort the particles according to their cell index. */
Matthieu Schaller's avatar
Matthieu Schaller committed
475
  if (s->nr_parts > 0)
476
    space_parts_sort(s, dest, s->nr_parts, 0, nr_nodes - 1, e->verbose);
477

478
479
#ifdef SWIFT_DEBUG_CHECKS
  /* Verify that the part have been sorted correctly. */
480
481
482
483
  for (size_t k = 0; k < s->nr_parts; k++) {
    const struct part *p = &s->parts[k];

    /* New cell index */
484
    const int new_cid =
485
486
487
488
        cell_getid(s->cdim, p->x[0] * s->iwidth[0], p->x[1] * s->iwidth[1],
                   p->x[2] * s->iwidth[2]);

    /* New cell of this part */
489
490
    const struct cell *c = &s->cells_top[new_cid];
    const int new_node = c->nodeID;
491

492
493
    if (dest[k] != new_node)
      error("part's new node index not matching sorted index.");
494
495
496
497
498

    if (p->x[0] < c->loc[0] || p->x[0] > c->loc[0] + c->width[0] ||
        p->x[1] < c->loc[1] || p->x[1] > c->loc[1] + c->width[1] ||
        p->x[2] < c->loc[2] || p->x[2] > c->loc[2] + c->width[2])
      error("part not sorted into the right top-level cell!");
499
500
501
  }
#endif

502
  /* We need to re-link the gpart partners of parts. */
503
504
505
506
507
508
  if (s->nr_parts > 0) {
    int current_dest = dest[0];
    size_t count_this_dest = 0;
    for (size_t k = 0; k < s->nr_parts; ++k) {
      if (s->parts[k].gpart != NULL) {

509
510
511
        /* As the addresses will be invalidated by the communications, we will
         * instead store the absolute index from the start of the sub-array of
         * particles to be sent to a given node.
512
         * Recall that gparts without partners have a positive id.
513
         * We will restore the pointers on the receiving node later on. */
514
515
516
517
        if (dest[k] != current_dest) {
          current_dest = dest[k];
          count_this_dest = 0;
        }
518

519
#ifdef SWIFT_DEBUG_CHECKS
520
        if (s->parts[k].gpart->id_or_neg_offset > 0)
521
522
          error("Trying to link a partnerless gpart !");
#endif
523

524
        s->parts[k].gpart->id_or_neg_offset = -count_this_dest;
525
        count_this_dest++;
526
527
528
      }
    }
  }
529
  free(dest);
530

531
  /* Get destination of each s-particle */
532
533
534
535
536
537
538
539
540
  int *s_counts;
  if ((s_counts = (int *)malloc(sizeof(int) * nr_nodes * nr_nodes)) == NULL)
    error("Failed to allocate s_counts temporary buffer.");
  bzero(s_counts, sizeof(int) * nr_nodes * nr_nodes);

  int *s_dest;
  if ((s_dest = (int *)malloc(sizeof(int) * s->nr_sparts)) == NULL)
    error("Failed to allocate s_dest temporary buffer.");

541
542
543
544
545
546
547
548
549
550
551
552
553
554
  for (size_t k = 0; k < s->nr_sparts; k++) {

    /* Periodic boundary conditions */
    for (int j = 0; j < 3; j++) {
      if (sparts[k].x[j] < 0.0)
        sparts[k].x[j] += dim[j];
      else if (sparts[k].x[j] >= dim[j])
        sparts[k].x[j] -= dim[j];
    }
    const int cid =
        cell_getid(cdim, sparts[k].x[0] * iwidth[0], sparts[k].x[1] * iwidth[1],
                   sparts[k].x[2] * iwidth[2]);
#ifdef SWIFT_DEBUG_CHECKS
    if (cid < 0 || cid >= s->nr_cells)
555
      error("Bad cell id %i for spart %zu at [%.3e,%.3e,%.3e].", cid, k,
556
557
558
559
560
561
562
563
564
565
            sparts[k].x[0], sparts[k].x[1], sparts[k].x[2]);
#endif

    s_dest[k] = cells[cid].nodeID;

    /* The counts array is indexed as count[from * nr_nodes + to]. */
    s_counts[nodeID * nr_nodes + s_dest[k]] += 1;
  }

  /* Sort the particles according to their cell index. */
Matthieu Schaller's avatar
Matthieu Schaller committed
566
  if (s->nr_sparts > 0)
567
    space_sparts_sort(s, s_dest, s->nr_sparts, 0, nr_nodes - 1, e->verbose);
568

569
570
#ifdef SWIFT_DEBUG_CHECKS
  /* Verify that the spart have been sorted correctly. */
571
572
573
574
  for (size_t k = 0; k < s->nr_sparts; k++) {
    const struct spart *sp = &s->sparts[k];

    /* New cell index */
575
    const int new_cid =
576
577
578
579
        cell_getid(s->cdim, sp->x[0] * s->iwidth[0], sp->x[1] * s->iwidth[1],
                   sp->x[2] * s->iwidth[2]);

    /* New cell of this spart */
580
581
    const struct cell *c = &s->cells_top[new_cid];
    const int new_node = c->nodeID;
582

583
584
    if (s_dest[k] != new_node)
      error("spart's new node index not matching sorted index.");
585
586
587
588
589

    if (sp->x[0] < c->loc[0] || sp->x[0] > c->loc[0] + c->width[0] ||
        sp->x[1] < c->loc[1] || sp->x[1] > c->loc[1] + c->width[1] ||
        sp->x[2] < c->loc[2] || sp->x[2] > c->loc[2] + c->width[2])
      error("spart not sorted into the right top-level cell!");
590
591
592
  }
#endif

593
  /* We need to re-link the gpart partners of sparts. */
594
595
596
  if (s->nr_sparts > 0) {
    int current_dest = s_dest[0];
    size_t count_this_dest = 0;
597
    for (size_t k = 0; k < s->nr_sparts; ++k) {
598
599
600
601
602
      if (s->sparts[k].gpart != NULL) {

        /* As the addresses will be invalidated by the communications, we will
         * instead store the absolute index from the start of the sub-array of
         * particles to be sent to a given node.
603
         * Recall that gparts without partners have a positive id.
604
605
606
607
608
609
610
         * We will restore the pointers on the receiving node later on. */
        if (s_dest[k] != current_dest) {
          current_dest = s_dest[k];
          count_this_dest = 0;
        }

#ifdef SWIFT_DEBUG_CHECKS
611
        if (s->sparts[k].gpart->id_or_neg_offset > 0)
612
613
614
615
616
617
618
619
620
          error("Trying to link a partnerless gpart !");
#endif

        s->sparts[k].gpart->id_or_neg_offset = -count_this_dest;
        count_this_dest++;
      }
    }
  }

621
622
  free(s_dest);

623
  /* Get destination of each g-particle */
624
625
626
627
628
629
630
631
632
  int *g_counts;
  if ((g_counts = (int *)malloc(sizeof(int) * nr_nodes * nr_nodes)) == NULL)
    error("Failed to allocate g_gcount temporary buffer.");
  bzero(g_counts, sizeof(int) * nr_nodes * nr_nodes);

  int *g_dest;
  if ((g_dest = (int *)malloc(sizeof(int) * s->nr_gparts)) == NULL)
    error("Failed to allocate g_dest temporary buffer.");

633
  for (size_t k = 0; k < s->nr_gparts; k++) {
634
635

    /* Periodic boundary conditions */
636
    for (int j = 0; j < 3; j++) {
637
638
639
640
      if (gparts[k].x[j] < 0.0)
        gparts[k].x[j] += dim[j];
      else if (gparts[k].x[j] >= dim[j])
        gparts[k].x[j] -= dim[j];
641
    }
James Willis's avatar
James Willis committed
642
643
644
    const int cid =
        cell_getid(cdim, gparts[k].x[0] * iwidth[0], gparts[k].x[1] * iwidth[1],
                   gparts[k].x[2] * iwidth[2]);
645
646
#ifdef SWIFT_DEBUG_CHECKS
    if (cid < 0 || cid >= s->nr_cells)
647
      error("Bad cell id %i for gpart %zu at [%.3e,%.3e,%.3e].", cid, k,
648
649
650
            gparts[k].x[0], gparts[k].x[1], gparts[k].x[2]);
#endif

651
    g_dest[k] = cells[cid].nodeID;
652
653

    /* The counts array is indexed as count[from * nr_nodes + to]. */
654
    g_counts[nodeID * nr_nodes + g_dest[k]] += 1;
655
  }
656
657

  /* Sort the gparticles according to their cell index. */
Matthieu Schaller's avatar
Matthieu Schaller committed
658
  if (s->nr_gparts > 0)
659
    space_gparts_sort(s, g_dest, s->nr_gparts, 0, nr_nodes - 1, e->verbose);
660

661
662
#ifdef SWIFT_DEBUG_CHECKS
  /* Verify that the gpart have been sorted correctly. */
663
664
665
666
  for (size_t k = 0; k < s->nr_gparts; k++) {
    const struct gpart *gp = &s->gparts[k];

    /* New cell index */
667
    const int new_cid =
668
669
670
671
        cell_getid(s->cdim, gp->x[0] * s->iwidth[0], gp->x[1] * s->iwidth[1],
                   gp->x[2] * s->iwidth[2]);

    /* New cell of this gpart */
672
673
    const struct cell *c = &s->cells_top[new_cid];
    const int new_node = c->nodeID;
674

675
    if (g_dest[k] != new_node)
676
677
      error("gpart's new node index not matching sorted index (%d != %d).",
            g_dest[k], new_node);
678
679
680
681
682

    if (gp->x[0] < c->loc[0] || gp->x[0] > c->loc[0] + c->width[0] ||
        gp->x[1] < c->loc[1] || gp->x[1] > c->loc[1] + c->width[1] ||
        gp->x[2] < c->loc[2] || gp->x[2] > c->loc[2] + c->width[2])
      error("gpart not sorted into the right top-level cell!");
683
684
685
  }
#endif

686
687
  free(g_dest);

688
689
690
691
692
  /* Get all the counts from all the nodes. */
  if (MPI_Allreduce(MPI_IN_PLACE, counts, nr_nodes * nr_nodes, MPI_INT, MPI_SUM,
                    MPI_COMM_WORLD) != MPI_SUCCESS)
    error("Failed to allreduce particle transfer counts.");

693
  /* Get all the s_counts from all the nodes. */
694
695
696
697
698
699
700
701
702
  if (MPI_Allreduce(MPI_IN_PLACE, g_counts, nr_nodes * nr_nodes, MPI_INT,
                    MPI_SUM, MPI_COMM_WORLD) != MPI_SUCCESS)
    error("Failed to allreduce gparticle transfer counts.");

  /* Get all the g_counts from all the nodes. */
  if (MPI_Allreduce(MPI_IN_PLACE, s_counts, nr_nodes * nr_nodes, MPI_INT,
                    MPI_SUM, MPI_COMM_WORLD) != MPI_SUCCESS)
    error("Failed to allreduce sparticle transfer counts.");

Peter W. Draper's avatar
Peter W. Draper committed
703
  /* Report how many particles will be moved. */
704
705
  if (e->verbose) {
    if (e->nodeID == 0) {
706
707
      size_t total = 0, g_total = 0, s_total = 0;
      size_t unmoved = 0, g_unmoved = 0, s_unmoved = 0;
708
709
710
      for (int p = 0, r = 0; p < nr_nodes; p++) {
        for (int s = 0; s < nr_nodes; s++) {
          total += counts[r];
711
712
713
714
715
716
717
          g_total += g_counts[r];
          s_total += s_counts[r];
          if (p == s) {
            unmoved += counts[r];
            g_unmoved += g_counts[r];
            s_unmoved += s_counts[r];
          }
718
719
720
          r++;
        }
      }
Matthieu Schaller's avatar
Matthieu Schaller committed
721
722
723
724
725
726
727
728
729
730
731
      if (total > 0)
        message("%ld of %ld (%.2f%%) of particles moved", total - unmoved,
                total, 100.0 * (double)(total - unmoved) / (double)total);
      if (g_total > 0)
        message("%ld of %ld (%.2f%%) of g-particles moved", g_total - g_unmoved,
                g_total,
                100.0 * (double)(g_total - g_unmoved) / (double)g_total);
      if (s_total > 0)
        message("%ld of %ld (%.2f%%) of s-particles moved", s_total - s_unmoved,
                s_total,
                100.0 * (double)(s_total - s_unmoved) / (double)s_total);
732
    }
733
734
  }

Peter W. Draper's avatar
Peter W. Draper committed
735
736
737
  /* Now each node knows how many parts, sparts and gparts will be transferred
   * to every other node.
   * Get the new numbers of particles for this node. */
738
  size_t nr_parts = 0, nr_gparts = 0, nr_sparts = 0;
739
  for (int k = 0; k < nr_nodes; k++) nr_parts += counts[k * nr_nodes + nodeID];
740
741
  for (int k = 0; k < nr_nodes; k++)
    nr_gparts += g_counts[k * nr_nodes + nodeID];
742
743
  for (int k = 0; k < nr_nodes; k++)
    nr_sparts += s_counts[k * nr_nodes + nodeID];
744

Peter W. Draper's avatar
Peter W. Draper committed
745
746
747
748
  /* Now exchange the particles, type by type to keep the memory required
   * under control. */

  /* SPH particles. */
749
  void *new_parts = engine_do_redistribute(counts, (char *)s->parts, nr_parts,
750
751
752
                                           sizeof(struct part), part_align,
                                           part_mpi_type, nr_nodes, nodeID);
  free(s->parts);
753
  s->parts = (struct part *)new_parts;
754
755
  s->nr_parts = nr_parts;
  s->size_parts = engine_redistribute_alloc_margin * nr_parts;
756

Peter W. Draper's avatar
Peter W. Draper committed
757
  /* Extra SPH particle properties. */
758
  new_parts = engine_do_redistribute(counts, (char *)s->xparts, nr_parts,
759
760
761
                                     sizeof(struct xpart), xpart_align,
                                     xpart_mpi_type, nr_nodes, nodeID);
  free(s->xparts);
762
  s->xparts = (struct xpart *)new_parts;
763

Peter W. Draper's avatar
Peter W. Draper committed
764
  /* Gravity particles. */
765
  new_parts = engine_do_redistribute(g_counts, (char *)s->gparts, nr_gparts,
766
767
768
                                     sizeof(struct gpart), gpart_align,
                                     gpart_mpi_type, nr_nodes, nodeID);
  free(s->gparts);
769
  s->gparts = (struct gpart *)new_parts;
770
771
  s->nr_gparts = nr_gparts;
  s->size_gparts = engine_redistribute_alloc_margin * nr_gparts;
772

Peter W. Draper's avatar
Peter W. Draper committed
773
  /* Star particles. */
774
  new_parts = engine_do_redistribute(s_counts, (char *)s->sparts, nr_sparts,
775
776
777
                                     sizeof(struct spart), spart_align,
                                     spart_mpi_type, nr_nodes, nodeID);
  free(s->sparts);
778
  s->sparts = (struct spart *)new_parts;
779
780
  s->nr_sparts = nr_sparts;
  s->size_sparts = engine_redistribute_alloc_margin * nr_sparts;
781

782
783
784
785
786
  /* All particles have now arrived. Time for some final operations on the
     stuff we just received */

  /* Restore the part<->gpart and spart<->gpart links */
  size_t offset_parts = 0, offset_sparts = 0, offset_gparts = 0;
787
788
789
790
791
  for (int node = 0; node < nr_nodes; ++node) {

    const int ind_recv = node * nr_nodes + nodeID;
    const size_t count_parts = counts[ind_recv];
    const size_t count_gparts = g_counts[ind_recv];
792
    const size_t count_sparts = s_counts[ind_recv];
793
794
795
796

    /* Loop over the gparts received from that node */
    for (size_t k = offset_gparts; k < offset_gparts + count_gparts; ++k) {

797
      /* Does this gpart have a gas partner ? */
798
      if (s->gparts[k].type == swift_type_gas) {
799

Matthieu Schaller's avatar
Style    
Matthieu Schaller committed
800
        const ptrdiff_t partner_index =
801
            offset_parts - s->gparts[k].id_or_neg_offset;
802
803

        /* Re-link */
804
805
        s->gparts[k].id_or_neg_offset = -partner_index;
        s->parts[partner_index].gpart = &s->gparts[k];
806
      }
807
808

      /* Does this gpart have a star partner ? */
809
      if (s->gparts[k].type == swift_type_star) {
810
811

        const ptrdiff_t partner_index =
812
            offset_sparts - s->gparts[k].id_or_neg_offset;
813
814

        /* Re-link */
815
816
        s->gparts[k].id_or_neg_offset = -partner_index;
        s->sparts[partner_index].gpart = &s->gparts[k];
817
      }
818
819
820
821
    }

    offset_parts += count_parts;
    offset_gparts += count_gparts;
822
    offset_sparts += count_sparts;
823
824
  }

825
826
827
828
829
  /* Clean up the counts now we done. */
  free(counts);
  free(g_counts);
  free(s_counts);

830
#ifdef SWIFT_DEBUG_CHECKS
831
  /* Verify that all parts are in the right place. */
832
  for (size_t k = 0; k < nr_parts; k++) {
833
834
835
    const int cid =
        cell_getid(cdim, s->parts[k].x[0] * iwidth[0],
                   s->parts[k].x[1] * iwidth[1], s->parts[k].x[2] * iwidth[2]);
836
    if (cells[cid].nodeID != nodeID)
837
      error("Received particle (%zu) that does not belong here (nodeID=%i).", k,
838
839
            cells[cid].nodeID);
  }
840
  for (size_t k = 0; k < nr_gparts; k++) {
841
842
843
    const int cid = cell_getid(cdim, s->gparts[k].x[0] * iwidth[0],
                               s->gparts[k].x[1] * iwidth[1],
                               s->gparts[k].x[2] * iwidth[2]);
844
845
846
847
848
    if (cells[cid].nodeID != nodeID)
      error("Received g-particle (%zu) that does not belong here (nodeID=%i).",
            k, cells[cid].nodeID);
  }
  for (size_t k = 0; k < nr_sparts; k++) {
849
850
851
    const int cid = cell_getid(cdim, s->sparts[k].x[0] * iwidth[0],
                               s->sparts[k].x[1] * iwidth[1],
                               s->sparts[k].x[2] * iwidth[2]);
852
853
854
855
    if (cells[cid].nodeID != nodeID)
      error("Received s-particle (%zu) that does not belong here (nodeID=%i).",
            k, cells[cid].nodeID);
  }
856

857
  /* Verify that the links are correct */
858
  part_verify_links(s->parts, s->gparts, s->sparts, nr_parts, nr_gparts,
859
                    nr_sparts, e->verbose);
860
#endif
861

862
863
864
865
866
  /* Be verbose about what just happened. */
  if (e->verbose) {
    int my_cells = 0;
    for (int k = 0; k < nr_cells; k++)
      if (cells[k].nodeID == nodeID) my_cells += 1;
867
868
    message("node %i now has %zu parts, %zu sparts and %zu gparts in %i cells.",
            nodeID, nr_parts, nr_sparts, nr_gparts, my_cells);
869
870
  }

871
872
873
  if (e->verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
874
#else
875
  error("SWIFT was not compiled with MPI support.");
876
877
#endif
}
878

879
/**
880
 * @brief Repartition the cells amongst the nodes.
881
882
883
 *
 * @param e The #engine.
 */
884
void engine_repartition(struct engine *e) {
885
886
887

#if defined(WITH_MPI) && defined(HAVE_METIS)

888
889
  ticks tic = getticks();

890
#ifdef SWIFT_DEBUG_CHECKS
891
892
893
894
  /* Be verbose about this. */
  if (e->nodeID == 0 || e->verbose) message("repartitioning space");
  fflush(stdout);

895
  /* Check that all cells have been drifted to the current time */
896
897
  space_check_drift_point(e->s, e->ti_old,
                          e->policy & engine_policy_self_gravity);
898
899
#endif

900
  /* Clear the repartition flag. */
901
  e->forcerepart = 0;
902

903
904
  /* Nothing to do if only using a single node. Also avoids METIS
   * bug that doesn't handle this case well. */
905
  if (e->nr_nodes == 1) return;
906

907
  /* Do the repartitioning. */
908
  partition_repartition(e->reparttype, e->nodeID, e->nr_nodes, e->s,
909
                        e->sched.tasks, e->sched.nr_tasks);
910

Peter W. Draper's avatar