space.c 48.2 KB
Newer Older
1
/*******************************************************************************
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 * This file is part of SWIFT.
 * Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
 *                    Matthieu Schaller (matthieu.schaller@durham.ac.uk)
 *               2015 Peter W. Draper (p.w.draper@durham.ac.uk)
 *               2016 John A. Regan (john.a.regan@durham.ac.uk)
 *                    Tom Theuns (tom.theuns@durham.ac.uk)
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 ******************************************************************************/
Pedro Gonnet's avatar
Pedro Gonnet committed
23
24
25
26
27
28
29
30

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <math.h>
31
#include <stdlib.h>
32
#include <string.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
33

34
35
/* MPI headers. */
#ifdef WITH_MPI
36
#include <mpi.h>
37
38
#endif

39
40
41
/* This object's header. */
#include "space.h"

Pedro Gonnet's avatar
Pedro Gonnet committed
42
/* Local headers. */
43
#include "atomic.h"
44
#include "engine.h"
45
#include "error.h"
46
47
#include "gravity.h"
#include "hydro.h"
48
#include "kernel_hydro.h"
49
#include "lock.h"
50
#include "minmax.h"
51
#include "runner.h"
52
#include "tools.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
53

54
55
56
/* Shared sort structure. */
struct parallel_sort space_sort_struct;

Pedro Gonnet's avatar
Pedro Gonnet committed
57
58
/* Split size. */
int space_splitsize = space_splitsize_default;
59
int space_subsize = space_subsize_default;
60
int space_maxsize = space_maxsize_default;
Pedro Gonnet's avatar
Pedro Gonnet committed
61
62
63

/* Map shift vector to sortlist. */
const int sortlistID[27] = {
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
    /* ( -1 , -1 , -1 ) */ 0,
    /* ( -1 , -1 ,  0 ) */ 1,
    /* ( -1 , -1 ,  1 ) */ 2,
    /* ( -1 ,  0 , -1 ) */ 3,
    /* ( -1 ,  0 ,  0 ) */ 4,
    /* ( -1 ,  0 ,  1 ) */ 5,
    /* ( -1 ,  1 , -1 ) */ 6,
    /* ( -1 ,  1 ,  0 ) */ 7,
    /* ( -1 ,  1 ,  1 ) */ 8,
    /* (  0 , -1 , -1 ) */ 9,
    /* (  0 , -1 ,  0 ) */ 10,
    /* (  0 , -1 ,  1 ) */ 11,
    /* (  0 ,  0 , -1 ) */ 12,
    /* (  0 ,  0 ,  0 ) */ 0,
    /* (  0 ,  0 ,  1 ) */ 12,
    /* (  0 ,  1 , -1 ) */ 11,
    /* (  0 ,  1 ,  0 ) */ 10,
    /* (  0 ,  1 ,  1 ) */ 9,
    /* (  1 , -1 , -1 ) */ 8,
    /* (  1 , -1 ,  0 ) */ 7,
    /* (  1 , -1 ,  1 ) */ 6,
    /* (  1 ,  0 , -1 ) */ 5,
    /* (  1 ,  0 ,  0 ) */ 4,
    /* (  1 ,  0 ,  1 ) */ 3,
    /* (  1 ,  1 , -1 ) */ 2,
    /* (  1 ,  1 ,  0 ) */ 1,
    /* (  1 ,  1 ,  1 ) */ 0};

92
93
94
95
96
97
98
99
100
101
102
103
/**
 * @brief Get the shift-id of the given pair of cells, swapping them
 *      if need be.
 *
 * @param s The space
 * @param ci Pointer to first #cell.
 * @param cj Pointer second #cell.
 * @param shift Vector from ci to cj.
 *
 * @return The shift ID and set shift, may or may not swap ci and cj.
 */

104
105
106
107
int space_getsid(struct space *s, struct cell **ci, struct cell **cj,
                 double *shift) {

  /* Get the relative distance between the pairs, wrapping. */
108
109
110
  const int periodic = s->periodic;
  double dx[3];
  for (int k = 0; k < 3; k++) {
111
112
113
114
115
116
117
118
119
120
121
    dx[k] = (*cj)->loc[k] - (*ci)->loc[k];
    if (periodic && dx[k] < -s->dim[k] / 2)
      shift[k] = s->dim[k];
    else if (periodic && dx[k] > s->dim[k] / 2)
      shift[k] = -s->dim[k];
    else
      shift[k] = 0.0;
    dx[k] += shift[k];
  }

  /* Get the sorting index. */
122
  int sid = 0;
123
  for (int k = 0; k < 3; k++)
124
125
126
127
    sid = 3 * sid + ((dx[k] < 0.0) ? 0 : ((dx[k] > 0.0) ? 2 : 1));

  /* Switch the cells around? */
  if (runner_flip[sid]) {
128
    struct cell *temp = *ci;
129
130
    *ci = *cj;
    *cj = temp;
131
    for (int k = 0; k < 3; k++) shift[k] = -shift[k];
132
133
134
135
136
137
  }
  sid = sortlistID[sid];

  /* Return the sort ID. */
  return sid;
}
138

139
/**
140
 * @brief Recursively dismantle a cell tree.
141
142
 *
 */
143
144
145
146

void space_rebuild_recycle(struct space *s, struct cell *c) {

  if (c->split)
147
    for (int k = 0; k < 8; k++)
148
149
150
151
152
153
154
      if (c->progeny[k] != NULL) {
        space_rebuild_recycle(s, c->progeny[k]);
        space_recycle(s, c->progeny[k]);
        c->progeny[k] = NULL;
      }
}

155
/**
156
 * @brief Re-build the cell grid.
157
 *
158
159
 * @param s The #space.
 * @param cell_max Maximum cell edge length.
160
 * @param verbose Print messages to stdout or not.
161
 */
162

163
void space_regrid(struct space *s, double cell_max, int verbose) {
164

165
  const size_t nr_parts = s->nr_parts;
166
  struct cell *restrict c;
167
  ticks tic = getticks();
168
169
170

  /* Run through the parts and get the current h_max. */
  // tic = getticks();
171
  float h_max = s->cell_min / kernel_gamma / space_stretch;
172
  if (nr_parts > 0) {
173
    if (s->cells != NULL) {
Tom Theuns's avatar
Tom Theuns committed
174
      for (int k = 0; k < s->nr_cells; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
175
        if (s->cells[k].h_max > h_max) h_max = s->cells[k].h_max;
176
177
      }
    } else {
178
      for (size_t k = 0; k < nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
179
        if (s->parts[k].h > h_max) h_max = s->parts[k].h;
180
181
      }
      s->h_max = h_max;
182
183
184
185
186
187
188
189
190
191
    }
  }

/* If we are running in parallel, make sure everybody agrees on
   how large the largest cell should be. */
#ifdef WITH_MPI
  {
    float buff;
    if (MPI_Allreduce(&h_max, &buff, 1, MPI_FLOAT, MPI_MAX, MPI_COMM_WORLD) !=
        MPI_SUCCESS)
192
      error("Failed to aggregate the rebuild flag across nodes.");
193
194
195
    h_max = buff;
  }
#endif
196
  if (verbose) message("h_max is %.3e (cell_max=%.3e).", h_max, cell_max);
197
198

  /* Get the new putative cell dimensions. */
199
  int cdim[3];
200
  for (int k = 0; k < 3; k++)
201
202
203
204
205
206
207
208
209
    cdim[k] =
        floor(s->dim[k] / fmax(h_max * kernel_gamma * space_stretch, cell_max));

  /* Check if we have enough cells for periodicity. */
  if (s->periodic && (cdim[0] < 3 || cdim[1] < 3 || cdim[2] < 3))
    error(
        "Must have at least 3 cells in each spatial dimension when periodicity "
        "is switched on.");

210
211
212
213
214
215
  /* Check if we have enough cells for gravity. */
  if (s->gravity && (cdim[0] < 8 || cdim[1] < 8 || cdim[2] < 8))
    error(
        "Must have at least 8 cells in each spatial dimension when gravity "
        "is switched on.");

216
217
218
/* In MPI-Land, changing the top-level cell size requires that the
 * global partition is recomputed and the particles redistributed.
 * Be prepared to do that. */
219
#ifdef WITH_MPI
Matthieu Schaller's avatar
Matthieu Schaller committed
220
  double oldwidth[3];
221
222
223
224
225
226
227
228
  double oldcdim[3];
  int *oldnodeIDs = NULL;
  if (cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] || cdim[2] < s->cdim[2]) {

    /* Capture state of current space. */
    oldcdim[0] = s->cdim[0];
    oldcdim[1] = s->cdim[1];
    oldcdim[2] = s->cdim[2];
229
230
231
    oldwidth[0] = s->width[0];
    oldwidth[1] = s->width[1];
    oldwidth[2] = s->width[2];
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246

    if ((oldnodeIDs = (int *)malloc(sizeof(int) * s->nr_cells)) == NULL)
      error("Failed to allocate temporary nodeIDs.");

    int cid = 0;
    for (int i = 0; i < s->cdim[0]; i++) {
      for (int j = 0; j < s->cdim[1]; j++) {
        for (int k = 0; k < s->cdim[2]; k++) {
          cid = cell_getid(oldcdim, i, j, k);
          oldnodeIDs[cid] = s->cells[cid].nodeID;
        }
      }
    }
  }

247
248
249
250
251
252
253
254
255
#endif

  /* Do we need to re-build the upper-level cells? */
  // tic = getticks();
  if (s->cells == NULL || cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] ||
      cdim[2] < s->cdim[2]) {

    /* Free the old cells, if they were allocated. */
    if (s->cells != NULL) {
256
      for (int k = 0; k < s->nr_cells; k++) {
257
258
259
260
261
262
263
264
        space_rebuild_recycle(s, &s->cells[k]);
        if (s->cells[k].sort != NULL) free(s->cells[k].sort);
      }
      free(s->cells);
      s->maxdepth = 0;
    }

    /* Set the new cell dimensions only if smaller. */
265
    for (int k = 0; k < 3; k++) {
266
      s->cdim[k] = cdim[k];
267
268
      s->width[k] = s->dim[k] / cdim[k];
      s->iwidth[k] = 1.0 / s->width[k];
269
    }
270
    const float dmin = fminf(s->width[0], fminf(s->width[1], s->width[2]));
271
272
273
274
275
276
277

    /* Allocate the highest level of cells. */
    s->tot_cells = s->nr_cells = cdim[0] * cdim[1] * cdim[2];
    if (posix_memalign((void *)&s->cells, 64,
                       s->nr_cells * sizeof(struct cell)) != 0)
      error("Failed to allocate cells.");
    bzero(s->cells, s->nr_cells * sizeof(struct cell));
278
    for (int k = 0; k < s->nr_cells; k++)
279
280
281
      if (lock_init(&s->cells[k].lock) != 0) error("Failed to init spinlock.");

    /* Set the cell location and sizes. */
282
283
284
    for (int i = 0; i < cdim[0]; i++)
      for (int j = 0; j < cdim[1]; j++)
        for (int k = 0; k < cdim[2]; k++) {
285
          c = &s->cells[cell_getid(cdim, i, j, k)];
286
287
288
289
290
291
          c->loc[0] = i * s->width[0];
          c->loc[1] = j * s->width[1];
          c->loc[2] = k * s->width[2];
          c->width[0] = s->width[0];
          c->width[1] = s->width[1];
          c->width[2] = s->width[2];
292
293
294
295
296
297
          c->dmin = dmin;
          c->depth = 0;
          c->count = 0;
          c->gcount = 0;
          c->super = c;
          lock_init(&c->lock);
Pedro Gonnet's avatar
Pedro Gonnet committed
298
        }
299
300

    /* Be verbose about the change. */
301
302
303
    if (verbose)
      message("set cell dimensions to [ %i %i %i ].", cdim[0], cdim[1],
              cdim[2]);
304
305
    fflush(stdout);

306
#ifdef WITH_MPI
307
308
309
310
311
    if (oldnodeIDs != NULL) {
      /* We have changed the top-level cell dimension, so need to redistribute
       * cells around the nodes. We repartition using the old space node
       * positions as a grid to resample. */
      if (s->e->nodeID == 0)
312
313
314
        message(
            "basic cell dimensions have increased - recalculating the "
            "global partition.");
315

Matthieu Schaller's avatar
Matthieu Schaller committed
316
      if (!partition_space_to_space(oldwidth, oldcdim, oldnodeIDs, s)) {
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334

        /* Failed, try another technique that requires no settings. */
        message("Failed to get a new partition, trying less optimal method");
        struct partition initial_partition;
#ifdef HAVE_METIS
        initial_partition.type = INITPART_METIS_NOWEIGHT;
#else
        initial_partition.type = INITPART_VECTORIZE;
#endif
        partition_initial_partition(&initial_partition, s->e->nodeID,
                                    s->e->nr_nodes, s);
      }

      /* Re-distribute the particles to their new nodes. */
      engine_redistribute(s->e);

      /* Make the proxies. */
      engine_makeproxies(s->e);
335

336
337
      /* Finished with these. */
      free(oldnodeIDs);
338
339
    }
#endif
340
  } /* re-build upper-level cells? */
341
342
  // message( "rebuilding upper-level cells took %.3f %s." ,
  // clocks_from_ticks(double)(getticks() - tic), clocks_getunit());
343
344
345
346
347

  /* Otherwise, just clean up the cells. */
  else {

    /* Free the old cells, if they were allocated. */
348
    for (int k = 0; k < s->nr_cells; k++) {
349
350
351
352
353
354
355
356
357
358
359
      space_rebuild_recycle(s, &s->cells[k]);
      s->cells[k].sorts = NULL;
      s->cells[k].nr_tasks = 0;
      s->cells[k].nr_density = 0;
      s->cells[k].nr_force = 0;
      s->cells[k].density = NULL;
      s->cells[k].force = NULL;
      s->cells[k].dx_max = 0.0f;
      s->cells[k].sorted = 0;
      s->cells[k].count = 0;
      s->cells[k].gcount = 0;
Matthieu Schaller's avatar
Matthieu Schaller committed
360
      s->cells[k].init = NULL;
Matthieu Schaller's avatar
Matthieu Schaller committed
361
      s->cells[k].ghost = NULL;
Matthieu Schaller's avatar
Matthieu Schaller committed
362
363
      s->cells[k].drift = NULL;
      s->cells[k].kick = NULL;
364
      s->cells[k].super = &s->cells[k];
365
    }
366
367
    s->maxdepth = 0;
  }
368
369
370
371

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
372
}
373
374
375
376
377
378

/**
 * @brief Re-build the cells as well as the tasks.
 *
 * @param s The #space in which to update the cells.
 * @param cell_max Maximal cell size.
379
 * @param verbose Print messages to stdout or not
380
381
 *
 */
382

383
void space_rebuild(struct space *s, double cell_max, int verbose) {
384

Matthieu Schaller's avatar
Matthieu Schaller committed
385
  const ticks tic = getticks();
386
387

  /* Be verbose about this. */
388
  // message("re)building space..."); fflush(stdout);
389
390

  /* Re-grid if necessary, or just re-set the cell data. */
391
  space_regrid(s, cell_max, verbose);
392

Pedro Gonnet's avatar
Pedro Gonnet committed
393
394
  size_t nr_parts = s->nr_parts;
  size_t nr_gparts = s->nr_gparts;
395
396
  struct cell *restrict cells = s->cells;

397
  const double ih[3] = {s->iwidth[0], s->iwidth[1], s->iwidth[2]};
Matthieu Schaller's avatar
Matthieu Schaller committed
398
399
  const double dim[3] = {s->dim[0], s->dim[1], s->dim[2]};
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
400
401
402
403

  /* Run through the particles and get their cell index. */
  // tic = getticks();
  const size_t ind_size = s->size_parts;
404
405
  int *ind;
  if ((ind = (int *)malloc(sizeof(int) * ind_size)) == NULL)
406
    error("Failed to allocate temporary particle indices.");
Pedro Gonnet's avatar
Pedro Gonnet committed
407
  for (size_t k = 0; k < nr_parts; k++) {
408
409
    struct part *restrict p = &s->parts[k];
    for (int j = 0; j < 3; j++)
410
411
412
413
      if (p->x[j] < 0.0)
        p->x[j] += dim[j];
      else if (p->x[j] >= dim[j])
        p->x[j] -= dim[j];
414
    ind[k] =
415
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
416
    cells[ind[k]].count++;
417
  }
Pedro Gonnet's avatar
Pedro Gonnet committed
418
419
  // message( "getting particle indices took %.3f %s." ,
  // clocks_from_ticks(getticks() - tic), clocks_getunit()):
420

421
422
423
424
425
426
427
  /* Run through the gravity particles and get their cell index. */
  // tic = getticks();
  const size_t gind_size = s->size_gparts;
  int *gind;
  if ((gind = (int *)malloc(sizeof(int) * gind_size)) == NULL)
    error("Failed to allocate temporary g-particle indices.");
  for (int k = 0; k < nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
428
    struct gpart *restrict gp = &s->gparts[k];
429
430
431
432
433
434
435
436
437
    for (int j = 0; j < 3; j++)
      if (gp->x[j] < 0.0)
        gp->x[j] += dim[j];
      else if (gp->x[j] >= dim[j])
        gp->x[j] -= dim[j];
    gind[k] =
        cell_getid(cdim, gp->x[0] * ih[0], gp->x[1] * ih[1], gp->x[2] * ih[2]);
    cells[gind[k]].gcount++;
  }
Matthieu Schaller's avatar
Matthieu Schaller committed
438
// message( "getting particle indices took %.3f %s." ,
439
// clocks_from_ticks(getticks() - tic), clocks_getunit());
440
441

#ifdef WITH_MPI
442

443
  /* Move non-local parts to the end of the list. */
444
  const int local_nodeID = s->e->nodeID;
445
  for (size_t k = 0; k < nr_parts;) {
446
    if (cells[ind[k]].nodeID != local_nodeID) {
447
448
      cells[ind[k]].count -= 1;
      nr_parts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
449
      const struct part tp = s->parts[k];
450
451
      s->parts[k] = s->parts[nr_parts];
      s->parts[nr_parts] = tp;
452
      if (s->parts[k].gpart != NULL) {
453
        s->parts[k].gpart->id_or_neg_offset = -k;
454
455
      }
      if (s->parts[nr_parts].gpart != NULL) {
456
        s->parts[nr_parts].gpart->id_or_neg_offset = -nr_parts;
457
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
458
      const struct xpart txp = s->xparts[k];
459
460
      s->xparts[k] = s->xparts[nr_parts];
      s->xparts[nr_parts] = txp;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
461
      const int t = ind[k];
462
463
      ind[k] = ind[nr_parts];
      ind[nr_parts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
464
    } else {
465
466
467
468
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
469

470
#ifdef SWIFT_DEBUG_CHECKS
Peter W. Draper's avatar
Peter W. Draper committed
471
  /* Check that all parts are in the correct places. */
472
  for (size_t k = 0; k < nr_parts; k++) {
473
474
475
476
477
478
479
    if (cells[ind[k]].nodeID != local_nodeID) {
      error("Failed to move all non-local parts to send list");
    }
  }
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
    if (cells[ind[k]].nodeID == local_nodeID) {
      error("Failed to remove local parts from send list");
480
    }
481
482
  }
#endif
483

484
  /* Move non-local gparts to the end of the list. */
485
  for (int k = 0; k < nr_gparts;) {
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
486
487
    if (cells[gind[k]].nodeID != local_nodeID) {
      cells[gind[k]].gcount -= 1;
488
      nr_gparts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
489
      const struct gpart tp = s->gparts[k];
490
491
      s->gparts[k] = s->gparts[nr_gparts];
      s->gparts[nr_gparts] = tp;
492
493
      if (s->gparts[k].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
494
      }
495
496
497
      if (s->gparts[nr_gparts].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
498
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
499
500
501
      const int t = gind[k];
      gind[k] = gind[nr_gparts];
      gind[nr_gparts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
502
    } else {
503
504
505
506
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
507

508
#ifdef SWIFT_DEBUG_CHECKS
509
510
511
512
513
514
515
516
517
  /* Check that all gparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_gparts; k++) {
    if (cells[gind[k]].nodeID != local_nodeID) {
      error("Failed to move all non-local gparts to send list");
    }
  }
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
    if (cells[gind[k]].nodeID == local_nodeID) {
      error("Failed to remove local gparts from send list");
518
    }
519
520
  }
#endif
521

522
523
  /* Exchange the strays, note that this potentially re-allocates
     the parts arrays. */
524
  size_t nr_parts_exchanged = s->nr_parts - nr_parts;
525
  size_t nr_gparts_exchanged = s->nr_gparts - nr_gparts;
Pedro Gonnet's avatar
Pedro Gonnet committed
526
527
528
529
  engine_exchange_strays(s->e, nr_parts, &ind[nr_parts], &nr_parts_exchanged,
                         nr_gparts, &gind[nr_gparts], &nr_gparts_exchanged);

  /* Set the new particle counts. */
530
  s->nr_parts = nr_parts + nr_parts_exchanged;
531
  s->nr_gparts = nr_gparts + nr_gparts_exchanged;
532
533

  /* Re-allocate the index array if needed.. */
534
  if (s->nr_parts > ind_size) {
535
536
    int *ind_new;
    if ((ind_new = (int *)malloc(sizeof(int) * s->nr_parts)) == NULL)
537
      error("Failed to allocate temporary particle indices.");
538
    memcpy(ind_new, ind, sizeof(int) * nr_parts);
539
540
    free(ind);
    ind = ind_new;
541
542
543
  }

  /* Assign each particle to its cell. */
Pedro Gonnet's avatar
Pedro Gonnet committed
544
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
545
    const struct part *const p = &s->parts[k];
546
    ind[k] =
547
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
548
    cells[ind[k]].count += 1;
549
550
551
552
553
#ifdef SWIFT_DEBUG_CHECKS
    if (cells[ind[k]].nodeID != local_nodeID)
      error("Received part that does not belong to me (nodeID=%i).",
            cells[ind[k]].nodeID);
#endif
554
  }
555
  nr_parts = s->nr_parts;
556
557

#endif /* WITH_MPI */
558
559

  /* Sort the parts according to their cells. */
560
  space_parts_sort(s, ind, nr_parts, 0, s->nr_cells - 1, verbose);
561
562

  /* Re-link the gparts. */
563
  part_relink_gparts(s->parts, nr_parts, 0);
564

565
#ifdef SWIFT_DEBUG_CHECKS
566
  /* Verify space_sort_struct. */
567
568
569
570
571
572
573
574
575
576
  for (size_t k = 1; k < nr_parts; k++) {
    if (ind[k - 1] > ind[k]) {
      error("Sort failed!");
    } else if (ind[k] != cell_getid(cdim, s->parts[k].x[0] * ih[0],
                                    s->parts[k].x[1] * ih[1],
                                    s->parts[k].x[2] * ih[2])) {
      error("Incorrect indices!");
    }
  }
#endif
577
578

  /* We no longer need the indices as of here. */
579
  free(ind);
580

581
582
583
584
#ifdef WITH_MPI

  /* Re-allocate the index array if needed.. */
  if (s->nr_gparts > gind_size) {
585
586
    int *gind_new;
    if ((gind_new = (int *)malloc(sizeof(int) * s->nr_gparts)) == NULL)
587
      error("Failed to allocate temporary g-particle indices.");
588
    memcpy(gind_new, gind, sizeof(int) * nr_gparts);
589
590
591
592
593
    free(gind);
    gind = gind_new;
  }

  /* Assign each particle to its cell. */
594
  for (int k = nr_gparts; k < s->nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
595
    const struct gpart *const p = &s->gparts[k];
596
597
    gind[k] =
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
Matthieu Schaller's avatar
Typo    
Matthieu Schaller committed
598
    cells[gind[k]].gcount += 1;
599
600
601
602
603
604
605
    /* if ( cells[ ind[k] ].nodeID != nodeID )
        error( "Received part that does not belong to me (nodeID=%i)." , cells[
       ind[k] ].nodeID ); */
  }
  nr_gparts = s->nr_gparts;

#endif
606
607

  /* Sort the parts according to their cells. */
Matthieu Schaller's avatar
Matthieu Schaller committed
608
  space_gparts_sort(s, gind, nr_gparts, 0, s->nr_cells - 1, verbose);
609
610

  /* Re-link the parts. */
611
  part_relink_parts(s->gparts, nr_gparts, s->parts);
612
613

  /* We no longer need the indices as of here. */
614
  free(gind);
615

616
#ifdef SWIFT_DEBUG_CHECKS
617
618
619
  /* Verify that the links are correct */
  for (size_t k = 0; k < nr_gparts; ++k) {

620
    if (s->gparts[k].id_or_neg_offset < 0) {
621

622
      const struct part *part = &s->parts[-s->gparts[k].id_or_neg_offset];
623

624
625
626
627
      if (part->gpart != &s->gparts[k]) error("Linking problem !");

      if (s->gparts[k].x[0] != part->x[0] || s->gparts[k].x[1] != part->x[1] ||
          s->gparts[k].x[2] != part->x[2])
628
629
630
631
632
        error("Linked particles are not at the same position !");
    }
  }
  for (size_t k = 0; k < nr_parts; ++k) {

633
634
635
    if (s->parts[k].gpart != NULL &&
        s->parts[k].gpart->id_or_neg_offset != -k) {
      error("Linking problem !");
636
637
    }
  }
638
#endif
639

640
641
  /* Hook the cells up to the parts. */
  // tic = getticks();
642
643
644
  struct part *finger = s->parts;
  struct xpart *xfinger = s->xparts;
  struct gpart *gfinger = s->gparts;
645
646
  for (int k = 0; k < s->nr_cells; k++) {
    struct cell *restrict c = &cells[k];
647
648
649
650
651
652
653
    c->parts = finger;
    c->xparts = xfinger;
    c->gparts = gfinger;
    finger = &finger[c->count];
    xfinger = &xfinger[c->count];
    gfinger = &gfinger[c->gcount];
  }
654
  // message( "hooking up cells took %.3f %s." ,
Matthieu Schaller's avatar
Matthieu Schaller committed
655
  // clocks_from_ticks(getticks() - tic), clocks_getunit());
656
657
658

  /* At this point, we have the upper-level cells, old or new. Now make
     sure that the parts in each cell are ok. */
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
  space_split(s, cells, verbose);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Split particles between cells of a hierarchy
 *
 * @param s The #space.
 * @param cells The cell hierarchy
 * @param verbose Are we talkative ?
 */
void space_split(struct space *s, struct cell *cells, int verbose) {

Matthieu Schaller's avatar
Matthieu Schaller committed
675
  const ticks tic = getticks();
676
677

  for (int k = 0; k < s->nr_cells; k++)
678
679
    scheduler_addtask(&s->e->sched, task_type_split_cell, task_subtype_none, k,
                      0, &cells[k], NULL, 0);
680
  engine_launch(s->e, s->e->nr_threads, 1 << task_type_split_cell, 0);
681

682
683
684
  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
685
}
686

687
/**
688
689
 * @brief Sort the particles and condensed particles according to the given
 *indices.
690
 *
Matthieu Schaller's avatar
Matthieu Schaller committed
691
 * @param s The #space.
692
693
694
695
 * @param ind The indices with respect to which the parts are sorted.
 * @param N The number of parts
 * @param min Lowest index.
 * @param max highest index.
696
 * @param verbose Are we talkative ?
697
 */
698

699
void space_parts_sort(struct space *s, int *ind, size_t N, int min, int max,
700
701
                      int verbose) {

Matthieu Schaller's avatar
Matthieu Schaller committed
702
  const ticks tic = getticks();
703
704

  /*Populate the global parallel_sort structure with the input data */
705
706
707
  space_sort_struct.parts = s->parts;
  space_sort_struct.xparts = s->xparts;
  space_sort_struct.ind = ind;
708
  space_sort_struct.stack_size = 2 * (max - min + 1) + 10 + s->e->nr_threads;
709
710
711
712
713
714
  if ((space_sort_struct.stack = malloc(sizeof(struct qstack) *
                                        space_sort_struct.stack_size)) == NULL)
    error("Failed to allocate sorting stack.");
  for (int i = 0; i < space_sort_struct.stack_size; i++)
    space_sort_struct.stack[i].ready = 0;

715
  /* Add the first interval. */
716
717
718
719
720
721
722
723
724
  space_sort_struct.stack[0].i = 0;
  space_sort_struct.stack[0].j = N - 1;
  space_sort_struct.stack[0].min = min;
  space_sort_struct.stack[0].max = max;
  space_sort_struct.stack[0].ready = 1;
  space_sort_struct.first = 0;
  space_sort_struct.last = 1;
  space_sort_struct.waiting = 1;

725
  /* Launch the sorting tasks. */
726
  engine_launch(s->e, s->e->nr_threads, (1 << task_type_part_sort), 0);
727

728
#ifdef SWIFT_DEBUG_CHECKS
729
  /* Verify space_sort_struct. */
730
  for (int i = 1; i < N; i++)
731
    if (ind[i - 1] > ind[i])
732
      error("Sorting failed (ind[%i]=%i,ind[%i]=%i), min=%i, max=%i.", i - 1,
733
734
735
            ind[i - 1], i, ind[i], min, max);
  message("Sorting succeeded.");
#endif
736

737
  /* Clean up. */
738
  free(space_sort_struct.stack);
739
740
741
742

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
743
}
744

745
void space_do_parts_sort() {
746

747
  /* Pointers to the sorting data. */
748
  int *ind = space_sort_struct.ind;
749
750
  struct part *parts = space_sort_struct.parts;
  struct xpart *xparts = space_sort_struct.xparts;
751

752
  /* Main loop. */
753
  while (space_sort_struct.waiting) {
754

755
    /* Grab an interval off the queue. */
756
757
    int qid =
        atomic_inc(&space_sort_struct.first) % space_sort_struct.stack_size;
758

759
    /* Wait for the entry to be ready, or for the sorting do be done. */
760
761
    while (!space_sort_struct.stack[qid].ready)
      if (!space_sort_struct.waiting) return;
762

763
    /* Get the stack entry. */
764
765
    ptrdiff_t i = space_sort_struct.stack[qid].i;
    ptrdiff_t j = space_sort_struct.stack[qid].j;
766
767
    int min = space_sort_struct.stack[qid].min;
    int max = space_sort_struct.stack[qid].max;
768
    space_sort_struct.stack[qid].ready = 0;
769

770
771
    /* Loop over sub-intervals. */
    while (1) {
772

773
      /* Bring beer. */
774
      const int pivot = (min + max) / 2;
775
776
      /* message("Working on interval [%i,%i] with min=%i, max=%i, pivot=%i.",
              i, j, min, max, pivot); */
777
778

      /* One pass of QuickSort's partitioning. */
779
780
      ptrdiff_t ii = i;
      ptrdiff_t jj = j;
781
782
783
784
      while (ii < jj) {
        while (ii <= j && ind[ii] <= pivot) ii++;
        while (jj >= i && ind[jj] > pivot) jj--;
        if (ii < jj) {
785
          size_t temp_i = ind[ii];
786
787
          ind[ii] = ind[jj];
          ind[jj] = temp_i;
788
          struct part temp_p = parts[ii];
789
790
          parts[ii] = parts[jj];
          parts[jj] = temp_p;
791
          struct xpart temp_xp = xparts[ii];
792
793
794
795
          xparts[ii] = xparts[jj];
          xparts[jj] = temp_xp;
        }
      }
796

797
#ifdef SWIFT_DEBUG_CHECKS
798
      /* Verify space_sort_struct. */
799
      for (int k = i; k <= jj; k++)
800
        if (ind[k] > pivot) {
801
802
          message("sorting failed at k=%i, ind[k]=%i, pivot=%i, i=%li, j=%li.",
                  k, ind[k], pivot, i, j);
803
804
805
806
          error("Partition failed (<=pivot).");
        }
      for (int k = jj + 1; k <= j; k++)
        if (ind[k] <= pivot) {
807
808
          message("sorting failed at k=%i, ind[k]=%i, pivot=%i, i=%li, j=%li.",
                  k, ind[k], pivot, i, j);
809
          error("Partition failed (>pivot).");
810
811
        }
#endif
812
813
814
815
816
817

      /* Split-off largest interval. */
      if (jj - i > j - jj + 1) {

        /* Recurse on the left? */
        if (jj > i && pivot > min) {
818
819
          qid = atomic_inc(&space_sort_struct.last) %
                space_sort_struct.stack_size;
820
821
          while (space_sort_struct.stack[qid].ready)
            ;
822
823
824
825
826
827
828
          space_sort_struct.stack[qid].i = i;
          space_sort_struct.stack[qid].j = jj;
          space_sort_struct.stack[qid].min = min;
          space_sort_struct.stack[qid].max = pivot;
          if (atomic_inc(&space_sort_struct.waiting) >=
              space_sort_struct.stack_size)
            error("Qstack overflow.");
829
          space_sort_struct.stack[qid].ready = 1;
830
        }
831

832
833
834
835
836
837
838
839
840
841
        /* Recurse on the right? */
        if (jj + 1 < j && pivot + 1 < max) {
          i = jj + 1;
          min = pivot + 1;
        } else
          break;

      } else {

        /* Recurse on the right? */
842
        if (pivot + 1 < max) {
843
844
          qid = atomic_inc(&space_sort_struct.last) %
                space_sort_struct.stack_size;
845
846
          while (space_sort_struct.stack[qid].ready)
            ;
847
848
849
850
851
852
853
          space_sort_struct.stack[qid].i = jj + 1;
          space_sort_struct.stack[qid].j = j;
          space_sort_struct.stack[qid].min = pivot + 1;
          space_sort_struct.stack[qid].max = max;
          if (atomic_inc(&space_sort_struct.waiting) >=
              space_sort_struct.stack_size)
            error("Qstack overflow.");
854
          space_sort_struct.stack[qid].ready = 1;
855
        }
856

857
858
859
860
861
862
863
        /* Recurse on the left? */
        if (jj > i && pivot > min) {
          j = jj;
          max = pivot;
        } else
          break;
      }
864

865
866
    } /* loop over sub-intervals. */

867
    atomic_dec(&space_sort_struct.waiting);
868
869

  } /* main loop. */
870
871
}

872
873
874
875
876
/**
 * @brief Sort the g-particles and condensed particles according to the given
 *indices.
 *
 * @param s The #space.
Matthieu Schaller's avatar
Matthieu Schaller committed
877
878
 * @param ind The indices with respect to which the gparts are sorted.
 * @param N The number of gparts
879
880
881
882
 * @param min Lowest index.
 * @param max highest index.
 * @param verbose Are we talkative ?
 */
Matthieu Schaller's avatar
Matthieu Schaller committed
883
void space_gparts_sort(struct space *s, int *ind, size_t N, int min, int max,
884
885
                       int verbose) {

Matthieu Schaller's avatar
Matthieu Schaller committed
886
  const ticks tic = getticks();
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910

  /*Populate the global parallel_sort structure with the input data */
  space_sort_struct.gparts = s->gparts;
  space_sort_struct.ind = ind;
  space_sort_struct.stack_size = 2 * (max - min + 1) + 10 + s->e->nr_threads;
  if ((space_sort_struct.stack = malloc(sizeof(struct qstack) *
                                        space_sort_struct.stack_size)) == NULL)
    error("Failed to allocate sorting stack.");
  for (int i = 0; i < space_sort_struct.stack_size; i++)
    space_sort_struct.stack[i].ready = 0;

  /* Add the first interval. */
  space_sort_struct.stack[0].i = 0;
  space_sort_struct.stack[0].j = N - 1;
  space_sort_struct.stack[0].min = min;
  space_sort_struct.stack[0].max = max;
  space_sort_struct.stack[0].ready = 1;
  space_sort_struct.first = 0;
  space_sort_struct.last = 1;
  space_sort_struct.waiting = 1;

  /* Launch the sorting tasks. */
  engine_launch(s->e, s->e->nr_threads, (1 << task_type_gpart_sort), 0);

911
#ifdef SWIFT_DEBUG_CHECKS
912
  /* Verify space_sort_struct. */
913
  for (int i = 1; i < N; i++)
914
915
    if (ind[i - 1] > ind[i])
      error("Sorting failed (ind[%i]=%i,ind[%i]=%i), min=%i, max=%i.", i - 1,
916
917
918
            ind[i - 1], i, ind[i], min, max);
  message("Sorting succeeded.");
#endif
919
920
921
922
923
924
925
926
927
928
929
930

  /* Clean up. */
  free(space_sort_struct.stack);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

void space_do_gparts_sort() {

  /* Pointers to the sorting data. */
Matthieu Schaller's avatar
Matthieu Schaller committed
931
  int *ind = space_sort_struct.ind;
932
  struct gpart *gparts = space_sort_struct.gparts;
933

934
  /* Main loop. */
935
  while (space_sort_struct.waiting) {
936

937
    /* Grab an interval off the queue. */
938
939
940
941
942
943
    int qid =
        atomic_inc(&space_sort_struct.first) % space_sort_struct.stack_size;

    /* Wait for the entry to be ready, or for the sorting do be done. */
    while (!space_sort_struct.stack[qid].ready)
      if (!space_sort_struct.waiting) return;
944

945
    /* Get the stack entry. */
946
947
948
949
950
    ptrdiff_t i = space_sort_struct.stack[qid].i;
    ptrdiff_t j = space_sort_struct.stack[qid].j;
    int min = space_sort_struct.stack[qid].min;
    int max = space_sort_struct.stack[qid].max;
    space_sort_struct.stack[qid].ready = 0;
951
952
953

    /* Loop over sub-intervals. */
    while (1) {
954

955
      /* Bring beer. */
956
957
958
      const int pivot = (min + max) / 2;
      /* message("Working on interval [%i,%i] with min=%i, max=%i, pivot=%i.",
              i, j, min, max, pivot); */
959
960

      /* One pass of QuickSort's partitioning. */
961
962
      ptrdiff_t ii = i;
      ptrdiff_t jj = j;
963
964
965
966
      while (ii < jj) {
        while (ii <= j && ind[ii] <= pivot) ii++;
        while (jj >= i && ind[jj] > pivot) jj--;
        if (ii < jj) {
967
          size_t temp_i = ind[ii];
968
969
          ind[ii] = ind[jj];
          ind[jj] = temp_i;
970
          struct gpart temp_p = gparts[ii];
971
972
973
974
          gparts[ii] = gparts[jj];
          gparts[jj] = temp_p;
        }
      }
975

976
#ifdef SWIFT_DEBUG_CHECKS
977
      /* Verify space_sort_struct. */
978
      for (int