space.c 57.7 KB
Newer Older
1
/*******************************************************************************
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 * This file is part of SWIFT.
 * Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
 *                    Matthieu Schaller (matthieu.schaller@durham.ac.uk)
 *               2015 Peter W. Draper (p.w.draper@durham.ac.uk)
 *               2016 John A. Regan (john.a.regan@durham.ac.uk)
 *                    Tom Theuns (tom.theuns@durham.ac.uk)
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 ******************************************************************************/
Pedro Gonnet's avatar
Pedro Gonnet committed
23
24
25
26
27
28
29
30

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <math.h>
31
#include <stdlib.h>
32
#include <string.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
33

34
35
/* MPI headers. */
#ifdef WITH_MPI
36
#include <mpi.h>
37
38
#endif

39
40
41
/* This object's header. */
#include "space.h"

Pedro Gonnet's avatar
Pedro Gonnet committed
42
/* Local headers. */
43
#include "atomic.h"
44
#include "const.h"
45
#include "cooling.h"
46
#include "engine.h"
47
#include "error.h"
48
49
#include "gravity.h"
#include "hydro.h"
50
#include "kernel_hydro.h"
51
#include "lock.h"
52
#include "minmax.h"
53
#include "runner.h"
54
#include "threadpool.h"
55
#include "tools.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
56
57
58

/* Split size. */
int space_splitsize = space_splitsize_default;
59
int space_subsize = space_subsize_default;
60
int space_maxsize = space_maxsize_default;
61
int space_maxcount = space_maxcount_default;
Pedro Gonnet's avatar
Pedro Gonnet committed
62
63
64

/* Map shift vector to sortlist. */
const int sortlistID[27] = {
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
    /* ( -1 , -1 , -1 ) */ 0,
    /* ( -1 , -1 ,  0 ) */ 1,
    /* ( -1 , -1 ,  1 ) */ 2,
    /* ( -1 ,  0 , -1 ) */ 3,
    /* ( -1 ,  0 ,  0 ) */ 4,
    /* ( -1 ,  0 ,  1 ) */ 5,
    /* ( -1 ,  1 , -1 ) */ 6,
    /* ( -1 ,  1 ,  0 ) */ 7,
    /* ( -1 ,  1 ,  1 ) */ 8,
    /* (  0 , -1 , -1 ) */ 9,
    /* (  0 , -1 ,  0 ) */ 10,
    /* (  0 , -1 ,  1 ) */ 11,
    /* (  0 ,  0 , -1 ) */ 12,
    /* (  0 ,  0 ,  0 ) */ 0,
    /* (  0 ,  0 ,  1 ) */ 12,
    /* (  0 ,  1 , -1 ) */ 11,
    /* (  0 ,  1 ,  0 ) */ 10,
    /* (  0 ,  1 ,  1 ) */ 9,
    /* (  1 , -1 , -1 ) */ 8,
    /* (  1 , -1 ,  0 ) */ 7,
    /* (  1 , -1 ,  1 ) */ 6,
    /* (  1 ,  0 , -1 ) */ 5,
    /* (  1 ,  0 ,  0 ) */ 4,
    /* (  1 ,  0 ,  1 ) */ 3,
    /* (  1 ,  1 , -1 ) */ 2,
    /* (  1 ,  1 ,  0 ) */ 1,
    /* (  1 ,  1 ,  1 ) */ 0};

93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
/**
 * @brief Interval stack necessary for parallel particle sorting.
 */
struct qstack {
  volatile ptrdiff_t i, j;
  volatile int min, max;
  volatile int ready;
};

/**
 * @brief Parallel particle-sorting stack
 */
struct parallel_sort {
  struct part *parts;
  struct gpart *gparts;
  struct xpart *xparts;
  int *ind;
  struct qstack *stack;
  unsigned int stack_size;
  volatile unsigned int first, last, waiting;
};

115
116
117
118
119
120
121
122
123
/**
 * @brief Information required to compute the particle cell indices.
 */
struct index_data {
  struct space *s;
  struct cell *cells;
  int *ind;
};

124
125
126
127
128
129
130
131
132
133
134
/**
 * @brief Get the shift-id of the given pair of cells, swapping them
 *      if need be.
 *
 * @param s The space
 * @param ci Pointer to first #cell.
 * @param cj Pointer second #cell.
 * @param shift Vector from ci to cj.
 *
 * @return The shift ID and set shift, may or may not swap ci and cj.
 */
135
136
137
138
int space_getsid(struct space *s, struct cell **ci, struct cell **cj,
                 double *shift) {

  /* Get the relative distance between the pairs, wrapping. */
139
140
141
  const int periodic = s->periodic;
  double dx[3];
  for (int k = 0; k < 3; k++) {
142
143
144
145
146
147
148
149
150
151
152
    dx[k] = (*cj)->loc[k] - (*ci)->loc[k];
    if (periodic && dx[k] < -s->dim[k] / 2)
      shift[k] = s->dim[k];
    else if (periodic && dx[k] > s->dim[k] / 2)
      shift[k] = -s->dim[k];
    else
      shift[k] = 0.0;
    dx[k] += shift[k];
  }

  /* Get the sorting index. */
153
  int sid = 0;
154
  for (int k = 0; k < 3; k++)
155
156
157
158
    sid = 3 * sid + ((dx[k] < 0.0) ? 0 : ((dx[k] > 0.0) ? 2 : 1));

  /* Switch the cells around? */
  if (runner_flip[sid]) {
159
    struct cell *temp = *ci;
160
161
    *ci = *cj;
    *cj = temp;
162
    for (int k = 0; k < 3; k++) shift[k] = -shift[k];
163
164
165
166
167
168
  }
  sid = sortlistID[sid];

  /* Return the sort ID. */
  return sid;
}
169

170
/**
171
 * @brief Recursively dismantle a cell tree.
172
 *
173
174
 * @param s The #space.
 * @param c The #cell to recycle.
175
 */
176
177
178
void space_rebuild_recycle(struct space *s, struct cell *c) {

  if (c->split)
179
    for (int k = 0; k < 8; k++)
180
181
182
183
184
185
186
      if (c->progeny[k] != NULL) {
        space_rebuild_recycle(s, c->progeny[k]);
        space_recycle(s, c->progeny[k]);
        c->progeny[k] = NULL;
      }
}

187
/**
188
 * @brief Re-build the top-level cell grid.
189
 *
190
 * @param s The #space.
191
 * @param verbose Print messages to stdout or not.
192
 */
193
void space_regrid(struct space *s, int verbose) {
194

195
  const size_t nr_parts = s->nr_parts;
196
  const ticks tic = getticks();
197
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
198

199
  /* Run through the cells and get the current h_max. */
200
  // tic = getticks();
201
  float h_max = s->cell_min / kernel_gamma / space_stretch;
202
  if (nr_parts > 0) {
203
    if (s->cells_top != NULL) {
Tom Theuns's avatar
Tom Theuns committed
204
      for (int k = 0; k < s->nr_cells; k++) {
205
206
207
        if (s->cells_top[k].nodeID == engine_rank &&
            s->cells_top[k].h_max > h_max) {
          h_max = s->cells_top[k].h_max;
208
        }
209
210
      }
    } else {
211
      for (size_t k = 0; k < nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
212
        if (s->parts[k].h > h_max) h_max = s->parts[k].h;
213
      }
214
215
216
217
218
219
220
221
222
223
    }
  }

/* If we are running in parallel, make sure everybody agrees on
   how large the largest cell should be. */
#ifdef WITH_MPI
  {
    float buff;
    if (MPI_Allreduce(&h_max, &buff, 1, MPI_FLOAT, MPI_MAX, MPI_COMM_WORLD) !=
        MPI_SUCCESS)
224
      error("Failed to aggregate the rebuild flag across nodes.");
225
226
227
    h_max = buff;
  }
#endif
228
  if (verbose) message("h_max is %.3e (cell_min=%.3e).", h_max, s->cell_min);
229
230

  /* Get the new putative cell dimensions. */
231
  const int cdim[3] = {
232
233
234
235
236
237
      floor(s->dim[0] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[1] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[2] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min))};
238
239
240
241
242

  /* Check if we have enough cells for periodicity. */
  if (s->periodic && (cdim[0] < 3 || cdim[1] < 3 || cdim[2] < 3))
    error(
        "Must have at least 3 cells in each spatial dimension when periodicity "
243
244
245
        "is switched on.\nThis error is often caused by any of the "
        "followings:\n"
        " - too few particles to generate a sensible grid,\n"
246
247
        " - the initial value of 'Scheduler:max_top_level_cells' is too "
        "small,\n"
248
        " - the (minimal) time-step is too large leading to particles with "
249
250
251
        "predicted smoothing lengths too large for the box size,\n"
        " - particle with velocities so large that they move by more than two "
        "box sizes per time-step.\n");
252

253
254
255
256
257
258
  /* Check if we have enough cells for gravity. */
  if (s->gravity && (cdim[0] < 8 || cdim[1] < 8 || cdim[2] < 8))
    error(
        "Must have at least 8 cells in each spatial dimension when gravity "
        "is switched on.");

259
260
261
/* In MPI-Land, changing the top-level cell size requires that the
 * global partition is recomputed and the particles redistributed.
 * Be prepared to do that. */
262
#ifdef WITH_MPI
Matthieu Schaller's avatar
Matthieu Schaller committed
263
  double oldwidth[3];
264
265
266
267
268
269
270
271
  double oldcdim[3];
  int *oldnodeIDs = NULL;
  if (cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] || cdim[2] < s->cdim[2]) {

    /* Capture state of current space. */
    oldcdim[0] = s->cdim[0];
    oldcdim[1] = s->cdim[1];
    oldcdim[2] = s->cdim[2];
272
273
274
    oldwidth[0] = s->width[0];
    oldwidth[1] = s->width[1];
    oldwidth[2] = s->width[2];
275
276
277
278
279
280
281
282
283

    if ((oldnodeIDs = (int *)malloc(sizeof(int) * s->nr_cells)) == NULL)
      error("Failed to allocate temporary nodeIDs.");

    int cid = 0;
    for (int i = 0; i < s->cdim[0]; i++) {
      for (int j = 0; j < s->cdim[1]; j++) {
        for (int k = 0; k < s->cdim[2]; k++) {
          cid = cell_getid(oldcdim, i, j, k);
284
          oldnodeIDs[cid] = s->cells_top[cid].nodeID;
285
286
287
288
289
        }
      }
    }
  }

290
291
292
293
#endif

  /* Do we need to re-build the upper-level cells? */
  // tic = getticks();
294
  if (s->cells_top == NULL || cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] ||
295
296
297
      cdim[2] < s->cdim[2]) {

    /* Free the old cells, if they were allocated. */
298
    if (s->cells_top != NULL) {
299
      for (int k = 0; k < s->nr_cells; k++) {
300
301
        space_rebuild_recycle(s, &s->cells_top[k]);
        if (s->cells_top[k].sort != NULL) free(s->cells_top[k].sort);
302
      }
303
      free(s->cells_top);
304
305
306
307
      s->maxdepth = 0;
    }

    /* Set the new cell dimensions only if smaller. */
308
    for (int k = 0; k < 3; k++) {
309
      s->cdim[k] = cdim[k];
310
311
      s->width[k] = s->dim[k] / cdim[k];
      s->iwidth[k] = 1.0 / s->width[k];
312
    }
313
    const float dmin = min(s->width[0], min(s->width[1], s->width[2]));
314
315
316

    /* Allocate the highest level of cells. */
    s->tot_cells = s->nr_cells = cdim[0] * cdim[1] * cdim[2];
317
    if (posix_memalign((void *)&s->cells_top, cell_align,
318
319
                       s->nr_cells * sizeof(struct cell)) != 0)
      error("Failed to allocate cells.");
320
    bzero(s->cells_top, s->nr_cells * sizeof(struct cell));
321
    for (int k = 0; k < s->nr_cells; k++)
322
323
      if (lock_init(&s->cells_top[k].lock) != 0)
        error("Failed to init spinlock.");
324
325

    /* Set the cell location and sizes. */
326
327
328
    for (int i = 0; i < cdim[0]; i++)
      for (int j = 0; j < cdim[1]; j++)
        for (int k = 0; k < cdim[2]; k++) {
329
          struct cell *restrict c = &s->cells_top[cell_getid(cdim, i, j, k)];
330
331
332
333
334
335
          c->loc[0] = i * s->width[0];
          c->loc[1] = j * s->width[1];
          c->loc[2] = k * s->width[2];
          c->width[0] = s->width[0];
          c->width[1] = s->width[1];
          c->width[2] = s->width[2];
336
337
338
339
340
          c->dmin = dmin;
          c->depth = 0;
          c->count = 0;
          c->gcount = 0;
          c->super = c;
341
          c->ti_old = ti_current;
342
          lock_init(&c->lock);
Pedro Gonnet's avatar
Pedro Gonnet committed
343
        }
344
345

    /* Be verbose about the change. */
346
347
348
    if (verbose)
      message("set cell dimensions to [ %i %i %i ].", cdim[0], cdim[1],
              cdim[2]);
349
350
    fflush(stdout);

351
#ifdef WITH_MPI
352
353
354
355
356
    if (oldnodeIDs != NULL) {
      /* We have changed the top-level cell dimension, so need to redistribute
       * cells around the nodes. We repartition using the old space node
       * positions as a grid to resample. */
      if (s->e->nodeID == 0)
357
358
359
        message(
            "basic cell dimensions have increased - recalculating the "
            "global partition.");
360

Matthieu Schaller's avatar
Matthieu Schaller committed
361
      if (!partition_space_to_space(oldwidth, oldcdim, oldnodeIDs, s)) {
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379

        /* Failed, try another technique that requires no settings. */
        message("Failed to get a new partition, trying less optimal method");
        struct partition initial_partition;
#ifdef HAVE_METIS
        initial_partition.type = INITPART_METIS_NOWEIGHT;
#else
        initial_partition.type = INITPART_VECTORIZE;
#endif
        partition_initial_partition(&initial_partition, s->e->nodeID,
                                    s->e->nr_nodes, s);
      }

      /* Re-distribute the particles to their new nodes. */
      engine_redistribute(s->e);

      /* Make the proxies. */
      engine_makeproxies(s->e);
380

381
382
      /* Finished with these. */
      free(oldnodeIDs);
383
384
    }
#endif
385
386
387
388

    // message( "rebuilding upper-level cells took %.3f %s." ,
    // clocks_from_ticks(double)(getticks() - tic), clocks_getunit());

389
390
  } /* re-build upper-level cells? */

391
  else { /* Otherwise, just clean up the cells. */
392
393

    /* Free the old cells, if they were allocated. */
394
    for (int k = 0; k < s->nr_cells; k++) {
395
396
397
398
399
400
      space_rebuild_recycle(s, &s->cells_top[k]);
      s->cells_top[k].sorts = NULL;
      s->cells_top[k].nr_tasks = 0;
      s->cells_top[k].density = NULL;
      s->cells_top[k].gradient = NULL;
      s->cells_top[k].force = NULL;
401
      s->cells_top[k].grav = NULL;
402
403
404
405
406
407
408
409
      s->cells_top[k].dx_max = 0.0f;
      s->cells_top[k].sorted = 0;
      s->cells_top[k].count = 0;
      s->cells_top[k].gcount = 0;
      s->cells_top[k].init = NULL;
      s->cells_top[k].extra_ghost = NULL;
      s->cells_top[k].ghost = NULL;
      s->cells_top[k].kick = NULL;
410
411
      s->cells_top[k].cooling = NULL;
      s->cells_top[k].sourceterms = NULL;
412
      s->cells_top[k].super = &s->cells_top[k];
413
414
415
416
417
418
419
420
421
422
423
#if WITH_MPI
      s->cells_top[k].recv_xv = NULL;
      s->cells_top[k].recv_rho = NULL;
      s->cells_top[k].recv_gradient = NULL;
      s->cells_top[k].recv_ti = NULL;

      s->cells_top[k].send_xv = NULL;
      s->cells_top[k].send_rho = NULL;
      s->cells_top[k].send_gradient = NULL;
      s->cells_top[k].send_ti = NULL;
#endif
424
    }
425
426
    s->maxdepth = 0;
  }
427
428
429
430

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
431
}
432
433
434
435
436

/**
 * @brief Re-build the cells as well as the tasks.
 *
 * @param s The #space in which to update the cells.
437
 * @param verbose Print messages to stdout or not
438
439
 *
 */
440
void space_rebuild(struct space *s, int verbose) {
441

Matthieu Schaller's avatar
Matthieu Schaller committed
442
  const ticks tic = getticks();
443
444

  /* Be verbose about this. */
445
  // message("re)building space..."); fflush(stdout);
446
447

  /* Re-grid if necessary, or just re-set the cell data. */
448
  space_regrid(s, verbose);
449

Pedro Gonnet's avatar
Pedro Gonnet committed
450
451
  size_t nr_parts = s->nr_parts;
  size_t nr_gparts = s->nr_gparts;
452
  struct cell *restrict cells_top = s->cells_top;
453
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
454
455

  /* Run through the particles and get their cell index. */
456
  const size_t ind_size = s->size_parts + 100;
457
458
  int *ind;
  if ((ind = (int *)malloc(sizeof(int) * ind_size)) == NULL)
459
    error("Failed to allocate temporary particle indices.");
460
  if (ind_size > 0) space_parts_get_cell_index(s, ind, cells_top, verbose);
461

462
  /* Run through the gravity particles and get their cell index. */
463
  const size_t gind_size = s->size_gparts + 100;
464
465
466
  int *gind;
  if ((gind = (int *)malloc(sizeof(int) * gind_size)) == NULL)
    error("Failed to allocate temporary g-particle indices.");
467
  if (gind_size > 0) space_gparts_get_cell_index(s, gind, cells_top, verbose);
468
469

#ifdef WITH_MPI
470

471
  /* Move non-local parts to the end of the list. */
472
  const int local_nodeID = s->e->nodeID;
473
  for (size_t k = 0; k < nr_parts;) {
474
    if (cells_top[ind[k]].nodeID != local_nodeID) {
475
      nr_parts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
476
      const struct part tp = s->parts[k];
477
478
      s->parts[k] = s->parts[nr_parts];
      s->parts[nr_parts] = tp;
479
      if (s->parts[k].gpart != NULL) {
480
        s->parts[k].gpart->id_or_neg_offset = -k;
481
482
      }
      if (s->parts[nr_parts].gpart != NULL) {
483
        s->parts[nr_parts].gpart->id_or_neg_offset = -nr_parts;
484
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
485
      const struct xpart txp = s->xparts[k];
486
487
      s->xparts[k] = s->xparts[nr_parts];
      s->xparts[nr_parts] = txp;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
488
      const int t = ind[k];
489
490
      ind[k] = ind[nr_parts];
      ind[nr_parts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
491
    } else {
492
493
494
495
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
496

497
#ifdef SWIFT_DEBUG_CHECKS
Peter W. Draper's avatar
Peter W. Draper committed
498
  /* Check that all parts are in the correct places. */
499
  for (size_t k = 0; k < nr_parts; k++) {
500
    if (cells_top[ind[k]].nodeID != local_nodeID) {
501
502
503
504
      error("Failed to move all non-local parts to send list");
    }
  }
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
505
    if (cells_top[ind[k]].nodeID == local_nodeID) {
506
      error("Failed to remove local parts from send list");
507
    }
508
509
  }
#endif
510

511
  /* Move non-local gparts to the end of the list. */
512
  for (size_t k = 0; k < nr_gparts;) {
513
    if (cells_top[gind[k]].nodeID != local_nodeID) {
514
      nr_gparts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
515
      const struct gpart tp = s->gparts[k];
516
517
      s->gparts[k] = s->gparts[nr_gparts];
      s->gparts[nr_gparts] = tp;
518
519
      if (s->gparts[k].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
520
      }
521
522
523
      if (s->gparts[nr_gparts].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
524
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
525
526
527
      const int t = gind[k];
      gind[k] = gind[nr_gparts];
      gind[nr_gparts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
528
    } else {
529
530
531
532
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
533

534
#ifdef SWIFT_DEBUG_CHECKS
535
536
  /* Check that all gparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_gparts; k++) {
537
    if (cells_top[gind[k]].nodeID != local_nodeID) {
538
539
540
541
      error("Failed to move all non-local gparts to send list");
    }
  }
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
542
    if (cells_top[gind[k]].nodeID == local_nodeID) {
543
      error("Failed to remove local gparts from send list");
544
    }
545
546
  }
#endif
547

548
549
  /* Exchange the strays, note that this potentially re-allocates
     the parts arrays. */
550
  size_t nr_parts_exchanged = s->nr_parts - nr_parts;
551
  size_t nr_gparts_exchanged = s->nr_gparts - nr_gparts;
Pedro Gonnet's avatar
Pedro Gonnet committed
552
553
554
555
  engine_exchange_strays(s->e, nr_parts, &ind[nr_parts], &nr_parts_exchanged,
                         nr_gparts, &gind[nr_gparts], &nr_gparts_exchanged);

  /* Set the new particle counts. */
556
  s->nr_parts = nr_parts + nr_parts_exchanged;
557
  s->nr_gparts = nr_gparts + nr_gparts_exchanged;
558
559

  /* Re-allocate the index array if needed.. */
560
  if (s->nr_parts + 1 > ind_size) {
561
    int *ind_new;
562
    if ((ind_new = (int *)malloc(sizeof(int) * (s->nr_parts + 1))) == NULL)
563
      error("Failed to allocate temporary particle indices.");
564
    memcpy(ind_new, ind, sizeof(int) * nr_parts);
565
566
    free(ind);
    ind = ind_new;
567
568
  }

569
570
571
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
  const double ih[3] = {s->iwidth[0], s->iwidth[1], s->iwidth[2]};

572
  /* Assign each particle to its cell. */
Pedro Gonnet's avatar
Pedro Gonnet committed
573
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
574
    const struct part *const p = &s->parts[k];
575
    ind[k] =
576
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
577
#ifdef SWIFT_DEBUG_CHECKS
578
    if (cells_top[ind[k]].nodeID != local_nodeID)
579
      error("Received part that does not belong to me (nodeID=%i).",
580
            cells_top[ind[k]].nodeID);
581
#endif
582
  }
583
  nr_parts = s->nr_parts;
584
585

#endif /* WITH_MPI */
586
587

  /* Sort the parts according to their cells. */
588
  space_parts_sort(s, ind, nr_parts, 0, s->nr_cells - 1, verbose);
589
590

  /* Re-link the gparts. */
591
  if (nr_parts > 0 && nr_gparts > 0) part_relink_gparts(s->parts, nr_parts, 0);
592

593
#ifdef SWIFT_DEBUG_CHECKS
594
  /* Verify space_sort_struct. */
595
596
597
  for (size_t k = 1; k < nr_parts; k++) {
    if (ind[k - 1] > ind[k]) {
      error("Sort failed!");
598
    } else if (ind[k] != cell_getid(s->cdim, s->parts[k].x[0] * s->iwidth[0],
599
600
                                    s->parts[k].x[1] * s->iwidth[1],
                                    s->parts[k].x[2] * s->iwidth[2])) {
601
602
603
604
      error("Incorrect indices!");
    }
  }
#endif
605

606
607
608
609
610
611
612
613
614
615
  /* Extract the cell counts from the sorted indices. */
  size_t last_index = 0;
  ind[nr_parts] = s->nr_cells;  // sentinel.
  for (size_t k = 0; k < nr_parts; k++) {
    if (ind[k] < ind[k + 1]) {
      cells_top[ind[k]].count = k - last_index + 1;
      last_index = k + 1;
    }
  }

616
  /* We no longer need the indices as of here. */
617
  free(ind);
618

619
620
621
#ifdef WITH_MPI

  /* Re-allocate the index array if needed.. */
622
  if (s->nr_gparts + 1 > gind_size) {
623
    int *gind_new;
624
    if ((gind_new = (int *)malloc(sizeof(int) * (s->nr_gparts + 1))) == NULL)
625
      error("Failed to allocate temporary g-particle indices.");
626
    memcpy(gind_new, gind, sizeof(int) * nr_gparts);
627
628
629
630
631
    free(gind);
    gind = gind_new;
  }

  /* Assign each particle to its cell. */
632
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
633
    const struct gpart *const p = &s->gparts[k];
634
635
    gind[k] =
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
636
637
638
639
640
641

#ifdef SWIFT_DEBUG_CHECKS
    if (cells_top[ind[k]].nodeID != s->e->nodeID)
      error("Received part that does not belong to me (nodeID=%i).",
            cells_top[ind[k]].nodeID);
#endif
642
643
644
645
  }
  nr_gparts = s->nr_gparts;

#endif
646

647
  /* Sort the gparts according to their cells. */
Matthieu Schaller's avatar
Matthieu Schaller committed
648
  space_gparts_sort(s, gind, nr_gparts, 0, s->nr_cells - 1, verbose);
649
650

  /* Re-link the parts. */
651
652
  if (nr_parts > 0 && nr_gparts > 0)
    part_relink_parts(s->gparts, nr_gparts, s->parts);
653

654
655
656
657
658
659
660
661
662
663
  /* Extract the cell counts from the sorted indices. */
  size_t last_gindex = 0;
  gind[nr_parts] = s->nr_cells;
  for (size_t k = 0; k < nr_gparts; k++) {
    if (gind[k] < gind[k + 1]) {
      cells_top[ind[k]].gcount = k - last_gindex + 1;
      last_gindex = k + 1;
    }
  }

664
  /* We no longer need the indices as of here. */
665
  free(gind);
666

667
#ifdef SWIFT_DEBUG_CHECKS
668
669
670
  /* Verify that the links are correct */
  for (size_t k = 0; k < nr_gparts; ++k) {

671
    if (s->gparts[k].id_or_neg_offset < 0) {
672

673
      const struct part *part = &s->parts[-s->gparts[k].id_or_neg_offset];
674

675
676
677
678
      if (part->gpart != &s->gparts[k]) error("Linking problem !");

      if (s->gparts[k].x[0] != part->x[0] || s->gparts[k].x[1] != part->x[1] ||
          s->gparts[k].x[2] != part->x[2])
679
680
681
682
683
        error("Linked particles are not at the same position !");
    }
  }
  for (size_t k = 0; k < nr_parts; ++k) {

684
    if (s->parts[k].gpart != NULL &&
685
        s->parts[k].gpart->id_or_neg_offset != -(ptrdiff_t)k) {
686
      error("Linking problem !");
687
688
    }
  }
689
#endif
690

691
692
  /* Hook the cells up to the parts. */
  // tic = getticks();
693
694
695
  struct part *finger = s->parts;
  struct xpart *xfinger = s->xparts;
  struct gpart *gfinger = s->gparts;
696
  for (int k = 0; k < s->nr_cells; k++) {
697
    struct cell *restrict c = &cells_top[k];
698
    c->ti_old = ti_current;
699
700
701
702
703
704
705
    c->parts = finger;
    c->xparts = xfinger;
    c->gparts = gfinger;
    finger = &finger[c->count];
    xfinger = &xfinger[c->count];
    gfinger = &gfinger[c->gcount];
  }
706
  // message( "hooking up cells took %.3f %s." ,
Matthieu Schaller's avatar
Matthieu Schaller committed
707
  // clocks_from_ticks(getticks() - tic), clocks_getunit());
708
709
710

  /* At this point, we have the upper-level cells, old or new. Now make
     sure that the parts in each cell are ok. */
711
  space_split(s, cells_top, s->nr_cells, verbose);
712
713
714
715
716
717
718
719
720

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Split particles between cells of a hierarchy
 *
721
722
 * This is done in parallel using threads in the #threadpool.
 *
723
 * @param s The #space.
724
725
 * @param cells The cell hierarchy.
 * @param nr_cells The number of cells.
726
727
 * @param verbose Are we talkative ?
 */
728
729
void space_split(struct space *s, struct cell *cells, int nr_cells,
                 int verbose) {
730

Matthieu Schaller's avatar
Matthieu Schaller committed
731
  const ticks tic = getticks();
732

733
  threadpool_map(&s->e->threadpool, space_split_mapper, cells, nr_cells,
734
                 sizeof(struct cell), 1, s);
735

736
737
738
  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
739
}
740

741
742
743
744
745
746
747
748
/**
 * @brief Runs through the top-level cells and checks whether tasks associated
 * with them can be split. If not, try to sanitize the cells.
 *
 * @param s The #space to act upon.
 */
void space_sanitize(struct space *s) {

749
750
  s->sanitized = 1;

751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
  for (int k = 0; k < s->nr_cells; k++) {

    struct cell *c = &s->cells_top[k];
    const double min_width = c->dmin;

    /* Do we have a problem ? */
    if (c->h_max * kernel_gamma * space_stretch > min_width * 0.5 &&
        c->count > space_maxcount) {

      /* Ok, clean-up the mess */
      cell_sanitize(c);
    }
  }
}

766
/**
767
 * @brief #threadpool mapper function to compute the particle cell indices.
768
 *
769
 * @param map_data Pointer towards the particles.
770
 * @param nr_parts The number of particles to treat.
771
 * @param extra_data Pointers to the space and index list
772
 */
773
774
void space_parts_get_cell_index_mapper(void *map_data, int nr_parts,
                                       void *extra_data) {
775

776
777
778
779
  /* Unpack the data */
  struct part *restrict parts = (struct part *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
780
  int *const ind = data->ind + (ptrdiff_t)(parts - s->parts);
781
782

  /* Get some constants */
783
784
785
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
Matthieu Schaller's avatar
Matthieu Schaller committed
786
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
787
788
789
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
790

791
  for (int k = 0; k < nr_parts; k++) {
792
793
794
795

    /* Get the particle */
    struct part *restrict p = &parts[k];

796
797
798
799
    const double old_pos_x = p->x[0];
    const double old_pos_y = p->x[1];
    const double old_pos_z = p->x[2];

800
    /* Put it back into the simulation volume */
801
802
803
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
804
805

    /* Get its cell index */
Matthieu Schaller's avatar
Matthieu Schaller committed
806
807
    const int index =
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
808
    ind[k] = index;
809

810
811
812
813
    /* Update the position */
    p->x[0] = pos_x;
    p->x[1] = pos_y;
    p->x[2] = pos_z;
814
815
816
817
  }
}

/**
818
 * @brief #threadpool mapper function to compute the g-particle cell indices.
819
 *
820
 * @param map_data Pointer towards the g-particles.
821
 * @param nr_gparts The number of g-particles to treat.
822
 * @param extra_data Pointers to the space and index list
823
 */
824
825
void space_gparts_get_cell_index_mapper(void *map_data, int nr_gparts,
                                        void *extra_data) {
826

827
828
829
830
  /* Unpack the data */
  struct gpart *restrict gparts = (struct gpart *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
831
  int *const ind = data->ind + (ptrdiff_t)(gparts - s->gparts);
832
833

  /* Get some constants */
Matthieu Schaller's avatar
Matthieu Schaller committed
834
835
836
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
837
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
Matthieu Schaller's avatar
Matthieu Schaller committed
838
839
840
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
841

842
  for (int k = 0; k < nr_gparts; k++) {
843
844
845
846

    /* Get the particle */
    struct gpart *restrict gp = &gparts[k];

Matthieu Schaller's avatar
Matthieu Schaller committed
847
848
849
850
    const double old_pos_x = gp->x[0];
    const double old_pos_y = gp->x[1];
    const double old_pos_z = gp->x[2];

851
    /* Put it back into the simulation volume */
Matthieu Schaller's avatar
Matthieu Schaller committed
852
853
854
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
855
856
857

    /* Get its cell index */
    const int index =
Matthieu Schaller's avatar
Matthieu Schaller committed
858
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
859
    ind[k] = index;
Matthieu Schaller's avatar
Matthieu Schaller committed
860
861
862
863
864

    /* Update the position */
    gp->x[0] = pos_x;
    gp->x[1] = pos_y;
    gp->x[2] = pos_z;
865
866
867
  }
}

868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
/**
 * @brief Computes the cell index of all the particles and update the cell
 * count.
 *
 * @param s The #space.
 * @param ind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_parts_get_cell_index(struct space *s, int *ind, struct cell *cells,
                                int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = ind;

  threadpool_map(&s->e->threadpool, space_parts_get_cell_index_mapper, s->parts,
                 s->nr_parts, sizeof(struct part), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Computes the cell index of all the g-particles and update the cell
 * gcount.
 *
 * @param s The #space.
 * @param gind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_gparts_get_cell_index(struct space *s, int *gind, struct cell *cells,
                                 int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = gind;

  threadpool_map(&s->e->threadpool, space_gparts_get_cell_index_mapper,
                 s->gparts, s->nr_gparts, sizeof(struct gpart), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

924
/**
925
 * @brief Sort the particles and condensed particles according to the given
926
 * indices.
927
 *
Matthieu Schaller's avatar
Matthieu Schaller committed
928
 * @param s The #space.
929
930
931
932
 * @param ind The indices with respect to which the parts are sorted.
 * @param N The number of parts
 * @param min Lowest index.
 * @param max highest index.
933
 * @param verbose Are we talkative ?
934
 */
935
void space_parts_sort(struct space *s, int *ind, size_t N, int min, int max,
936
937
                      int verbose) {

Matthieu Schaller's avatar
Matthieu Schaller committed
938
  const ticks tic = getticks();
939

940
941
942
943
944
945
  /* Populate a parallel_sort structure with the input data */
  struct parallel_sort sort_struct;
  sort_struct.parts = s->parts;
  sort_struct.xparts = s->xparts;
  sort_struct.ind = ind;
  sort_struct.stack_size = 2 * (max - min + 1) + 10 + s->e->nr_threads;
946
947
  if ((sort_struct.stack =
           malloc(sizeof(struct qstack) * sort_struct.stack_size)) == NULL)
948
    error("Failed to allocate sorting stack.");
Matthieu Schaller's avatar
Matthieu Schaller committed
949
  for (unsigned int i = 0; i < sort_struct.stack_size; i++)
950
    sort_struct.stack[i].ready = 0;
951

952
  /* Add the first interval. */
953
954
955
956
957
958
959
960
961
962
963
  sort_struct.stack[0].i = 0;
  sort_struct.stack[0].j = N - 1;
  sort_struct.stack[0].min = min;
  sort_struct.stack[0].max = max;
  sort_struct.stack[0].ready = 1;
  sort_struct.first = 0;
  sort_struct.last = 1;
  sort_struct.waiting = 1;

  /* Launch the sorting tasks with a stride of zero such that the same
     map data is passed to each thread. */
964
965
  threadpool_map(&s->e->threadpool, space_parts_sort_mapper, &sort_struct,
                 s->e->threadpool.num_threads, 0, 1, NULL);
966

967
#ifdef SWIFT_DEBUG_CHECKS
968
  /* Verify space_sort_struct. */
969
  for (size_t i = 1; i < N; i++)
970
    if (ind[i - 1] > ind[i])
971
      error("Sorting failed (ind[%zu]=%i,ind[%zu]=%i), min=%i, max=%i.", i - 1,