space.c 96.1 KB
Newer Older
1
/*******************************************************************************
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 * This file is part of SWIFT.
 * Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
 *                    Matthieu Schaller (matthieu.schaller@durham.ac.uk)
 *               2015 Peter W. Draper (p.w.draper@durham.ac.uk)
 *               2016 John A. Regan (john.a.regan@durham.ac.uk)
 *                    Tom Theuns (tom.theuns@durham.ac.uk)
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 ******************************************************************************/
Pedro Gonnet's avatar
Pedro Gonnet committed
23
24
25
26
27
28
29
30

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <math.h>
31
#include <stdlib.h>
32
#include <string.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
33

34
35
/* MPI headers. */
#ifdef WITH_MPI
36
#include <mpi.h>
37
38
#endif

39
40
41
/* This object's header. */
#include "space.h"

Pedro Gonnet's avatar
Pedro Gonnet committed
42
/* Local headers. */
43
#include "atomic.h"
44
#include "const.h"
45
#include "cooling.h"
46
#include "engine.h"
47
#include "error.h"
48
49
#include "gravity.h"
#include "hydro.h"
50
#include "kernel_hydro.h"
51
#include "lock.h"
52
#include "memswap.h"
53
#include "minmax.h"
54
#include "multipole.h"
55
#include "runner.h"
56
#include "sort_part.h"
57
#include "stars.h"
58
#include "threadpool.h"
59
#include "tools.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
60
61
62

/* Split size. */
int space_splitsize = space_splitsize_default;
63
64
int space_subsize_pair = space_subsize_pair_default;
int space_subsize_self = space_subsize_self_default;
65
int space_maxsize = space_maxsize_default;
Pedro Gonnet's avatar
Pedro Gonnet committed
66

67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
/**
 * @brief Interval stack necessary for parallel particle sorting.
 */
struct qstack {
  volatile ptrdiff_t i, j;
  volatile int min, max;
  volatile int ready;
};

/**
 * @brief Parallel particle-sorting stack
 */
struct parallel_sort {
  struct part *parts;
  struct gpart *gparts;
  struct xpart *xparts;
83
  struct spart *sparts;
84
85
86
87
88
89
  int *ind;
  struct qstack *stack;
  unsigned int stack_size;
  volatile unsigned int first, last, waiting;
};

90
91
92
93
94
95
96
97
98
/**
 * @brief Information required to compute the particle cell indices.
 */
struct index_data {
  struct space *s;
  struct cell *cells;
  int *ind;
};

99
100
101
102
103
104
105
106
107
108
109
/**
 * @brief Get the shift-id of the given pair of cells, swapping them
 *      if need be.
 *
 * @param s The space
 * @param ci Pointer to first #cell.
 * @param cj Pointer second #cell.
 * @param shift Vector from ci to cj.
 *
 * @return The shift ID and set shift, may or may not swap ci and cj.
 */
110
111
112
113
int space_getsid(struct space *s, struct cell **ci, struct cell **cj,
                 double *shift) {

  /* Get the relative distance between the pairs, wrapping. */
114
115
116
  const int periodic = s->periodic;
  double dx[3];
  for (int k = 0; k < 3; k++) {
117
118
119
120
121
122
123
124
125
126
127
    dx[k] = (*cj)->loc[k] - (*ci)->loc[k];
    if (periodic && dx[k] < -s->dim[k] / 2)
      shift[k] = s->dim[k];
    else if (periodic && dx[k] > s->dim[k] / 2)
      shift[k] = -s->dim[k];
    else
      shift[k] = 0.0;
    dx[k] += shift[k];
  }

  /* Get the sorting index. */
128
  int sid = 0;
129
  for (int k = 0; k < 3; k++)
130
131
132
133
    sid = 3 * sid + ((dx[k] < 0.0) ? 0 : ((dx[k] > 0.0) ? 2 : 1));

  /* Switch the cells around? */
  if (runner_flip[sid]) {
134
    struct cell *temp = *ci;
135
136
    *ci = *cj;
    *cj = temp;
137
    for (int k = 0; k < 3; k++) shift[k] = -shift[k];
138
139
140
141
142
143
  }
  sid = sortlistID[sid];

  /* Return the sort ID. */
  return sid;
}
144

145
/**
146
 * @brief Recursively dismantle a cell tree.
147
 *
148
149
 * @param s The #space.
 * @param c The #cell to recycle.
Matthieu Schaller's avatar
Matthieu Schaller committed
150
151
152
153
154
155
 * @param cell_rec_begin Pointer to the start of the list of cells to recycle.
 * @param cell_rec_end Pointer to the end of the list of cells to recycle.
 * @param multipole_rec_begin Pointer to the start of the list of multipoles to
 * recycle.
 * @param multipole_rec_end Pointer to the end of the list of multipoles to
 * recycle.
156
 */
157
void space_rebuild_recycle_rec(struct space *s, struct cell *c,
158
159
                               struct cell **cell_rec_begin,
                               struct cell **cell_rec_end,
160
161
                               struct gravity_tensors **multipole_rec_begin,
                               struct gravity_tensors **multipole_rec_end) {
162
  if (c->split)
163
    for (int k = 0; k < 8; k++)
164
      if (c->progeny[k] != NULL) {
165
166
167
168
169
170
        space_rebuild_recycle_rec(s, c->progeny[k], cell_rec_begin,
                                  cell_rec_end, multipole_rec_begin,
                                  multipole_rec_end);

        c->progeny[k]->next = *cell_rec_begin;
        *cell_rec_begin = c->progeny[k];
171
172
173
174
175

        if (s->gravity) {
          c->progeny[k]->multipole->next = *multipole_rec_begin;
          *multipole_rec_begin = c->progeny[k]->multipole;
        }
176
177

        if (*cell_rec_end == NULL) *cell_rec_end = *cell_rec_begin;
178
        if (s->gravity && *multipole_rec_end == NULL)
179
180
181
          *multipole_rec_end = *multipole_rec_begin;

        c->progeny[k]->multipole = NULL;
182
183
184
185
        c->progeny[k] = NULL;
      }
}

186
187
188
189
190
191
192
193
void space_rebuild_recycle_mapper(void *map_data, int num_elements,
                                  void *extra_data) {

  struct space *s = (struct space *)extra_data;
  struct cell *cells = (struct cell *)map_data;

  for (int k = 0; k < num_elements; k++) {
    struct cell *c = &cells[k];
194
    struct cell *cell_rec_begin = NULL, *cell_rec_end = NULL;
195
196
    struct gravity_tensors *multipole_rec_begin = NULL,
                           *multipole_rec_end = NULL;
197
198
199
200
201
    space_rebuild_recycle_rec(s, c, &cell_rec_begin, &cell_rec_end,
                              &multipole_rec_begin, &multipole_rec_end);
    if (cell_rec_begin != NULL)
      space_recycle_list(s, cell_rec_begin, cell_rec_end, multipole_rec_begin,
                         multipole_rec_end);
202
203
204
205
206
207
    c->sorts = NULL;
    c->nr_tasks = 0;
    c->density = NULL;
    c->gradient = NULL;
    c->force = NULL;
    c->grav = NULL;
208
209
    c->dx_max_part = 0.0f;
    c->dx_max_gpart = 0.0f;
210
    c->dx_max_sort = 0.0f;
211
212
213
    c->sorted = 0;
    c->count = 0;
    c->gcount = 0;
214
    c->scount = 0;
215
    c->init_grav = NULL;
216
    c->extra_ghost = NULL;
217
218
    c->ghost_in = NULL;
    c->ghost_out = NULL;
219
    c->ghost = NULL;
220
221
    c->kick1 = NULL;
    c->kick2 = NULL;
222
    c->timestep = NULL;
223
224
    c->drift_part = NULL;
    c->drift_gpart = NULL;
225
226
    c->cooling = NULL;
    c->sourceterms = NULL;
227
228
    c->grav_ghost[0] = NULL;
    c->grav_ghost[1] = NULL;
229
230
    c->grav_long_range = NULL;
    c->grav_down = NULL;
231
    c->super = c;
232
233
234
235
    c->parts = NULL;
    c->xparts = NULL;
    c->gparts = NULL;
    c->sparts = NULL;
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
    if (c->sort != NULL) {
      free(c->sort);
      c->sort = NULL;
    }
#if WITH_MPI
    c->recv_xv = NULL;
    c->recv_rho = NULL;
    c->recv_gradient = NULL;
    c->recv_ti = NULL;

    c->send_xv = NULL;
    c->send_rho = NULL;
    c->send_gradient = NULL;
    c->send_ti = NULL;
#endif
  }
}

254
/**
255
 * @brief Re-build the top-level cell grid.
256
 *
257
 * @param s The #space.
258
 * @param verbose Print messages to stdout or not.
259
 */
260
void space_regrid(struct space *s, int verbose) {
261

262
  const size_t nr_parts = s->nr_parts;
263
  const ticks tic = getticks();
264
  const integertime_t ti_old = (s->e != NULL) ? s->e->ti_old : 0;
265

266
  /* Run through the cells and get the current h_max. */
267
  // tic = getticks();
268
  float h_max = s->cell_min / kernel_gamma / space_stretch;
269
  if (nr_parts > 0) {
270
    if (s->cells_top != NULL) {
Tom Theuns's avatar
Tom Theuns committed
271
      for (int k = 0; k < s->nr_cells; k++) {
272
273
274
        if (s->cells_top[k].nodeID == engine_rank &&
            s->cells_top[k].h_max > h_max) {
          h_max = s->cells_top[k].h_max;
275
        }
276
277
      }
    } else {
278
      for (size_t k = 0; k < nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
279
        if (s->parts[k].h > h_max) h_max = s->parts[k].h;
280
      }
281
282
283
284
285
286
287
288
289
290
    }
  }

/* If we are running in parallel, make sure everybody agrees on
   how large the largest cell should be. */
#ifdef WITH_MPI
  {
    float buff;
    if (MPI_Allreduce(&h_max, &buff, 1, MPI_FLOAT, MPI_MAX, MPI_COMM_WORLD) !=
        MPI_SUCCESS)
291
      error("Failed to aggregate the rebuild flag across nodes.");
292
293
294
    h_max = buff;
  }
#endif
295
  if (verbose) message("h_max is %.3e (cell_min=%.3e).", h_max, s->cell_min);
296
297

  /* Get the new putative cell dimensions. */
298
  const int cdim[3] = {
299
300
301
302
303
304
      floor(s->dim[0] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[1] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[2] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min))};
305
306
307
308
309

  /* Check if we have enough cells for periodicity. */
  if (s->periodic && (cdim[0] < 3 || cdim[1] < 3 || cdim[2] < 3))
    error(
        "Must have at least 3 cells in each spatial dimension when periodicity "
310
311
312
        "is switched on.\nThis error is often caused by any of the "
        "followings:\n"
        " - too few particles to generate a sensible grid,\n"
313
314
        " - the initial value of 'Scheduler:max_top_level_cells' is too "
        "small,\n"
315
        " - the (minimal) time-step is too large leading to particles with "
316
        "predicted smoothing lengths too large for the box size,\n"
317
        " - particles with velocities so large that they move by more than two "
318
        "box sizes per time-step.\n");
319

320
  /* Check if we have enough cells for periodic gravity. */
321
  if (s->gravity && s->periodic && (cdim[0] < 8 || cdim[1] < 8 || cdim[2] < 8))
322
    error(
323
324
        "Must have at least 8 cells in each spatial dimension when periodic "
        "gravity is switched on.\nThis error is often caused by any of the "
325
326
327
328
329
330
        "followings:\n"
        " - too few particles to generate a sensible grid,\n"
        " - the initial value of 'Scheduler:max_top_level_cells' is too "
        "small,\n"
        " - the (minimal) time-step is too large leading to particles with "
        "predicted smoothing lengths too large for the box size,\n"
331
        " - particles with velocities so large that they move by more than two "
332
        "box sizes per time-step.\n");
333

334
335
336
/* In MPI-Land, changing the top-level cell size requires that the
 * global partition is recomputed and the particles redistributed.
 * Be prepared to do that. */
337
#ifdef WITH_MPI
Matthieu Schaller's avatar
Matthieu Schaller committed
338
  double oldwidth[3];
339
340
341
342
343
344
345
346
  double oldcdim[3];
  int *oldnodeIDs = NULL;
  if (cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] || cdim[2] < s->cdim[2]) {

    /* Capture state of current space. */
    oldcdim[0] = s->cdim[0];
    oldcdim[1] = s->cdim[1];
    oldcdim[2] = s->cdim[2];
347
348
349
    oldwidth[0] = s->width[0];
    oldwidth[1] = s->width[1];
    oldwidth[2] = s->width[2];
350
351
352
353
354
355
356
357
358

    if ((oldnodeIDs = (int *)malloc(sizeof(int) * s->nr_cells)) == NULL)
      error("Failed to allocate temporary nodeIDs.");

    int cid = 0;
    for (int i = 0; i < s->cdim[0]; i++) {
      for (int j = 0; j < s->cdim[1]; j++) {
        for (int k = 0; k < s->cdim[2]; k++) {
          cid = cell_getid(oldcdim, i, j, k);
359
          oldnodeIDs[cid] = s->cells_top[cid].nodeID;
360
361
362
363
364
        }
      }
    }
  }

365
366
367
368
#endif

  /* Do we need to re-build the upper-level cells? */
  // tic = getticks();
369
  if (s->cells_top == NULL || cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] ||
370
371
      cdim[2] < s->cdim[2]) {

372
373
/* Be verbose about this. */
#ifdef SWIFT_DEBUG_CHECKS
374
    message("(re)griding space cdim=(%d %d %d)", cdim[0], cdim[1], cdim[2]);
375
376
377
    fflush(stdout);
#endif

378
    /* Free the old cells, if they were allocated. */
379
    if (s->cells_top != NULL) {
380
381
      threadpool_map(&s->e->threadpool, space_rebuild_recycle_mapper,
                     s->cells_top, s->nr_cells, sizeof(struct cell), 100, s);
382
      free(s->cells_top);
383
      free(s->multipoles_top);
384
385
386
387
      s->maxdepth = 0;
    }

    /* Set the new cell dimensions only if smaller. */
388
    for (int k = 0; k < 3; k++) {
389
      s->cdim[k] = cdim[k];
390
391
      s->width[k] = s->dim[k] / cdim[k];
      s->iwidth[k] = 1.0 / s->width[k];
392
    }
393
    const float dmin = min(s->width[0], min(s->width[1], s->width[2]));
394
395
396

    /* Allocate the highest level of cells. */
    s->tot_cells = s->nr_cells = cdim[0] * cdim[1] * cdim[2];
397
    if (posix_memalign((void *)&s->cells_top, cell_align,
398
                       s->nr_cells * sizeof(struct cell)) != 0)
399
      error("Failed to allocate top-level cells.");
400
    bzero(s->cells_top, s->nr_cells * sizeof(struct cell));
401

402
403
404
    /* Allocate the multipoles for the top-level cells. */
    if (s->gravity) {
      if (posix_memalign((void *)&s->multipoles_top, multipole_align,
405
                         s->nr_cells * sizeof(struct gravity_tensors)) != 0)
406
        error("Failed to allocate top-level multipoles.");
407
      bzero(s->multipoles_top, s->nr_cells * sizeof(struct gravity_tensors));
408
409
    }

410
    /* Set the cells' locks */
411
    for (int k = 0; k < s->nr_cells; k++) {
412
      if (lock_init(&s->cells_top[k].lock) != 0)
413
414
415
416
417
418
419
420
        error("Failed to init spinlock for hydro.");
      if (lock_init(&s->cells_top[k].glock) != 0)
        error("Failed to init spinlock for gravity.");
      if (lock_init(&s->cells_top[k].mlock) != 0)
        error("Failed to init spinlock for multipoles.");
      if (lock_init(&s->cells_top[k].slock) != 0)
        error("Failed to init spinlock for stars.");
    }
421
422

    /* Set the cell location and sizes. */
423
424
425
    for (int i = 0; i < cdim[0]; i++)
      for (int j = 0; j < cdim[1]; j++)
        for (int k = 0; k < cdim[2]; k++) {
426
427
          const size_t cid = cell_getid(cdim, i, j, k);
          struct cell *restrict c = &s->cells_top[cid];
428
429
430
431
432
433
          c->loc[0] = i * s->width[0];
          c->loc[1] = j * s->width[1];
          c->loc[2] = k * s->width[2];
          c->width[0] = s->width[0];
          c->width[1] = s->width[1];
          c->width[2] = s->width[2];
434
435
436
437
          c->dmin = dmin;
          c->depth = 0;
          c->count = 0;
          c->gcount = 0;
438
          c->scount = 0;
439
          c->super = c;
440
441
          c->ti_old_part = ti_old;
          c->ti_old_gpart = ti_old;
442
          c->ti_old_multipole = ti_old;
443
          if (s->gravity) c->multipole = &s->multipoles_top[cid];
Pedro Gonnet's avatar
Pedro Gonnet committed
444
        }
445
446

    /* Be verbose about the change. */
447
448
449
    if (verbose)
      message("set cell dimensions to [ %i %i %i ].", cdim[0], cdim[1],
              cdim[2]);
450

451
#ifdef WITH_MPI
452
453
454
455
456
    if (oldnodeIDs != NULL) {
      /* We have changed the top-level cell dimension, so need to redistribute
       * cells around the nodes. We repartition using the old space node
       * positions as a grid to resample. */
      if (s->e->nodeID == 0)
457
458
459
        message(
            "basic cell dimensions have increased - recalculating the "
            "global partition.");
460

Matthieu Schaller's avatar
Matthieu Schaller committed
461
      if (!partition_space_to_space(oldwidth, oldcdim, oldnodeIDs, s)) {
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479

        /* Failed, try another technique that requires no settings. */
        message("Failed to get a new partition, trying less optimal method");
        struct partition initial_partition;
#ifdef HAVE_METIS
        initial_partition.type = INITPART_METIS_NOWEIGHT;
#else
        initial_partition.type = INITPART_VECTORIZE;
#endif
        partition_initial_partition(&initial_partition, s->e->nodeID,
                                    s->e->nr_nodes, s);
      }

      /* Re-distribute the particles to their new nodes. */
      engine_redistribute(s->e);

      /* Make the proxies. */
      engine_makeproxies(s->e);
480

481
482
      /* Finished with these. */
      free(oldnodeIDs);
483
    }
Pedro Gonnet's avatar
Pedro Gonnet committed
484
#endif /* WITH_MPI */
485
486
487
488

    // message( "rebuilding upper-level cells took %.3f %s." ,
    // clocks_from_ticks(double)(getticks() - tic), clocks_getunit());

489
  }      /* re-build upper-level cells? */
490
  else { /* Otherwise, just clean up the cells. */
491
492

    /* Free the old cells, if they were allocated. */
493
494
    threadpool_map(&s->e->threadpool, space_rebuild_recycle_mapper,
                   s->cells_top, s->nr_cells, sizeof(struct cell), 100, s);
495
496
    s->maxdepth = 0;
  }
497
498
499
500

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
501
}
502
503
504
505
506

/**
 * @brief Re-build the cells as well as the tasks.
 *
 * @param s The #space in which to update the cells.
507
 * @param verbose Print messages to stdout or not
508
509
 *
 */
510
void space_rebuild(struct space *s, int verbose) {
511

Matthieu Schaller's avatar
Matthieu Schaller committed
512
  const ticks tic = getticks();
513

514
515
/* Be verbose about this. */
#ifdef SWIFT_DEBUG_CHECKS
Pedro Gonnet's avatar
Pedro Gonnet committed
516
  if (s->e->nodeID == 0 || verbose) message("(re)building space");
517
518
  fflush(stdout);
#endif
519
520

  /* Re-grid if necessary, or just re-set the cell data. */
521
  space_regrid(s, verbose);
522

Pedro Gonnet's avatar
Pedro Gonnet committed
523
524
  size_t nr_parts = s->nr_parts;
  size_t nr_gparts = s->nr_gparts;
525
  size_t nr_sparts = s->nr_sparts;
526
  struct cell *restrict cells_top = s->cells_top;
527
  const integertime_t ti_old = (s->e != NULL) ? s->e->ti_old : 0;
528

Pedro Gonnet's avatar
Pedro Gonnet committed
529
530
531
  /* Run through the particles and get their cell index. Allocates
     an index that is larger than the number of particles to avoid
     re-allocating after shuffling. */
532
  const size_t ind_size = s->size_parts + 100;
533
534
  int *ind;
  if ((ind = (int *)malloc(sizeof(int) * ind_size)) == NULL)
535
    error("Failed to allocate temporary particle indices.");
536
  if (s->size_parts > 0) space_parts_get_cell_index(s, ind, cells_top, verbose);
537

538
  /* Run through the gravity particles and get their cell index. */
539
  const size_t gind_size = s->size_gparts + 100;
540
541
542
  int *gind;
  if ((gind = (int *)malloc(sizeof(int) * gind_size)) == NULL)
    error("Failed to allocate temporary g-particle indices.");
Pedro Gonnet's avatar
Pedro Gonnet committed
543
544
  if (s->size_gparts > 0)
    space_gparts_get_cell_index(s, gind, cells_top, verbose);
545

546
547
548
549
550
551
552
553
  /* Run through the star particles and get their cell index. */
  const size_t sind_size = s->size_sparts + 100;
  int *sind;
  if ((sind = (int *)malloc(sizeof(int) * sind_size)) == NULL)
    error("Failed to allocate temporary s-particle indices.");
  if (s->size_sparts > 0)
    space_sparts_get_cell_index(s, sind, cells_top, verbose);

554
#ifdef WITH_MPI
555
  const int local_nodeID = s->e->nodeID;
556

557
  /* Move non-local parts to the end of the list. */
558
  for (size_t k = 0; k < nr_parts;) {
559
    if (cells_top[ind[k]].nodeID != local_nodeID) {
560
      nr_parts -= 1;
561
      /* Swap the particle */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
562
      const struct part tp = s->parts[k];
563
564
      s->parts[k] = s->parts[nr_parts];
      s->parts[nr_parts] = tp;
565
      /* Swap the link with the gpart */
566
      if (s->parts[k].gpart != NULL) {
567
        s->parts[k].gpart->id_or_neg_offset = -k;
568
569
      }
      if (s->parts[nr_parts].gpart != NULL) {
570
        s->parts[nr_parts].gpart->id_or_neg_offset = -nr_parts;
571
      }
572
      /* Swap the xpart */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
573
      const struct xpart txp = s->xparts[k];
574
575
      s->xparts[k] = s->xparts[nr_parts];
      s->xparts[nr_parts] = txp;
576
      /* Swap the index */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
577
      const int t = ind[k];
578
579
      ind[k] = ind[nr_parts];
      ind[nr_parts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
580
    } else {
581
582
583
584
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
585

586
#ifdef SWIFT_DEBUG_CHECKS
Peter W. Draper's avatar
Peter W. Draper committed
587
  /* Check that all parts are in the correct places. */
588
  for (size_t k = 0; k < nr_parts; k++) {
589
    if (cells_top[ind[k]].nodeID != local_nodeID) {
590
591
592
593
      error("Failed to move all non-local parts to send list");
    }
  }
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
594
    if (cells_top[ind[k]].nodeID == local_nodeID) {
595
      error("Failed to remove local parts from send list");
596
    }
597
598
  }
#endif
599

600
601
602
603
604
605
606
607
608
609
610
611
  /* Move non-local sparts to the end of the list. */
  for (size_t k = 0; k < nr_sparts;) {
    if (cells_top[sind[k]].nodeID != local_nodeID) {
      nr_sparts -= 1;
      /* Swap the particle */
      const struct spart tp = s->sparts[k];
      s->sparts[k] = s->sparts[nr_sparts];
      s->sparts[nr_sparts] = tp;
      /* Swap the link with the gpart */
      if (s->sparts[k].gpart != NULL) {
        s->sparts[k].gpart->id_or_neg_offset = -k;
      }
612
613
      if (s->sparts[nr_sparts].gpart != NULL) {
        s->sparts[nr_sparts].gpart->id_or_neg_offset = -nr_sparts;
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
      }
      /* Swap the index */
      const int t = sind[k];
      sind[k] = sind[nr_sparts];
      sind[nr_sparts] = t;
    } else {
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }

#ifdef SWIFT_DEBUG_CHECKS
  /* Check that all sparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_sparts; k++) {
    if (cells_top[sind[k]].nodeID != local_nodeID) {
      error("Failed to move all non-local sparts to send list");
    }
  }
  for (size_t k = nr_sparts; k < s->nr_sparts; k++) {
    if (cells_top[sind[k]].nodeID == local_nodeID) {
      error("Failed to remove local sparts from send list");
    }
  }
#endif

639
  /* Move non-local gparts to the end of the list. */
640
  for (size_t k = 0; k < nr_gparts;) {
641
    if (cells_top[gind[k]].nodeID != local_nodeID) {
642
      nr_gparts -= 1;
643
      /* Swap the particle */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
644
      const struct gpart tp = s->gparts[k];
645
646
      s->gparts[k] = s->gparts[nr_gparts];
      s->gparts[nr_gparts] = tp;
647
648
      /* Swap the link with part/spart */
      if (s->gparts[k].type == swift_type_gas) {
649
        s->parts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
650
651
      } else if (s->gparts[k].type == swift_type_star) {
        s->sparts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
652
      }
653
      if (s->gparts[nr_gparts].type == swift_type_gas) {
654
655
        s->parts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
656
657
658
      } else if (s->gparts[nr_gparts].type == swift_type_star) {
        s->sparts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
659
      }
660
      /* Swap the index */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
661
662
663
      const int t = gind[k];
      gind[k] = gind[nr_gparts];
      gind[nr_gparts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
664
    } else {
665
666
667
668
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
669

670
#ifdef SWIFT_DEBUG_CHECKS
671
672
  /* Check that all gparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_gparts; k++) {
673
    if (cells_top[gind[k]].nodeID != local_nodeID) {
674
675
676
677
      error("Failed to move all non-local gparts to send list");
    }
  }
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
678
    if (cells_top[gind[k]].nodeID == local_nodeID) {
679
      error("Failed to remove local gparts from send list");
680
    }
681
682
  }
#endif
683

684
685
  /* Exchange the strays, note that this potentially re-allocates
     the parts arrays. */
686
  size_t nr_parts_exchanged = s->nr_parts - nr_parts;
687
  size_t nr_gparts_exchanged = s->nr_gparts - nr_gparts;
688
  size_t nr_sparts_exchanged = s->nr_sparts - nr_sparts;
Pedro Gonnet's avatar
Pedro Gonnet committed
689
  engine_exchange_strays(s->e, nr_parts, &ind[nr_parts], &nr_parts_exchanged,
690
691
                         nr_gparts, &gind[nr_gparts], &nr_gparts_exchanged,
                         nr_sparts, &sind[nr_sparts], &nr_sparts_exchanged);
Pedro Gonnet's avatar
Pedro Gonnet committed
692
693

  /* Set the new particle counts. */
694
  s->nr_parts = nr_parts + nr_parts_exchanged;
695
  s->nr_gparts = nr_gparts + nr_gparts_exchanged;
696
  s->nr_sparts = nr_sparts + nr_sparts_exchanged;
697

698
  /* Re-allocate the index array for the parts if needed.. */
699
  if (s->nr_parts + 1 > ind_size) {
700
    int *ind_new;
701
    if ((ind_new = (int *)malloc(sizeof(int) * (s->nr_parts + 1))) == NULL)
702
      error("Failed to allocate temporary particle indices.");
703
    memcpy(ind_new, ind, sizeof(int) * nr_parts);
704
705
    free(ind);
    ind = ind_new;
706
707
  }

708
  /* Re-allocate the index array for the sparts if needed.. */
709
  if (s->nr_sparts + 1 > sind_size) {
710
711
    int *sind_new;
    if ((sind_new = (int *)malloc(sizeof(int) * (s->nr_sparts + 1))) == NULL)
712
      error("Failed to allocate temporary s-particle indices.");
713
714
715
716
717
    memcpy(sind_new, sind, sizeof(int) * nr_sparts);
    free(sind);
    sind = sind_new;
  }

718
719
720
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
  const double ih[3] = {s->iwidth[0], s->iwidth[1], s->iwidth[2]};

721
  /* Assign each received part to its cell. */
Pedro Gonnet's avatar
Pedro Gonnet committed
722
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
723
    const struct part *const p = &s->parts[k];
724
    ind[k] =
725
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
726
#ifdef SWIFT_DEBUG_CHECKS
727
    if (cells_top[ind[k]].nodeID != local_nodeID)
728
      error("Received part that does not belong to me (nodeID=%i).",
729
            cells_top[ind[k]].nodeID);
730
#endif
731
  }
732
  nr_parts = s->nr_parts;
733

734
  /* Assign each received spart to its cell. */
735
736
737
738
739
740
  for (size_t k = nr_sparts; k < s->nr_sparts; k++) {
    const struct spart *const sp = &s->sparts[k];
    sind[k] =
        cell_getid(cdim, sp->x[0] * ih[0], sp->x[1] * ih[1], sp->x[2] * ih[2]);
#ifdef SWIFT_DEBUG_CHECKS
    if (cells_top[sind[k]].nodeID != local_nodeID)
741
      error("Received s-part that does not belong to me (nodeID=%i).",
742
743
744
745
746
            cells_top[sind[k]].nodeID);
#endif
  }
  nr_sparts = s->nr_sparts;

747
#endif /* WITH_MPI */
748
749

  /* Sort the parts according to their cells. */
750
751
  if (nr_parts > 0)
    space_parts_sort(s, ind, nr_parts, 0, s->nr_cells - 1, verbose);
752

753
754
755
#ifdef SWIFT_DEBUG_CHECKS
  /* Verify that the part have been sorted correctly. */
  for (size_t k = 0; k < nr_parts; k++) {
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
    const struct part *p = &s->parts[k];

    /* New cell index */
    const int new_ind =
        cell_getid(s->cdim, p->x[0] * s->iwidth[0], p->x[1] * s->iwidth[1],
                   p->x[2] * s->iwidth[2]);

    /* New cell of this part */
    const struct cell *c = &s->cells_top[new_ind];

    if (ind[k] != new_ind)
      error("part's new cell index not matching sorted index.");

    if (p->x[0] < c->loc[0] || p->x[0] > c->loc[0] + c->width[0] ||
        p->x[1] < c->loc[1] || p->x[1] > c->loc[1] + c->width[1] ||
        p->x[2] < c->loc[2] || p->x[2] > c->loc[2] + c->width[2])
772
773
774
775
      error("part not sorted into the right top-level cell!");
  }
#endif

776
777
778
779
  /* Sort the sparts according to their cells. */
  if (nr_sparts > 0)
    space_sparts_sort(s, sind, nr_sparts, 0, s->nr_cells - 1, verbose);

780
781
782
#ifdef SWIFT_DEBUG_CHECKS
  /* Verify that the spart have been sorted correctly. */
  for (size_t k = 0; k < nr_sparts; k++) {
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
    const struct spart *sp = &s->sparts[k];

    /* New cell index */
    const int new_sind =
        cell_getid(s->cdim, sp->x[0] * s->iwidth[0], sp->x[1] * s->iwidth[1],
                   sp->x[2] * s->iwidth[2]);

    /* New cell of this spart */
    const struct cell *c = &s->cells_top[new_sind];

    if (sind[k] != new_sind)
      error("spart's new cell index not matching sorted index.");

    if (sp->x[0] < c->loc[0] || sp->x[0] > c->loc[0] + c->width[0] ||
        sp->x[1] < c->loc[1] || sp->x[1] > c->loc[1] + c->width[1] ||
        sp->x[2] < c->loc[2] || sp->x[2] > c->loc[2] + c->width[2])
799
800
801
802
      error("spart not sorted into the right top-level cell!");
  }
#endif

803
804
805
806
807
  /* Re-link the gparts to their (s-)particles. */
  if (nr_parts > 0 && nr_gparts > 0)
    part_relink_gparts_to_parts(s->parts, nr_parts, 0);
  if (nr_sparts > 0 && nr_gparts > 0)
    part_relink_gparts_to_sparts(s->sparts, nr_sparts, 0);
808

809
810
811
812
813
814
815
816
817
818
  /* Extract the cell counts from the sorted indices. */
  size_t last_index = 0;
  ind[nr_parts] = s->nr_cells;  // sentinel.
  for (size_t k = 0; k < nr_parts; k++) {
    if (ind[k] < ind[k + 1]) {
      cells_top[ind[k]].count = k - last_index + 1;
      last_index = k + 1;
    }
  }

819
820
  /* Extract the cell counts from the sorted indices. */
  size_t last_sindex = 0;
821
  sind[nr_sparts] = s->nr_cells;  // sentinel.
822
823
824
825
826
827
828
  for (size_t k = 0; k < nr_sparts; k++) {
    if (sind[k] < sind[k + 1]) {
      cells_top[sind[k]].scount = k - last_sindex + 1;
      last_sindex = k + 1;
    }
  }

829
  /* We no longer need the indices as of here. */
830
  free(ind);
831
  free(sind);
832

833
834
#ifdef WITH_MPI

835
  /* Re-allocate the index array for the gparts if needed.. */
836
  if (s->nr_gparts + 1 > gind_size) {
837
    int *gind_new;
838
    if ((gind_new = (int *)malloc(sizeof(int) * (s->nr_gparts + 1))) == NULL)
839
      error("Failed to allocate temporary g-particle indices.");
840
    memcpy(gind_new, gind, sizeof(int) * nr_gparts);
841
842
843
844
    free(gind);
    gind = gind_new;
  }

845
  /* Assign each received gpart to its cell. */
846
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
847
    const struct gpart *const p = &s->gparts[k];
848
849
    gind[k] =
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
850
851

#ifdef SWIFT_DEBUG_CHECKS
852
    if (cells_top[gind[k]].nodeID != s->e->nodeID)
853
      error("Received g-part that does not belong to me (nodeID=%i).",
854
            cells_top[gind[k]].nodeID);
855
#endif
856
857
858
  }
  nr_gparts = s->nr_gparts;

859
#endif /* WITH_MPI */
860

861
  /* Sort the gparts according to their cells. */
862
863
  if (nr_gparts > 0)
    space_gparts_sort(s, gind, nr_gparts, 0, s->nr_cells - 1, verbose);
864

865
866
867
#ifdef SWIFT_DEBUG_CHECKS
  /* Verify that the gpart have been sorted correctly. */
  for (size_t k = 0; k < nr_gparts; k++) {
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
    const struct gpart *gp = &s->gparts[k];

    /* New cell index */
    const int new_gind =
        cell_getid(s->cdim, gp->x[0] * s->iwidth[0], gp->x[1] * s->iwidth[1],
                   gp->x[2] * s->iwidth[2]);

    /* New cell of this gpart */
    const struct cell *c = &s->cells_top[new_gind];

    if (gind[k] != new_gind)
      error("gpart's new cell index not matching sorted index.");

    if (gp->x[0] < c->loc[0] || gp->x[0] > c->loc[0] + c->width[0] ||
        gp->x[1] < c->loc[1] || gp->x[1] > c->loc[1] + c->width[1] ||
        gp->x[2] < c->loc[2] || gp->x[2] > c->loc[2] + c->width[2])
884
885
886
887
      error("gpart not sorted into the right top-level cell!");
  }
#endif

888
  /* Re-link the parts. */
889
  if (nr_parts > 0 && nr_gparts > 0)
890
891
892
893
894
    part_relink_parts_to_gparts(s->gparts, nr_gparts, s->parts);

  /* Re-link the sparts. */
  if (nr_sparts > 0 && nr_gparts > 0)
    part_relink_sparts_to_gparts(s->gparts, nr_gparts, s->sparts);
895

896
897
  /* Extract the cell counts from the sorted indices. */
  size_t last_gindex = 0;
898
  gind[nr_gparts] = s->nr_cells;
899
900
  for (size_t k = 0; k < nr_gparts; k++) {
    if (gind[k] < gind[k + 1]) {
901
      cells_top[gind[k]].gcount = k - last_gindex + 1;
902
903
904
905
      last_gindex = k + 1;
    }
  }

906
  /* We no longer need the indices as of here. */
907
  free(gind);
908

909
#ifdef SWIFT_DEBUG_CHECKS
910
  /* Verify that the links are correct */
911
912
913
  if ((nr_gparts > 0 && nr_parts > 0) || (nr_gparts > 0 && nr_sparts > 0))
    part_verify_links(s->parts, s->gparts, s->sparts, nr_parts, nr_gparts,
                      nr_sparts, verbose);
914
#endif
915

916
917
  /* Hook the cells up to the parts. */
  // tic = getticks();
918
919
920
  struct part *finger = s->parts;
  struct xpart *xfinger = s->xparts;
  struct gpart *gfinger = s->gparts;
921
  struct spart *sfinger = s->sparts;
922
  for (int k = 0; k < s->nr_cells; k++) {
923
    struct cell *restrict c = &cells_top[k];
924
925
    c->ti_old_part = ti_old;
    c->ti_old_gpart = ti_old;
926
    c->ti_old_multipole = ti_old;
927
928
929
930
931
932
933
934
935
936
    if (c->nodeID == engine_rank) {
      c->parts = finger;
      c->xparts = xfinger;
      c->gparts = gfinger;
      c->sparts = sfinger;
      finger = &finger[c->count];
      xfinger = &xfinger[c->count];
      gfinger = &gfinger[c->gcount];
      sfinger = &sfinger[c->scount];
    }
937
  }