space.c 57.2 KB
Newer Older
1
/*******************************************************************************
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 * This file is part of SWIFT.
 * Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
 *                    Matthieu Schaller (matthieu.schaller@durham.ac.uk)
 *               2015 Peter W. Draper (p.w.draper@durham.ac.uk)
 *               2016 John A. Regan (john.a.regan@durham.ac.uk)
 *                    Tom Theuns (tom.theuns@durham.ac.uk)
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 ******************************************************************************/
Pedro Gonnet's avatar
Pedro Gonnet committed
23
24
25
26
27
28
29
30

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <math.h>
31
#include <stdlib.h>
32
#include <string.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
33

34
35
/* MPI headers. */
#ifdef WITH_MPI
36
#include <mpi.h>
37
38
#endif

39
40
41
/* This object's header. */
#include "space.h"

Pedro Gonnet's avatar
Pedro Gonnet committed
42
/* Local headers. */
43
#include "atomic.h"
44
#include "const.h"
45
#include "cooling.h"
46
#include "engine.h"
47
#include "error.h"
48
49
#include "gravity.h"
#include "hydro.h"
50
#include "kernel_hydro.h"
51
#include "lock.h"
52
#include "minmax.h"
53
#include "runner.h"
54
#include "threadpool.h"
55
#include "tools.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
56
57
58

/* Split size. */
int space_splitsize = space_splitsize_default;
59
int space_subsize = space_subsize_default;
60
int space_maxsize = space_maxsize_default;
61
int space_maxcount = space_maxcount_default;
Pedro Gonnet's avatar
Pedro Gonnet committed
62
63
64

/* Map shift vector to sortlist. */
const int sortlistID[27] = {
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
    /* ( -1 , -1 , -1 ) */ 0,
    /* ( -1 , -1 ,  0 ) */ 1,
    /* ( -1 , -1 ,  1 ) */ 2,
    /* ( -1 ,  0 , -1 ) */ 3,
    /* ( -1 ,  0 ,  0 ) */ 4,
    /* ( -1 ,  0 ,  1 ) */ 5,
    /* ( -1 ,  1 , -1 ) */ 6,
    /* ( -1 ,  1 ,  0 ) */ 7,
    /* ( -1 ,  1 ,  1 ) */ 8,
    /* (  0 , -1 , -1 ) */ 9,
    /* (  0 , -1 ,  0 ) */ 10,
    /* (  0 , -1 ,  1 ) */ 11,
    /* (  0 ,  0 , -1 ) */ 12,
    /* (  0 ,  0 ,  0 ) */ 0,
    /* (  0 ,  0 ,  1 ) */ 12,
    /* (  0 ,  1 , -1 ) */ 11,
    /* (  0 ,  1 ,  0 ) */ 10,
    /* (  0 ,  1 ,  1 ) */ 9,
    /* (  1 , -1 , -1 ) */ 8,
    /* (  1 , -1 ,  0 ) */ 7,
    /* (  1 , -1 ,  1 ) */ 6,
    /* (  1 ,  0 , -1 ) */ 5,
    /* (  1 ,  0 ,  0 ) */ 4,
    /* (  1 ,  0 ,  1 ) */ 3,
    /* (  1 ,  1 , -1 ) */ 2,
    /* (  1 ,  1 ,  0 ) */ 1,
    /* (  1 ,  1 ,  1 ) */ 0};

93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
/**
 * @brief Interval stack necessary for parallel particle sorting.
 */
struct qstack {
  volatile ptrdiff_t i, j;
  volatile int min, max;
  volatile int ready;
};

/**
 * @brief Parallel particle-sorting stack
 */
struct parallel_sort {
  struct part *parts;
  struct gpart *gparts;
  struct xpart *xparts;
  int *ind;
  struct qstack *stack;
  unsigned int stack_size;
  volatile unsigned int first, last, waiting;
};

115
116
117
118
119
120
121
122
123
/**
 * @brief Information required to compute the particle cell indices.
 */
struct index_data {
  struct space *s;
  struct cell *cells;
  int *ind;
};

124
125
126
127
128
129
130
131
132
133
134
/**
 * @brief Get the shift-id of the given pair of cells, swapping them
 *      if need be.
 *
 * @param s The space
 * @param ci Pointer to first #cell.
 * @param cj Pointer second #cell.
 * @param shift Vector from ci to cj.
 *
 * @return The shift ID and set shift, may or may not swap ci and cj.
 */
135
136
137
138
int space_getsid(struct space *s, struct cell **ci, struct cell **cj,
                 double *shift) {

  /* Get the relative distance between the pairs, wrapping. */
139
140
141
  const int periodic = s->periodic;
  double dx[3];
  for (int k = 0; k < 3; k++) {
142
143
144
145
146
147
148
149
150
151
152
    dx[k] = (*cj)->loc[k] - (*ci)->loc[k];
    if (periodic && dx[k] < -s->dim[k] / 2)
      shift[k] = s->dim[k];
    else if (periodic && dx[k] > s->dim[k] / 2)
      shift[k] = -s->dim[k];
    else
      shift[k] = 0.0;
    dx[k] += shift[k];
  }

  /* Get the sorting index. */
153
  int sid = 0;
154
  for (int k = 0; k < 3; k++)
155
156
157
158
    sid = 3 * sid + ((dx[k] < 0.0) ? 0 : ((dx[k] > 0.0) ? 2 : 1));

  /* Switch the cells around? */
  if (runner_flip[sid]) {
159
    struct cell *temp = *ci;
160
161
    *ci = *cj;
    *cj = temp;
162
    for (int k = 0; k < 3; k++) shift[k] = -shift[k];
163
164
165
166
167
168
  }
  sid = sortlistID[sid];

  /* Return the sort ID. */
  return sid;
}
169

170
/**
171
 * @brief Recursively dismantle a cell tree.
172
 *
173
174
 * @param s The #space.
 * @param c The #cell to recycle.
175
 */
176
177
178
void space_rebuild_recycle(struct space *s, struct cell *c) {

  if (c->split)
179
    for (int k = 0; k < 8; k++)
180
181
182
183
184
185
186
      if (c->progeny[k] != NULL) {
        space_rebuild_recycle(s, c->progeny[k]);
        space_recycle(s, c->progeny[k]);
        c->progeny[k] = NULL;
      }
}

187
/**
188
 * @brief Re-build the top-level cell grid.
189
 *
190
191
 * @param s The #space.
 * @param cell_max Maximum cell edge length.
192
 * @param verbose Print messages to stdout or not.
193
 */
194
void space_regrid(struct space *s, double cell_max, int verbose) {
195

196
  const size_t nr_parts = s->nr_parts;
197
  const ticks tic = getticks();
198
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
199

200
  /* Run through the cells and get the current h_max. */
201
  // tic = getticks();
202
  float h_max = s->cell_min / kernel_gamma / space_stretch;
203
  if (nr_parts > 0) {
204
    if (s->cells_top != NULL) {
Tom Theuns's avatar
Tom Theuns committed
205
      for (int k = 0; k < s->nr_cells; k++) {
206
207
208
        if (s->cells_top[k].nodeID == engine_rank &&
            s->cells_top[k].h_max > h_max) {
          h_max = s->cells_top[k].h_max;
209
        }
210
211
      }
    } else {
212
      for (size_t k = 0; k < nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
213
        if (s->parts[k].h > h_max) h_max = s->parts[k].h;
214
      }
215
216
217
218
219
220
221
222
223
224
    }
  }

/* If we are running in parallel, make sure everybody agrees on
   how large the largest cell should be. */
#ifdef WITH_MPI
  {
    float buff;
    if (MPI_Allreduce(&h_max, &buff, 1, MPI_FLOAT, MPI_MAX, MPI_COMM_WORLD) !=
        MPI_SUCCESS)
225
      error("Failed to aggregate the rebuild flag across nodes.");
226
227
228
    h_max = buff;
  }
#endif
229
  if (verbose) message("h_max is %.3e (cell_max=%.3e).", h_max, cell_max);
230
231

  /* Get the new putative cell dimensions. */
232
233
234
235
  const int cdim[3] = {
      floor(s->dim[0] / fmax(h_max * kernel_gamma * space_stretch, cell_max)),
      floor(s->dim[1] / fmax(h_max * kernel_gamma * space_stretch, cell_max)),
      floor(s->dim[2] / fmax(h_max * kernel_gamma * space_stretch, cell_max))};
236
237
238
239
240

  /* Check if we have enough cells for periodicity. */
  if (s->periodic && (cdim[0] < 3 || cdim[1] < 3 || cdim[2] < 3))
    error(
        "Must have at least 3 cells in each spatial dimension when periodicity "
241
242
243
244
        "is switched on.\nThis error is often caused by any of the "
        "followings:\n"
        " - too few particles to generate a sensible grid,\n"
        " - the initial value of 'SPH:max_smoothing_length' is too large,\n"
245
        " - the (minimal) time-step is too large leading to particles with "
246
247
248
        "predicted smoothing lengths too large for the box size,\n"
        " - particle with velocities so large that they move by more than two "
        "box sizes per time-step.\n");
249

250
251
252
253
254
255
  /* Check if we have enough cells for gravity. */
  if (s->gravity && (cdim[0] < 8 || cdim[1] < 8 || cdim[2] < 8))
    error(
        "Must have at least 8 cells in each spatial dimension when gravity "
        "is switched on.");

256
257
258
/* In MPI-Land, changing the top-level cell size requires that the
 * global partition is recomputed and the particles redistributed.
 * Be prepared to do that. */
259
#ifdef WITH_MPI
Matthieu Schaller's avatar
Matthieu Schaller committed
260
  double oldwidth[3];
261
262
263
264
265
266
267
268
  double oldcdim[3];
  int *oldnodeIDs = NULL;
  if (cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] || cdim[2] < s->cdim[2]) {

    /* Capture state of current space. */
    oldcdim[0] = s->cdim[0];
    oldcdim[1] = s->cdim[1];
    oldcdim[2] = s->cdim[2];
269
270
271
    oldwidth[0] = s->width[0];
    oldwidth[1] = s->width[1];
    oldwidth[2] = s->width[2];
272
273
274
275
276
277
278
279
280

    if ((oldnodeIDs = (int *)malloc(sizeof(int) * s->nr_cells)) == NULL)
      error("Failed to allocate temporary nodeIDs.");

    int cid = 0;
    for (int i = 0; i < s->cdim[0]; i++) {
      for (int j = 0; j < s->cdim[1]; j++) {
        for (int k = 0; k < s->cdim[2]; k++) {
          cid = cell_getid(oldcdim, i, j, k);
281
          oldnodeIDs[cid] = s->cells_top[cid].nodeID;
282
283
284
285
286
        }
      }
    }
  }

287
288
289
290
#endif

  /* Do we need to re-build the upper-level cells? */
  // tic = getticks();
291
  if (s->cells_top == NULL || cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] ||
292
293
294
      cdim[2] < s->cdim[2]) {

    /* Free the old cells, if they were allocated. */
295
    if (s->cells_top != NULL) {
296
      for (int k = 0; k < s->nr_cells; k++) {
297
298
        space_rebuild_recycle(s, &s->cells_top[k]);
        if (s->cells_top[k].sort != NULL) free(s->cells_top[k].sort);
299
      }
300
      free(s->cells_top);
301
302
303
304
      s->maxdepth = 0;
    }

    /* Set the new cell dimensions only if smaller. */
305
    for (int k = 0; k < 3; k++) {
306
      s->cdim[k] = cdim[k];
307
308
      s->width[k] = s->dim[k] / cdim[k];
      s->iwidth[k] = 1.0 / s->width[k];
309
    }
310
    const float dmin = min(s->width[0], min(s->width[1], s->width[2]));
311
312
313

    /* Allocate the highest level of cells. */
    s->tot_cells = s->nr_cells = cdim[0] * cdim[1] * cdim[2];
314
    if (posix_memalign((void *)&s->cells_top, cell_align,
315
316
                       s->nr_cells * sizeof(struct cell)) != 0)
      error("Failed to allocate cells.");
317
    bzero(s->cells_top, s->nr_cells * sizeof(struct cell));
318
    for (int k = 0; k < s->nr_cells; k++)
319
320
      if (lock_init(&s->cells_top[k].lock) != 0)
        error("Failed to init spinlock.");
321
322

    /* Set the cell location and sizes. */
323
324
325
    for (int i = 0; i < cdim[0]; i++)
      for (int j = 0; j < cdim[1]; j++)
        for (int k = 0; k < cdim[2]; k++) {
326
          struct cell *restrict c = &s->cells_top[cell_getid(cdim, i, j, k)];
327
328
329
330
331
332
          c->loc[0] = i * s->width[0];
          c->loc[1] = j * s->width[1];
          c->loc[2] = k * s->width[2];
          c->width[0] = s->width[0];
          c->width[1] = s->width[1];
          c->width[2] = s->width[2];
333
334
335
336
337
          c->dmin = dmin;
          c->depth = 0;
          c->count = 0;
          c->gcount = 0;
          c->super = c;
338
          c->ti_old = ti_current;
339
          lock_init(&c->lock);
Pedro Gonnet's avatar
Pedro Gonnet committed
340
        }
341
342

    /* Be verbose about the change. */
343
344
345
    if (verbose)
      message("set cell dimensions to [ %i %i %i ].", cdim[0], cdim[1],
              cdim[2]);
346
347
    fflush(stdout);

348
#ifdef WITH_MPI
349
350
351
352
353
    if (oldnodeIDs != NULL) {
      /* We have changed the top-level cell dimension, so need to redistribute
       * cells around the nodes. We repartition using the old space node
       * positions as a grid to resample. */
      if (s->e->nodeID == 0)
354
355
356
        message(
            "basic cell dimensions have increased - recalculating the "
            "global partition.");
357

Matthieu Schaller's avatar
Matthieu Schaller committed
358
      if (!partition_space_to_space(oldwidth, oldcdim, oldnodeIDs, s)) {
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376

        /* Failed, try another technique that requires no settings. */
        message("Failed to get a new partition, trying less optimal method");
        struct partition initial_partition;
#ifdef HAVE_METIS
        initial_partition.type = INITPART_METIS_NOWEIGHT;
#else
        initial_partition.type = INITPART_VECTORIZE;
#endif
        partition_initial_partition(&initial_partition, s->e->nodeID,
                                    s->e->nr_nodes, s);
      }

      /* Re-distribute the particles to their new nodes. */
      engine_redistribute(s->e);

      /* Make the proxies. */
      engine_makeproxies(s->e);
377

378
379
      /* Finished with these. */
      free(oldnodeIDs);
380
381
    }
#endif
382
383
384
385

    // message( "rebuilding upper-level cells took %.3f %s." ,
    // clocks_from_ticks(double)(getticks() - tic), clocks_getunit());

386
387
  } /* re-build upper-level cells? */

388
  else { /* Otherwise, just clean up the cells. */
389
390

    /* Free the old cells, if they were allocated. */
391
    for (int k = 0; k < s->nr_cells; k++) {
392
393
394
395
396
397
      space_rebuild_recycle(s, &s->cells_top[k]);
      s->cells_top[k].sorts = NULL;
      s->cells_top[k].nr_tasks = 0;
      s->cells_top[k].density = NULL;
      s->cells_top[k].gradient = NULL;
      s->cells_top[k].force = NULL;
398
      s->cells_top[k].grav = NULL;
399
400
401
402
403
404
405
406
      s->cells_top[k].dx_max = 0.0f;
      s->cells_top[k].sorted = 0;
      s->cells_top[k].count = 0;
      s->cells_top[k].gcount = 0;
      s->cells_top[k].init = NULL;
      s->cells_top[k].extra_ghost = NULL;
      s->cells_top[k].ghost = NULL;
      s->cells_top[k].kick = NULL;
407
408
      s->cells_top[k].cooling = NULL;
      s->cells_top[k].sourceterms = NULL;
409
      s->cells_top[k].super = &s->cells_top[k];
410
411
412
413
414
415
416
417
418
419
420
#if WITH_MPI
      s->cells_top[k].recv_xv = NULL;
      s->cells_top[k].recv_rho = NULL;
      s->cells_top[k].recv_gradient = NULL;
      s->cells_top[k].recv_ti = NULL;

      s->cells_top[k].send_xv = NULL;
      s->cells_top[k].send_rho = NULL;
      s->cells_top[k].send_gradient = NULL;
      s->cells_top[k].send_ti = NULL;
#endif
421
    }
422
423
    s->maxdepth = 0;
  }
424
425
426
427

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
428
}
429
430
431
432
433
434

/**
 * @brief Re-build the cells as well as the tasks.
 *
 * @param s The #space in which to update the cells.
 * @param cell_max Maximal cell size.
435
 * @param verbose Print messages to stdout or not
436
437
 *
 */
438
void space_rebuild(struct space *s, double cell_max, int verbose) {
439

Matthieu Schaller's avatar
Matthieu Schaller committed
440
  const ticks tic = getticks();
441
442

  /* Be verbose about this. */
443
  // message("re)building space..."); fflush(stdout);
444
445

  /* Re-grid if necessary, or just re-set the cell data. */
446
  space_regrid(s, cell_max, verbose);
447

Pedro Gonnet's avatar
Pedro Gonnet committed
448
449
  size_t nr_parts = s->nr_parts;
  size_t nr_gparts = s->nr_gparts;
450
  struct cell *restrict cells_top = s->cells_top;
451
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
452
453
454

  /* Run through the particles and get their cell index. */
  const size_t ind_size = s->size_parts;
455
456
  int *ind;
  if ((ind = (int *)malloc(sizeof(int) * ind_size)) == NULL)
457
    error("Failed to allocate temporary particle indices.");
458
  if (ind_size > 0) space_parts_get_cell_index(s, ind, cells_top, verbose);
459
  for (size_t i = 0; i < s->nr_parts; ++i) cells_top[ind[i]].count++;
460

461
462
463
464
465
  /* Run through the gravity particles and get their cell index. */
  const size_t gind_size = s->size_gparts;
  int *gind;
  if ((gind = (int *)malloc(sizeof(int) * gind_size)) == NULL)
    error("Failed to allocate temporary g-particle indices.");
466
  if (gind_size > 0) space_gparts_get_cell_index(s, gind, cells_top, verbose);
467
  for (size_t i = 0; i < s->nr_gparts; ++i) cells_top[gind[i]].gcount++;
468
469

#ifdef WITH_MPI
470

471
  /* Move non-local parts to the end of the list. */
472
  const int local_nodeID = s->e->nodeID;
473
  for (size_t k = 0; k < nr_parts;) {
474
475
    if (cells_top[ind[k]].nodeID != local_nodeID) {
      cells_top[ind[k]].count -= 1;
476
      nr_parts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
477
      const struct part tp = s->parts[k];
478
479
      s->parts[k] = s->parts[nr_parts];
      s->parts[nr_parts] = tp;
480
      if (s->parts[k].gpart != NULL) {
481
        s->parts[k].gpart->id_or_neg_offset = -k;
482
483
      }
      if (s->parts[nr_parts].gpart != NULL) {
484
        s->parts[nr_parts].gpart->id_or_neg_offset = -nr_parts;
485
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
486
      const struct xpart txp = s->xparts[k];
487
488
      s->xparts[k] = s->xparts[nr_parts];
      s->xparts[nr_parts] = txp;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
489
      const int t = ind[k];
490
491
      ind[k] = ind[nr_parts];
      ind[nr_parts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
492
    } else {
493
494
495
496
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
497

498
#ifdef SWIFT_DEBUG_CHECKS
Peter W. Draper's avatar
Peter W. Draper committed
499
  /* Check that all parts are in the correct places. */
500
  for (size_t k = 0; k < nr_parts; k++) {
501
    if (cells_top[ind[k]].nodeID != local_nodeID) {
502
503
504
505
      error("Failed to move all non-local parts to send list");
    }
  }
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
506
    if (cells_top[ind[k]].nodeID == local_nodeID) {
507
      error("Failed to remove local parts from send list");
508
    }
509
510
  }
#endif
511

512
  /* Move non-local gparts to the end of the list. */
513
  for (size_t k = 0; k < nr_gparts;) {
514
515
    if (cells_top[gind[k]].nodeID != local_nodeID) {
      cells_top[gind[k]].gcount -= 1;
516
      nr_gparts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
517
      const struct gpart tp = s->gparts[k];
518
519
      s->gparts[k] = s->gparts[nr_gparts];
      s->gparts[nr_gparts] = tp;
520
521
      if (s->gparts[k].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
522
      }
523
524
525
      if (s->gparts[nr_gparts].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
526
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
527
528
529
      const int t = gind[k];
      gind[k] = gind[nr_gparts];
      gind[nr_gparts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
530
    } else {
531
532
533
534
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
535

536
#ifdef SWIFT_DEBUG_CHECKS
537
538
  /* Check that all gparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_gparts; k++) {
539
    if (cells_top[gind[k]].nodeID != local_nodeID) {
540
541
542
543
      error("Failed to move all non-local gparts to send list");
    }
  }
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
544
    if (cells_top[gind[k]].nodeID == local_nodeID) {
545
      error("Failed to remove local gparts from send list");
546
    }
547
548
  }
#endif
549

550
551
  /* Exchange the strays, note that this potentially re-allocates
     the parts arrays. */
552
  size_t nr_parts_exchanged = s->nr_parts - nr_parts;
553
  size_t nr_gparts_exchanged = s->nr_gparts - nr_gparts;
Pedro Gonnet's avatar
Pedro Gonnet committed
554
555
556
557
  engine_exchange_strays(s->e, nr_parts, &ind[nr_parts], &nr_parts_exchanged,
                         nr_gparts, &gind[nr_gparts], &nr_gparts_exchanged);

  /* Set the new particle counts. */
558
  s->nr_parts = nr_parts + nr_parts_exchanged;
559
  s->nr_gparts = nr_gparts + nr_gparts_exchanged;
560
561

  /* Re-allocate the index array if needed.. */
562
  if (s->nr_parts > ind_size) {
563
564
    int *ind_new;
    if ((ind_new = (int *)malloc(sizeof(int) * s->nr_parts)) == NULL)
565
      error("Failed to allocate temporary particle indices.");
566
    memcpy(ind_new, ind, sizeof(int) * nr_parts);
567
568
    free(ind);
    ind = ind_new;
569
570
  }

571
572
573
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
  const double ih[3] = {s->iwidth[0], s->iwidth[1], s->iwidth[2]};

574
  /* Assign each particle to its cell. */
Pedro Gonnet's avatar
Pedro Gonnet committed
575
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
576
    const struct part *const p = &s->parts[k];
577
    ind[k] =
578
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
579
    cells_top[ind[k]].count += 1;
580
#ifdef SWIFT_DEBUG_CHECKS
581
    if (cells_top[ind[k]].nodeID != local_nodeID)
582
      error("Received part that does not belong to me (nodeID=%i).",
583
            cells_top[ind[k]].nodeID);
584
#endif
585
  }
586
  nr_parts = s->nr_parts;
587
588

#endif /* WITH_MPI */
589
590

  /* Sort the parts according to their cells. */
591
  space_parts_sort(s, ind, nr_parts, 0, s->nr_cells - 1, verbose);
592
593

  /* Re-link the gparts. */
594
  if (nr_parts > 0 && nr_gparts > 0) part_relink_gparts(s->parts, nr_parts, 0);
595

596
#ifdef SWIFT_DEBUG_CHECKS
597
  /* Verify space_sort_struct. */
598
599
600
  for (size_t k = 1; k < nr_parts; k++) {
    if (ind[k - 1] > ind[k]) {
      error("Sort failed!");
601
    } else if (ind[k] != cell_getid(s->cdim, s->parts[k].x[0] * s->iwidth[0],
602
603
                                    s->parts[k].x[1] * s->iwidth[1],
                                    s->parts[k].x[2] * s->iwidth[2])) {
604
605
606
607
      error("Incorrect indices!");
    }
  }
#endif
608
609

  /* We no longer need the indices as of here. */
610
  free(ind);
611

612
613
614
615
#ifdef WITH_MPI

  /* Re-allocate the index array if needed.. */
  if (s->nr_gparts > gind_size) {
616
617
    int *gind_new;
    if ((gind_new = (int *)malloc(sizeof(int) * s->nr_gparts)) == NULL)
618
      error("Failed to allocate temporary g-particle indices.");
619
    memcpy(gind_new, gind, sizeof(int) * nr_gparts);
620
621
622
623
624
    free(gind);
    gind = gind_new;
  }

  /* Assign each particle to its cell. */
625
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
626
    const struct gpart *const p = &s->gparts[k];
627
628
    gind[k] =
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
629
630
631
632
633
634
635
    cells_top[gind[k]].gcount += 1;

#ifdef SWIFT_DEBUG_CHECKS
    if (cells_top[ind[k]].nodeID != s->e->nodeID)
      error("Received part that does not belong to me (nodeID=%i).",
            cells_top[ind[k]].nodeID);
#endif
636
637
638
639
  }
  nr_gparts = s->nr_gparts;

#endif
640

641
  /* Sort the gparts according to their cells. */
Matthieu Schaller's avatar
Matthieu Schaller committed
642
  space_gparts_sort(s, gind, nr_gparts, 0, s->nr_cells - 1, verbose);
643
644

  /* Re-link the parts. */
645
646
  if (nr_parts > 0 && nr_gparts > 0)
    part_relink_parts(s->gparts, nr_gparts, s->parts);
647
648

  /* We no longer need the indices as of here. */
649
  free(gind);
650

651
#ifdef SWIFT_DEBUG_CHECKS
652
653
654
  /* Verify that the links are correct */
  for (size_t k = 0; k < nr_gparts; ++k) {

655
    if (s->gparts[k].id_or_neg_offset < 0) {
656

657
      const struct part *part = &s->parts[-s->gparts[k].id_or_neg_offset];
658

659
660
661
662
      if (part->gpart != &s->gparts[k]) error("Linking problem !");

      if (s->gparts[k].x[0] != part->x[0] || s->gparts[k].x[1] != part->x[1] ||
          s->gparts[k].x[2] != part->x[2])
663
664
665
666
667
        error("Linked particles are not at the same position !");
    }
  }
  for (size_t k = 0; k < nr_parts; ++k) {

668
    if (s->parts[k].gpart != NULL &&
669
        s->parts[k].gpart->id_or_neg_offset != -(ptrdiff_t)k) {
670
      error("Linking problem !");
671
672
    }
  }
673
#endif
674

675
676
  /* Hook the cells up to the parts. */
  // tic = getticks();
677
678
679
  struct part *finger = s->parts;
  struct xpart *xfinger = s->xparts;
  struct gpart *gfinger = s->gparts;
680
  for (int k = 0; k < s->nr_cells; k++) {
681
    struct cell *restrict c = &cells_top[k];
682
    c->ti_old = ti_current;
683
684
685
686
687
688
689
    c->parts = finger;
    c->xparts = xfinger;
    c->gparts = gfinger;
    finger = &finger[c->count];
    xfinger = &xfinger[c->count];
    gfinger = &gfinger[c->gcount];
  }
690
  // message( "hooking up cells took %.3f %s." ,
Matthieu Schaller's avatar
Matthieu Schaller committed
691
  // clocks_from_ticks(getticks() - tic), clocks_getunit());
692
693
694

  /* At this point, we have the upper-level cells, old or new. Now make
     sure that the parts in each cell are ok. */
695
  space_split(s, cells_top, s->nr_cells, verbose);
696
697
698
699
700
701
702
703
704

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Split particles between cells of a hierarchy
 *
705
706
 * This is done in parallel using threads in the #threadpool.
 *
707
 * @param s The #space.
708
709
 * @param cells The cell hierarchy.
 * @param nr_cells The number of cells.
710
711
 * @param verbose Are we talkative ?
 */
712
713
void space_split(struct space *s, struct cell *cells, int nr_cells,
                 int verbose) {
714

Matthieu Schaller's avatar
Matthieu Schaller committed
715
  const ticks tic = getticks();
716

717
  threadpool_map(&s->e->threadpool, space_split_mapper, cells, nr_cells,
718
                 sizeof(struct cell), 1, s);
719

720
721
722
  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
723
}
724

725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
/**
 * @brief Runs through the top-level cells and checks whether tasks associated
 * with them can be split. If not, try to sanitize the cells.
 *
 * @param s The #space to act upon.
 */
void space_sanitize(struct space *s) {

  for (int k = 0; k < s->nr_cells; k++) {

    struct cell *c = &s->cells_top[k];
    const double min_width = c->dmin;

    /* Do we have a problem ? */
    if (c->h_max * kernel_gamma * space_stretch > min_width * 0.5 &&
        c->count > space_maxcount) {

      /* Ok, clean-up the mess */
      cell_sanitize(c);
    }
  }
}

748
/**
749
 * @brief #threadpool mapper function to compute the particle cell indices.
750
 *
751
 * @param map_data Pointer towards the particles.
752
 * @param nr_parts The number of particles to treat.
753
 * @param extra_data Pointers to the space and index list
754
 */
755
756
void space_parts_get_cell_index_mapper(void *map_data, int nr_parts,
                                       void *extra_data) {
757

758
759
760
761
  /* Unpack the data */
  struct part *restrict parts = (struct part *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
762
  int *const ind = data->ind + (ptrdiff_t)(parts - s->parts);
763
764

  /* Get some constants */
765
766
767
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
Matthieu Schaller's avatar
Matthieu Schaller committed
768
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
769
770
771
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
772

773
  for (int k = 0; k < nr_parts; k++) {
774
775
776
777

    /* Get the particle */
    struct part *restrict p = &parts[k];

778
779
780
781
    const double old_pos_x = p->x[0];
    const double old_pos_y = p->x[1];
    const double old_pos_z = p->x[2];

782
    /* Put it back into the simulation volume */
783
784
785
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
786
787

    /* Get its cell index */
Matthieu Schaller's avatar
Matthieu Schaller committed
788
789
    const int index =
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
790
    ind[k] = index;
791

792
793
794
795
    /* Update the position */
    p->x[0] = pos_x;
    p->x[1] = pos_y;
    p->x[2] = pos_z;
796
797
798
799
  }
}

/**
800
 * @brief #threadpool mapper function to compute the g-particle cell indices.
801
 *
802
 * @param map_data Pointer towards the g-particles.
803
 * @param nr_gparts The number of g-particles to treat.
804
 * @param extra_data Pointers to the space and index list
805
 */
806
807
void space_gparts_get_cell_index_mapper(void *map_data, int nr_gparts,
                                        void *extra_data) {
808

809
810
811
812
  /* Unpack the data */
  struct gpart *restrict gparts = (struct gpart *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
813
  int *const ind = data->ind + (ptrdiff_t)(gparts - s->gparts);
814
815

  /* Get some constants */
Matthieu Schaller's avatar
Matthieu Schaller committed
816
817
818
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
819
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
Matthieu Schaller's avatar
Matthieu Schaller committed
820
821
822
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
823

824
  for (int k = 0; k < nr_gparts; k++) {
825
826
827
828

    /* Get the particle */
    struct gpart *restrict gp = &gparts[k];

Matthieu Schaller's avatar
Matthieu Schaller committed
829
830
831
832
    const double old_pos_x = gp->x[0];
    const double old_pos_y = gp->x[1];
    const double old_pos_z = gp->x[2];

833
    /* Put it back into the simulation volume */
Matthieu Schaller's avatar
Matthieu Schaller committed
834
835
836
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
837
838
839

    /* Get its cell index */
    const int index =
Matthieu Schaller's avatar
Matthieu Schaller committed
840
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
841
    ind[k] = index;
Matthieu Schaller's avatar
Matthieu Schaller committed
842
843
844
845
846

    /* Update the position */
    gp->x[0] = pos_x;
    gp->x[1] = pos_y;
    gp->x[2] = pos_z;
847
848
849
  }
}

850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
/**
 * @brief Computes the cell index of all the particles and update the cell
 * count.
 *
 * @param s The #space.
 * @param ind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_parts_get_cell_index(struct space *s, int *ind, struct cell *cells,
                                int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = ind;

  threadpool_map(&s->e->threadpool, space_parts_get_cell_index_mapper, s->parts,
                 s->nr_parts, sizeof(struct part), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Computes the cell index of all the g-particles and update the cell
 * gcount.
 *
 * @param s The #space.
 * @param gind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_gparts_get_cell_index(struct space *s, int *gind, struct cell *cells,
                                 int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = gind;

  threadpool_map(&s->e->threadpool, space_gparts_get_cell_index_mapper,
                 s->gparts, s->nr_gparts, sizeof(struct gpart), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

906
/**
907
 * @brief Sort the particles and condensed particles according to the given
908
 * indices.
909
 *
Matthieu Schaller's avatar
Matthieu Schaller committed
910
 * @param s The #space.
911
912
913
914
 * @param ind The indices with respect to which the parts are sorted.
 * @param N The number of parts
 * @param min Lowest index.
 * @param max highest index.
915
 * @param verbose Are we talkative ?
916
 */
917
void space_parts_sort(struct space *s, int *ind, size_t N, int min, int max,
918
919
                      int verbose) {

Matthieu Schaller's avatar
Matthieu Schaller committed
920
  const ticks tic = getticks();
921

922
923
924
925
926
927
  /* Populate a parallel_sort structure with the input data */
  struct parallel_sort sort_struct;
  sort_struct.parts = s->parts;
  sort_struct.xparts = s->xparts;
  sort_struct.ind = ind;
  sort_struct.stack_size = 2 * (max - min + 1) + 10 + s->e->nr_threads;
928
929
  if ((sort_struct.stack =
           malloc(sizeof(struct qstack) * sort_struct.stack_size)) == NULL)
930
    error("Failed to allocate sorting stack.");
Matthieu Schaller's avatar
Matthieu Schaller committed
931
  for (unsigned int i = 0; i < sort_struct.stack_size; i++)
932
    sort_struct.stack[i].ready = 0;
933

934
  /* Add the first interval. */
935
936
937
938
939
940
941
942
943
944
945
  sort_struct.stack[0].i = 0;
  sort_struct.stack[0].j = N - 1;
  sort_struct.stack[0].min = min;
  sort_struct.stack[0].max = max;
  sort_struct.stack[0].ready = 1;
  sort_struct.first = 0;
  sort_struct.last = 1;
  sort_struct.waiting = 1;

  /* Launch the sorting tasks with a stride of zero such that the same
     map data is passed to each thread. */
946
947
  threadpool_map(&s->e->threadpool, space_parts_sort_mapper, &sort_struct,
                 s->e->threadpool.num_threads, 0, 1, NULL);
948

949
#ifdef SWIFT_DEBUG_CHECKS
950
  /* Verify space_sort_struct. */
951
  for (size_t i = 1; i < N; i++)
952
    if (ind[i - 1] > ind[i])
953
      error("Sorting failed (ind[%zu]=%i,ind[%zu]=%i), min=%i, max=%i.", i - 1,
954
955
956
            ind[i - 1], i, ind[i], min, max);
  message("Sorting succeeded.");
#endif
957

958
  /* Clean up. */
959
  free(sort_struct.stack);
960
961
962
963

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
964
}
965

966
967
void space_parts_sort_mapper(void *map_data, int num_elements,
                             void *extra_data) {
968
969
970

  /* Unpack the mapping data. */
  struct parallel_sort *sort_struct = (struct parallel_sort *)map_data;
971

972
  /* Pointers to the sorting data. */