space.c 58 KB
Newer Older
1
/*******************************************************************************
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 * This file is part of SWIFT.
 * Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
 *                    Matthieu Schaller (matthieu.schaller@durham.ac.uk)
 *               2015 Peter W. Draper (p.w.draper@durham.ac.uk)
 *               2016 John A. Regan (john.a.regan@durham.ac.uk)
 *                    Tom Theuns (tom.theuns@durham.ac.uk)
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 ******************************************************************************/
Pedro Gonnet's avatar
Pedro Gonnet committed
23
24
25
26
27
28
29
30

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <math.h>
31
#include <stdlib.h>
32
#include <string.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
33

34
35
/* MPI headers. */
#ifdef WITH_MPI
36
#include <mpi.h>
37
38
#endif

39
40
41
/* This object's header. */
#include "space.h"

Pedro Gonnet's avatar
Pedro Gonnet committed
42
/* Local headers. */
43
#include "atomic.h"
44
#include "const.h"
45
#include "cooling.h"
46
#include "engine.h"
47
#include "error.h"
48
49
#include "gravity.h"
#include "hydro.h"
50
#include "kernel_hydro.h"
51
#include "lock.h"
52
#include "memswap.h"
53
#include "minmax.h"
54
#include "runner.h"
55
#include "threadpool.h"
56
#include "tools.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
57
58
59

/* Split size. */
int space_splitsize = space_splitsize_default;
60
int space_subsize = space_subsize_default;
61
int space_maxsize = space_maxsize_default;
62
int space_maxcount = space_maxcount_default;
Pedro Gonnet's avatar
Pedro Gonnet committed
63
64
65

/* Map shift vector to sortlist. */
const int sortlistID[27] = {
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
    /* ( -1 , -1 , -1 ) */ 0,
    /* ( -1 , -1 ,  0 ) */ 1,
    /* ( -1 , -1 ,  1 ) */ 2,
    /* ( -1 ,  0 , -1 ) */ 3,
    /* ( -1 ,  0 ,  0 ) */ 4,
    /* ( -1 ,  0 ,  1 ) */ 5,
    /* ( -1 ,  1 , -1 ) */ 6,
    /* ( -1 ,  1 ,  0 ) */ 7,
    /* ( -1 ,  1 ,  1 ) */ 8,
    /* (  0 , -1 , -1 ) */ 9,
    /* (  0 , -1 ,  0 ) */ 10,
    /* (  0 , -1 ,  1 ) */ 11,
    /* (  0 ,  0 , -1 ) */ 12,
    /* (  0 ,  0 ,  0 ) */ 0,
    /* (  0 ,  0 ,  1 ) */ 12,
    /* (  0 ,  1 , -1 ) */ 11,
    /* (  0 ,  1 ,  0 ) */ 10,
    /* (  0 ,  1 ,  1 ) */ 9,
    /* (  1 , -1 , -1 ) */ 8,
    /* (  1 , -1 ,  0 ) */ 7,
    /* (  1 , -1 ,  1 ) */ 6,
    /* (  1 ,  0 , -1 ) */ 5,
    /* (  1 ,  0 ,  0 ) */ 4,
    /* (  1 ,  0 ,  1 ) */ 3,
    /* (  1 ,  1 , -1 ) */ 2,
    /* (  1 ,  1 ,  0 ) */ 1,
    /* (  1 ,  1 ,  1 ) */ 0};

94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
/**
 * @brief Interval stack necessary for parallel particle sorting.
 */
struct qstack {
  volatile ptrdiff_t i, j;
  volatile int min, max;
  volatile int ready;
};

/**
 * @brief Parallel particle-sorting stack
 */
struct parallel_sort {
  struct part *parts;
  struct gpart *gparts;
  struct xpart *xparts;
  int *ind;
  struct qstack *stack;
  unsigned int stack_size;
  volatile unsigned int first, last, waiting;
};

116
117
118
119
120
121
122
123
124
/**
 * @brief Information required to compute the particle cell indices.
 */
struct index_data {
  struct space *s;
  struct cell *cells;
  int *ind;
};

125
126
127
128
129
130
131
132
133
134
135
/**
 * @brief Get the shift-id of the given pair of cells, swapping them
 *      if need be.
 *
 * @param s The space
 * @param ci Pointer to first #cell.
 * @param cj Pointer second #cell.
 * @param shift Vector from ci to cj.
 *
 * @return The shift ID and set shift, may or may not swap ci and cj.
 */
136
137
138
139
int space_getsid(struct space *s, struct cell **ci, struct cell **cj,
                 double *shift) {

  /* Get the relative distance between the pairs, wrapping. */
140
141
142
  const int periodic = s->periodic;
  double dx[3];
  for (int k = 0; k < 3; k++) {
143
144
145
146
147
148
149
150
151
152
153
    dx[k] = (*cj)->loc[k] - (*ci)->loc[k];
    if (periodic && dx[k] < -s->dim[k] / 2)
      shift[k] = s->dim[k];
    else if (periodic && dx[k] > s->dim[k] / 2)
      shift[k] = -s->dim[k];
    else
      shift[k] = 0.0;
    dx[k] += shift[k];
  }

  /* Get the sorting index. */
154
  int sid = 0;
155
  for (int k = 0; k < 3; k++)
156
157
158
159
    sid = 3 * sid + ((dx[k] < 0.0) ? 0 : ((dx[k] > 0.0) ? 2 : 1));

  /* Switch the cells around? */
  if (runner_flip[sid]) {
160
    struct cell *temp = *ci;
161
162
    *ci = *cj;
    *cj = temp;
163
    for (int k = 0; k < 3; k++) shift[k] = -shift[k];
164
165
166
167
168
169
  }
  sid = sortlistID[sid];

  /* Return the sort ID. */
  return sid;
}
170

171
/**
172
 * @brief Recursively dismantle a cell tree.
173
 *
174
175
 * @param s The #space.
 * @param c The #cell to recycle.
176
 */
177
178
179
void space_rebuild_recycle(struct space *s, struct cell *c) {

  if (c->split)
180
    for (int k = 0; k < 8; k++)
181
182
183
184
185
186
187
      if (c->progeny[k] != NULL) {
        space_rebuild_recycle(s, c->progeny[k]);
        space_recycle(s, c->progeny[k]);
        c->progeny[k] = NULL;
      }
}

188
189
190
/**
 * @brief Mapper function to clean out the cell hierarchies for a regrid.
 */
Pedro Gonnet's avatar
Pedro Gonnet committed
191
192
193
194

void space_clear_cells_mapper(void *map_data, int num_elements,
                              void *extra_data) {

195
196
  struct cell *cells = (struct cell *)map_data;
  struct space *s = (struct space *)extra_data;
Pedro Gonnet's avatar
Pedro Gonnet committed
197

198
199
  for (int k = 0; k < num_elements; k++) {
    struct cell *c = &cells[k];
Pedro Gonnet's avatar
Pedro Gonnet committed
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
    space_rebuild_recycle(s, c);
    c->sorts = NULL;
    c->nr_tasks = 0;
    c->density = NULL;
    c->gradient = NULL;
    c->force = NULL;
    c->grav = NULL;
    c->dx_max = 0.0f;
    c->sorted = 0;
    c->count = 0;
    c->gcount = 0;
    c->init = NULL;
    c->extra_ghost = NULL;
    c->ghost = NULL;
    c->kick = NULL;
    c->cooling = NULL;
    c->sourceterms = NULL;
    c->super = c;
218
#if WITH_MPI
Pedro Gonnet's avatar
Pedro Gonnet committed
219
220
221
222
223
224
225
226
227
    c->recv_xv = NULL;
    c->recv_rho = NULL;
    c->recv_gradient = NULL;
    c->recv_ti = NULL;

    c->send_xv = NULL;
    c->send_rho = NULL;
    c->send_gradient = NULL;
    c->send_ti = NULL;
228
229
230
231
#endif
  }
}

232
/**
233
 * @brief Re-build the top-level cell grid.
234
 *
235
 * @param s The #space.
236
 * @param verbose Print messages to stdout or not.
237
 */
238
void space_regrid(struct space *s, int verbose) {
239

240
  const size_t nr_parts = s->nr_parts;
241
  const ticks tic = getticks();
242
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
243

244
  /* Run through the cells and get the current h_max. */
245
  // tic = getticks();
246
  float h_max = s->cell_min / kernel_gamma / space_stretch;
247
  if (nr_parts > 0) {
248
    if (s->cells_top != NULL) {
Tom Theuns's avatar
Tom Theuns committed
249
      for (int k = 0; k < s->nr_cells; k++) {
250
251
252
        if (s->cells_top[k].nodeID == engine_rank &&
            s->cells_top[k].h_max > h_max) {
          h_max = s->cells_top[k].h_max;
253
        }
254
255
      }
    } else {
256
      for (size_t k = 0; k < nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
257
        if (s->parts[k].h > h_max) h_max = s->parts[k].h;
258
      }
259
260
261
262
263
264
265
266
267
268
    }
  }

/* If we are running in parallel, make sure everybody agrees on
   how large the largest cell should be. */
#ifdef WITH_MPI
  {
    float buff;
    if (MPI_Allreduce(&h_max, &buff, 1, MPI_FLOAT, MPI_MAX, MPI_COMM_WORLD) !=
        MPI_SUCCESS)
269
      error("Failed to aggregate the rebuild flag across nodes.");
270
271
272
    h_max = buff;
  }
#endif
273
  if (verbose) message("h_max is %.3e (cell_min=%.3e).", h_max, s->cell_min);
274
275

  /* Get the new putative cell dimensions. */
276
  const int cdim[3] = {
277
278
279
280
281
282
      floor(s->dim[0] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[1] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[2] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min))};
283
284
285
286
287

  /* Check if we have enough cells for periodicity. */
  if (s->periodic && (cdim[0] < 3 || cdim[1] < 3 || cdim[2] < 3))
    error(
        "Must have at least 3 cells in each spatial dimension when periodicity "
288
289
290
        "is switched on.\nThis error is often caused by any of the "
        "followings:\n"
        " - too few particles to generate a sensible grid,\n"
291
292
        " - the initial value of 'Scheduler:max_top_level_cells' is too "
        "small,\n"
293
        " - the (minimal) time-step is too large leading to particles with "
294
295
296
        "predicted smoothing lengths too large for the box size,\n"
        " - particle with velocities so large that they move by more than two "
        "box sizes per time-step.\n");
297

298
299
300
301
302
303
  /* Check if we have enough cells for gravity. */
  if (s->gravity && (cdim[0] < 8 || cdim[1] < 8 || cdim[2] < 8))
    error(
        "Must have at least 8 cells in each spatial dimension when gravity "
        "is switched on.");

304
305
306
/* In MPI-Land, changing the top-level cell size requires that the
 * global partition is recomputed and the particles redistributed.
 * Be prepared to do that. */
307
#ifdef WITH_MPI
Matthieu Schaller's avatar
Matthieu Schaller committed
308
  double oldwidth[3];
309
310
311
312
313
314
315
316
  double oldcdim[3];
  int *oldnodeIDs = NULL;
  if (cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] || cdim[2] < s->cdim[2]) {

    /* Capture state of current space. */
    oldcdim[0] = s->cdim[0];
    oldcdim[1] = s->cdim[1];
    oldcdim[2] = s->cdim[2];
317
318
319
    oldwidth[0] = s->width[0];
    oldwidth[1] = s->width[1];
    oldwidth[2] = s->width[2];
320
321
322
323
324
325
326
327
328

    if ((oldnodeIDs = (int *)malloc(sizeof(int) * s->nr_cells)) == NULL)
      error("Failed to allocate temporary nodeIDs.");

    int cid = 0;
    for (int i = 0; i < s->cdim[0]; i++) {
      for (int j = 0; j < s->cdim[1]; j++) {
        for (int k = 0; k < s->cdim[2]; k++) {
          cid = cell_getid(oldcdim, i, j, k);
329
          oldnodeIDs[cid] = s->cells_top[cid].nodeID;
330
331
332
333
334
        }
      }
    }
  }

335
336
337
338
#endif

  /* Do we need to re-build the upper-level cells? */
  // tic = getticks();
339
  if (s->cells_top == NULL || cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] ||
340
341
342
      cdim[2] < s->cdim[2]) {

    /* Free the old cells, if they were allocated. */
343
    if (s->cells_top != NULL) {
344
      for (int k = 0; k < s->nr_cells; k++) {
345
346
        space_rebuild_recycle(s, &s->cells_top[k]);
        if (s->cells_top[k].sort != NULL) free(s->cells_top[k].sort);
347
      }
348
      free(s->cells_top);
349
350
351
352
      s->maxdepth = 0;
    }

    /* Set the new cell dimensions only if smaller. */
353
    for (int k = 0; k < 3; k++) {
354
      s->cdim[k] = cdim[k];
355
356
      s->width[k] = s->dim[k] / cdim[k];
      s->iwidth[k] = 1.0 / s->width[k];
357
    }
358
    const float dmin = min(s->width[0], min(s->width[1], s->width[2]));
359
360
361

    /* Allocate the highest level of cells. */
    s->tot_cells = s->nr_cells = cdim[0] * cdim[1] * cdim[2];
362
    if (posix_memalign((void *)&s->cells_top, cell_align,
363
364
                       s->nr_cells * sizeof(struct cell)) != 0)
      error("Failed to allocate cells.");
365
    bzero(s->cells_top, s->nr_cells * sizeof(struct cell));
366
    for (int k = 0; k < s->nr_cells; k++)
367
368
      if (lock_init(&s->cells_top[k].lock) != 0)
        error("Failed to init spinlock.");
369
370

    /* Set the cell location and sizes. */
371
372
373
    for (int i = 0; i < cdim[0]; i++)
      for (int j = 0; j < cdim[1]; j++)
        for (int k = 0; k < cdim[2]; k++) {
374
          struct cell *restrict c = &s->cells_top[cell_getid(cdim, i, j, k)];
375
376
377
378
379
380
          c->loc[0] = i * s->width[0];
          c->loc[1] = j * s->width[1];
          c->loc[2] = k * s->width[2];
          c->width[0] = s->width[0];
          c->width[1] = s->width[1];
          c->width[2] = s->width[2];
381
382
383
384
385
          c->dmin = dmin;
          c->depth = 0;
          c->count = 0;
          c->gcount = 0;
          c->super = c;
386
          c->ti_old = ti_current;
387
          lock_init(&c->lock);
Pedro Gonnet's avatar
Pedro Gonnet committed
388
        }
389
390

    /* Be verbose about the change. */
391
392
393
    if (verbose)
      message("set cell dimensions to [ %i %i %i ].", cdim[0], cdim[1],
              cdim[2]);
394
395
    fflush(stdout);

396
#ifdef WITH_MPI
397
398
399
400
401
    if (oldnodeIDs != NULL) {
      /* We have changed the top-level cell dimension, so need to redistribute
       * cells around the nodes. We repartition using the old space node
       * positions as a grid to resample. */
      if (s->e->nodeID == 0)
402
403
404
        message(
            "basic cell dimensions have increased - recalculating the "
            "global partition.");
405

Matthieu Schaller's avatar
Matthieu Schaller committed
406
      if (!partition_space_to_space(oldwidth, oldcdim, oldnodeIDs, s)) {
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424

        /* Failed, try another technique that requires no settings. */
        message("Failed to get a new partition, trying less optimal method");
        struct partition initial_partition;
#ifdef HAVE_METIS
        initial_partition.type = INITPART_METIS_NOWEIGHT;
#else
        initial_partition.type = INITPART_VECTORIZE;
#endif
        partition_initial_partition(&initial_partition, s->e->nodeID,
                                    s->e->nr_nodes, s);
      }

      /* Re-distribute the particles to their new nodes. */
      engine_redistribute(s->e);

      /* Make the proxies. */
      engine_makeproxies(s->e);
425

426
427
      /* Finished with these. */
      free(oldnodeIDs);
428
    }
Pedro Gonnet's avatar
Pedro Gonnet committed
429
#endif /* WITH_MPI */
430
431
432
433

    // message( "rebuilding upper-level cells took %.3f %s." ,
    // clocks_from_ticks(double)(getticks() - tic), clocks_getunit());

434
435
  } /* re-build upper-level cells? */

436
  else { /* Otherwise, just clean up the cells. */
437
438

    /* Free the old cells, if they were allocated. */
Pedro Gonnet's avatar
Pedro Gonnet committed
439
440
    threadpool_map(&s->e->threadpool, space_clear_cells_mapper, s->cells_top,
                   s->nr_cells, sizeof(struct cell), 100, s);
441
    // space_clear_cells_mapper(s->cells_top, s->nr_cells, s);
442
443
    s->maxdepth = 0;
  }
444
445
446
447

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
448
}
449
450
451
452
453

/**
 * @brief Re-build the cells as well as the tasks.
 *
 * @param s The #space in which to update the cells.
454
 * @param verbose Print messages to stdout or not
455
456
 *
 */
457
void space_rebuild(struct space *s, int verbose) {
458

Matthieu Schaller's avatar
Matthieu Schaller committed
459
  const ticks tic = getticks();
460
461

  /* Be verbose about this. */
462
  // message("re)building space..."); fflush(stdout);
463
464

  /* Re-grid if necessary, or just re-set the cell data. */
465
  space_regrid(s, verbose);
466

Pedro Gonnet's avatar
Pedro Gonnet committed
467
468
  size_t nr_parts = s->nr_parts;
  size_t nr_gparts = s->nr_gparts;
469
  struct cell *restrict cells_top = s->cells_top;
470
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
471
472

  /* Run through the particles and get their cell index. */
473
  const size_t ind_size = s->size_parts + 100;
474
475
  int *ind;
  if ((ind = (int *)malloc(sizeof(int) * ind_size)) == NULL)
476
    error("Failed to allocate temporary particle indices.");
477
  if (s->size_parts > 0) space_parts_get_cell_index(s, ind, cells_top, verbose);
478

479
  /* Run through the gravity particles and get their cell index. */
480
  const size_t gind_size = s->size_gparts + 100;
481
482
483
  int *gind;
  if ((gind = (int *)malloc(sizeof(int) * gind_size)) == NULL)
    error("Failed to allocate temporary g-particle indices.");
Pedro Gonnet's avatar
Pedro Gonnet committed
484
485
  if (s->size_gparts > 0)
    space_gparts_get_cell_index(s, gind, cells_top, verbose);
486
487

#ifdef WITH_MPI
488

489
  /* Move non-local parts to the end of the list. */
490
  const int local_nodeID = s->e->nodeID;
491
  for (size_t k = 0; k < nr_parts;) {
492
    if (cells_top[ind[k]].nodeID != local_nodeID) {
493
      nr_parts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
494
      const struct part tp = s->parts[k];
495
496
      s->parts[k] = s->parts[nr_parts];
      s->parts[nr_parts] = tp;
497
      if (s->parts[k].gpart != NULL) {
498
        s->parts[k].gpart->id_or_neg_offset = -k;
499
500
      }
      if (s->parts[nr_parts].gpart != NULL) {
501
        s->parts[nr_parts].gpart->id_or_neg_offset = -nr_parts;
502
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
503
      const struct xpart txp = s->xparts[k];
504
505
      s->xparts[k] = s->xparts[nr_parts];
      s->xparts[nr_parts] = txp;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
506
      const int t = ind[k];
507
508
      ind[k] = ind[nr_parts];
      ind[nr_parts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
509
    } else {
510
511
512
513
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
514

515
#ifdef SWIFT_DEBUG_CHECKS
Peter W. Draper's avatar
Peter W. Draper committed
516
  /* Check that all parts are in the correct places. */
517
  for (size_t k = 0; k < nr_parts; k++) {
518
    if (cells_top[ind[k]].nodeID != local_nodeID) {
519
520
521
522
      error("Failed to move all non-local parts to send list");
    }
  }
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
523
    if (cells_top[ind[k]].nodeID == local_nodeID) {
524
      error("Failed to remove local parts from send list");
525
    }
526
527
  }
#endif
528

529
  /* Move non-local gparts to the end of the list. */
530
  for (size_t k = 0; k < nr_gparts;) {
531
    if (cells_top[gind[k]].nodeID != local_nodeID) {
532
      nr_gparts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
533
      const struct gpart tp = s->gparts[k];
534
535
      s->gparts[k] = s->gparts[nr_gparts];
      s->gparts[nr_gparts] = tp;
536
537
      if (s->gparts[k].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
538
      }
539
540
541
      if (s->gparts[nr_gparts].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
542
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
543
544
545
      const int t = gind[k];
      gind[k] = gind[nr_gparts];
      gind[nr_gparts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
546
    } else {
547
548
549
550
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
551

552
#ifdef SWIFT_DEBUG_CHECKS
553
554
  /* Check that all gparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_gparts; k++) {
555
    if (cells_top[gind[k]].nodeID != local_nodeID) {
556
557
558
559
      error("Failed to move all non-local gparts to send list");
    }
  }
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
560
    if (cells_top[gind[k]].nodeID == local_nodeID) {
561
      error("Failed to remove local gparts from send list");
562
    }
563
564
  }
#endif
565

566
567
  /* Exchange the strays, note that this potentially re-allocates
     the parts arrays. */
568
  size_t nr_parts_exchanged = s->nr_parts - nr_parts;
569
  size_t nr_gparts_exchanged = s->nr_gparts - nr_gparts;
Pedro Gonnet's avatar
Pedro Gonnet committed
570
571
572
573
  engine_exchange_strays(s->e, nr_parts, &ind[nr_parts], &nr_parts_exchanged,
                         nr_gparts, &gind[nr_gparts], &nr_gparts_exchanged);

  /* Set the new particle counts. */
574
  s->nr_parts = nr_parts + nr_parts_exchanged;
575
  s->nr_gparts = nr_gparts + nr_gparts_exchanged;
576
577

  /* Re-allocate the index array if needed.. */
578
  if (s->nr_parts + 1 > ind_size) {
579
    int *ind_new;
580
    if ((ind_new = (int *)malloc(sizeof(int) * (s->nr_parts + 1))) == NULL)
581
      error("Failed to allocate temporary particle indices.");
582
    memcpy(ind_new, ind, sizeof(int) * nr_parts);
583
584
    free(ind);
    ind = ind_new;
585
586
  }

587
588
589
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
  const double ih[3] = {s->iwidth[0], s->iwidth[1], s->iwidth[2]};

590
  /* Assign each particle to its cell. */
Pedro Gonnet's avatar
Pedro Gonnet committed
591
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
592
    const struct part *const p = &s->parts[k];
593
    ind[k] =
594
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
595
#ifdef SWIFT_DEBUG_CHECKS
596
    if (cells_top[ind[k]].nodeID != local_nodeID)
597
      error("Received part that does not belong to me (nodeID=%i).",
598
            cells_top[ind[k]].nodeID);
599
#endif
600
  }
601
  nr_parts = s->nr_parts;
602
603

#endif /* WITH_MPI */
604
605

  /* Sort the parts according to their cells. */
606
607
  if (nr_parts > 0)
    space_parts_sort(s, ind, nr_parts, 0, s->nr_cells - 1, verbose);
608
609

  /* Re-link the gparts. */
610
  if (nr_parts > 0 && nr_gparts > 0) part_relink_gparts(s->parts, nr_parts, 0);
611

612
#ifdef SWIFT_DEBUG_CHECKS
613
  /* Verify space_sort_struct. */
614
615
616
  for (size_t k = 1; k < nr_parts; k++) {
    if (ind[k - 1] > ind[k]) {
      error("Sort failed!");
617
    } else if (ind[k] != cell_getid(s->cdim, s->parts[k].x[0] * s->iwidth[0],
618
619
                                    s->parts[k].x[1] * s->iwidth[1],
                                    s->parts[k].x[2] * s->iwidth[2])) {
620
621
622
623
      error("Incorrect indices!");
    }
  }
#endif
624

625
626
627
628
629
630
631
632
633
634
  /* Extract the cell counts from the sorted indices. */
  size_t last_index = 0;
  ind[nr_parts] = s->nr_cells;  // sentinel.
  for (size_t k = 0; k < nr_parts; k++) {
    if (ind[k] < ind[k + 1]) {
      cells_top[ind[k]].count = k - last_index + 1;
      last_index = k + 1;
    }
  }

635
  /* We no longer need the indices as of here. */
636
  free(ind);
637

638
639
640
#ifdef WITH_MPI

  /* Re-allocate the index array if needed.. */
641
  if (s->nr_gparts + 1 > gind_size) {
642
    int *gind_new;
643
    if ((gind_new = (int *)malloc(sizeof(int) * (s->nr_gparts + 1))) == NULL)
644
      error("Failed to allocate temporary g-particle indices.");
645
    memcpy(gind_new, gind, sizeof(int) * nr_gparts);
646
647
648
649
650
    free(gind);
    gind = gind_new;
  }

  /* Assign each particle to its cell. */
651
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
652
    const struct gpart *const p = &s->gparts[k];
653
654
    gind[k] =
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
655
656
657
658
659
660

#ifdef SWIFT_DEBUG_CHECKS
    if (cells_top[ind[k]].nodeID != s->e->nodeID)
      error("Received part that does not belong to me (nodeID=%i).",
            cells_top[ind[k]].nodeID);
#endif
661
662
663
664
  }
  nr_gparts = s->nr_gparts;

#endif
665

666
  /* Sort the gparts according to their cells. */
667
668
  if (nr_gparts > 0)
    space_gparts_sort(s, gind, nr_gparts, 0, s->nr_cells - 1, verbose);
669
670

  /* Re-link the parts. */
671
672
  if (nr_parts > 0 && nr_gparts > 0)
    part_relink_parts(s->gparts, nr_gparts, s->parts);
673

674
675
676
677
678
679
680
681
682
683
  /* Extract the cell counts from the sorted indices. */
  size_t last_gindex = 0;
  gind[nr_parts] = s->nr_cells;
  for (size_t k = 0; k < nr_gparts; k++) {
    if (gind[k] < gind[k + 1]) {
      cells_top[ind[k]].gcount = k - last_gindex + 1;
      last_gindex = k + 1;
    }
  }

684
  /* We no longer need the indices as of here. */
685
  free(gind);
686

687
#ifdef SWIFT_DEBUG_CHECKS
688
689
690
  /* Verify that the links are correct */
  for (size_t k = 0; k < nr_gparts; ++k) {

691
    if (s->gparts[k].id_or_neg_offset < 0) {
692

693
      const struct part *part = &s->parts[-s->gparts[k].id_or_neg_offset];
694

695
696
697
698
      if (part->gpart != &s->gparts[k]) error("Linking problem !");

      if (s->gparts[k].x[0] != part->x[0] || s->gparts[k].x[1] != part->x[1] ||
          s->gparts[k].x[2] != part->x[2])
699
700
701
702
703
        error("Linked particles are not at the same position !");
    }
  }
  for (size_t k = 0; k < nr_parts; ++k) {

704
    if (s->parts[k].gpart != NULL &&
705
        s->parts[k].gpart->id_or_neg_offset != -(ptrdiff_t)k) {
706
      error("Linking problem !");
707
708
    }
  }
709
#endif
710

711
712
  /* Hook the cells up to the parts. */
  // tic = getticks();
713
714
715
  struct part *finger = s->parts;
  struct xpart *xfinger = s->xparts;
  struct gpart *gfinger = s->gparts;
716
  for (int k = 0; k < s->nr_cells; k++) {
717
    struct cell *restrict c = &cells_top[k];
718
    c->ti_old = ti_current;
719
720
721
722
723
724
725
    c->parts = finger;
    c->xparts = xfinger;
    c->gparts = gfinger;
    finger = &finger[c->count];
    xfinger = &xfinger[c->count];
    gfinger = &gfinger[c->gcount];
  }
726
  // message( "hooking up cells took %.3f %s." ,
Matthieu Schaller's avatar
Matthieu Schaller committed
727
  // clocks_from_ticks(getticks() - tic), clocks_getunit());
728
729
730

  /* At this point, we have the upper-level cells, old or new. Now make
     sure that the parts in each cell are ok. */
731
  space_split(s, cells_top, s->nr_cells, verbose);
732
733
734
735
736
737
738
739
740

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Split particles between cells of a hierarchy
 *
741
742
 * This is done in parallel using threads in the #threadpool.
 *
743
 * @param s The #space.
744
745
 * @param cells The cell hierarchy.
 * @param nr_cells The number of cells.
746
747
 * @param verbose Are we talkative ?
 */
748
749
void space_split(struct space *s, struct cell *cells, int nr_cells,
                 int verbose) {
750

Matthieu Schaller's avatar
Matthieu Schaller committed
751
  const ticks tic = getticks();
752

753
  threadpool_map(&s->e->threadpool, space_split_mapper, cells, nr_cells,
754
                 sizeof(struct cell), 1, s);
755

756
757
758
  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
759
}
760

761
762
763
764
765
766
767
768
/**
 * @brief Runs through the top-level cells and checks whether tasks associated
 * with them can be split. If not, try to sanitize the cells.
 *
 * @param s The #space to act upon.
 */
void space_sanitize(struct space *s) {

769
770
  s->sanitized = 1;

771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
  for (int k = 0; k < s->nr_cells; k++) {

    struct cell *c = &s->cells_top[k];
    const double min_width = c->dmin;

    /* Do we have a problem ? */
    if (c->h_max * kernel_gamma * space_stretch > min_width * 0.5 &&
        c->count > space_maxcount) {

      /* Ok, clean-up the mess */
      cell_sanitize(c);
    }
  }
}

786
/**
787
 * @brief #threadpool mapper function to compute the particle cell indices.
788
 *
789
 * @param map_data Pointer towards the particles.
790
 * @param nr_parts The number of particles to treat.
791
 * @param extra_data Pointers to the space and index list
792
 */
793
794
void space_parts_get_cell_index_mapper(void *map_data, int nr_parts,
                                       void *extra_data) {
795

796
797
798
799
  /* Unpack the data */
  struct part *restrict parts = (struct part *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
800
  int *const ind = data->ind + (ptrdiff_t)(parts - s->parts);
801
802

  /* Get some constants */
803
804
805
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
Matthieu Schaller's avatar
Matthieu Schaller committed
806
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
807
808
809
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
810

811
  for (int k = 0; k < nr_parts; k++) {
812
813
814
815

    /* Get the particle */
    struct part *restrict p = &parts[k];

816
817
818
819
    const double old_pos_x = p->x[0];
    const double old_pos_y = p->x[1];
    const double old_pos_z = p->x[2];

820
    /* Put it back into the simulation volume */
821
822
823
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
824
825

    /* Get its cell index */
Matthieu Schaller's avatar
Matthieu Schaller committed
826
827
    const int index =
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
828
    ind[k] = index;
829

830
831
832
833
    /* Update the position */
    p->x[0] = pos_x;
    p->x[1] = pos_y;
    p->x[2] = pos_z;
834
835
836
837
  }
}

/**
838
 * @brief #threadpool mapper function to compute the g-particle cell indices.
839
 *
840
 * @param map_data Pointer towards the g-particles.
841
 * @param nr_gparts The number of g-particles to treat.
842
 * @param extra_data Pointers to the space and index list
843
 */
844
845
void space_gparts_get_cell_index_mapper(void *map_data, int nr_gparts,
                                        void *extra_data) {
846

847
848
849
850
  /* Unpack the data */
  struct gpart *restrict gparts = (struct gpart *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
851
  int *const ind = data->ind + (ptrdiff_t)(gparts - s->gparts);
852
853

  /* Get some constants */
Matthieu Schaller's avatar
Matthieu Schaller committed
854
855
856
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
857
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
Matthieu Schaller's avatar
Matthieu Schaller committed
858
859
860
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
861

862
  for (int k = 0; k < nr_gparts; k++) {
863
864
865
866

    /* Get the particle */
    struct gpart *restrict gp = &gparts[k];

Matthieu Schaller's avatar
Matthieu Schaller committed
867
868
869
870
    const double old_pos_x = gp->x[0];
    const double old_pos_y = gp->x[1];
    const double old_pos_z = gp->x[2];

871
    /* Put it back into the simulation volume */
Matthieu Schaller's avatar
Matthieu Schaller committed
872
873
874
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
875
876
877

    /* Get its cell index */
    const int index =
Matthieu Schaller's avatar
Matthieu Schaller committed
878
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
879
    ind[k] = index;
Matthieu Schaller's avatar
Matthieu Schaller committed
880
881
882
883
884

    /* Update the position */
    gp->x[0] = pos_x;
    gp->x[1] = pos_y;
    gp->x[2] = pos_z;
885
886
887
  }
}

888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
/**
 * @brief Computes the cell index of all the particles and update the cell
 * count.
 *
 * @param s The #space.
 * @param ind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_parts_get_cell_index(struct space *s, int *ind, struct cell *cells,
                                int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = ind;

  threadpool_map(&s->e->threadpool, space_parts_get_cell_index_mapper, s->parts,
                 s->nr_parts, sizeof(struct part), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Computes the cell index of all the g-particles and update the cell
 * gcount.
 *
 * @param s The #space.
 * @param gind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_gparts_get_cell_index(struct space *s, int *gind, struct cell *cells,
                                 int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = gind;

  threadpool_map(&s->e->threadpool, space_gparts_get_cell_index_mapper,
                 s->gparts, s->nr_gparts, sizeof(struct gpart), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

944
/**
945
 * @brief Sort the particles and condensed particles according to the given
946
 * indices.
947
 *
Matthieu Schaller's avatar
Matthieu Schaller committed
948
 * @param s The #space.
949
950
951
952
 * @param ind The indices with respect to which the parts are sorted.
 * @param N The number of parts
 * @param min Lowest index.
 * @param max highest index.
953
 * @param verbose Are we talkative ?
954
 */
955
void space_parts_sort(struct space *s, int *ind, size_t N, int min, int max,
956
957
                      int verbose) {

Matthieu Schaller's avatar
Matthieu Schaller committed
958
  const ticks tic = getticks();
959

960
961
962
963
964
965
  /* Populate a parallel_sort structure with the input data */
  struct parallel_sort sort_struct;
  sort_struct.parts = s->parts;
  sort_struct.xparts = s->xparts;
  sort_struct.ind = ind;
  sort_struct.stack_size = 2 * (max - min + 1) + 10 + s->e->nr_threads;
966
967
  if ((sort_struct.stack =
           malloc(sizeof(struct qstack) * sort_struct.stack_size)) == NULL)
968
    error("Failed to allocate sorting stack.");
Matthieu Schaller's avatar
Matthieu Schaller committed
969
  for (unsigned int i = 0; i < sort_struct.stack_size; i++)
970
    sort_struct.stack[i].ready = 0;
971

972
  /* Add the first interval. */
973
974
975
976
977
978
979
980
981
982
983
  sort_struct.stack[0].i = 0;
  sort_struct.stack[0].j = N - 1;
  sort_struct.stack[0].min = min;
  sort_struct.stack[0].max = max;
  sort_struct.stack[0].ready = 1;
  sort_struct.first = 0;
  sort_struct.last = 1;
  sort_struct.waiting = 1;

  /* Launch the sorting tasks with a stride of zero such that the same
     map data is passed to each thread. */
984
985
  threadpool_map(&s->e->threadpool, space_parts_sort_mapper, &sort_struct,
                 s->e->threadpool.num_threads, 0, 1, NULL);