space.c 107 KB
Newer Older
1
/*******************************************************************************
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 * This file is part of SWIFT.
 * Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
 *                    Matthieu Schaller (matthieu.schaller@durham.ac.uk)
 *               2015 Peter W. Draper (p.w.draper@durham.ac.uk)
 *               2016 John A. Regan (john.a.regan@durham.ac.uk)
 *                    Tom Theuns (tom.theuns@durham.ac.uk)
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 ******************************************************************************/
Pedro Gonnet's avatar
Pedro Gonnet committed
23
24
25
26
27
28
29
30

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <math.h>
31
#include <stdlib.h>
32
#include <string.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
33

34
35
/* MPI headers. */
#ifdef WITH_MPI
36
#include <mpi.h>
37
38
#endif

39
40
41
/* This object's header. */
#include "space.h"

Pedro Gonnet's avatar
Pedro Gonnet committed
42
/* Local headers. */
43
#include "atomic.h"
44
#include "const.h"
45
#include "cooling.h"
46
#include "engine.h"
47
#include "error.h"
48
49
#include "gravity.h"
#include "hydro.h"
50
#include "kernel_hydro.h"
51
#include "lock.h"
52
#include "memswap.h"
53
#include "minmax.h"
54
#include "multipole.h"
55
#include "restart.h"
56
#include "runner.h"
57
#include "sort_part.h"
58
#include "stars.h"
59
#include "threadpool.h"
60
#include "tools.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
61
62
63

/* Split size. */
int space_splitsize = space_splitsize_default;
64
65
66
int space_subsize_pair_hydro = space_subsize_pair_hydro_default;
int space_subsize_self_hydro = space_subsize_self_hydro_default;
int space_subsize_pair_grav = space_subsize_pair_grav_default;
67
int space_subsize_self_grav = space_subsize_self_grav_default;
68
int space_maxsize = space_maxsize_default;
69
70
71
#ifdef SWIFT_DEBUG_CHECKS
int last_cell_id;
#endif
Pedro Gonnet's avatar
Pedro Gonnet committed
72

73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
/**
 * @brief Interval stack necessary for parallel particle sorting.
 */
struct qstack {
  volatile ptrdiff_t i, j;
  volatile int min, max;
  volatile int ready;
};

/**
 * @brief Parallel particle-sorting stack
 */
struct parallel_sort {
  struct part *parts;
  struct gpart *gparts;
  struct xpart *xparts;
89
  struct spart *sparts;
90
91
92
93
94
95
  int *ind;
  struct qstack *stack;
  unsigned int stack_size;
  volatile unsigned int first, last, waiting;
};

96
97
98
99
100
101
102
103
104
/**
 * @brief Information required to compute the particle cell indices.
 */
struct index_data {
  struct space *s;
  struct cell *cells;
  int *ind;
};

105
106
107
108
109
110
111
112
113
114
115
/**
 * @brief Get the shift-id of the given pair of cells, swapping them
 *      if need be.
 *
 * @param s The space
 * @param ci Pointer to first #cell.
 * @param cj Pointer second #cell.
 * @param shift Vector from ci to cj.
 *
 * @return The shift ID and set shift, may or may not swap ci and cj.
 */
116
117
118
119
int space_getsid(struct space *s, struct cell **ci, struct cell **cj,
                 double *shift) {

  /* Get the relative distance between the pairs, wrapping. */
120
121
122
  const int periodic = s->periodic;
  double dx[3];
  for (int k = 0; k < 3; k++) {
123
124
125
126
127
128
129
130
131
132
133
    dx[k] = (*cj)->loc[k] - (*ci)->loc[k];
    if (periodic && dx[k] < -s->dim[k] / 2)
      shift[k] = s->dim[k];
    else if (periodic && dx[k] > s->dim[k] / 2)
      shift[k] = -s->dim[k];
    else
      shift[k] = 0.0;
    dx[k] += shift[k];
  }

  /* Get the sorting index. */
134
  int sid = 0;
135
  for (int k = 0; k < 3; k++)
136
137
138
139
    sid = 3 * sid + ((dx[k] < 0.0) ? 0 : ((dx[k] > 0.0) ? 2 : 1));

  /* Switch the cells around? */
  if (runner_flip[sid]) {
140
    struct cell *temp = *ci;
141
142
    *ci = *cj;
    *cj = temp;
143
    for (int k = 0; k < 3; k++) shift[k] = -shift[k];
144
145
146
147
148
149
  }
  sid = sortlistID[sid];

  /* Return the sort ID. */
  return sid;
}
150

151
/**
152
 * @brief Recursively dismantle a cell tree.
153
 *
154
155
 * @param s The #space.
 * @param c The #cell to recycle.
Matthieu Schaller's avatar
Matthieu Schaller committed
156
157
158
159
160
161
 * @param cell_rec_begin Pointer to the start of the list of cells to recycle.
 * @param cell_rec_end Pointer to the end of the list of cells to recycle.
 * @param multipole_rec_begin Pointer to the start of the list of multipoles to
 * recycle.
 * @param multipole_rec_end Pointer to the end of the list of multipoles to
 * recycle.
162
 */
163
void space_rebuild_recycle_rec(struct space *s, struct cell *c,
164
165
                               struct cell **cell_rec_begin,
                               struct cell **cell_rec_end,
166
167
                               struct gravity_tensors **multipole_rec_begin,
                               struct gravity_tensors **multipole_rec_end) {
168
  if (c->split)
169
    for (int k = 0; k < 8; k++)
170
      if (c->progeny[k] != NULL) {
171
172
173
174
175
176
        space_rebuild_recycle_rec(s, c->progeny[k], cell_rec_begin,
                                  cell_rec_end, multipole_rec_begin,
                                  multipole_rec_end);

        c->progeny[k]->next = *cell_rec_begin;
        *cell_rec_begin = c->progeny[k];
177
178
179
180
181

        if (s->gravity) {
          c->progeny[k]->multipole->next = *multipole_rec_begin;
          *multipole_rec_begin = c->progeny[k]->multipole;
        }
182
183

        if (*cell_rec_end == NULL) *cell_rec_end = *cell_rec_begin;
184
        if (s->gravity && *multipole_rec_end == NULL)
185
186
187
          *multipole_rec_end = *multipole_rec_begin;

        c->progeny[k]->multipole = NULL;
188
189
190
191
        c->progeny[k] = NULL;
      }
}

192
193
194
195
196
197
198
199
void space_rebuild_recycle_mapper(void *map_data, int num_elements,
                                  void *extra_data) {

  struct space *s = (struct space *)extra_data;
  struct cell *cells = (struct cell *)map_data;

  for (int k = 0; k < num_elements; k++) {
    struct cell *c = &cells[k];
200
    struct cell *cell_rec_begin = NULL, *cell_rec_end = NULL;
201
202
    struct gravity_tensors *multipole_rec_begin = NULL,
                           *multipole_rec_end = NULL;
203
204
205
206
207
    space_rebuild_recycle_rec(s, c, &cell_rec_begin, &cell_rec_end,
                              &multipole_rec_begin, &multipole_rec_end);
    if (cell_rec_begin != NULL)
      space_recycle_list(s, cell_rec_begin, cell_rec_end, multipole_rec_begin,
                         multipole_rec_end);
208
209
210
211
212
213
    c->sorts = NULL;
    c->nr_tasks = 0;
    c->density = NULL;
    c->gradient = NULL;
    c->force = NULL;
    c->grav = NULL;
214
215
    c->dx_max_part = 0.0f;
    c->dx_max_gpart = 0.0f;
216
    c->dx_max_sort = 0.0f;
217
218
219
    c->sorted = 0;
    c->count = 0;
    c->gcount = 0;
220
    c->scount = 0;
221
    c->init_grav = NULL;
222
    c->extra_ghost = NULL;
223
224
    c->ghost_in = NULL;
    c->ghost_out = NULL;
225
    c->ghost = NULL;
226
227
    c->kick1 = NULL;
    c->kick2 = NULL;
228
    c->timestep = NULL;
229
    c->end_force = NULL;
230
231
    c->drift_part = NULL;
    c->drift_gpart = NULL;
232
233
    c->cooling = NULL;
    c->sourceterms = NULL;
234
235
    c->grav_ghost_in = NULL;
    c->grav_ghost_out = NULL;
236
237
    c->grav_long_range = NULL;
    c->grav_down = NULL;
238
    c->super = c;
239
240
    c->super_hydro = c;
    c->super_gravity = c;
241
242
243
244
    c->parts = NULL;
    c->xparts = NULL;
    c->gparts = NULL;
    c->sparts = NULL;
Matthieu Schaller's avatar
Matthieu Schaller committed
245
    if (s->gravity) bzero(c->multipole, sizeof(struct gravity_tensors));
246
247
248
249
250
    for (int i = 0; i < 13; i++)
      if (c->sort[i] != NULL) {
        free(c->sort[i]);
        c->sort[i] = NULL;
      }
251
252
253
254
#if WITH_MPI
    c->recv_xv = NULL;
    c->recv_rho = NULL;
    c->recv_gradient = NULL;
255
    c->recv_grav = NULL;
256
257
258
259
260
    c->recv_ti = NULL;

    c->send_xv = NULL;
    c->send_rho = NULL;
    c->send_gradient = NULL;
261
    c->send_grav = NULL;
262
263
264
265
266
    c->send_ti = NULL;
#endif
  }
}

267
268
269
270
/**
 * @brief Free up any allocated cells.
 */
void space_free_cells(struct space *s) {
Matthieu Schaller's avatar
Matthieu Schaller committed
271
272
  threadpool_map(&s->e->threadpool, space_rebuild_recycle_mapper, s->cells_top,
                 s->nr_cells, sizeof(struct cell), 0, s);
273
274
275
  s->maxdepth = 0;
}

276
/**
277
 * @brief Re-build the top-level cell grid.
278
 *
279
 * @param s The #space.
280
 * @param verbose Print messages to stdout or not.
281
 */
282
void space_regrid(struct space *s, int verbose) {
283

284
  const size_t nr_parts = s->nr_parts;
285
  const ticks tic = getticks();
286
  const integertime_t ti_old = (s->e != NULL) ? s->e->ti_old : 0;
287

288
  /* Run through the cells and get the current h_max. */
289
  // tic = getticks();
290
  float h_max = s->cell_min / kernel_gamma / space_stretch;
291
  if (nr_parts > 0) {
292
    if (s->cells_top != NULL) {
Tom Theuns's avatar
Tom Theuns committed
293
      for (int k = 0; k < s->nr_cells; k++) {
294
295
296
        if (s->cells_top[k].nodeID == engine_rank &&
            s->cells_top[k].h_max > h_max) {
          h_max = s->cells_top[k].h_max;
297
        }
298
299
      }
    } else {
300
      for (size_t k = 0; k < nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
301
        if (s->parts[k].h > h_max) h_max = s->parts[k].h;
302
      }
303
304
305
306
307
308
309
310
311
312
    }
  }

/* If we are running in parallel, make sure everybody agrees on
   how large the largest cell should be. */
#ifdef WITH_MPI
  {
    float buff;
    if (MPI_Allreduce(&h_max, &buff, 1, MPI_FLOAT, MPI_MAX, MPI_COMM_WORLD) !=
        MPI_SUCCESS)
313
      error("Failed to aggregate the rebuild flag across nodes.");
314
315
316
    h_max = buff;
  }
#endif
317
  if (verbose) message("h_max is %.3e (cell_min=%.3e).", h_max, s->cell_min);
318
319

  /* Get the new putative cell dimensions. */
320
  const int cdim[3] = {
321
322
323
324
325
326
      floor(s->dim[0] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[1] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[2] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min))};
327
328
329
330
331

  /* Check if we have enough cells for periodicity. */
  if (s->periodic && (cdim[0] < 3 || cdim[1] < 3 || cdim[2] < 3))
    error(
        "Must have at least 3 cells in each spatial dimension when periodicity "
332
333
334
        "is switched on.\nThis error is often caused by any of the "
        "followings:\n"
        " - too few particles to generate a sensible grid,\n"
335
336
        " - the initial value of 'Scheduler:max_top_level_cells' is too "
        "small,\n"
337
        " - the (minimal) time-step is too large leading to particles with "
338
        "predicted smoothing lengths too large for the box size,\n"
339
        " - particles with velocities so large that they move by more than two "
340
        "box sizes per time-step.\n");
341

342
  /* Check if we have enough cells for periodic gravity. */
343
  if (s->gravity && s->periodic && (cdim[0] < 8 || cdim[1] < 8 || cdim[2] < 8))
344
    error(
345
346
        "Must have at least 8 cells in each spatial dimension when periodic "
        "gravity is switched on.\nThis error is often caused by any of the "
347
348
349
350
351
352
        "followings:\n"
        " - too few particles to generate a sensible grid,\n"
        " - the initial value of 'Scheduler:max_top_level_cells' is too "
        "small,\n"
        " - the (minimal) time-step is too large leading to particles with "
        "predicted smoothing lengths too large for the box size,\n"
353
        " - particles with velocities so large that they move by more than two "
354
        "box sizes per time-step.\n");
355

356
357
358
/* In MPI-Land, changing the top-level cell size requires that the
 * global partition is recomputed and the particles redistributed.
 * Be prepared to do that. */
359
#ifdef WITH_MPI
Matthieu Schaller's avatar
Matthieu Schaller committed
360
  double oldwidth[3];
361
362
363
364
365
366
367
368
  double oldcdim[3];
  int *oldnodeIDs = NULL;
  if (cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] || cdim[2] < s->cdim[2]) {

    /* Capture state of current space. */
    oldcdim[0] = s->cdim[0];
    oldcdim[1] = s->cdim[1];
    oldcdim[2] = s->cdim[2];
369
370
371
    oldwidth[0] = s->width[0];
    oldwidth[1] = s->width[1];
    oldwidth[2] = s->width[2];
372
373
374
375
376
377
378
379
380

    if ((oldnodeIDs = (int *)malloc(sizeof(int) * s->nr_cells)) == NULL)
      error("Failed to allocate temporary nodeIDs.");

    int cid = 0;
    for (int i = 0; i < s->cdim[0]; i++) {
      for (int j = 0; j < s->cdim[1]; j++) {
        for (int k = 0; k < s->cdim[2]; k++) {
          cid = cell_getid(oldcdim, i, j, k);
381
          oldnodeIDs[cid] = s->cells_top[cid].nodeID;
382
383
384
385
386
        }
      }
    }
  }

387
388
389
390
#endif

  /* Do we need to re-build the upper-level cells? */
  // tic = getticks();
391
  if (s->cells_top == NULL || cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] ||
392
393
      cdim[2] < s->cdim[2]) {

394
395
/* Be verbose about this. */
#ifdef SWIFT_DEBUG_CHECKS
396
    message("(re)griding space cdim=(%d %d %d)", cdim[0], cdim[1], cdim[2]);
397
398
399
    fflush(stdout);
#endif

400
    /* Free the old cells, if they were allocated. */
401
    if (s->cells_top != NULL) {
402
      space_free_cells(s);
403
      free(s->local_cells_top);
404
      free(s->cells_top);
405
      free(s->multipoles_top);
406
407
    }

408
409
410
411
    /* Also free the task arrays, these will be regenerated and we can use the
     * memory while copying the particle arrays. */
    if (s->e != NULL) scheduler_free_tasks(&s->e->sched);

412
    /* Set the new cell dimensions only if smaller. */
413
    for (int k = 0; k < 3; k++) {
414
      s->cdim[k] = cdim[k];
415
416
      s->width[k] = s->dim[k] / cdim[k];
      s->iwidth[k] = 1.0 / s->width[k];
417
    }
418
    const float dmin = min3(s->width[0], s->width[1], s->width[2]);
419
420
421

    /* Allocate the highest level of cells. */
    s->tot_cells = s->nr_cells = cdim[0] * cdim[1] * cdim[2];
422
    if (posix_memalign((void *)&s->cells_top, cell_align,
423
                       s->nr_cells * sizeof(struct cell)) != 0)
424
      error("Failed to allocate top-level cells.");
425
    bzero(s->cells_top, s->nr_cells * sizeof(struct cell));
426

427
428
429
    /* Allocate the multipoles for the top-level cells. */
    if (s->gravity) {
      if (posix_memalign((void *)&s->multipoles_top, multipole_align,
430
                         s->nr_cells * sizeof(struct gravity_tensors)) != 0)
431
        error("Failed to allocate top-level multipoles.");
432
      bzero(s->multipoles_top, s->nr_cells * sizeof(struct gravity_tensors));
433
434
    }

435
436
437
438
439
440
    /* Allocate the indices of local cells */
    if (posix_memalign((void *)&s->local_cells_top, SWIFT_STRUCT_ALIGNMENT,
                       s->nr_cells * sizeof(int)) != 0)
      error("Failed to allocate indices of local top-level cells.");
    bzero(s->local_cells_top, s->nr_cells * sizeof(int));

441
    /* Set the cells' locks */
442
    for (int k = 0; k < s->nr_cells; k++) {
443
      if (lock_init(&s->cells_top[k].lock) != 0)
444
445
446
447
448
449
450
451
        error("Failed to init spinlock for hydro.");
      if (lock_init(&s->cells_top[k].glock) != 0)
        error("Failed to init spinlock for gravity.");
      if (lock_init(&s->cells_top[k].mlock) != 0)
        error("Failed to init spinlock for multipoles.");
      if (lock_init(&s->cells_top[k].slock) != 0)
        error("Failed to init spinlock for stars.");
    }
452
453

    /* Set the cell location and sizes. */
454
455
456
    for (int i = 0; i < cdim[0]; i++)
      for (int j = 0; j < cdim[1]; j++)
        for (int k = 0; k < cdim[2]; k++) {
457
458
          const size_t cid = cell_getid(cdim, i, j, k);
          struct cell *restrict c = &s->cells_top[cid];
459
460
461
462
463
464
          c->loc[0] = i * s->width[0];
          c->loc[1] = j * s->width[1];
          c->loc[2] = k * s->width[2];
          c->width[0] = s->width[0];
          c->width[1] = s->width[1];
          c->width[2] = s->width[2];
465
466
467
468
          c->dmin = dmin;
          c->depth = 0;
          c->count = 0;
          c->gcount = 0;
469
          c->scount = 0;
470
          c->super = c;
471
472
          c->super_hydro = c;
          c->super_gravity = c;
473
474
          c->ti_old_part = ti_old;
          c->ti_old_gpart = ti_old;
475
          c->ti_old_multipole = ti_old;
Matthieu Schaller's avatar
Matthieu Schaller committed
476
          if (s->gravity) c->multipole = &s->multipoles_top[cid];
Pedro Gonnet's avatar
Pedro Gonnet committed
477
        }
478
479

    /* Be verbose about the change. */
480
481
482
    if (verbose)
      message("set cell dimensions to [ %i %i %i ].", cdim[0], cdim[1],
              cdim[2]);
483

484
#ifdef WITH_MPI
485
486
487
488
489
    if (oldnodeIDs != NULL) {
      /* We have changed the top-level cell dimension, so need to redistribute
       * cells around the nodes. We repartition using the old space node
       * positions as a grid to resample. */
      if (s->e->nodeID == 0)
490
491
492
        message(
            "basic cell dimensions have increased - recalculating the "
            "global partition.");
493

Matthieu Schaller's avatar
Matthieu Schaller committed
494
      if (!partition_space_to_space(oldwidth, oldcdim, oldnodeIDs, s)) {
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512

        /* Failed, try another technique that requires no settings. */
        message("Failed to get a new partition, trying less optimal method");
        struct partition initial_partition;
#ifdef HAVE_METIS
        initial_partition.type = INITPART_METIS_NOWEIGHT;
#else
        initial_partition.type = INITPART_VECTORIZE;
#endif
        partition_initial_partition(&initial_partition, s->e->nodeID,
                                    s->e->nr_nodes, s);
      }

      /* Re-distribute the particles to their new nodes. */
      engine_redistribute(s->e);

      /* Make the proxies. */
      engine_makeproxies(s->e);
513

514
515
      /* Finished with these. */
      free(oldnodeIDs);
516
    }
Pedro Gonnet's avatar
Pedro Gonnet committed
517
#endif /* WITH_MPI */
518
519
520
521

    // message( "rebuilding upper-level cells took %.3f %s." ,
    // clocks_from_ticks(double)(getticks() - tic), clocks_getunit());

522
  }      /* re-build upper-level cells? */
523
  else { /* Otherwise, just clean up the cells. */
524
525

    /* Free the old cells, if they were allocated. */
526
    space_free_cells(s);
527
  }
528
529
530
531

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
532
}
533
534
535
536
537

/**
 * @brief Re-build the cells as well as the tasks.
 *
 * @param s The #space in which to update the cells.
538
 * @param verbose Print messages to stdout or not
539
540
 *
 */
541
void space_rebuild(struct space *s, int verbose) {
542

Matthieu Schaller's avatar
Matthieu Schaller committed
543
  const ticks tic = getticks();
544

545
546
/* Be verbose about this. */
#ifdef SWIFT_DEBUG_CHECKS
Pedro Gonnet's avatar
Pedro Gonnet committed
547
  if (s->e->nodeID == 0 || verbose) message("(re)building space");
548
549
  fflush(stdout);
#endif
550
551

  /* Re-grid if necessary, or just re-set the cell data. */
552
  space_regrid(s, verbose);
553

Pedro Gonnet's avatar
Pedro Gonnet committed
554
555
  size_t nr_parts = s->nr_parts;
  size_t nr_gparts = s->nr_gparts;
556
  size_t nr_sparts = s->nr_sparts;
557
  struct cell *restrict cells_top = s->cells_top;
558
  const integertime_t ti_old = (s->e != NULL) ? s->e->ti_old : 0;
559

Pedro Gonnet's avatar
Pedro Gonnet committed
560
561
562
  /* Run through the particles and get their cell index. Allocates
     an index that is larger than the number of particles to avoid
     re-allocating after shuffling. */
563
  const size_t ind_size = s->size_parts + 100;
564
565
  int *ind;
  if ((ind = (int *)malloc(sizeof(int) * ind_size)) == NULL)
566
    error("Failed to allocate temporary particle indices.");
567
  if (s->size_parts > 0) space_parts_get_cell_index(s, ind, cells_top, verbose);
568

569
  /* Run through the gravity particles and get their cell index. */
570
  const size_t gind_size = s->size_gparts + 100;
571
572
573
  int *gind;
  if ((gind = (int *)malloc(sizeof(int) * gind_size)) == NULL)
    error("Failed to allocate temporary g-particle indices.");
Pedro Gonnet's avatar
Pedro Gonnet committed
574
575
  if (s->size_gparts > 0)
    space_gparts_get_cell_index(s, gind, cells_top, verbose);
576

577
578
579
580
581
582
583
584
  /* Run through the star particles and get their cell index. */
  const size_t sind_size = s->size_sparts + 100;
  int *sind;
  if ((sind = (int *)malloc(sizeof(int) * sind_size)) == NULL)
    error("Failed to allocate temporary s-particle indices.");
  if (s->size_sparts > 0)
    space_sparts_get_cell_index(s, sind, cells_top, verbose);

585
#ifdef WITH_MPI
586
  const int local_nodeID = s->e->nodeID;
587

588
  /* Move non-local parts to the end of the list. */
589
  for (size_t k = 0; k < nr_parts;) {
590
    if (cells_top[ind[k]].nodeID != local_nodeID) {
591
      nr_parts -= 1;
592
      /* Swap the particle */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
593
      const struct part tp = s->parts[k];
594
595
      s->parts[k] = s->parts[nr_parts];
      s->parts[nr_parts] = tp;
596
      /* Swap the link with the gpart */
597
      if (s->parts[k].gpart != NULL) {
598
        s->parts[k].gpart->id_or_neg_offset = -k;
599
600
      }
      if (s->parts[nr_parts].gpart != NULL) {
601
        s->parts[nr_parts].gpart->id_or_neg_offset = -nr_parts;
602
      }
603
      /* Swap the xpart */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
604
      const struct xpart txp = s->xparts[k];
605
606
      s->xparts[k] = s->xparts[nr_parts];
      s->xparts[nr_parts] = txp;
607
      /* Swap the index */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
608
      const int t = ind[k];
609
610
      ind[k] = ind[nr_parts];
      ind[nr_parts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
611
    } else {
612
613
614
615
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
616

617
#ifdef SWIFT_DEBUG_CHECKS
Peter W. Draper's avatar
Peter W. Draper committed
618
  /* Check that all parts are in the correct places. */
619
  for (size_t k = 0; k < nr_parts; k++) {
620
    if (cells_top[ind[k]].nodeID != local_nodeID) {
621
622
623
624
      error("Failed to move all non-local parts to send list");
    }
  }
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
625
    if (cells_top[ind[k]].nodeID == local_nodeID) {
626
      error("Failed to remove local parts from send list");
627
    }
628
629
  }
#endif
630

631
632
633
634
635
636
637
638
639
640
641
642
  /* Move non-local sparts to the end of the list. */
  for (size_t k = 0; k < nr_sparts;) {
    if (cells_top[sind[k]].nodeID != local_nodeID) {
      nr_sparts -= 1;
      /* Swap the particle */
      const struct spart tp = s->sparts[k];
      s->sparts[k] = s->sparts[nr_sparts];
      s->sparts[nr_sparts] = tp;
      /* Swap the link with the gpart */
      if (s->sparts[k].gpart != NULL) {
        s->sparts[k].gpart->id_or_neg_offset = -k;
      }
643
644
      if (s->sparts[nr_sparts].gpart != NULL) {
        s->sparts[nr_sparts].gpart->id_or_neg_offset = -nr_sparts;
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
      }
      /* Swap the index */
      const int t = sind[k];
      sind[k] = sind[nr_sparts];
      sind[nr_sparts] = t;
    } else {
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }

#ifdef SWIFT_DEBUG_CHECKS
  /* Check that all sparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_sparts; k++) {
    if (cells_top[sind[k]].nodeID != local_nodeID) {
      error("Failed to move all non-local sparts to send list");
    }
  }
  for (size_t k = nr_sparts; k < s->nr_sparts; k++) {
    if (cells_top[sind[k]].nodeID == local_nodeID) {
      error("Failed to remove local sparts from send list");
    }
  }
#endif

670
  /* Move non-local gparts to the end of the list. */
671
  for (size_t k = 0; k < nr_gparts;) {
672
    if (cells_top[gind[k]].nodeID != local_nodeID) {
673
      nr_gparts -= 1;
674
      /* Swap the particle */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
675
      const struct gpart tp = s->gparts[k];
676
677
      s->gparts[k] = s->gparts[nr_gparts];
      s->gparts[nr_gparts] = tp;
678
679
      /* Swap the link with part/spart */
      if (s->gparts[k].type == swift_type_gas) {
680
        s->parts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
681
682
      } else if (s->gparts[k].type == swift_type_star) {
        s->sparts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
683
      }
684
      if (s->gparts[nr_gparts].type == swift_type_gas) {
685
686
        s->parts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
687
688
689
      } else if (s->gparts[nr_gparts].type == swift_type_star) {
        s->sparts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
690
      }
691
      /* Swap the index */
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
692
693
694
      const int t = gind[k];
      gind[k] = gind[nr_gparts];
      gind[nr_gparts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
695
    } else {
696
697
698
699
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
700

701
#ifdef SWIFT_DEBUG_CHECKS
702
703
  /* Check that all gparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_gparts; k++) {
704
    if (cells_top[gind[k]].nodeID != local_nodeID) {
705
706
707
708
      error("Failed to move all non-local gparts to send list");
    }
  }
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
709
    if (cells_top[gind[k]].nodeID == local_nodeID) {
710
      error("Failed to remove local gparts from send list");
711
    }
712
713
  }
#endif
714

715
716
  /* Exchange the strays, note that this potentially re-allocates
     the parts arrays. */
717
  size_t nr_parts_exchanged = s->nr_parts - nr_parts;
718
  size_t nr_gparts_exchanged = s->nr_gparts - nr_gparts;
719
  size_t nr_sparts_exchanged = s->nr_sparts - nr_sparts;
Pedro Gonnet's avatar
Pedro Gonnet committed
720
  engine_exchange_strays(s->e, nr_parts, &ind[nr_parts], &nr_parts_exchanged,
721
722
                         nr_gparts, &gind[nr_gparts], &nr_gparts_exchanged,
                         nr_sparts, &sind[nr_sparts], &nr_sparts_exchanged);
Pedro Gonnet's avatar
Pedro Gonnet committed
723
724

  /* Set the new particle counts. */
725
  s->nr_parts = nr_parts + nr_parts_exchanged;
726
  s->nr_gparts = nr_gparts + nr_gparts_exchanged;
727
  s->nr_sparts = nr_sparts + nr_sparts_exchanged;
728

729
  /* Re-allocate the index array for the parts if needed.. */
730
  if (s->nr_parts + 1 > ind_size) {
731
    int *ind_new;
732
    if ((ind_new = (int *)malloc(sizeof(int) * (s->nr_parts + 1))) == NULL)
733
      error("Failed to allocate temporary particle indices.");
734
    memcpy(ind_new, ind, sizeof(int) * nr_parts);
735
736
    free(ind);
    ind = ind_new;
737
738
  }

739
  /* Re-allocate the index array for the sparts if needed.. */
740
  if (s->nr_sparts + 1 > sind_size) {
741
742
    int *sind_new;
    if ((sind_new = (int *)malloc(sizeof(int) * (s->nr_sparts + 1))) == NULL)
743
      error("Failed to allocate temporary s-particle indices.");
744
745
746
747
748
    memcpy(sind_new, sind, sizeof(int) * nr_sparts);
    free(sind);
    sind = sind_new;
  }

749
750
751
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
  const double ih[3] = {s->iwidth[0], s->iwidth[1], s->iwidth[2]};

752
  /* Assign each received part to its cell. */
Pedro Gonnet's avatar
Pedro Gonnet committed
753
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
754
    const struct part *const p = &s->parts[k];
755
    ind[k] =
756
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
757
#ifdef SWIFT_DEBUG_CHECKS
758
    if (cells_top[ind[k]].nodeID != local_nodeID)
759
      error("Received part that does not belong to me (nodeID=%i).",
760
            cells_top[ind[k]].nodeID);
761
#endif
762
  }
763
  nr_parts = s->nr_parts;
764

765
  /* Assign each received spart to its cell. */
766
767
768
769
770
771
  for (size_t k = nr_sparts; k < s->nr_sparts; k++) {
    const struct spart *const sp = &s->sparts[k];
    sind[k] =
        cell_getid(cdim, sp->x[0] * ih[0], sp->x[1] * ih[1], sp->x[2] * ih[2]);
#ifdef SWIFT_DEBUG_CHECKS
    if (cells_top[sind[k]].nodeID != local_nodeID)
772
      error("Received s-part that does not belong to me (nodeID=%i).",
773
774
775
776
777
            cells_top[sind[k]].nodeID);
#endif
  }
  nr_sparts = s->nr_sparts;

778
#endif /* WITH_MPI */
779
780

  /* Sort the parts according to their cells. */
781
782
  if (nr_parts > 0)
    space_parts_sort(s, ind, nr_parts, 0, s->nr_cells - 1, verbose);
783

784
785
786
#ifdef SWIFT_DEBUG_CHECKS
  /* Verify that the part have been sorted correctly. */
  for (size_t k = 0; k < nr_parts; k++) {
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
    const struct part *p = &s->parts[k];

    /* New cell index */
    const int new_ind =
        cell_getid(s->cdim, p->x[0] * s->iwidth[0], p->x[1] * s->iwidth[1],
                   p->x[2] * s->iwidth[2]);

    /* New cell of this part */
    const struct cell *c = &s->cells_top[new_ind];

    if (ind[k] != new_ind)
      error("part's new cell index not matching sorted index.");

    if (p->x[0] < c->loc[0] || p->x[0] > c->loc[0] + c->width[0] ||
        p->x[1] < c->loc[1] || p->x[1] > c->loc[1] + c->width[1] ||
        p->x[2] < c->loc[2] || p->x[2] > c->loc[2] + c->width[2])
803
804
805
806
      error("part not sorted into the right top-level cell!");
  }
#endif

807
808
809
810
  /* Sort the sparts according to their cells. */
  if (nr_sparts > 0)
    space_sparts_sort(s, sind, nr_sparts, 0, s->nr_cells - 1, verbose);

811
812
813
#ifdef SWIFT_DEBUG_CHECKS
  /* Verify that the spart have been sorted correctly. */
  for (size_t k = 0; k < nr_sparts; k++) {
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
    const struct spart *sp = &s->sparts[k];

    /* New cell index */
    const int new_sind =
        cell_getid(s->cdim, sp->x[0] * s->iwidth[0], sp->x[1] * s->iwidth[1],
                   sp->x[2] * s->iwidth[2]);

    /* New cell of this spart */
    const struct cell *c = &s->cells_top[new_sind];

    if (sind[k] != new_sind)
      error("spart's new cell index not matching sorted index.");

    if (sp->x[0] < c->loc[0] || sp->x[0] > c->loc[0] + c->width[0] ||
        sp->x[1] < c->loc[1] || sp->x[1] > c->loc[1] + c->width[1] ||
        sp->x[2] < c->loc[2] || sp->x[2] > c->loc[2] + c->width[2])
830
831
832
833
      error("spart not sorted into the right top-level cell!");
  }
#endif

834
835
836
837
838
  /* Re-link the gparts to their (s-)particles. */
  if (nr_parts > 0 && nr_gparts > 0)
    part_relink_gparts_to_parts(s->parts, nr_parts, 0);
  if (nr_sparts > 0 && nr_gparts > 0)
    part_relink_gparts_to_sparts(s->sparts, nr_sparts, 0);
839

840
841
842
843
844
845
846
847
848
849
  /* Extract the cell counts from the sorted indices. */
  size_t last_index = 0;
  ind[nr_parts] = s->nr_cells;  // sentinel.
  for (size_t k = 0; k < nr_parts; k++) {
    if (ind[k] < ind[k + 1]) {
      cells_top[ind[k]].count = k - last_index + 1;
      last_index = k + 1;
    }
  }

850
851
  /* Extract the cell counts from the sorted indices. */
  size_t last_sindex = 0;
852
  sind[nr_sparts] = s->nr_cells;  // sentinel.
853
854
855
856
857
858
859
  for (size_t k = 0; k < nr_sparts; k++) {
    if (sind[k] < sind[k + 1]) {
      cells_top[sind[k]].scount = k - last_sindex + 1;
      last_sindex = k + 1;
    }
  }

860
  /* We no longer need the indices as of here. */
861
  free(ind);
862
  free(sind);
863

864
865
#ifdef WITH_MPI

866
  /* Re-allocate the index array for the gparts if needed.. */
867
  if (s->nr_gparts + 1 > gind_size) {
868
    int *gind_new;
869
    if ((gind_new = (int *)malloc(sizeof(int) * (s->nr_gparts + 1))) == NULL)
870
      error("Failed to allocate temporary g-particle indices.");
871
    memcpy(gind_new, gind, sizeof(int) * nr_gparts);
872
873
874
875
    free(gind);
    gind = gind_new;
  }

876
  /* Assign each received gpart to its cell. */
877
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
878
    const struct gpart *const p = &s->gparts[k];
879
880
    gind[k] =
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
881
882

#ifdef SWIFT_DEBUG_CHECKS
883
    if (cells_top[gind[k]].nodeID != s->e->nodeID)
884
      error("Received g-part that does not belong to me (nodeID=%i).",
885
            cells_top[gind[k]].nodeID);
886
#endif
887
888
889
  }
  nr_gparts = s->nr_gparts;

890
#endif /* WITH_MPI */
891

892
  /* Sort the gparts according to their cells. */
893
894
  if (nr_gparts > 0)
    space_gparts_sort(s, gind, nr_gparts, 0, s->nr_cells - 1, verbose);
895

896
897
898
#ifdef SWIFT_DEBUG_CHECKS
  /* Verify that the gpart have been sorted correctly. */
  for (size_t k = 0; k < nr_gparts; k++) {
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
    const struct gpart *gp = &s->gparts[k];

    /* New cell index */
    const int new_gind =
        cell_getid(s->cdim, gp->x[0] * s->iwidth[0], gp->x[1] * s->iwidth[1],
                   gp->x[2] * s->iwidth[2]);

    /* New cell of this gpart */
    const struct cell *c = &s->cells_top[new_gind];

    if (gind[k] != new_gind)
      error("gpart's new cell index not matching sorted index.");

    if (gp->x[0] < c->loc[0] || gp->x[0] > c->loc[0] + c->width[0] ||
        gp->x[1] < c->loc[1] || gp->x[1] > c->loc[1] + c->width[1] ||
        gp->x[2] < c->loc[2] || gp->x[2] > c->loc[2] + c->width[2])
915
916
917
918
      error("gpart not sorted into the right top-level cell!");
  }
#endif

919
  /* Re-link the parts. */
920
  if (nr_parts > 0 && nr_gparts > 0)
921
922
923
924
925
    part_relink_parts_to_gparts(s->gparts, nr_gparts, s->parts);

  /* Re-link the sparts. */
  if (nr_sparts > 0 && nr_gparts > 0)
    part_relink_sparts_to_gparts(s->gparts, nr_gparts, s->sparts);
926

927
928
  /* Extract the cell counts from the sorted indices. */
  size_t last_gindex = 0;
James Willis's avatar