space.c 60.8 KB
Newer Older
1
/*******************************************************************************
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 * This file is part of SWIFT.
 * Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
 *                    Matthieu Schaller (matthieu.schaller@durham.ac.uk)
 *               2015 Peter W. Draper (p.w.draper@durham.ac.uk)
 *               2016 John A. Regan (john.a.regan@durham.ac.uk)
 *                    Tom Theuns (tom.theuns@durham.ac.uk)
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 ******************************************************************************/
Pedro Gonnet's avatar
Pedro Gonnet committed
23
24
25
26
27
28
29
30

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <math.h>
31
#include <stdlib.h>
32
#include <string.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
33

34
35
/* MPI headers. */
#ifdef WITH_MPI
36
#include <mpi.h>
37
38
#endif

39
40
41
/* This object's header. */
#include "space.h"

Pedro Gonnet's avatar
Pedro Gonnet committed
42
/* Local headers. */
43
#include "atomic.h"
44
#include "const.h"
45
#include "cooling.h"
46
#include "engine.h"
47
#include "error.h"
48
49
#include "gravity.h"
#include "hydro.h"
50
#include "kernel_hydro.h"
51
#include "lock.h"
52
#include "memswap.h"
53
#include "minmax.h"
54
#include "runner.h"
55
#include "threadpool.h"
56
#include "tools.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
57
58
59

/* Split size. */
int space_splitsize = space_splitsize_default;
60
int space_subsize = space_subsize_default;
61
int space_maxsize = space_maxsize_default;
62
int space_maxcount = space_maxcount_default;
Pedro Gonnet's avatar
Pedro Gonnet committed
63
64
65

/* Map shift vector to sortlist. */
const int sortlistID[27] = {
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
    /* ( -1 , -1 , -1 ) */ 0,
    /* ( -1 , -1 ,  0 ) */ 1,
    /* ( -1 , -1 ,  1 ) */ 2,
    /* ( -1 ,  0 , -1 ) */ 3,
    /* ( -1 ,  0 ,  0 ) */ 4,
    /* ( -1 ,  0 ,  1 ) */ 5,
    /* ( -1 ,  1 , -1 ) */ 6,
    /* ( -1 ,  1 ,  0 ) */ 7,
    /* ( -1 ,  1 ,  1 ) */ 8,
    /* (  0 , -1 , -1 ) */ 9,
    /* (  0 , -1 ,  0 ) */ 10,
    /* (  0 , -1 ,  1 ) */ 11,
    /* (  0 ,  0 , -1 ) */ 12,
    /* (  0 ,  0 ,  0 ) */ 0,
    /* (  0 ,  0 ,  1 ) */ 12,
    /* (  0 ,  1 , -1 ) */ 11,
    /* (  0 ,  1 ,  0 ) */ 10,
    /* (  0 ,  1 ,  1 ) */ 9,
    /* (  1 , -1 , -1 ) */ 8,
    /* (  1 , -1 ,  0 ) */ 7,
    /* (  1 , -1 ,  1 ) */ 6,
    /* (  1 ,  0 , -1 ) */ 5,
    /* (  1 ,  0 ,  0 ) */ 4,
    /* (  1 ,  0 ,  1 ) */ 3,
    /* (  1 ,  1 , -1 ) */ 2,
    /* (  1 ,  1 ,  0 ) */ 1,
    /* (  1 ,  1 ,  1 ) */ 0};

94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
/**
 * @brief Interval stack necessary for parallel particle sorting.
 */
struct qstack {
  volatile ptrdiff_t i, j;
  volatile int min, max;
  volatile int ready;
};

/**
 * @brief Parallel particle-sorting stack
 */
struct parallel_sort {
  struct part *parts;
  struct gpart *gparts;
  struct xpart *xparts;
  int *ind;
  struct qstack *stack;
  unsigned int stack_size;
  volatile unsigned int first, last, waiting;
};

116
117
118
119
120
121
122
123
124
/**
 * @brief Information required to compute the particle cell indices.
 */
struct index_data {
  struct space *s;
  struct cell *cells;
  int *ind;
};

125
126
127
128
129
130
131
132
133
134
135
/**
 * @brief Get the shift-id of the given pair of cells, swapping them
 *      if need be.
 *
 * @param s The space
 * @param ci Pointer to first #cell.
 * @param cj Pointer second #cell.
 * @param shift Vector from ci to cj.
 *
 * @return The shift ID and set shift, may or may not swap ci and cj.
 */
136
137
138
139
int space_getsid(struct space *s, struct cell **ci, struct cell **cj,
                 double *shift) {

  /* Get the relative distance between the pairs, wrapping. */
140
141
142
  const int periodic = s->periodic;
  double dx[3];
  for (int k = 0; k < 3; k++) {
143
144
145
146
147
148
149
150
151
152
153
    dx[k] = (*cj)->loc[k] - (*ci)->loc[k];
    if (periodic && dx[k] < -s->dim[k] / 2)
      shift[k] = s->dim[k];
    else if (periodic && dx[k] > s->dim[k] / 2)
      shift[k] = -s->dim[k];
    else
      shift[k] = 0.0;
    dx[k] += shift[k];
  }

  /* Get the sorting index. */
154
  int sid = 0;
155
  for (int k = 0; k < 3; k++)
156
157
158
159
    sid = 3 * sid + ((dx[k] < 0.0) ? 0 : ((dx[k] > 0.0) ? 2 : 1));

  /* Switch the cells around? */
  if (runner_flip[sid]) {
160
    struct cell *temp = *ci;
161
162
    *ci = *cj;
    *cj = temp;
163
    for (int k = 0; k < 3; k++) shift[k] = -shift[k];
164
165
166
167
168
169
  }
  sid = sortlistID[sid];

  /* Return the sort ID. */
  return sid;
}
170

171
/**
172
 * @brief Recursively dismantle a cell tree.
173
 *
174
175
 * @param s The #space.
 * @param c The #cell to recycle.
Matthieu Schaller's avatar
Matthieu Schaller committed
176
177
 * @param rec_begin Pointer to the start of the list of cells to recycle.
 * @param rec_end Pointer to the end of the list of cells to recycle.
178
 */
179
180
void space_rebuild_recycle_rec(struct space *s, struct cell *c,
                               struct cell **rec_begin, struct cell **rec_end) {
181
  if (c->split)
182
    for (int k = 0; k < 8; k++)
183
      if (c->progeny[k] != NULL) {
184
185
186
187
        space_rebuild_recycle_rec(s, c->progeny[k], rec_begin, rec_end);
        c->progeny[k]->next = *rec_begin;
        *rec_begin = c->progeny[k];
        if (*rec_end == NULL) *rec_end = *rec_begin;
188
189
190
191
        c->progeny[k] = NULL;
      }
}

192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
void space_rebuild_recycle_mapper(void *map_data, int num_elements,
                                  void *extra_data) {

  struct space *s = (struct space *)extra_data;
  struct cell *cells = (struct cell *)map_data;

  for (int k = 0; k < num_elements; k++) {
    struct cell *c = &cells[k];
    struct cell *rec_begin = NULL, *rec_end = NULL;
    space_rebuild_recycle_rec(s, c, &rec_begin, &rec_end);
    if (rec_begin != NULL) space_recycle_list(s, rec_begin, rec_end);
    c->sorts = NULL;
    c->nr_tasks = 0;
    c->density = NULL;
    c->gradient = NULL;
    c->force = NULL;
    c->grav = NULL;
    c->dx_max = 0.0f;
    c->sorted = 0;
    c->count = 0;
    c->gcount = 0;
    c->init = NULL;
    c->extra_ghost = NULL;
    c->ghost = NULL;
    c->kick = NULL;
217
    c->drift = NULL;
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
    c->cooling = NULL;
    c->sourceterms = NULL;
    c->super = c;
    if (c->sort != NULL) {
      free(c->sort);
      c->sort = NULL;
    }
#if WITH_MPI
    c->recv_xv = NULL;
    c->recv_rho = NULL;
    c->recv_gradient = NULL;
    c->recv_ti = NULL;

    c->send_xv = NULL;
    c->send_rho = NULL;
    c->send_gradient = NULL;
    c->send_ti = NULL;
#endif
  }
}

239
/**
240
 * @brief Re-build the top-level cell grid.
241
 *
242
 * @param s The #space.
243
 * @param verbose Print messages to stdout or not.
244
 */
245
void space_regrid(struct space *s, int verbose) {
246

247
  const size_t nr_parts = s->nr_parts;
248
  const ticks tic = getticks();
249
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
250

251
  /* Run through the cells and get the current h_max. */
252
  // tic = getticks();
253
  float h_max = s->cell_min / kernel_gamma / space_stretch;
254
  if (nr_parts > 0) {
255
    if (s->cells_top != NULL) {
Tom Theuns's avatar
Tom Theuns committed
256
      for (int k = 0; k < s->nr_cells; k++) {
257
258
259
        if (s->cells_top[k].nodeID == engine_rank &&
            s->cells_top[k].h_max > h_max) {
          h_max = s->cells_top[k].h_max;
260
        }
261
262
      }
    } else {
263
      for (size_t k = 0; k < nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
264
        if (s->parts[k].h > h_max) h_max = s->parts[k].h;
265
      }
266
267
268
269
270
271
272
273
274
275
    }
  }

/* If we are running in parallel, make sure everybody agrees on
   how large the largest cell should be. */
#ifdef WITH_MPI
  {
    float buff;
    if (MPI_Allreduce(&h_max, &buff, 1, MPI_FLOAT, MPI_MAX, MPI_COMM_WORLD) !=
        MPI_SUCCESS)
276
      error("Failed to aggregate the rebuild flag across nodes.");
277
278
279
    h_max = buff;
  }
#endif
280
  if (verbose) message("h_max is %.3e (cell_min=%.3e).", h_max, s->cell_min);
281
282

  /* Get the new putative cell dimensions. */
283
  const int cdim[3] = {
284
285
286
287
288
289
      floor(s->dim[0] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[1] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[2] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min))};
290
291
292
293
294

  /* Check if we have enough cells for periodicity. */
  if (s->periodic && (cdim[0] < 3 || cdim[1] < 3 || cdim[2] < 3))
    error(
        "Must have at least 3 cells in each spatial dimension when periodicity "
295
296
297
        "is switched on.\nThis error is often caused by any of the "
        "followings:\n"
        " - too few particles to generate a sensible grid,\n"
298
299
        " - the initial value of 'Scheduler:max_top_level_cells' is too "
        "small,\n"
300
        " - the (minimal) time-step is too large leading to particles with "
301
302
303
        "predicted smoothing lengths too large for the box size,\n"
        " - particle with velocities so large that they move by more than two "
        "box sizes per time-step.\n");
304

305
306
307
308
309
310
  /* Check if we have enough cells for gravity. */
  if (s->gravity && (cdim[0] < 8 || cdim[1] < 8 || cdim[2] < 8))
    error(
        "Must have at least 8 cells in each spatial dimension when gravity "
        "is switched on.");

311
312
313
/* In MPI-Land, changing the top-level cell size requires that the
 * global partition is recomputed and the particles redistributed.
 * Be prepared to do that. */
314
#ifdef WITH_MPI
Matthieu Schaller's avatar
Matthieu Schaller committed
315
  double oldwidth[3];
316
317
318
319
320
321
322
323
  double oldcdim[3];
  int *oldnodeIDs = NULL;
  if (cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] || cdim[2] < s->cdim[2]) {

    /* Capture state of current space. */
    oldcdim[0] = s->cdim[0];
    oldcdim[1] = s->cdim[1];
    oldcdim[2] = s->cdim[2];
324
325
326
    oldwidth[0] = s->width[0];
    oldwidth[1] = s->width[1];
    oldwidth[2] = s->width[2];
327
328
329
330
331
332
333
334
335

    if ((oldnodeIDs = (int *)malloc(sizeof(int) * s->nr_cells)) == NULL)
      error("Failed to allocate temporary nodeIDs.");

    int cid = 0;
    for (int i = 0; i < s->cdim[0]; i++) {
      for (int j = 0; j < s->cdim[1]; j++) {
        for (int k = 0; k < s->cdim[2]; k++) {
          cid = cell_getid(oldcdim, i, j, k);
336
          oldnodeIDs[cid] = s->cells_top[cid].nodeID;
337
338
339
340
341
        }
      }
    }
  }

342
343
344
345
#endif

  /* Do we need to re-build the upper-level cells? */
  // tic = getticks();
346
  if (s->cells_top == NULL || cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] ||
347
348
      cdim[2] < s->cdim[2]) {

349
350
351
352
353
354
/* Be verbose about this. */
#ifdef SWIFT_DEBUG_CHECKS
    message("re)griding space cdim=(%d %d %d)", cdim[0], cdim[1], cdim[2]);
    fflush(stdout);
#endif

355
    /* Free the old cells, if they were allocated. */
356
    if (s->cells_top != NULL) {
357
358
      threadpool_map(&s->e->threadpool, space_rebuild_recycle_mapper,
                     s->cells_top, s->nr_cells, sizeof(struct cell), 100, s);
359
      free(s->cells_top);
360
361
362
363
      s->maxdepth = 0;
    }

    /* Set the new cell dimensions only if smaller. */
364
    for (int k = 0; k < 3; k++) {
365
      s->cdim[k] = cdim[k];
366
367
      s->width[k] = s->dim[k] / cdim[k];
      s->iwidth[k] = 1.0 / s->width[k];
368
    }
369
    const float dmin = min(s->width[0], min(s->width[1], s->width[2]));
370
371
372

    /* Allocate the highest level of cells. */
    s->tot_cells = s->nr_cells = cdim[0] * cdim[1] * cdim[2];
373
    if (posix_memalign((void *)&s->cells_top, cell_align,
374
375
                       s->nr_cells * sizeof(struct cell)) != 0)
      error("Failed to allocate cells.");
376
    bzero(s->cells_top, s->nr_cells * sizeof(struct cell));
377
378

    /* Set the cells' locks */
379
    for (int k = 0; k < s->nr_cells; k++)
380
381
      if (lock_init(&s->cells_top[k].lock) != 0)
        error("Failed to init spinlock.");
382
383

    /* Set the cell location and sizes. */
384
385
386
    for (int i = 0; i < cdim[0]; i++)
      for (int j = 0; j < cdim[1]; j++)
        for (int k = 0; k < cdim[2]; k++) {
387
          struct cell *restrict c = &s->cells_top[cell_getid(cdim, i, j, k)];
388
389
390
391
392
393
          c->loc[0] = i * s->width[0];
          c->loc[1] = j * s->width[1];
          c->loc[2] = k * s->width[2];
          c->width[0] = s->width[0];
          c->width[1] = s->width[1];
          c->width[2] = s->width[2];
394
395
396
397
          c->dmin = dmin;
          c->depth = 0;
          c->count = 0;
          c->gcount = 0;
Matthieu Schaller's avatar
Matthieu Schaller committed
398
          c->super = c;
399
          c->ti_old = ti_current;
400
          lock_init(&c->lock);
Pedro Gonnet's avatar
Pedro Gonnet committed
401
        }
402
403

    /* Be verbose about the change. */
404
405
406
    if (verbose)
      message("set cell dimensions to [ %i %i %i ].", cdim[0], cdim[1],
              cdim[2]);
407

408
#ifdef WITH_MPI
409
410
411
412
413
    if (oldnodeIDs != NULL) {
      /* We have changed the top-level cell dimension, so need to redistribute
       * cells around the nodes. We repartition using the old space node
       * positions as a grid to resample. */
      if (s->e->nodeID == 0)
414
415
416
        message(
            "basic cell dimensions have increased - recalculating the "
            "global partition.");
417

Matthieu Schaller's avatar
Matthieu Schaller committed
418
      if (!partition_space_to_space(oldwidth, oldcdim, oldnodeIDs, s)) {
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436

        /* Failed, try another technique that requires no settings. */
        message("Failed to get a new partition, trying less optimal method");
        struct partition initial_partition;
#ifdef HAVE_METIS
        initial_partition.type = INITPART_METIS_NOWEIGHT;
#else
        initial_partition.type = INITPART_VECTORIZE;
#endif
        partition_initial_partition(&initial_partition, s->e->nodeID,
                                    s->e->nr_nodes, s);
      }

      /* Re-distribute the particles to their new nodes. */
      engine_redistribute(s->e);

      /* Make the proxies. */
      engine_makeproxies(s->e);
437

438
439
      /* Finished with these. */
      free(oldnodeIDs);
440
    }
Pedro Gonnet's avatar
Pedro Gonnet committed
441
#endif /* WITH_MPI */
442
443
444
445

    // message( "rebuilding upper-level cells took %.3f %s." ,
    // clocks_from_ticks(double)(getticks() - tic), clocks_getunit());

446
  }      /* re-build upper-level cells? */
447
  else { /* Otherwise, just clean up the cells. */
448
449

    /* Free the old cells, if they were allocated. */
450
451
    threadpool_map(&s->e->threadpool, space_rebuild_recycle_mapper,
                   s->cells_top, s->nr_cells, sizeof(struct cell), 100, s);
452
453
    s->maxdepth = 0;
  }
454
455
456
457

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
458
}
459
460
461
462
463

/**
 * @brief Re-build the cells as well as the tasks.
 *
 * @param s The #space in which to update the cells.
464
 * @param verbose Print messages to stdout or not
465
466
 *
 */
467
void space_rebuild(struct space *s, int verbose) {
468

Matthieu Schaller's avatar
Matthieu Schaller committed
469
  const ticks tic = getticks();
470

471
472
473
474
475
/* Be verbose about this. */
#ifdef SWIFT_DEBUG_CHECKS
  message("re)building space");
  fflush(stdout);
#endif
476
477

  /* Re-grid if necessary, or just re-set the cell data. */
478
  space_regrid(s, verbose);
479

Pedro Gonnet's avatar
Pedro Gonnet committed
480
481
  size_t nr_parts = s->nr_parts;
  size_t nr_gparts = s->nr_gparts;
482
  struct cell *restrict cells_top = s->cells_top;
483
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
484

Pedro Gonnet's avatar
Pedro Gonnet committed
485
486
487
  /* Run through the particles and get their cell index. Allocates
     an index that is larger than the number of particles to avoid
     re-allocating after shuffling. */
488
  const size_t ind_size = s->size_parts + 100;
489
490
  int *ind;
  if ((ind = (int *)malloc(sizeof(int) * ind_size)) == NULL)
491
    error("Failed to allocate temporary particle indices.");
492
  if (s->size_parts > 0) space_parts_get_cell_index(s, ind, cells_top, verbose);
493

494
  /* Run through the gravity particles and get their cell index. */
495
  const size_t gind_size = s->size_gparts + 100;
496
497
498
  int *gind;
  if ((gind = (int *)malloc(sizeof(int) * gind_size)) == NULL)
    error("Failed to allocate temporary g-particle indices.");
Pedro Gonnet's avatar
Pedro Gonnet committed
499
500
  if (s->size_gparts > 0)
    space_gparts_get_cell_index(s, gind, cells_top, verbose);
501
502
503

#ifdef WITH_MPI
  /* Move non-local parts to the end of the list. */
504
  const int local_nodeID = s->e->nodeID;
505
  for (size_t k = 0; k < nr_parts;) {
506
    if (cells_top[ind[k]].nodeID != local_nodeID) {
507
      nr_parts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
508
      const struct part tp = s->parts[k];
509
510
      s->parts[k] = s->parts[nr_parts];
      s->parts[nr_parts] = tp;
511
      if (s->parts[k].gpart != NULL) {
512
        s->parts[k].gpart->id_or_neg_offset = -k;
513
514
      }
      if (s->parts[nr_parts].gpart != NULL) {
515
        s->parts[nr_parts].gpart->id_or_neg_offset = -nr_parts;
516
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
517
      const struct xpart txp = s->xparts[k];
518
519
      s->xparts[k] = s->xparts[nr_parts];
      s->xparts[nr_parts] = txp;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
520
      const int t = ind[k];
521
522
      ind[k] = ind[nr_parts];
      ind[nr_parts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
523
    } else {
524
525
526
527
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
528

529
#ifdef SWIFT_DEBUG_CHECKS
Peter W. Draper's avatar
Peter W. Draper committed
530
  /* Check that all parts are in the correct places. */
531
  for (size_t k = 0; k < nr_parts; k++) {
532
    if (cells_top[ind[k]].nodeID != local_nodeID) {
533
534
535
536
      error("Failed to move all non-local parts to send list");
    }
  }
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
537
    if (cells_top[ind[k]].nodeID == local_nodeID) {
538
      error("Failed to remove local parts from send list");
539
    }
540
541
  }
#endif
542

543
  /* Move non-local gparts to the end of the list. */
544
  for (size_t k = 0; k < nr_gparts;) {
545
    if (cells_top[gind[k]].nodeID != local_nodeID) {
546
      nr_gparts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
547
      const struct gpart tp = s->gparts[k];
548
549
      s->gparts[k] = s->gparts[nr_gparts];
      s->gparts[nr_gparts] = tp;
550
551
      if (s->gparts[k].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
552
      }
553
554
555
      if (s->gparts[nr_gparts].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
556
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
557
558
559
      const int t = gind[k];
      gind[k] = gind[nr_gparts];
      gind[nr_gparts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
560
    } else {
561
562
563
564
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
565

566
#ifdef SWIFT_DEBUG_CHECKS
567
568
  /* Check that all gparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_gparts; k++) {
569
    if (cells_top[gind[k]].nodeID != local_nodeID) {
570
571
572
573
      error("Failed to move all non-local gparts to send list");
    }
  }
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
574
    if (cells_top[gind[k]].nodeID == local_nodeID) {
575
      error("Failed to remove local gparts from send list");
576
    }
577
578
  }
#endif
579

580
581
  /* Exchange the strays, note that this potentially re-allocates
     the parts arrays. */
582
  size_t nr_parts_exchanged = s->nr_parts - nr_parts;
583
  size_t nr_gparts_exchanged = s->nr_gparts - nr_gparts;
Pedro Gonnet's avatar
Pedro Gonnet committed
584
585
586
587
  engine_exchange_strays(s->e, nr_parts, &ind[nr_parts], &nr_parts_exchanged,
                         nr_gparts, &gind[nr_gparts], &nr_gparts_exchanged);

  /* Set the new particle counts. */
588
  s->nr_parts = nr_parts + nr_parts_exchanged;
589
  s->nr_gparts = nr_gparts + nr_gparts_exchanged;
590
591

  /* Re-allocate the index array if needed.. */
592
  if (s->nr_parts + 1 > ind_size) {
593
    int *ind_new;
594
    if ((ind_new = (int *)malloc(sizeof(int) * (s->nr_parts + 1))) == NULL)
595
      error("Failed to allocate temporary particle indices.");
596
    memcpy(ind_new, ind, sizeof(int) * nr_parts);
597
598
    free(ind);
    ind = ind_new;
599
600
  }

601
602
603
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
  const double ih[3] = {s->iwidth[0], s->iwidth[1], s->iwidth[2]};

604
  /* Assign each particle to its cell. */
Pedro Gonnet's avatar
Pedro Gonnet committed
605
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
606
    const struct part *const p = &s->parts[k];
607
    ind[k] =
608
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
609
#ifdef SWIFT_DEBUG_CHECKS
610
    if (cells_top[ind[k]].nodeID != local_nodeID)
611
      error("Received part that does not belong to me (nodeID=%i).",
612
            cells_top[ind[k]].nodeID);
613
#endif
614
  }
615
  nr_parts = s->nr_parts;
616
617

#endif /* WITH_MPI */
618
619

  /* Sort the parts according to their cells. */
620
621
  if (nr_parts > 0)
    space_parts_sort(s, ind, nr_parts, 0, s->nr_cells - 1, verbose);
622
623

  /* Re-link the gparts. */
624
  if (nr_parts > 0 && nr_gparts > 0) part_relink_gparts(s->parts, nr_parts, 0);
625

626
#ifdef SWIFT_DEBUG_CHECKS
627
  /* Verify space_sort_struct. */
628
629
630
  for (size_t k = 1; k < nr_parts; k++) {
    if (ind[k - 1] > ind[k]) {
      error("Sort failed!");
631
    } else if (ind[k] != cell_getid(s->cdim, s->parts[k].x[0] * s->iwidth[0],
632
633
                                    s->parts[k].x[1] * s->iwidth[1],
                                    s->parts[k].x[2] * s->iwidth[2])) {
634
635
636
637
      error("Incorrect indices!");
    }
  }
#endif
638

639
640
641
642
643
644
645
646
647
648
  /* Extract the cell counts from the sorted indices. */
  size_t last_index = 0;
  ind[nr_parts] = s->nr_cells;  // sentinel.
  for (size_t k = 0; k < nr_parts; k++) {
    if (ind[k] < ind[k + 1]) {
      cells_top[ind[k]].count = k - last_index + 1;
      last_index = k + 1;
    }
  }

649
  /* We no longer need the indices as of here. */
650
  free(ind);
651

652
653
654
#ifdef WITH_MPI

  /* Re-allocate the index array if needed.. */
655
  if (s->nr_gparts + 1 > gind_size) {
656
    int *gind_new;
657
    if ((gind_new = (int *)malloc(sizeof(int) * (s->nr_gparts + 1))) == NULL)
658
      error("Failed to allocate temporary g-particle indices.");
659
    memcpy(gind_new, gind, sizeof(int) * nr_gparts);
660
661
662
663
664
    free(gind);
    gind = gind_new;
  }

  /* Assign each particle to its cell. */
665
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
666
    const struct gpart *const p = &s->gparts[k];
667
668
    gind[k] =
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
669
670

#ifdef SWIFT_DEBUG_CHECKS
671
    if (cells_top[gind[k]].nodeID != s->e->nodeID)
672
      error("Received part that does not belong to me (nodeID=%i).",
673
            cells_top[gind[k]].nodeID);
674
#endif
675
676
677
678
  }
  nr_gparts = s->nr_gparts;

#endif
679

680
  /* Sort the gparts according to their cells. */
681
682
  if (nr_gparts > 0)
    space_gparts_sort(s, gind, nr_gparts, 0, s->nr_cells - 1, verbose);
683
684

  /* Re-link the parts. */
685
686
  if (nr_parts > 0 && nr_gparts > 0)
    part_relink_parts(s->gparts, nr_gparts, s->parts);
687

688
689
  /* Extract the cell counts from the sorted indices. */
  size_t last_gindex = 0;
690
  gind[nr_gparts] = s->nr_cells;
691
692
  for (size_t k = 0; k < nr_gparts; k++) {
    if (gind[k] < gind[k + 1]) {
693
      cells_top[gind[k]].gcount = k - last_gindex + 1;
694
695
696
697
      last_gindex = k + 1;
    }
  }

698
  /* We no longer need the indices as of here. */
699
  free(gind);
700

701
#ifdef SWIFT_DEBUG_CHECKS
702
703
704
  /* Verify that the links are correct */
  for (size_t k = 0; k < nr_gparts; ++k) {

705
    if (s->gparts[k].id_or_neg_offset < 0) {
706

707
      const struct part *part = &s->parts[-s->gparts[k].id_or_neg_offset];
708

709
710
711
712
      if (part->gpart != &s->gparts[k]) error("Linking problem !");

      if (s->gparts[k].x[0] != part->x[0] || s->gparts[k].x[1] != part->x[1] ||
          s->gparts[k].x[2] != part->x[2])
713
714
715
716
717
        error("Linked particles are not at the same position !");
    }
  }
  for (size_t k = 0; k < nr_parts; ++k) {

718
    if (s->parts[k].gpart != NULL &&
719
        s->parts[k].gpart->id_or_neg_offset != -(ptrdiff_t)k) {
720
      error("Linking problem !");
721
722
    }
  }
723
#endif
724

725
726
  /* Hook the cells up to the parts. */
  // tic = getticks();
727
728
729
  struct part *finger = s->parts;
  struct xpart *xfinger = s->xparts;
  struct gpart *gfinger = s->gparts;
730
  for (int k = 0; k < s->nr_cells; k++) {
731
    struct cell *restrict c = &cells_top[k];
732
    c->ti_old = ti_current;
733
734
735
736
737
738
739
    c->parts = finger;
    c->xparts = xfinger;
    c->gparts = gfinger;
    finger = &finger[c->count];
    xfinger = &xfinger[c->count];
    gfinger = &gfinger[c->gcount];
  }
740
  // message( "hooking up cells took %.3f %s." ,
Matthieu Schaller's avatar
Matthieu Schaller committed
741
  // clocks_from_ticks(getticks() - tic), clocks_getunit());
742
743
744

  /* At this point, we have the upper-level cells, old or new. Now make
     sure that the parts in each cell are ok. */
745
  space_split(s, cells_top, s->nr_cells, verbose);
746
747
748
749
750
751
752
753
754

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Split particles between cells of a hierarchy
 *
755
756
 * This is done in parallel using threads in the #threadpool.
 *
757
 * @param s The #space.
758
759
 * @param cells The cell hierarchy.
 * @param nr_cells The number of cells.
760
761
 * @param verbose Are we talkative ?
 */
762
763
void space_split(struct space *s, struct cell *cells, int nr_cells,
                 int verbose) {
764

Matthieu Schaller's avatar
Matthieu Schaller committed
765
  const ticks tic = getticks();
766

767
  threadpool_map(&s->e->threadpool, space_split_mapper, cells, nr_cells,
768
                 sizeof(struct cell), 1, s);
769

770
771
772
  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
773
}
774

775
776
777
778
779
780
781
782
/**
 * @brief Runs through the top-level cells and checks whether tasks associated
 * with them can be split. If not, try to sanitize the cells.
 *
 * @param s The #space to act upon.
 */
void space_sanitize(struct space *s) {

783
784
  s->sanitized = 1;

785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
  for (int k = 0; k < s->nr_cells; k++) {

    struct cell *c = &s->cells_top[k];
    const double min_width = c->dmin;

    /* Do we have a problem ? */
    if (c->h_max * kernel_gamma * space_stretch > min_width * 0.5 &&
        c->count > space_maxcount) {

      /* Ok, clean-up the mess */
      cell_sanitize(c);
    }
  }
}

800
/**
801
 * @brief #threadpool mapper function to compute the particle cell indices.
802
 *
803
 * @param map_data Pointer towards the particles.
804
 * @param nr_parts The number of particles to treat.
805
 * @param extra_data Pointers to the space and index list
806
 */
807
808
void space_parts_get_cell_index_mapper(void *map_data, int nr_parts,
                                       void *extra_data) {
809

810
811
812
813
  /* Unpack the data */
  struct part *restrict parts = (struct part *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
814
  int *const ind = data->ind + (ptrdiff_t)(parts - s->parts);
815
816

  /* Get some constants */
817
818
819
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
Matthieu Schaller's avatar
Matthieu Schaller committed
820
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
821
822
823
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
824

825
  for (int k = 0; k < nr_parts; k++) {
826
827
828
829

    /* Get the particle */
    struct part *restrict p = &parts[k];

830
831
832
833
    const double old_pos_x = p->x[0];
    const double old_pos_y = p->x[1];
    const double old_pos_z = p->x[2];

834
    /* Put it back into the simulation volume */
835
836
837
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
838
839

    /* Get its cell index */
Matthieu Schaller's avatar
Matthieu Schaller committed
840
841
    const int index =
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
842
    ind[k] = index;
843

844
845
846
847
    /* Update the position */
    p->x[0] = pos_x;
    p->x[1] = pos_y;
    p->x[2] = pos_z;
848
849
850
851
  }
}

/**
852
 * @brief #threadpool mapper function to compute the g-particle cell indices.
853
 *
854
 * @param map_data Pointer towards the g-particles.
855
 * @param nr_gparts The number of g-particles to treat.
856
 * @param extra_data Pointers to the space and index list
857
 */
858
859
void space_gparts_get_cell_index_mapper(void *map_data, int nr_gparts,
                                        void *extra_data) {
860

861
862
863
864
  /* Unpack the data */
  struct gpart *restrict gparts = (struct gpart *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
865
  int *const ind = data->ind + (ptrdiff_t)(gparts - s->gparts);
866
867

  /* Get some constants */
Matthieu Schaller's avatar
Matthieu Schaller committed
868
869
870
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
871
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
Matthieu Schaller's avatar
Matthieu Schaller committed
872
873
874
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
875

876
  for (int k = 0; k < nr_gparts; k++) {
877
878
879
880

    /* Get the particle */
    struct gpart *restrict gp = &gparts[k];

Matthieu Schaller's avatar
Matthieu Schaller committed
881
882
883
884
    const double old_pos_x = gp->x[0];
    const double old_pos_y = gp->x[1];
    const double old_pos_z = gp->x[2];

885
    /* Put it back into the simulation volume */
Matthieu Schaller's avatar
Matthieu Schaller committed
886
887
888
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
889
890
891

    /* Get its cell index */
    const int index =
Matthieu Schaller's avatar
Matthieu Schaller committed
892
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
893
    ind[k] = index;
Matthieu Schaller's avatar
Matthieu Schaller committed
894
895
896
897
898

    /* Update the position */
    gp->x[0] = pos_x;
    gp->x[1] = pos_y;
    gp->x[2] = pos_z;
899
900
901
  }
}

902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
/**
 * @brief Computes the cell index of all the particles and update the cell
 * count.
 *
 * @param s The #space.
 * @param ind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_parts_get_cell_index(struct space *s, int *ind, struct cell *cells,
                                int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = ind;

  threadpool_map(&s->e->threadpool, space_parts_get_cell_index_mapper, s->parts,
                 s->nr_parts, sizeof(struct part), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Computes the cell index of all the g-particles and update the cell
 * gcount.
 *
 * @param s The #space.
 * @param gind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_gparts_get_cell_index(struct space *s, int *gind, struct cell *cells,
                                 int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = gind;

  threadpool_map(&s->e->threadpool, space_gparts_get_cell_index_mapper,
                 s->gparts, s->nr_gparts, sizeof(struct gpart), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

958
/**
959
 * @brief Sort the particles and condensed particles according to the given
960
 * indices.
961
 *
Matthieu Schaller's avatar
Matthieu Schaller committed
962
 * @param s The #space.
963
964
965
966
 * @param ind The indices with respect to which the parts are sorted.
 * @param N The number of parts
 * @param min Lowest index.
 * @param max highest index.
967
 * @param verbose Are we talkative ?
968
 */
969
void space_parts_sort(struct space *s, int *ind, size_t N, int min, int max,
970
971
                      int verbose) {

Matthieu Schaller's avatar
Matthieu Schaller committed
972
  const ticks tic = getticks();
973

974
975
976
977
978