space.c 62.8 KB
Newer Older
1
/*******************************************************************************
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
 * This file is part of SWIFT.
 * Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
 *                    Matthieu Schaller (matthieu.schaller@durham.ac.uk)
 *               2015 Peter W. Draper (p.w.draper@durham.ac.uk)
 *               2016 John A. Regan (john.a.regan@durham.ac.uk)
 *                    Tom Theuns (tom.theuns@durham.ac.uk)
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published
 * by the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 ******************************************************************************/
Pedro Gonnet's avatar
Pedro Gonnet committed
23
24
25
26
27
28
29
30

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <math.h>
31
#include <stdlib.h>
32
#include <string.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
33

34
35
/* MPI headers. */
#ifdef WITH_MPI
36
#include <mpi.h>
37
38
#endif

39
40
41
/* This object's header. */
#include "space.h"

Pedro Gonnet's avatar
Pedro Gonnet committed
42
/* Local headers. */
43
#include "atomic.h"
44
#include "const.h"
45
#include "cooling.h"
46
#include "engine.h"
47
#include "error.h"
48
49
#include "gravity.h"
#include "hydro.h"
50
#include "kernel_hydro.h"
51
#include "lock.h"
52
#include "memswap.h"
53
#include "minmax.h"
54
#include "runner.h"
55
#include "stars.h"
56
#include "threadpool.h"
57
#include "tools.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
58
59
60

/* Split size. */
int space_splitsize = space_splitsize_default;
61
int space_subsize = space_subsize_default;
62
int space_maxsize = space_maxsize_default;
63
int space_maxcount = space_maxcount_default;
Pedro Gonnet's avatar
Pedro Gonnet committed
64
65
66

/* Map shift vector to sortlist. */
const int sortlistID[27] = {
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
    /* ( -1 , -1 , -1 ) */ 0,
    /* ( -1 , -1 ,  0 ) */ 1,
    /* ( -1 , -1 ,  1 ) */ 2,
    /* ( -1 ,  0 , -1 ) */ 3,
    /* ( -1 ,  0 ,  0 ) */ 4,
    /* ( -1 ,  0 ,  1 ) */ 5,
    /* ( -1 ,  1 , -1 ) */ 6,
    /* ( -1 ,  1 ,  0 ) */ 7,
    /* ( -1 ,  1 ,  1 ) */ 8,
    /* (  0 , -1 , -1 ) */ 9,
    /* (  0 , -1 ,  0 ) */ 10,
    /* (  0 , -1 ,  1 ) */ 11,
    /* (  0 ,  0 , -1 ) */ 12,
    /* (  0 ,  0 ,  0 ) */ 0,
    /* (  0 ,  0 ,  1 ) */ 12,
    /* (  0 ,  1 , -1 ) */ 11,
    /* (  0 ,  1 ,  0 ) */ 10,
    /* (  0 ,  1 ,  1 ) */ 9,
    /* (  1 , -1 , -1 ) */ 8,
    /* (  1 , -1 ,  0 ) */ 7,
    /* (  1 , -1 ,  1 ) */ 6,
    /* (  1 ,  0 , -1 ) */ 5,
    /* (  1 ,  0 ,  0 ) */ 4,
    /* (  1 ,  0 ,  1 ) */ 3,
    /* (  1 ,  1 , -1 ) */ 2,
    /* (  1 ,  1 ,  0 ) */ 1,
    /* (  1 ,  1 ,  1 ) */ 0};

95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
/**
 * @brief Interval stack necessary for parallel particle sorting.
 */
struct qstack {
  volatile ptrdiff_t i, j;
  volatile int min, max;
  volatile int ready;
};

/**
 * @brief Parallel particle-sorting stack
 */
struct parallel_sort {
  struct part *parts;
  struct gpart *gparts;
  struct xpart *xparts;
  int *ind;
  struct qstack *stack;
  unsigned int stack_size;
  volatile unsigned int first, last, waiting;
};

117
118
119
120
121
122
123
124
125
/**
 * @brief Information required to compute the particle cell indices.
 */
struct index_data {
  struct space *s;
  struct cell *cells;
  int *ind;
};

126
127
128
129
130
131
132
133
134
135
136
/**
 * @brief Get the shift-id of the given pair of cells, swapping them
 *      if need be.
 *
 * @param s The space
 * @param ci Pointer to first #cell.
 * @param cj Pointer second #cell.
 * @param shift Vector from ci to cj.
 *
 * @return The shift ID and set shift, may or may not swap ci and cj.
 */
137
138
139
140
int space_getsid(struct space *s, struct cell **ci, struct cell **cj,
                 double *shift) {

  /* Get the relative distance between the pairs, wrapping. */
141
142
143
  const int periodic = s->periodic;
  double dx[3];
  for (int k = 0; k < 3; k++) {
144
145
146
147
148
149
150
151
152
153
154
    dx[k] = (*cj)->loc[k] - (*ci)->loc[k];
    if (periodic && dx[k] < -s->dim[k] / 2)
      shift[k] = s->dim[k];
    else if (periodic && dx[k] > s->dim[k] / 2)
      shift[k] = -s->dim[k];
    else
      shift[k] = 0.0;
    dx[k] += shift[k];
  }

  /* Get the sorting index. */
155
  int sid = 0;
156
  for (int k = 0; k < 3; k++)
157
158
159
160
    sid = 3 * sid + ((dx[k] < 0.0) ? 0 : ((dx[k] > 0.0) ? 2 : 1));

  /* Switch the cells around? */
  if (runner_flip[sid]) {
161
    struct cell *temp = *ci;
162
163
    *ci = *cj;
    *cj = temp;
164
    for (int k = 0; k < 3; k++) shift[k] = -shift[k];
165
166
167
168
169
170
  }
  sid = sortlistID[sid];

  /* Return the sort ID. */
  return sid;
}
171

172
/**
173
 * @brief Recursively dismantle a cell tree.
174
 *
175
176
 * @param s The #space.
 * @param c The #cell to recycle.
Matthieu Schaller's avatar
Matthieu Schaller committed
177
178
 * @param rec_begin Pointer to the start of the list of cells to recycle.
 * @param rec_end Pointer to the end of the list of cells to recycle.
179
 */
180
181
void space_rebuild_recycle_rec(struct space *s, struct cell *c,
                               struct cell **rec_begin, struct cell **rec_end) {
182
  if (c->split)
183
    for (int k = 0; k < 8; k++)
184
      if (c->progeny[k] != NULL) {
185
186
187
188
        space_rebuild_recycle_rec(s, c->progeny[k], rec_begin, rec_end);
        c->progeny[k]->next = *rec_begin;
        *rec_begin = c->progeny[k];
        if (*rec_end == NULL) *rec_end = *rec_begin;
189
190
191
192
        c->progeny[k] = NULL;
      }
}

193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
void space_rebuild_recycle_mapper(void *map_data, int num_elements,
                                  void *extra_data) {

  struct space *s = (struct space *)extra_data;
  struct cell *cells = (struct cell *)map_data;

  for (int k = 0; k < num_elements; k++) {
    struct cell *c = &cells[k];
    struct cell *rec_begin = NULL, *rec_end = NULL;
    space_rebuild_recycle_rec(s, c, &rec_begin, &rec_end);
    if (rec_begin != NULL) space_recycle_list(s, rec_begin, rec_end);
    c->sorts = NULL;
    c->nr_tasks = 0;
    c->density = NULL;
    c->gradient = NULL;
    c->force = NULL;
    c->grav = NULL;
    c->dx_max = 0.0f;
    c->sorted = 0;
    c->count = 0;
    c->gcount = 0;
    c->init = NULL;
    c->extra_ghost = NULL;
    c->ghost = NULL;
    c->kick = NULL;
    c->cooling = NULL;
    c->sourceterms = NULL;
    c->super = c;
    if (c->sort != NULL) {
      free(c->sort);
      c->sort = NULL;
    }
#if WITH_MPI
    c->recv_xv = NULL;
    c->recv_rho = NULL;
    c->recv_gradient = NULL;
    c->recv_ti = NULL;

    c->send_xv = NULL;
    c->send_rho = NULL;
    c->send_gradient = NULL;
    c->send_ti = NULL;
#endif
  }
}

239
/**
240
 * @brief Re-build the top-level cell grid.
241
 *
242
 * @param s The #space.
243
 * @param verbose Print messages to stdout or not.
244
 */
245
void space_regrid(struct space *s, int verbose) {
246

247
  const size_t nr_parts = s->nr_parts;
248
  const ticks tic = getticks();
249
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
250

251
  /* Run through the cells and get the current h_max. */
252
  // tic = getticks();
253
  float h_max = s->cell_min / kernel_gamma / space_stretch;
254
  if (nr_parts > 0) {
255
    if (s->cells_top != NULL) {
Tom Theuns's avatar
Tom Theuns committed
256
      for (int k = 0; k < s->nr_cells; k++) {
257
258
259
        if (s->cells_top[k].nodeID == engine_rank &&
            s->cells_top[k].h_max > h_max) {
          h_max = s->cells_top[k].h_max;
260
        }
261
262
      }
    } else {
263
      for (size_t k = 0; k < nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
264
        if (s->parts[k].h > h_max) h_max = s->parts[k].h;
265
      }
266
267
268
269
270
271
272
273
274
275
    }
  }

/* If we are running in parallel, make sure everybody agrees on
   how large the largest cell should be. */
#ifdef WITH_MPI
  {
    float buff;
    if (MPI_Allreduce(&h_max, &buff, 1, MPI_FLOAT, MPI_MAX, MPI_COMM_WORLD) !=
        MPI_SUCCESS)
276
      error("Failed to aggregate the rebuild flag across nodes.");
277
278
279
    h_max = buff;
  }
#endif
280
  if (verbose) message("h_max is %.3e (cell_min=%.3e).", h_max, s->cell_min);
281
282

  /* Get the new putative cell dimensions. */
283
  const int cdim[3] = {
284
285
286
287
288
289
      floor(s->dim[0] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[1] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min)),
      floor(s->dim[2] /
            fmax(h_max * kernel_gamma * space_stretch, s->cell_min))};
290
291
292
293
294

  /* Check if we have enough cells for periodicity. */
  if (s->periodic && (cdim[0] < 3 || cdim[1] < 3 || cdim[2] < 3))
    error(
        "Must have at least 3 cells in each spatial dimension when periodicity "
295
296
297
        "is switched on.\nThis error is often caused by any of the "
        "followings:\n"
        " - too few particles to generate a sensible grid,\n"
298
299
        " - the initial value of 'Scheduler:max_top_level_cells' is too "
        "small,\n"
300
        " - the (minimal) time-step is too large leading to particles with "
301
302
303
        "predicted smoothing lengths too large for the box size,\n"
        " - particle with velocities so large that they move by more than two "
        "box sizes per time-step.\n");
304

305
306
307
308
309
310
  /* Check if we have enough cells for gravity. */
  if (s->gravity && (cdim[0] < 8 || cdim[1] < 8 || cdim[2] < 8))
    error(
        "Must have at least 8 cells in each spatial dimension when gravity "
        "is switched on.");

311
312
313
/* In MPI-Land, changing the top-level cell size requires that the
 * global partition is recomputed and the particles redistributed.
 * Be prepared to do that. */
314
#ifdef WITH_MPI
Matthieu Schaller's avatar
Matthieu Schaller committed
315
  double oldwidth[3];
316
317
318
319
320
321
322
323
  double oldcdim[3];
  int *oldnodeIDs = NULL;
  if (cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] || cdim[2] < s->cdim[2]) {

    /* Capture state of current space. */
    oldcdim[0] = s->cdim[0];
    oldcdim[1] = s->cdim[1];
    oldcdim[2] = s->cdim[2];
324
325
326
    oldwidth[0] = s->width[0];
    oldwidth[1] = s->width[1];
    oldwidth[2] = s->width[2];
327
328
329
330
331
332
333
334
335

    if ((oldnodeIDs = (int *)malloc(sizeof(int) * s->nr_cells)) == NULL)
      error("Failed to allocate temporary nodeIDs.");

    int cid = 0;
    for (int i = 0; i < s->cdim[0]; i++) {
      for (int j = 0; j < s->cdim[1]; j++) {
        for (int k = 0; k < s->cdim[2]; k++) {
          cid = cell_getid(oldcdim, i, j, k);
336
          oldnodeIDs[cid] = s->cells_top[cid].nodeID;
337
338
339
340
341
        }
      }
    }
  }

342
343
344
345
#endif

  /* Do we need to re-build the upper-level cells? */
  // tic = getticks();
346
  if (s->cells_top == NULL || cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] ||
347
348
349
      cdim[2] < s->cdim[2]) {

    /* Free the old cells, if they were allocated. */
350
    if (s->cells_top != NULL) {
351
352
      threadpool_map(&s->e->threadpool, space_rebuild_recycle_mapper,
                     s->cells_top, s->nr_cells, sizeof(struct cell), 100, s);
353
      free(s->cells_top);
354
355
356
357
      s->maxdepth = 0;
    }

    /* Set the new cell dimensions only if smaller. */
358
    for (int k = 0; k < 3; k++) {
359
      s->cdim[k] = cdim[k];
360
361
      s->width[k] = s->dim[k] / cdim[k];
      s->iwidth[k] = 1.0 / s->width[k];
362
    }
363
    const float dmin = min(s->width[0], min(s->width[1], s->width[2]));
364
365
366

    /* Allocate the highest level of cells. */
    s->tot_cells = s->nr_cells = cdim[0] * cdim[1] * cdim[2];
367
    if (posix_memalign((void *)&s->cells_top, cell_align,
368
369
                       s->nr_cells * sizeof(struct cell)) != 0)
      error("Failed to allocate cells.");
370
    bzero(s->cells_top, s->nr_cells * sizeof(struct cell));
371
372

    /* Set the cells' locks */
373
    for (int k = 0; k < s->nr_cells; k++)
374
375
      if (lock_init(&s->cells_top[k].lock) != 0)
        error("Failed to init spinlock.");
376
377

    /* Set the cell location and sizes. */
378
379
380
    for (int i = 0; i < cdim[0]; i++)
      for (int j = 0; j < cdim[1]; j++)
        for (int k = 0; k < cdim[2]; k++) {
381
          struct cell *restrict c = &s->cells_top[cell_getid(cdim, i, j, k)];
382
383
384
385
386
387
          c->loc[0] = i * s->width[0];
          c->loc[1] = j * s->width[1];
          c->loc[2] = k * s->width[2];
          c->width[0] = s->width[0];
          c->width[1] = s->width[1];
          c->width[2] = s->width[2];
388
389
390
391
392
          c->dmin = dmin;
          c->depth = 0;
          c->count = 0;
          c->gcount = 0;
          c->super = c;
393
          c->ti_old = ti_current;
394
          lock_init(&c->lock);
Pedro Gonnet's avatar
Pedro Gonnet committed
395
        }
396
397

    /* Be verbose about the change. */
398
399
400
    if (verbose)
      message("set cell dimensions to [ %i %i %i ].", cdim[0], cdim[1],
              cdim[2]);
401

402
#ifdef WITH_MPI
403
404
405
406
407
    if (oldnodeIDs != NULL) {
      /* We have changed the top-level cell dimension, so need to redistribute
       * cells around the nodes. We repartition using the old space node
       * positions as a grid to resample. */
      if (s->e->nodeID == 0)
408
409
410
        message(
            "basic cell dimensions have increased - recalculating the "
            "global partition.");
411

Matthieu Schaller's avatar
Matthieu Schaller committed
412
      if (!partition_space_to_space(oldwidth, oldcdim, oldnodeIDs, s)) {
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430

        /* Failed, try another technique that requires no settings. */
        message("Failed to get a new partition, trying less optimal method");
        struct partition initial_partition;
#ifdef HAVE_METIS
        initial_partition.type = INITPART_METIS_NOWEIGHT;
#else
        initial_partition.type = INITPART_VECTORIZE;
#endif
        partition_initial_partition(&initial_partition, s->e->nodeID,
                                    s->e->nr_nodes, s);
      }

      /* Re-distribute the particles to their new nodes. */
      engine_redistribute(s->e);

      /* Make the proxies. */
      engine_makeproxies(s->e);
431

432
433
      /* Finished with these. */
      free(oldnodeIDs);
434
    }
Pedro Gonnet's avatar
Pedro Gonnet committed
435
#endif /* WITH_MPI */
436
437
438
439

    // message( "rebuilding upper-level cells took %.3f %s." ,
    // clocks_from_ticks(double)(getticks() - tic), clocks_getunit());

440
  }      /* re-build upper-level cells? */
441
  else { /* Otherwise, just clean up the cells. */
442
443

    /* Free the old cells, if they were allocated. */
444
445
    threadpool_map(&s->e->threadpool, space_rebuild_recycle_mapper,
                   s->cells_top, s->nr_cells, sizeof(struct cell), 100, s);
446
447
    s->maxdepth = 0;
  }
448
449
450
451

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
452
}
453
454
455
456
457

/**
 * @brief Re-build the cells as well as the tasks.
 *
 * @param s The #space in which to update the cells.
458
 * @param verbose Print messages to stdout or not
459
460
 *
 */
461
void space_rebuild(struct space *s, int verbose) {
462

Matthieu Schaller's avatar
Matthieu Schaller committed
463
  const ticks tic = getticks();
464
465

  /* Be verbose about this. */
466
  // message("re)building space..."); fflush(stdout);
467
468

  /* Re-grid if necessary, or just re-set the cell data. */
469
  space_regrid(s, verbose);
470

Pedro Gonnet's avatar
Pedro Gonnet committed
471
472
  size_t nr_parts = s->nr_parts;
  size_t nr_gparts = s->nr_gparts;
473
  struct cell *restrict cells_top = s->cells_top;
474
  const int ti_current = (s->e != NULL) ? s->e->ti_current : 0;
475

Pedro Gonnet's avatar
Pedro Gonnet committed
476
477
478
  /* Run through the particles and get their cell index. Allocates
     an index that is larger than the number of particles to avoid
     re-allocating after shuffling. */
479
  const size_t ind_size = s->size_parts + 100;
480
481
  int *ind;
  if ((ind = (int *)malloc(sizeof(int) * ind_size)) == NULL)
482
    error("Failed to allocate temporary particle indices.");
483
  if (s->size_parts > 0) space_parts_get_cell_index(s, ind, cells_top, verbose);
484

485
  /* Run through the gravity particles and get their cell index. */
486
  const size_t gind_size = s->size_gparts + 100;
487
488
489
  int *gind;
  if ((gind = (int *)malloc(sizeof(int) * gind_size)) == NULL)
    error("Failed to allocate temporary g-particle indices.");
Pedro Gonnet's avatar
Pedro Gonnet committed
490
491
  if (s->size_gparts > 0)
    space_gparts_get_cell_index(s, gind, cells_top, verbose);
492
493

#ifdef WITH_MPI
494

495
  /* Move non-local parts to the end of the list. */
496
  const int local_nodeID = s->e->nodeID;
497
  for (size_t k = 0; k < nr_parts;) {
498
    if (cells_top[ind[k]].nodeID != local_nodeID) {
499
      nr_parts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
500
      const struct part tp = s->parts[k];
501
502
      s->parts[k] = s->parts[nr_parts];
      s->parts[nr_parts] = tp;
503
      if (s->parts[k].gpart != NULL) {
504
        s->parts[k].gpart->id_or_neg_offset = -k;
505
506
      }
      if (s->parts[nr_parts].gpart != NULL) {
507
        s->parts[nr_parts].gpart->id_or_neg_offset = -nr_parts;
508
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
509
      const struct xpart txp = s->xparts[k];
510
511
      s->xparts[k] = s->xparts[nr_parts];
      s->xparts[nr_parts] = txp;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
512
      const int t = ind[k];
513
514
      ind[k] = ind[nr_parts];
      ind[nr_parts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
515
    } else {
516
517
518
519
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
520

521
#ifdef SWIFT_DEBUG_CHECKS
Peter W. Draper's avatar
Peter W. Draper committed
522
  /* Check that all parts are in the correct places. */
523
  for (size_t k = 0; k < nr_parts; k++) {
524
    if (cells_top[ind[k]].nodeID != local_nodeID) {
525
526
527
528
      error("Failed to move all non-local parts to send list");
    }
  }
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
529
    if (cells_top[ind[k]].nodeID == local_nodeID) {
530
      error("Failed to remove local parts from send list");
531
    }
532
533
  }
#endif
534

535
  /* Move non-local gparts to the end of the list. */
536
  for (size_t k = 0; k < nr_gparts;) {
537
    if (cells_top[gind[k]].nodeID != local_nodeID) {
538
      nr_gparts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
539
      const struct gpart tp = s->gparts[k];
540
541
      s->gparts[k] = s->gparts[nr_gparts];
      s->gparts[nr_gparts] = tp;
542
543
      if (s->gparts[k].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[k].id_or_neg_offset].gpart = &s->gparts[k];
544
      }
545
546
547
      if (s->gparts[nr_gparts].id_or_neg_offset <= 0) {
        s->parts[-s->gparts[nr_gparts].id_or_neg_offset].gpart =
            &s->gparts[nr_gparts];
548
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
549
550
551
      const int t = gind[k];
      gind[k] = gind[nr_gparts];
      gind[nr_gparts] = t;
Matthieu Schaller's avatar
Matthieu Schaller committed
552
    } else {
553
554
555
556
      /* Increment when not exchanging otherwise we need to retest "k".*/
      k++;
    }
  }
557

558
#ifdef SWIFT_DEBUG_CHECKS
559
560
  /* Check that all gparts are in the correct place (untested). */
  for (size_t k = 0; k < nr_gparts; k++) {
561
    if (cells_top[gind[k]].nodeID != local_nodeID) {
562
563
564
565
      error("Failed to move all non-local gparts to send list");
    }
  }
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
566
    if (cells_top[gind[k]].nodeID == local_nodeID) {
567
      error("Failed to remove local gparts from send list");
568
    }
569
570
  }
#endif
571

572
573
  /* Exchange the strays, note that this potentially re-allocates
     the parts arrays. */
574
  size_t nr_parts_exchanged = s->nr_parts - nr_parts;
575
  size_t nr_gparts_exchanged = s->nr_gparts - nr_gparts;
Pedro Gonnet's avatar
Pedro Gonnet committed
576
577
578
579
  engine_exchange_strays(s->e, nr_parts, &ind[nr_parts], &nr_parts_exchanged,
                         nr_gparts, &gind[nr_gparts], &nr_gparts_exchanged);

  /* Set the new particle counts. */
580
  s->nr_parts = nr_parts + nr_parts_exchanged;
581
  s->nr_gparts = nr_gparts + nr_gparts_exchanged;
582
583

  /* Re-allocate the index array if needed.. */
584
  if (s->nr_parts + 1 > ind_size) {
585
    int *ind_new;
586
    if ((ind_new = (int *)malloc(sizeof(int) * (s->nr_parts + 1))) == NULL)
587
      error("Failed to allocate temporary particle indices.");
588
    memcpy(ind_new, ind, sizeof(int) * nr_parts);
589
590
    free(ind);
    ind = ind_new;
591
592
  }

593
594
595
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
  const double ih[3] = {s->iwidth[0], s->iwidth[1], s->iwidth[2]};

596
  /* Assign each particle to its cell. */
Pedro Gonnet's avatar
Pedro Gonnet committed
597
  for (size_t k = nr_parts; k < s->nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
598
    const struct part *const p = &s->parts[k];
599
    ind[k] =
600
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
601
#ifdef SWIFT_DEBUG_CHECKS
602
    if (cells_top[ind[k]].nodeID != local_nodeID)
603
      error("Received part that does not belong to me (nodeID=%i).",
604
            cells_top[ind[k]].nodeID);
605
#endif
606
  }
607
  nr_parts = s->nr_parts;
608
609

#endif /* WITH_MPI */
610
611

  /* Sort the parts according to their cells. */
612
613
  if (nr_parts > 0)
    space_parts_sort(s, ind, nr_parts, 0, s->nr_cells - 1, verbose);
614
615

  /* Re-link the gparts. */
616
  if (nr_parts > 0 && nr_gparts > 0) part_relink_gparts(s->parts, nr_parts, 0);
617

618
#ifdef SWIFT_DEBUG_CHECKS
619
  /* Verify space_sort_struct. */
620
621
622
  for (size_t k = 1; k < nr_parts; k++) {
    if (ind[k - 1] > ind[k]) {
      error("Sort failed!");
623
    } else if (ind[k] != cell_getid(s->cdim, s->parts[k].x[0] * s->iwidth[0],
624
625
                                    s->parts[k].x[1] * s->iwidth[1],
                                    s->parts[k].x[2] * s->iwidth[2])) {
626
627
628
629
      error("Incorrect indices!");
    }
  }
#endif
630

631
632
633
634
635
636
637
638
639
640
  /* Extract the cell counts from the sorted indices. */
  size_t last_index = 0;
  ind[nr_parts] = s->nr_cells;  // sentinel.
  for (size_t k = 0; k < nr_parts; k++) {
    if (ind[k] < ind[k + 1]) {
      cells_top[ind[k]].count = k - last_index + 1;
      last_index = k + 1;
    }
  }

641
  /* We no longer need the indices as of here. */
642
  free(ind);
643

644
645
646
#ifdef WITH_MPI

  /* Re-allocate the index array if needed.. */
647
  if (s->nr_gparts + 1 > gind_size) {
648
    int *gind_new;
649
    if ((gind_new = (int *)malloc(sizeof(int) * (s->nr_gparts + 1))) == NULL)
650
      error("Failed to allocate temporary g-particle indices.");
651
    memcpy(gind_new, gind, sizeof(int) * nr_gparts);
652
653
654
655
656
    free(gind);
    gind = gind_new;
  }

  /* Assign each particle to its cell. */
657
  for (size_t k = nr_gparts; k < s->nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
658
    const struct gpart *const p = &s->gparts[k];
659
660
    gind[k] =
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
661
662

#ifdef SWIFT_DEBUG_CHECKS
663
    if (cells_top[gind[k]].nodeID != s->e->nodeID)
664
      error("Received part that does not belong to me (nodeID=%i).",
665
            cells_top[gind[k]].nodeID);
666
#endif
667
668
669
670
  }
  nr_gparts = s->nr_gparts;

#endif
671

672
  /* Sort the gparts according to their cells. */
673
674
  if (nr_gparts > 0)
    space_gparts_sort(s, gind, nr_gparts, 0, s->nr_cells - 1, verbose);
675
676

  /* Re-link the parts. */
677
678
  if (nr_parts > 0 && nr_gparts > 0)
    part_relink_parts(s->gparts, nr_gparts, s->parts);
679

680
681
  /* Extract the cell counts from the sorted indices. */
  size_t last_gindex = 0;
682
  gind[nr_gparts] = s->nr_cells;
683
684
  for (size_t k = 0; k < nr_gparts; k++) {
    if (gind[k] < gind[k + 1]) {
685
      cells_top[gind[k]].gcount = k - last_gindex + 1;
686
687
688
689
      last_gindex = k + 1;
    }
  }

690
  /* We no longer need the indices as of here. */
691
  free(gind);
692

693
#ifdef SWIFT_DEBUG_CHECKS
694
695
696
  /* Verify that the links are correct */
  for (size_t k = 0; k < nr_gparts; ++k) {

697
    if (s->gparts[k].id_or_neg_offset < 0) {
698

699
      const struct part *part = &s->parts[-s->gparts[k].id_or_neg_offset];
700

701
702
703
704
      if (part->gpart != &s->gparts[k]) error("Linking problem !");

      if (s->gparts[k].x[0] != part->x[0] || s->gparts[k].x[1] != part->x[1] ||
          s->gparts[k].x[2] != part->x[2])
705
706
707
708
709
        error("Linked particles are not at the same position !");
    }
  }
  for (size_t k = 0; k < nr_parts; ++k) {

710
    if (s->parts[k].gpart != NULL &&
711
        s->parts[k].gpart->id_or_neg_offset != -(ptrdiff_t)k) {
712
      error("Linking problem !");
713
714
    }
  }
715
#endif
716

717
718
  /* Hook the cells up to the parts. */
  // tic = getticks();
719
720
721
  struct part *finger = s->parts;
  struct xpart *xfinger = s->xparts;
  struct gpart *gfinger = s->gparts;
722
  for (int k = 0; k < s->nr_cells; k++) {
723
    struct cell *restrict c = &cells_top[k];
724
    c->ti_old = ti_current;
725
726
727
728
729
730
731
    c->parts = finger;
    c->xparts = xfinger;
    c->gparts = gfinger;
    finger = &finger[c->count];
    xfinger = &xfinger[c->count];
    gfinger = &gfinger[c->gcount];
  }
732
  // message( "hooking up cells took %.3f %s." ,
Matthieu Schaller's avatar
Matthieu Schaller committed
733
  // clocks_from_ticks(getticks() - tic), clocks_getunit());
734
735
736

  /* At this point, we have the upper-level cells, old or new. Now make
     sure that the parts in each cell are ok. */
737
  space_split(s, cells_top, s->nr_cells, verbose);
738
739
740
741
742
743
744
745
746

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Split particles between cells of a hierarchy
 *
747
748
 * This is done in parallel using threads in the #threadpool.
 *
749
 * @param s The #space.
750
751
 * @param cells The cell hierarchy.
 * @param nr_cells The number of cells.
752
753
 * @param verbose Are we talkative ?
 */
754
755
void space_split(struct space *s, struct cell *cells, int nr_cells,
                 int verbose) {
756

Matthieu Schaller's avatar
Matthieu Schaller committed
757
  const ticks tic = getticks();
758

759
  threadpool_map(&s->e->threadpool, space_split_mapper, cells, nr_cells,
760
                 sizeof(struct cell), 1, s);
761

762
763
764
  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
765
}
766

767
768
769
770
771
772
773
774
/**
 * @brief Runs through the top-level cells and checks whether tasks associated
 * with them can be split. If not, try to sanitize the cells.
 *
 * @param s The #space to act upon.
 */
void space_sanitize(struct space *s) {

775
776
  s->sanitized = 1;

777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
  for (int k = 0; k < s->nr_cells; k++) {

    struct cell *c = &s->cells_top[k];
    const double min_width = c->dmin;

    /* Do we have a problem ? */
    if (c->h_max * kernel_gamma * space_stretch > min_width * 0.5 &&
        c->count > space_maxcount) {

      /* Ok, clean-up the mess */
      cell_sanitize(c);
    }
  }
}

792
/**
793
 * @brief #threadpool mapper function to compute the particle cell indices.
794
 *
795
 * @param map_data Pointer towards the particles.
796
 * @param nr_parts The number of particles to treat.
797
 * @param extra_data Pointers to the space and index list
798
 */
799
800
void space_parts_get_cell_index_mapper(void *map_data, int nr_parts,
                                       void *extra_data) {
801

802
803
804
805
  /* Unpack the data */
  struct part *restrict parts = (struct part *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
806
  int *const ind = data->ind + (ptrdiff_t)(parts - s->parts);
807
808

  /* Get some constants */
809
810
811
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
Matthieu Schaller's avatar
Matthieu Schaller committed
812
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
813
814
815
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
816

817
  for (int k = 0; k < nr_parts; k++) {
818
819
820
821

    /* Get the particle */
    struct part *restrict p = &parts[k];

822
823
824
825
    const double old_pos_x = p->x[0];
    const double old_pos_y = p->x[1];
    const double old_pos_z = p->x[2];

826
    /* Put it back into the simulation volume */
827
828
829
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
830
831

    /* Get its cell index */
Matthieu Schaller's avatar
Matthieu Schaller committed
832
833
    const int index =
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
834
    ind[k] = index;
835

836
837
838
839
    /* Update the position */
    p->x[0] = pos_x;
    p->x[1] = pos_y;
    p->x[2] = pos_z;
840
841
842
843
  }
}

/**
844
 * @brief #threadpool mapper function to compute the g-particle cell indices.
845
 *
846
 * @param map_data Pointer towards the g-particles.
847
 * @param nr_gparts The number of g-particles to treat.
848
 * @param extra_data Pointers to the space and index list
849
 */
850
851
void space_gparts_get_cell_index_mapper(void *map_data, int nr_gparts,
                                        void *extra_data) {
852

853
854
855
856
  /* Unpack the data */
  struct gpart *restrict gparts = (struct gpart *)map_data;
  struct index_data *data = (struct index_data *)extra_data;
  struct space *s = data->s;
857
  int *const ind = data->ind + (ptrdiff_t)(gparts - s->gparts);
858
859

  /* Get some constants */
Matthieu Schaller's avatar
Matthieu Schaller committed
860
861
862
  const double dim_x = s->dim[0];
  const double dim_y = s->dim[1];
  const double dim_z = s->dim[2];
863
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
Matthieu Schaller's avatar
Matthieu Schaller committed
864
865
866
  const double ih_x = s->iwidth[0];
  const double ih_y = s->iwidth[1];
  const double ih_z = s->iwidth[2];
867

868
  for (int k = 0; k < nr_gparts; k++) {
869
870
871
872

    /* Get the particle */
    struct gpart *restrict gp = &gparts[k];

Matthieu Schaller's avatar
Matthieu Schaller committed
873
874
875
876
    const double old_pos_x = gp->x[0];
    const double old_pos_y = gp->x[1];
    const double old_pos_z = gp->x[2];

877
    /* Put it back into the simulation volume */
Matthieu Schaller's avatar
Matthieu Schaller committed
878
879
880
    const double pos_x = box_wrap(old_pos_x, 0.0, dim_x);
    const double pos_y = box_wrap(old_pos_y, 0.0, dim_y);
    const double pos_z = box_wrap(old_pos_z, 0.0, dim_z);
881
882
883

    /* Get its cell index */
    const int index =
Matthieu Schaller's avatar
Matthieu Schaller committed
884
        cell_getid(cdim, pos_x * ih_x, pos_y * ih_y, pos_z * ih_z);
885
    ind[k] = index;
Matthieu Schaller's avatar
Matthieu Schaller committed
886
887
888
889
890

    /* Update the position */
    gp->x[0] = pos_x;
    gp->x[1] = pos_y;
    gp->x[2] = pos_z;
891
892
893
  }
}

894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
/**
 * @brief Computes the cell index of all the particles and update the cell
 * count.
 *
 * @param s The #space.
 * @param ind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_parts_get_cell_index(struct space *s, int *ind, struct cell *cells,
                                int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = ind;

  threadpool_map(&s->e->threadpool, space_parts_get_cell_index_mapper, s->parts,
                 s->nr_parts, sizeof(struct part), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Computes the cell index of all the g-particles and update the cell
 * gcount.
 *
 * @param s The #space.
 * @param gind The array of indices to fill.
 * @param cells The array of #cell to update.
 * @param verbose Are we talkative ?
 */
void space_gparts_get_cell_index(struct space *s, int *gind, struct cell *cells,
                                 int verbose) {

  const ticks tic = getticks();

  /* Pack the extra information */
  struct index_data data;
  data.s = s;
  data.cells = cells;
  data.ind = gind;

  threadpool_map(&s->e->threadpool, space_gparts_get_cell_index_mapper,
                 s->gparts, s->nr_gparts, sizeof(struct gpart), 1000, &data);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

950
/**
951
 * @brief Sort the particles and condensed particles according to the given
952
 * indices.
953
 *
Matthieu Schaller's avatar
Matthieu Schaller committed
954
 * @param s The #space.
955
956
957
958
 * @param ind The indices with respect to which the parts are sorted.
 * @param N The number of parts
 * @param min Lowest index.
 * @param max highest index.
959
 * @param verbose Are we talkative ?
960
 */
961
void space_parts_sort(struct space *s, int *ind, size_t N, int min, int max,
962
963
                      int verbose) {

Matthieu Schaller's avatar
Matthieu Schaller committed
964
  const ticks tic = getticks();
965

966
967
968
969
970
971
  /* Populate a parallel_sort structure with the input data */
  struct parallel_sort sort_struct;
  sort_struct.parts = s->parts;
  sort_struct.xparts = s->xparts;
  sort_struct.ind = ind;
  sort_struct.stack_size = 2 * (max - min + 1) + 10 + s->e->nr_threads;
972
973
  if ((sort_struct.stack =
           malloc(sizeof(struct qstack) * sort_struct.stack_size)) == NULL)
974
    error("Failed to allocate sorting stack.");
Matthieu Schaller's avatar
Matthieu Schaller committed
975
  for (unsigned int i = 0; i < sort_struct.stack_size; i++)
976
    sort_struct.stack[i].ready = 0;
977