space.c 39.5 KB
Newer Older
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
/*******************************************************************************
* This file is part of SWIFT.
* Copyright (c) 2012 Pedro Gonnet (pedro.gonnet@durham.ac.uk)
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published
* by the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program.  If not, see <http://www.gnu.org/licenses/>.
*
******************************************************************************/
Pedro Gonnet's avatar
Pedro Gonnet committed
19
20
21
22
23
24
25
26

/* Config parameters. */
#include "../config.h"

/* Some standard headers. */
#include <float.h>
#include <limits.h>
#include <math.h>
27
#include <string.h>
28
#include <stdlib.h>
Pedro Gonnet's avatar
Pedro Gonnet committed
29

30
31
/* MPI headers. */
#ifdef WITH_MPI
32
#include <mpi.h>
33
34
#endif

35
36
37
/* This object's header. */
#include "space.h"

Pedro Gonnet's avatar
Pedro Gonnet committed
38
/* Local headers. */
39
#include "atomic.h"
40
#include "engine.h"
41
#include "error.h"
42
43
#include "kernel.h"
#include "lock.h"
44
#include "minmax.h"
45
#include "runner.h"
Pedro Gonnet's avatar
Pedro Gonnet committed
46

47
48
49
/* Shared sort structure. */
struct parallel_sort space_sort_struct;

Pedro Gonnet's avatar
Pedro Gonnet committed
50
51
/* Split size. */
int space_splitsize = space_splitsize_default;
52
int space_subsize = space_subsize_default;
53
int space_maxsize = space_maxsize_default;
Pedro Gonnet's avatar
Pedro Gonnet committed
54
55
56

/* Map shift vector to sortlist. */
const int sortlistID[27] = {
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
    /* ( -1 , -1 , -1 ) */ 0,
    /* ( -1 , -1 ,  0 ) */ 1,
    /* ( -1 , -1 ,  1 ) */ 2,
    /* ( -1 ,  0 , -1 ) */ 3,
    /* ( -1 ,  0 ,  0 ) */ 4,
    /* ( -1 ,  0 ,  1 ) */ 5,
    /* ( -1 ,  1 , -1 ) */ 6,
    /* ( -1 ,  1 ,  0 ) */ 7,
    /* ( -1 ,  1 ,  1 ) */ 8,
    /* (  0 , -1 , -1 ) */ 9,
    /* (  0 , -1 ,  0 ) */ 10,
    /* (  0 , -1 ,  1 ) */ 11,
    /* (  0 ,  0 , -1 ) */ 12,
    /* (  0 ,  0 ,  0 ) */ 0,
    /* (  0 ,  0 ,  1 ) */ 12,
    /* (  0 ,  1 , -1 ) */ 11,
    /* (  0 ,  1 ,  0 ) */ 10,
    /* (  0 ,  1 ,  1 ) */ 9,
    /* (  1 , -1 , -1 ) */ 8,
    /* (  1 , -1 ,  0 ) */ 7,
    /* (  1 , -1 ,  1 ) */ 6,
    /* (  1 ,  0 , -1 ) */ 5,
    /* (  1 ,  0 ,  0 ) */ 4,
    /* (  1 ,  0 ,  1 ) */ 3,
    /* (  1 ,  1 , -1 ) */ 2,
    /* (  1 ,  1 ,  0 ) */ 1,
    /* (  1 ,  1 ,  1 ) */ 0};

85
86
87
88
89
90
91
92
93
94
95
96
/**
 * @brief Get the shift-id of the given pair of cells, swapping them
 *      if need be.
 *
 * @param s The space
 * @param ci Pointer to first #cell.
 * @param cj Pointer second #cell.
 * @param shift Vector from ci to cj.
 *
 * @return The shift ID and set shift, may or may not swap ci and cj.
 */

97
98
99
100
int space_getsid(struct space *s, struct cell **ci, struct cell **cj,
                 double *shift) {

  /* Get the relative distance between the pairs, wrapping. */
101
102
103
  const int periodic = s->periodic;
  double dx[3];
  for (int k = 0; k < 3; k++) {
104
105
106
107
108
109
110
111
112
113
114
    dx[k] = (*cj)->loc[k] - (*ci)->loc[k];
    if (periodic && dx[k] < -s->dim[k] / 2)
      shift[k] = s->dim[k];
    else if (periodic && dx[k] > s->dim[k] / 2)
      shift[k] = -s->dim[k];
    else
      shift[k] = 0.0;
    dx[k] += shift[k];
  }

  /* Get the sorting index. */
115
  int sid = 0;
116
  for (int k = 0; k < 3; k++)
117
118
119
120
    sid = 3 * sid + ((dx[k] < 0.0) ? 0 : ((dx[k] > 0.0) ? 2 : 1));

  /* Switch the cells around? */
  if (runner_flip[sid]) {
121
    struct cell *temp = *ci;
122
123
    *ci = *cj;
    *cj = temp;
124
    for (int k = 0; k < 3; k++) shift[k] = -shift[k];
125
126
127
128
129
130
  }
  sid = sortlistID[sid];

  /* Return the sort ID. */
  return sid;
}
131

132
/**
133
 * @brief Recursively dismantle a cell tree.
134
135
 *
 */
136
137
138
139

void space_rebuild_recycle(struct space *s, struct cell *c) {

  if (c->split)
140
    for (int k = 0; k < 8; k++)
141
142
143
144
145
146
147
      if (c->progeny[k] != NULL) {
        space_rebuild_recycle(s, c->progeny[k]);
        space_recycle(s, c->progeny[k]);
        c->progeny[k] = NULL;
      }
}

148
/**
149
 * @brief Re-build the cell grid.
150
 *
151
152
 * @param s The #space.
 * @param cell_max Maximum cell edge length.
153
 * @param verbose Print messages to stdout or not.
154
 */
155

156
void space_regrid(struct space *s, double cell_max, int verbose) {
157

158
159
  float h_max = s->cell_min / kernel_gamma / space_stretch;
  const size_t nr_parts = s->nr_parts;
160
  struct cell *restrict c;
161
  ticks tic = getticks();
162
163
164

  /* Run through the parts and get the current h_max. */
  // tic = getticks();
165
  if (nr_parts > 0) {
166
    if (s->cells != NULL) {
Tom Theuns's avatar
Tom Theuns committed
167
      for (int k = 0; k < s->nr_cells; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
168
        if (s->cells[k].h_max > h_max) h_max = s->cells[k].h_max;
169
170
      }
    } else {
Tom Theuns's avatar
Tom Theuns committed
171
      for (int k = 0; k < nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
172
        if (s->parts[k].h > h_max) h_max = s->parts[k].h;
173
174
      }
      s->h_max = h_max;
175
    }
Matthieu Schaller's avatar
Matthieu Schaller committed
176
177
178
  } else {
    /* It would be nice to replace this with something more physical or
     * meaningful */
179
    h_max = s->dim[0] / 16.f;
180
181
182
183
184
185
186
187
188
189
    s->h_max = h_max;
  }

/* If we are running in parallel, make sure everybody agrees on
   how large the largest cell should be. */
#ifdef WITH_MPI
  {
    float buff;
    if (MPI_Allreduce(&h_max, &buff, 1, MPI_FLOAT, MPI_MAX, MPI_COMM_WORLD) !=
        MPI_SUCCESS)
190
      error("Failed to aggregate the rebuild flag across nodes.");
191
192
193
    h_max = buff;
  }
#endif
194
  if (verbose) message("h_max is %.3e (cell_max=%.3e).", h_max, cell_max);
195
196

  /* Get the new putative cell dimensions. */
197
  int cdim[3];
198
  for (int k = 0; k < 3; k++)
199
200
201
202
203
204
205
206
207
208
209
210
211
212
    cdim[k] =
        floor(s->dim[k] / fmax(h_max * kernel_gamma * space_stretch, cell_max));

  /* Check if we have enough cells for periodicity. */
  if (s->periodic && (cdim[0] < 3 || cdim[1] < 3 || cdim[2] < 3))
    error(
        "Must have at least 3 cells in each spatial dimension when periodicity "
        "is switched on.");

/* In MPI-Land, we're not allowed to change the top-level cell size. */
#ifdef WITH_MPI
  if (cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] || cdim[2] < s->cdim[2])
    error("Root-level change of cell size not allowed.");
#endif
213

214
215
216
217
218
219
220
  /* Do we need to re-build the upper-level cells? */
  // tic = getticks();
  if (s->cells == NULL || cdim[0] < s->cdim[0] || cdim[1] < s->cdim[1] ||
      cdim[2] < s->cdim[2]) {

    /* Free the old cells, if they were allocated. */
    if (s->cells != NULL) {
221
      for (int k = 0; k < s->nr_cells; k++) {
222
223
224
225
226
227
228
229
        space_rebuild_recycle(s, &s->cells[k]);
        if (s->cells[k].sort != NULL) free(s->cells[k].sort);
      }
      free(s->cells);
      s->maxdepth = 0;
    }

    /* Set the new cell dimensions only if smaller. */
230
    for (int k = 0; k < 3; k++) {
231
232
233
234
      s->cdim[k] = cdim[k];
      s->h[k] = s->dim[k] / cdim[k];
      s->ih[k] = 1.0 / s->h[k];
    }
235
    const float dmin = fminf(s->h[0], fminf(s->h[1], s->h[2]));
236
237
238
239
240
241
242

    /* Allocate the highest level of cells. */
    s->tot_cells = s->nr_cells = cdim[0] * cdim[1] * cdim[2];
    if (posix_memalign((void *)&s->cells, 64,
                       s->nr_cells * sizeof(struct cell)) != 0)
      error("Failed to allocate cells.");
    bzero(s->cells, s->nr_cells * sizeof(struct cell));
243
    for (int k = 0; k < s->nr_cells; k++)
244
245
246
      if (lock_init(&s->cells[k].lock) != 0) error("Failed to init spinlock.");

    /* Set the cell location and sizes. */
247
248
249
    for (int i = 0; i < cdim[0]; i++)
      for (int j = 0; j < cdim[1]; j++)
        for (int k = 0; k < cdim[2]; k++) {
250
251
252
253
254
255
256
257
258
259
260
261
262
          c = &s->cells[cell_getid(cdim, i, j, k)];
          c->loc[0] = i * s->h[0];
          c->loc[1] = j * s->h[1];
          c->loc[2] = k * s->h[2];
          c->h[0] = s->h[0];
          c->h[1] = s->h[1];
          c->h[2] = s->h[2];
          c->dmin = dmin;
          c->depth = 0;
          c->count = 0;
          c->gcount = 0;
          c->super = c;
          lock_init(&c->lock);
Pedro Gonnet's avatar
Pedro Gonnet committed
263
        }
264
265

    /* Be verbose about the change. */
266
267
268
    if (verbose)
      message("set cell dimensions to [ %i %i %i ].", cdim[0], cdim[1],
              cdim[2]);
269
270
271
    fflush(stdout);

  } /* re-build upper-level cells? */
272
273
  // message( "rebuilding upper-level cells took %.3f %s." ,
  // clocks_from_ticks(double)(getticks() - tic), clocks_getunit());
274
275
276
277
278

  /* Otherwise, just clean up the cells. */
  else {

    /* Free the old cells, if they were allocated. */
279
    for (int k = 0; k < s->nr_cells; k++) {
280
281
282
283
284
285
286
287
288
289
290
      space_rebuild_recycle(s, &s->cells[k]);
      s->cells[k].sorts = NULL;
      s->cells[k].nr_tasks = 0;
      s->cells[k].nr_density = 0;
      s->cells[k].nr_force = 0;
      s->cells[k].density = NULL;
      s->cells[k].force = NULL;
      s->cells[k].dx_max = 0.0f;
      s->cells[k].sorted = 0;
      s->cells[k].count = 0;
      s->cells[k].gcount = 0;
Matthieu Schaller's avatar
Matthieu Schaller committed
291
      s->cells[k].init = NULL;
Matthieu Schaller's avatar
Matthieu Schaller committed
292
      s->cells[k].ghost = NULL;
Matthieu Schaller's avatar
Matthieu Schaller committed
293
294
      s->cells[k].drift = NULL;
      s->cells[k].kick = NULL;
295
      s->cells[k].super = &s->cells[k];
296
    }
297
298
    s->maxdepth = 0;
  }
299
300
301
302

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
303
}
304
305
306
307
308
309

/**
 * @brief Re-build the cells as well as the tasks.
 *
 * @param s The #space in which to update the cells.
 * @param cell_max Maximal cell size.
310
 * @param verbose Print messages to stdout or not
311
312
 *
 */
313

314
void space_rebuild(struct space *s, double cell_max, int verbose) {
315

Matthieu Schaller's avatar
Matthieu Schaller committed
316
  const ticks tic = getticks();
317
318

  /* Be verbose about this. */
319
  // message("re)building space..."); fflush(stdout);
320
321

  /* Re-grid if necessary, or just re-set the cell data. */
322
  space_regrid(s, cell_max, verbose);
323

324
325
326
327
  int nr_parts = s->nr_parts;
  int nr_gparts = s->nr_gparts;
  struct cell *restrict cells = s->cells;

Matthieu Schaller's avatar
Matthieu Schaller committed
328
329
330
  const double ih[3] = {s->ih[0], s->ih[1], s->ih[2]};
  const double dim[3] = {s->dim[0], s->dim[1], s->dim[2]};
  const int cdim[3] = {s->cdim[0], s->cdim[1], s->cdim[2]};
331
332
333
334

  /* Run through the particles and get their cell index. */
  // tic = getticks();
  const size_t ind_size = s->size_parts;
335
336
  int *ind;
  if ((ind = (int *)malloc(sizeof(int) * ind_size)) == NULL)
337
338
339
340
    error("Failed to allocate temporary particle indices.");
  for (int k = 0; k < nr_parts; k++) {
    struct part *restrict p = &s->parts[k];
    for (int j = 0; j < 3; j++)
341
342
343
344
      if (p->x[j] < 0.0)
        p->x[j] += dim[j];
      else if (p->x[j] >= dim[j])
        p->x[j] -= dim[j];
345
    ind[k] =
346
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
Matthieu Schaller's avatar
Matthieu Schaller committed
347
    cells[ind[k]].count++;
348
  }
Pedro Gonnet's avatar
Pedro Gonnet committed
349
350
  // message( "getting particle indices took %.3f %s." ,
  // clocks_from_ticks(getticks() - tic), clocks_getunit()):
351

352
353
354
355
356
357
358
  /* Run through the gravity particles and get their cell index. */
  // tic = getticks();
  const size_t gind_size = s->size_gparts;
  int *gind;
  if ((gind = (int *)malloc(sizeof(int) * gind_size)) == NULL)
    error("Failed to allocate temporary g-particle indices.");
  for (int k = 0; k < nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
359
    struct gpart *restrict gp = &s->gparts[k];
360
361
362
363
364
365
366
367
368
    for (int j = 0; j < 3; j++)
      if (gp->x[j] < 0.0)
        gp->x[j] += dim[j];
      else if (gp->x[j] >= dim[j])
        gp->x[j] -= dim[j];
    gind[k] =
        cell_getid(cdim, gp->x[0] * ih[0], gp->x[1] * ih[1], gp->x[2] * ih[2]);
    cells[gind[k]].gcount++;
  }
Matthieu Schaller's avatar
Matthieu Schaller committed
369
// message( "getting particle indices took %.3f %s." ,
370
// clocks_from_ticks(getticks() - tic), clocks_getunit());
371
372
373

#ifdef WITH_MPI
  /* Move non-local parts to the end of the list. */
374
  const int local_nodeID = s->e->nodeID;
375
  for (int k = 0; k < nr_parts; k++)
376
    if (cells[ind[k]].nodeID != local_nodeID) {
377
378
      cells[ind[k]].count -= 1;
      nr_parts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
379
      const struct part tp = s->parts[k];
380
381
      s->parts[k] = s->parts[nr_parts];
      s->parts[nr_parts] = tp;
382
383
384
385
386
387
      if (s->parts[k].gpart != NULL) {
        s->parts[k].gpart->part = &s->parts[k];
      }
      if (s->parts[nr_parts].gpart != NULL) {
        s->parts[nr_parts].gpart->part = &s->parts[nr_parts];
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
388
      const struct xpart txp = s->xparts[k];
389
390
      s->xparts[k] = s->xparts[nr_parts];
      s->xparts[nr_parts] = txp;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
391
      const int t = ind[k];
392
393
      ind[k] = ind[nr_parts];
      ind[nr_parts] = t;
394
395
    }

396
397
  /* Move non-local gparts to the end of the list. */
  for (int k = 0; k < nr_gparts; k++)
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
398
399
    if (cells[gind[k]].nodeID != local_nodeID) {
      cells[gind[k]].gcount -= 1;
400
      nr_gparts -= 1;
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
401
      const struct gpart tp = s->gparts[k];
402
403
      s->gparts[k] = s->gparts[nr_gparts];
      s->gparts[nr_gparts] = tp;
404
405
406
407
408
409
      if (s->gparts[k].id > 0) {
        s->gparts[k].part->gpart = &s->gparts[k];
      }
      if (s->gparts[nr_gparts].id > 0) {
        s->gparts[nr_gparts].part->gpart = &s->gparts[nr_gparts];
      }
Matthieu Schaller's avatar
Bug fix    
Matthieu Schaller committed
410
411
412
      const int t = gind[k];
      gind[k] = gind[nr_gparts];
      gind[nr_gparts] = t;
413
414
    }

415
416
  /* Exchange the strays, note that this potentially re-allocates
     the parts arrays. */
417
418
419
  /* TODO: This function also exchanges gparts, but this is shorted-out
     until they are fully implemented. */
  size_t nr_parts_exchanged = s->nr_parts - nr_parts;
420
  size_t nr_gparts_exchanged = s->nr_gparts - nr_gparts;
Pedro Gonnet's avatar
Pedro Gonnet committed
421
422
423
  engine_exchange_strays(s->e, nr_parts, &ind[nr_parts], &nr_parts_exchanged,
                         nr_gparts, &gind[nr_gparts], &nr_gparts_exchanged);

424
  /* Add post-processing, i.e. re-linking/creating of gparts here. */
Pedro Gonnet's avatar
Pedro Gonnet committed
425
426

  /* Set the new particle counts. */
427
  s->nr_parts = nr_parts + nr_parts_exchanged;
428
  s->nr_gparts = nr_gparts + nr_gparts_exchanged;
429
430

  /* Re-allocate the index array if needed.. */
431
  if (s->nr_parts > ind_size) {
432
433
    int *ind_new;
    if ((ind_new = (int *)malloc(sizeof(int) * s->nr_parts)) == NULL)
434
      error("Failed to allocate temporary particle indices.");
435
    memcpy(ind_new, ind, sizeof(size_t) * nr_parts);
436
437
    free(ind);
    ind = ind_new;
438
439
440
  }

  /* Assign each particle to its cell. */
441
  for (int k = nr_parts; k < s->nr_parts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
442
    const struct part *const p = &s->parts[k];
443
    ind[k] =
444
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
445
446
447
448
    cells[ind[k]].count += 1;
    /* if ( cells[ ind[k] ].nodeID != nodeID )
        error( "Received part that does not belong to me (nodeID=%i)." , cells[
       ind[k] ].nodeID ); */
449
  }
450
  nr_parts = s->nr_parts;
451
452
453
#endif

  /* Sort the parts according to their cells. */
454
  space_parts_sort(s, ind, nr_parts, 0, s->nr_cells - 1, verbose);
455

456
  /* Re-link the gparts. */
457
  for (int k = 0; k < nr_parts; k++)
458
    if (s->parts[k].gpart != NULL) s->parts[k].gpart->part = &s->parts[k];
459

460
  /* Verify space_sort_struct. */
461
  /* for ( k = 1 ; k < nr_parts ; k++ ) {
462
      if ( ind[k-1] > ind[k] ) {
463
464
          error( "Sort failed!" );
          }
465
      else if ( ind[k] != cell_getid( cdim , parts[k].x[0]*ih[0] ,
466
467
468
469
470
     parts[k].x[1]*ih[1] , parts[k].x[2]*ih[2] ) )
          error( "Incorrect indices!" );
      } */

  /* We no longer need the indices as of here. */
471
  free(ind);
472

Tom Theuns's avatar
Tom Theuns committed
473
#ifdef WITH_MPI
474
475
476

  /* Re-allocate the index array if needed.. */
  if (s->nr_gparts > gind_size) {
477
478
    int *gind_new;
    if ((gind_new = (int *)malloc(sizeof(int) * s->nr_gparts)) == NULL)
479
      error("Failed to allocate temporary g-particle indices.");
480
    memcpy(gind_new, gind, sizeof(int) * nr_gparts);
481
482
483
484
485
    free(gind);
    gind = gind_new;
  }

  /* Assign each particle to its cell. */
486
  for (int k = nr_gparts; k < s->nr_gparts; k++) {
Matthieu Schaller's avatar
Matthieu Schaller committed
487
    const struct gpart *const p = &s->gparts[k];
488
489
    gind[k] =
        cell_getid(cdim, p->x[0] * ih[0], p->x[1] * ih[1], p->x[2] * ih[2]);
Matthieu Schaller's avatar
Typo    
Matthieu Schaller committed
490
    cells[gind[k]].gcount += 1;
491
492
493
494
495
496
    /* if ( cells[ ind[k] ].nodeID != nodeID )
        error( "Received part that does not belong to me (nodeID=%i)." , cells[
       ind[k] ].nodeID ); */
  }
  nr_gparts = s->nr_gparts;

Tom Theuns's avatar
Tom Theuns committed
497
#endif
498
499

  /* Sort the parts according to their cells. */
500
  space_gparts_sort(s->gparts, gind, nr_gparts, 0, s->nr_cells - 1);
501
502

  /* Re-link the parts. */
503
  for (int k = 0; k < nr_gparts; k++)
504
    if (s->gparts[k].id > 0) s->gparts[k].part->gpart = &s->gparts[k];
505
506

  /* We no longer need the indices as of here. */
507
  free(gind);
508

509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
  /* Verify that the links are correct */
  /* MATTHIEU: To be commented out once we are happy */
  for (size_t k = 0; k < nr_gparts; ++k) {

    if (s->gparts[k].id > 0) {

      if (s->gparts[k].part->gpart != &s->gparts[k]) error("Linking problem !");

      if (s->gparts[k].x[0] != s->gparts[k].part->x[0] ||
          s->gparts[k].x[1] != s->gparts[k].part->x[1] ||
          s->gparts[k].x[2] != s->gparts[k].part->x[2])
        error("Linked particles are not at the same position !");
    }
  }
  for (size_t k = 0; k < nr_parts; ++k) {

    if (s->parts[k].gpart != NULL) {

      if (s->parts[k].gpart->part != &s->parts[k]) error("Linking problem !");
    }
  }

531
532
  /* Hook the cells up to the parts. */
  // tic = getticks();
533
534
535
  struct part *finger = s->parts;
  struct xpart *xfinger = s->xparts;
  struct gpart *gfinger = s->gparts;
536
537
  for (int k = 0; k < s->nr_cells; k++) {
    struct cell *restrict c = &cells[k];
538
539
540
541
542
543
544
    c->parts = finger;
    c->xparts = xfinger;
    c->gparts = gfinger;
    finger = &finger[c->count];
    xfinger = &xfinger[c->count];
    gfinger = &gfinger[c->gcount];
  }
545
  // message( "hooking up cells took %.3f %s." ,
Matthieu Schaller's avatar
Matthieu Schaller committed
546
  // clocks_from_ticks(getticks() - tic), clocks_getunit());
547
548
549

  /* At this point, we have the upper-level cells, old or new. Now make
     sure that the parts in each cell are ok. */
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
  space_split(s, cells, verbose);

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
}

/**
 * @brief Split particles between cells of a hierarchy
 *
 * @param s The #space.
 * @param cells The cell hierarchy
 * @param verbose Are we talkative ?
 */
void space_split(struct space *s, struct cell *cells, int verbose) {

Matthieu Schaller's avatar
Matthieu Schaller committed
566
  const ticks tic = getticks();
567
568

  for (int k = 0; k < s->nr_cells; k++)
569
570
    scheduler_addtask(&s->e->sched, task_type_split_cell, task_subtype_none, k,
                      0, &cells[k], NULL, 0);
571
  engine_launch(s->e, s->e->nr_threads, 1 << task_type_split_cell, 0);
572

573
574
575
  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
576
}
577

578
/**
579
580
 * @brief Sort the particles and condensed particles according to the given
 *indices.
581
 *
Matthieu Schaller's avatar
Matthieu Schaller committed
582
 * @param s The #space.
583
584
585
586
 * @param ind The indices with respect to which the parts are sorted.
 * @param N The number of parts
 * @param min Lowest index.
 * @param max highest index.
587
 * @param verbose Are we talkative ?
588
 */
589

590
void space_parts_sort(struct space *s, int *ind, size_t N, int min, int max,
591
592
593
594
595
                      int verbose) {

  ticks tic = getticks();

  /*Populate the global parallel_sort structure with the input data */
596
597
598
  space_sort_struct.parts = s->parts;
  space_sort_struct.xparts = s->xparts;
  space_sort_struct.ind = ind;
599
  space_sort_struct.stack_size = 2 * (max - min + 1) + 10 + s->e->nr_threads;
600
601
602
603
604
605
  if ((space_sort_struct.stack = malloc(sizeof(struct qstack) *
                                        space_sort_struct.stack_size)) == NULL)
    error("Failed to allocate sorting stack.");
  for (int i = 0; i < space_sort_struct.stack_size; i++)
    space_sort_struct.stack[i].ready = 0;

606
  /* Add the first interval. */
607
608
609
610
611
612
613
614
615
  space_sort_struct.stack[0].i = 0;
  space_sort_struct.stack[0].j = N - 1;
  space_sort_struct.stack[0].min = min;
  space_sort_struct.stack[0].max = max;
  space_sort_struct.stack[0].ready = 1;
  space_sort_struct.first = 0;
  space_sort_struct.last = 1;
  space_sort_struct.waiting = 1;

616
  /* Launch the sorting tasks. */
617
  engine_launch(s->e, s->e->nr_threads, (1 << task_type_psort), 0);
618
619

  /* Verify space_sort_struct. */
620
  /* for (int i = 1; i < N; i++)
621
    if (ind[i - 1] > ind[i])
622
623
      error("Sorting failed (ind[%i]=%i,ind[%i]=%i), min=%i, max=%i.", i - 1,
  ind[i - 1], i,
624
625
            ind[i], min, max);
  message("Sorting succeeded."); */
626

627
  /* Clean up. */
628
  free(space_sort_struct.stack);
629
630
631
632

  if (verbose)
    message("took %.3f %s.", clocks_from_ticks(getticks() - tic),
            clocks_getunit());
633
}
634

635
void space_do_parts_sort() {
636

637
  /* Pointers to the sorting data. */
638
  int *ind = space_sort_struct.ind;
639
640
  struct part *parts = space_sort_struct.parts;
  struct xpart *xparts = space_sort_struct.xparts;
641

642
  /* Main loop. */
643
  while (space_sort_struct.waiting) {
644

645
    /* Grab an interval off the queue. */
646
647
    int qid =
        atomic_inc(&space_sort_struct.first) % space_sort_struct.stack_size;
648

649
    /* Wait for the entry to be ready, or for the sorting do be done. */
650
651
    while (!space_sort_struct.stack[qid].ready)
      if (!space_sort_struct.waiting) return;
652

653
    /* Get the stack entry. */
654
655
    ptrdiff_t i = space_sort_struct.stack[qid].i;
    ptrdiff_t j = space_sort_struct.stack[qid].j;
656
657
    int min = space_sort_struct.stack[qid].min;
    int max = space_sort_struct.stack[qid].max;
658
    space_sort_struct.stack[qid].ready = 0;
659

660
661
    /* Loop over sub-intervals. */
    while (1) {
662

663
      /* Bring beer. */
664
      const int pivot = (min + max) / 2;
665
666
      /* message("Working on interval [%i,%i] with min=%i, max=%i, pivot=%i.",
              i, j, min, max, pivot); */
667
668

      /* One pass of QuickSort's partitioning. */
669
670
      ptrdiff_t ii = i;
      ptrdiff_t jj = j;
671
672
673
674
      while (ii < jj) {
        while (ii <= j && ind[ii] <= pivot) ii++;
        while (jj >= i && ind[jj] > pivot) jj--;
        if (ii < jj) {
675
          size_t temp_i = ind[ii];
676
677
          ind[ii] = ind[jj];
          ind[jj] = temp_i;
678
          struct part temp_p = parts[ii];
679
680
          parts[ii] = parts[jj];
          parts[jj] = temp_p;
681
          struct xpart temp_xp = xparts[ii];
682
683
684
685
          xparts[ii] = xparts[jj];
          xparts[jj] = temp_xp;
        }
      }
686

687
      /* Verify space_sort_struct. */
688
689
690
691
692
693
694
695
696
697
698
699
      /* for (int k = i; k <= jj; k++)
        if (ind[k] > pivot) {
          message("sorting failed at k=%i, ind[k]=%i, pivot=%i, i=%i, j=%i.", k,
                  ind[k], pivot, i, j);
          error("Partition failed (<=pivot).");
        }
      for (int k = jj + 1; k <= j; k++)
        if (ind[k] <= pivot) {
          message("sorting failed at k=%i, ind[k]=%i, pivot=%i, i=%i, j=%i.", k,
                  ind[k], pivot, i, j);
          error("Partition failed (>pivot).");
        } */
700
701
702
703
704
705

      /* Split-off largest interval. */
      if (jj - i > j - jj + 1) {

        /* Recurse on the left? */
        if (jj > i && pivot > min) {
706
707
          qid = atomic_inc(&space_sort_struct.last) %
                space_sort_struct.stack_size;
708
709
          while (space_sort_struct.stack[qid].ready)
            ;
710
711
712
713
714
715
716
          space_sort_struct.stack[qid].i = i;
          space_sort_struct.stack[qid].j = jj;
          space_sort_struct.stack[qid].min = min;
          space_sort_struct.stack[qid].max = pivot;
          if (atomic_inc(&space_sort_struct.waiting) >=
              space_sort_struct.stack_size)
            error("Qstack overflow.");
717
          space_sort_struct.stack[qid].ready = 1;
718
        }
719

720
721
722
723
724
725
726
727
728
729
        /* Recurse on the right? */
        if (jj + 1 < j && pivot + 1 < max) {
          i = jj + 1;
          min = pivot + 1;
        } else
          break;

      } else {

        /* Recurse on the right? */
730
        if (pivot + 1 < max) {
731
732
          qid = atomic_inc(&space_sort_struct.last) %
                space_sort_struct.stack_size;
733
734
          while (space_sort_struct.stack[qid].ready)
            ;
735
736
737
738
739
740
741
          space_sort_struct.stack[qid].i = jj + 1;
          space_sort_struct.stack[qid].j = j;
          space_sort_struct.stack[qid].min = pivot + 1;
          space_sort_struct.stack[qid].max = max;
          if (atomic_inc(&space_sort_struct.waiting) >=
              space_sort_struct.stack_size)
            error("Qstack overflow.");
742
          space_sort_struct.stack[qid].ready = 1;
743
        }
744

745
746
747
748
749
750
751
        /* Recurse on the left? */
        if (jj > i && pivot > min) {
          j = jj;
          max = pivot;
        } else
          break;
      }
752

753
754
    } /* loop over sub-intervals. */

755
    atomic_dec(&space_sort_struct.waiting);
756
757

  } /* main loop. */
758
759
}

760
void space_gparts_sort(struct gpart *gparts, int *ind, size_t N, int min,
761
                       int max) {
762
763

  struct qstack {
764
765
    volatile size_t i, j;
    volatile int min, max;
766
767
768
769
770
771
772
    volatile int ready;
  };
  struct qstack *qstack;
  int qstack_size = 2 * (max - min) + 10;
  volatile unsigned int first, last, waiting;

  int pivot;
773
  ptrdiff_t i, ii, j, jj, temp_i;
774
  int qid;
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
  struct gpart temp_p;

  /* for ( int k = 0 ; k < N ; k++ )
      if ( ind[k] > max || ind[k] < min )
          error( "ind[%i]=%i is not in [%i,%i]." , k , ind[k] , min , max ); */

  /* Allocate the stack. */
  if ((qstack = malloc(sizeof(struct qstack) * qstack_size)) == NULL)
    error("Failed to allocate qstack.");

  /* Init the interval stack. */
  qstack[0].i = 0;
  qstack[0].j = N - 1;
  qstack[0].min = min;
  qstack[0].max = max;
  qstack[0].ready = 1;
  for (i = 1; i < qstack_size; i++) qstack[i].ready = 0;
  first = 0;
  last = 1;
  waiting = 1;

796
797
  /* Main loop. */
  while (waiting > 0) {
798

799
800
    /* Grab an interval off the queue. */
    qid = (first++) % qstack_size;
801

802
803
804
805
806
807
808
809
810
    /* Get the stack entry. */
    i = qstack[qid].i;
    j = qstack[qid].j;
    min = qstack[qid].min;
    max = qstack[qid].max;
    qstack[qid].ready = 0;

    /* Loop over sub-intervals. */
    while (1) {
811

812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
      /* Bring beer. */
      pivot = (min + max) / 2;

      /* One pass of QuickSort's partitioning. */
      ii = i;
      jj = j;
      while (ii < jj) {
        while (ii <= j && ind[ii] <= pivot) ii++;
        while (jj >= i && ind[jj] > pivot) jj--;
        if (ii < jj) {
          temp_i = ind[ii];
          ind[ii] = ind[jj];
          ind[jj] = temp_i;
          temp_p = gparts[ii];
          gparts[ii] = gparts[jj];
          gparts[jj] = temp_p;
        }
      }
830

831
      /* Verify space_sort_struct. */
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
      /* for ( int k = i ; k <= jj ; k++ )
         if ( ind[k] > pivot ) {
         message( "sorting failed at k=%i, ind[k]=%i, pivot=%i, i=%i, j=%i,
         N=%i." , k , ind[k] , pivot , i , j , N );
         error( "Partition failed (<=pivot)." );
         }
         for ( int k = jj+1 ; k <= j ; k++ )
         if ( ind[k] <= pivot ) {
         message( "sorting failed at k=%i, ind[k]=%i, pivot=%i, i=%i, j=%i,
         N=%i." , k , ind[k] , pivot , i , j , N );
         error( "Partition failed (>pivot)." );
         } */

      /* Split-off largest interval. */
      if (jj - i > j - jj + 1) {

        /* Recurse on the left? */
        if (jj > i && pivot > min) {
          qid = (last++) % qstack_size;
          qstack[qid].i = i;
          qstack[qid].j = jj;
          qstack[qid].min = min;
          qstack[qid].max = pivot;
          qstack[qid].ready = 1;
          if ((waiting++) >= qstack_size) error("Qstack overflow.");
        }
858

859
860
861
862
863
864
        /* Recurse on the right? */
        if (jj + 1 < j && pivot + 1 < max) {
          i = jj + 1;
          min = pivot + 1;
        } else
          break;
865

866
867
868
      } else {

        /* Recurse on the right? */
869
        if (pivot + 1 < max) {
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
          qid = (last++) % qstack_size;
          qstack[qid].i = jj + 1;
          qstack[qid].j = j;
          qstack[qid].min = pivot + 1;
          qstack[qid].max = max;
          qstack[qid].ready = 1;
          if ((waiting++) >= qstack_size) error("Qstack overflow.");
        }

        /* Recurse on the left? */
        if (jj > i && pivot > min) {
          j = jj;
          max = pivot;
        } else
          break;
      }

    } /* loop over sub-intervals. */

    waiting--;

  } /* main loop. */
892

893
  /* Verify space_sort_struct. */
894
895
896
897
898
899
900
901
  /* for ( i = 1 ; i < N ; i++ )
      if ( ind[i-1] > ind[i] )
          error( "Sorting failed (ind[%i]=%i,ind[%i]=%i)." , i-1 , ind[i-1] , i
     , ind[i] ); */

  /* Clean up. */
  free(qstack);
}
902

Pedro Gonnet's avatar
Pedro Gonnet committed
903
/**
904
 * @brief Mapping function to free the sorted indices buffers.
Pedro Gonnet's avatar
Pedro Gonnet committed
905
906
 */

907
void space_map_clearsort(struct cell *c, void *data) {
Pedro Gonnet's avatar
Pedro Gonnet committed
908

909
910
911
912
913
  if (c->sort != NULL) {
    free(c->sort);
    c->sort = NULL;
  }
}
Pedro Gonnet's avatar
Pedro Gonnet committed
914

915
916
917
/**
 * @brief Map a function to all particles in a cell recursively.
 *
918
 * @param c The #cell we are working in.
919
920
921
922
 * @param fun Function pointer to apply on the cells.
 * @param data Data passed to the function fun.
 */

Pedro Gonnet's avatar
Pedro Gonnet committed
923
924
925
926
static void rec_map_parts(struct cell *c,
                          void (*fun)(struct part *p, struct cell *c,
                                      void *data),
                          void *data) {
927
928
929
930
931
932

  int k;

  /* No progeny? */
  if (!c->split)
    for (k = 0; k < c->count; k++) fun(&c->parts[k], c, data);
Pedro Gonnet's avatar
Pedro Gonnet committed
933

934
935
936
937
938
939
  /* Otherwise, recurse. */
  else
    for (k = 0; k < 8; k++)
      if (c->progeny[k] != NULL) rec_map_parts(c->progeny[k], fun, data);
}

Pedro Gonnet's avatar
Pedro Gonnet committed
940
/**
941
 * @brief Map a function to all particles in a space.
Pedro Gonnet's avatar
Pedro Gonnet committed
942
943
 *
 * @param s The #space we are working in.
944
945
 * @param fun Function pointer to apply on the cells.
 * @param data Data passed to the function fun.
Pedro Gonnet's avatar
Pedro Gonnet committed
946
947
 */

948
949
950
void space_map_parts(struct space *s,
                     void (*fun)(struct part *p, struct cell *c, void *data),
                     void *data) {
Pedro Gonnet's avatar
Pedro Gonnet committed
951

952
953
  int cid = 0;

954
  /* Call the recursive function on all higher-level cells. */
Pedro Gonnet's avatar
Pedro Gonnet committed
955
956
  for (cid = 0; cid < s->nr_cells; cid++)
    rec_map_parts(&s->cells[cid], fun, data);
957
}
958

959
960
961
962
963
964
965
966
/**
 * @brief Map a function to all particles in a cell recursively.
 *
 * @param c The #cell we are working in.
 * @param fun Function pointer to apply on the cells.
 */

static void rec_map_parts_xparts(struct cell *c,
967
968
                                 void (*fun)(struct part *p, struct xpart *xp,
                                             struct cell *c)) {
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989

  int k;

  /* No progeny? */
  if (!c->split)
    for (k = 0; k < c->count; k++) fun(&c->parts[k], &c->xparts[k], c);

  /* Otherwise, recurse. */
  else
    for (k = 0; k < 8; k++)
      if (c->progeny[k] != NULL) rec_map_parts_xparts(c->progeny[k], fun);
}

/**
 * @brief Map a function to all particles (#part and #xpart) in a space.
 *
 * @param s The #space we are working in.
 * @param fun Function pointer to apply on the particles in the cells.
 */

void space_map_parts_xparts(struct space *s,
990
991
                            void (*fun)(struct part *p, struct xpart *xp,
                                        struct cell *c)) {
992
993
994
995
996
997
998
999

  int cid = 0;

  /* Call the recursive function on all higher-level cells. */
  for (cid = 0; cid < s->nr_cells; cid++)
    rec_map_parts_xparts(&s->cells[cid], fun);
}

1000
1001
1002
/**
 * @brief Map a function to all particles in a cell recursively.
 *
1003
 * @param c The #cell we are working in.
1004
1005
1006
1007
 * @param full Map to all cells, including cells with sub-cells.
 * @param fun Function pointer to apply on the cells.
 * @param data Data passed to the function fun.
 */
1008

Pedro Gonnet's avatar
Pedro Gonnet committed
1009
1010
1011
static void rec_map_cells_post(struct cell *c, int full,
                               void (*fun)(struct cell *c, void *data),
                               void *data) {
1012

1013
1014
1015
1016
1017
  int k;

  /* Recurse. */
  if (c->split)
    for (k = 0; k < 8; k++)
Pedro Gonnet's avatar
Pedro Gonnet committed
1018
1019
1020
      if (c->progeny[k] != NULL)
        rec_map_cells_post(c->progeny[k], full, fun, data);

1021
1022
  /* No progeny? */
  if (full || !c->split) fun(c, data);
1023
}
Pedro Gonnet's avatar
Pedro Gonnet committed
1024
1025

/**
1026
 * @brief Map a function to all particles in a aspace.
Pedro Gonnet's avatar
Pedro Gonnet committed
1027
1028
 *
 * @param s The #space we are working in.
1029
 * @param full Map to all cells, including cells with sub-cells.
1030
1031
 * @param fun Function pointer to apply on the cells.
 * @param data Data passed to the function fun.
Pedro Gonnet's avatar
Pedro Gonnet committed
1032
 */
1033

1034
void space_map_cells_post(struct space *s, int full,
Pedro Gonnet's avatar
Pedro Gonnet committed
1035
                          void (*fun)(struct cell *c, void *data), void *data) {
1036

1037
  int cid = 0;
1038

1039
  /* Call the recursive function on all higher-level cells. */
Pedro Gonnet's avatar
Pedro Gonnet committed
1040
1041
  for (cid = 0; cid < s->nr_cells; cid++)
    rec_map_cells_post(&s->cells[cid], full, fun, data);
1042
}
1043

Pedro Gonnet's avatar
Pedro Gonnet committed
1044
1045
1046
static void rec_map_cells_pre(struct cell *c, int full,
                              void (*fun)(struct cell *c, void *data),
                              void *data) {
1047

1048
  int k;
Pedro Gonnet's avatar
Pedro Gonnet committed
1049

1050
1051
  /* No progeny? */
  if (full || !c->split) fun(c, data);
Pedro Gonnet's avatar
Pedro Gonnet committed
1052

1053
1054
1055
  /* Recurse. */
  if (c->split)
    for (k = 0; k < 8; k++)
Pedro Gonnet's avatar
Pedro Gonnet committed
1056